All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc: Enable VMX copy on PPC970 (G5)
@ 2016-01-21  0:25 Michael Ellerman
  2016-01-21  9:51 ` Marc Dietrich
  2016-01-22  8:08 ` Segher Boessenkool
  0 siblings, 2 replies; 5+ messages in thread
From: Michael Ellerman @ 2016-01-21  0:25 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Anton Blanchard, Benjamin Herrenschmidt, Segher Boessenkool

There's no reason I'm aware of that the VMX copy loop shouldn't work on
PPC970. And in fact it seems to boot and generally be happy.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/include/asm/cputable.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/cputable.h b/arch/powerpc/include/asm/cputable.h
index b118072670fb..f412666fafe2 100644
--- a/arch/powerpc/include/asm/cputable.h
+++ b/arch/powerpc/include/asm/cputable.h
@@ -411,7 +411,7 @@ enum {
 	    CPU_FTR_PPCAS_ARCH_V2 | CPU_FTR_CTRL | CPU_FTR_ARCH_201 | \
 	    CPU_FTR_ALTIVEC_COMP | CPU_FTR_CAN_NAP | CPU_FTR_MMCRA | \
 	    CPU_FTR_CP_USE_DCBTZ | CPU_FTR_STCX_CHECKS_ADDRESS | \
-	    CPU_FTR_HVMODE | CPU_FTR_DABRX)
+	    CPU_FTR_HVMODE | CPU_FTR_DABRX | CPU_FTR_VMX_COPY)
 #define CPU_FTRS_POWER5	(CPU_FTR_USE_TB | CPU_FTR_LWSYNC | \
 	    CPU_FTR_PPCAS_ARCH_V2 | CPU_FTR_CTRL | \
 	    CPU_FTR_MMCRA | CPU_FTR_SMT | \
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc: Enable VMX copy on PPC970 (G5)
  2016-01-21  0:25 [PATCH] powerpc: Enable VMX copy on PPC970 (G5) Michael Ellerman
@ 2016-01-21  9:51 ` Marc Dietrich
  2016-01-21 10:23   ` Michael Ellerman
  2016-01-22  8:08 ` Segher Boessenkool
  1 sibling, 1 reply; 5+ messages in thread
From: Marc Dietrich @ 2016-01-21  9:51 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Michael Ellerman, linuxppc-dev, Anton Blanchard

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

Am Donnerstag, 21. Januar 2016, 11:25:27 schrieb Michael Ellerman:
> There's no reason I'm aware of that the VMX copy loop shouldn't work on
> PPC970. And in fact it seems to boot and generally be happy.

does the same also hold for Cell? Maybe there are even more optimizations 
which can be copied from PPC970.

Marc 


> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  arch/powerpc/include/asm/cputable.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/include/asm/cputable.h
> b/arch/powerpc/include/asm/cputable.h index b118072670fb..f412666fafe2
> 100644
> --- a/arch/powerpc/include/asm/cputable.h
> +++ b/arch/powerpc/include/asm/cputable.h
> @@ -411,7 +411,7 @@ enum {
>  	    CPU_FTR_PPCAS_ARCH_V2 | CPU_FTR_CTRL | CPU_FTR_ARCH_201 | \
>  	    CPU_FTR_ALTIVEC_COMP | CPU_FTR_CAN_NAP | CPU_FTR_MMCRA | \
>  	    CPU_FTR_CP_USE_DCBTZ | CPU_FTR_STCX_CHECKS_ADDRESS | \
> -	    CPU_FTR_HVMODE | CPU_FTR_DABRX)
> +	    CPU_FTR_HVMODE | CPU_FTR_DABRX | CPU_FTR_VMX_COPY)
>  #define CPU_FTRS_POWER5	(CPU_FTR_USE_TB | CPU_FTR_LWSYNC | \
>  	    CPU_FTR_PPCAS_ARCH_V2 | CPU_FTR_CTRL | \
>  	    CPU_FTR_MMCRA | CPU_FTR_SMT | \

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc: Enable VMX copy on PPC970 (G5)
  2016-01-21  9:51 ` Marc Dietrich
@ 2016-01-21 10:23   ` Michael Ellerman
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2016-01-21 10:23 UTC (permalink / raw)
  To: Marc Dietrich, linuxppc-dev; +Cc: linuxppc-dev, Anton Blanchard

On Thu, 2016-01-21 at 10:51 +0100, Marc Dietrich wrote:

> Am Donnerstag, 21. Januar 2016, 11:25:27 schrieb Michael Ellerman:

> > There's no reason I'm aware of that the VMX copy loop shouldn't work on
> > PPC970. And in fact it seems to boot and generally be happy.
> 
> does the same also hold for Cell? Maybe there are even more optimizations 
> which can be copied from PPC970.

Yeah in theory the PPE has VMX, I'll try it.

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc: Enable VMX copy on PPC970 (G5)
  2016-01-21  0:25 [PATCH] powerpc: Enable VMX copy on PPC970 (G5) Michael Ellerman
  2016-01-21  9:51 ` Marc Dietrich
@ 2016-01-22  8:08 ` Segher Boessenkool
  2016-01-22  8:37   ` Michael Ellerman
  1 sibling, 1 reply; 5+ messages in thread
From: Segher Boessenkool @ 2016-01-22  8:08 UTC (permalink / raw)
  To: Michael Ellerman; +Cc: linuxppc-dev, Anton Blanchard, Benjamin Herrenschmidt

On Thu, Jan 21, 2016 at 11:25:27AM +1100, Michael Ellerman wrote:
> There's no reason I'm aware of that the VMX copy loop shouldn't work on
> PPC970. And in fact it seems to boot and generally be happy.

But is it faster?


Segher

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc: Enable VMX copy on PPC970 (G5)
  2016-01-22  8:08 ` Segher Boessenkool
@ 2016-01-22  8:37   ` Michael Ellerman
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2016-01-22  8:37 UTC (permalink / raw)
  To: Segher Boessenkool; +Cc: linuxppc-dev, Anton Blanchard, Benjamin Herrenschmidt

On Fri, 2016-01-22 at 02:08 -0600, Segher Boessenkool wrote:
> On Thu, Jan 21, 2016 at 11:25:27AM +1100, Michael Ellerman wrote:
> > There's no reason I'm aware of that the VMX copy loop shouldn't work on
> > PPC970. And in fact it seems to boot and generally be happy.
> 
> But is it faster?

Well Anton wrote it, so of course it is. ;)

Will try and get some numbers.

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-01-22  8:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-21  0:25 [PATCH] powerpc: Enable VMX copy on PPC970 (G5) Michael Ellerman
2016-01-21  9:51 ` Marc Dietrich
2016-01-21 10:23   ` Michael Ellerman
2016-01-22  8:08 ` Segher Boessenkool
2016-01-22  8:37   ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.