[review-request][jethro][PATCH] bitbake: toaster: make runbuilds to loop

[review-request][jethro][PATCH] bitbake: toaster: make runbuilds to loop

[Ed Bartosh]

From: Ed Bartosh <ed.bartosh@linux.intel.com>

Made runbuilds to loop to avoid having a loop in shell code and
initialize heavy Django init machinery every second.

Ignored exceptions to prevent exiting a loop.

(Bitbake rev: e04da15556ca0936de652b8c085e4199e5551457)

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: brian avery <avery.brian@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
---
 .../lib/toaster/bldcontrol/management/commands/runbuilds.py | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/bitbake/lib/toaster/bldcontrol/management/commands/runbuilds.py b/bitbake/lib/toaster/bldcontrol/management/commands/runbuilds.py
index 5243a50..48dc618 100644
--- a/bitbake/lib/toaster/bldcontrol/management/commands/runbuilds.py
+++ b/bitbake/lib/toaster/bldcontrol/management/commands/runbuilds.py
@@ -5,6 +5,7 @@ from bldcontrol.bbcontroller import getBuildEnvironmentController, ShellCmdExcep
 from bldcontrol.models import BuildRequest, BuildEnvironment, BRError, BRVariable
 import os
 import logging
+import time
 
 logger = logging.getLogger("ToasterScheduler")
 
@@ -128,6 +129,12 @@ class Command(NoArgsCommand):
 
 
     def handle_noargs(self, **options):
-        self.cleanup()
-        self.archive()
-        self.schedule()
+        while True:
+            try:
+                self.cleanup()
+                self.archive()
+                self.schedule()
+            except:
+                pass
+
+            time.sleep(1)
-- 
2.1.4

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [review-request][jethro][PATCH] bitbake: toaster: make runbuilds to loop

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 2604 bytes --]

On 22 January 2016 at 12:36, Ed Bartosh <eduard.bartosh@intel.com> wrote:

> From: Ed Bartosh <ed.bartosh@linux.intel.com>
>
> Made runbuilds to loop to avoid having a loop in shell code and
> initialize heavy Django init machinery every second.
>

I've sent this to bitbake-devel.

Elliot


>
> Ignored exceptions to prevent exiting a loop.
>
> (Bitbake rev: e04da15556ca0936de652b8c085e4199e5551457)
>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> Signed-off-by: brian avery <avery.brian@gmail.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
> ---
>  .../lib/toaster/bldcontrol/management/commands/runbuilds.py | 13
> ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git
> a/bitbake/lib/toaster/bldcontrol/management/commands/runbuilds.py
> b/bitbake/lib/toaster/bldcontrol/management/commands/runbuilds.py
> index 5243a50..48dc618 100644
> --- a/bitbake/lib/toaster/bldcontrol/management/commands/runbuilds.py
> +++ b/bitbake/lib/toaster/bldcontrol/management/commands/runbuilds.py
> @@ -5,6 +5,7 @@ from bldcontrol.bbcontroller import
> getBuildEnvironmentController, ShellCmdExcep
>  from bldcontrol.models import BuildRequest, BuildEnvironment, BRError,
> BRVariable
>  import os
>  import logging
> +import time
>
>  logger = logging.getLogger("ToasterScheduler")
>
> @@ -128,6 +129,12 @@ class Command(NoArgsCommand):
>
>
>      def handle_noargs(self, **options):
> -        self.cleanup()
> -        self.archive()
> -        self.schedule()
> +        while True:
> +            try:
> +                self.cleanup()
> +                self.archive()
> +                self.schedule()
> +            except:
> +                pass
> +
> +            time.sleep(1)
> --
> 2.1.4
>
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 3842 bytes --]