All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/3] Add support for Firefly RK3288
@ 2016-01-22 15:53 Ariel D'Alessandro
  2016-01-22 15:53 ` [Buildroot] [PATCH 1/3] mali-t76x: add new package Ariel D'Alessandro
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Ariel D'Alessandro @ 2016-01-22 15:53 UTC (permalink / raw)
  To: buildroot

Hi all,

This patchset adds support for the Firefly RK3288 board [0].
Support includes running Qt5 + EGLFS backend, so the board is
configured in that way, as follows:

A new mali-t76x package is added, which installs the required libraries
for Mali Midgard GPU from ARM [1].

Although most of the kernel support for the board has been mainlined,
the kernel is taken from Heiko St?bner's [2] devel/somewhat-stable
branch as it includes the latest support and the Mali GPU drivers.
The GPU drivers should be added as an extension separated from the
kernel in the future.

Uboot bootloader is taken from mainline tag v2016.01.

The building process will output a 'sdcard.img' that is ready to be
flash into a SD card and boot the board.

Regards,

Links:
[0] http://en.t-firefly.com/en/firenow/firefly_rk3288/specifications/
[1] http://malideveloper.arm.com/resources/drivers/arm-mali-midgard-gpu-user-space-drivers/
[2] https://github.com/mmind/linux-rockchip

Ariel D'Alessandro (3):
  mali-t76x: add new package
  board/firefly_rk3288: add new board
  configs/firefly_rk3288: new board

 board/firefly/firefly-rk3288/build_sd_image.sh     | 18 ++++++
 board/firefly/firefly-rk3288/extlinux.conf         |  6 ++
 board/firefly/firefly-rk3288/post-image.sh         |  6 ++
 board/firefly/firefly-rk3288/pre-image.sh          |  3 +
 board/firefly/firefly-rk3288/readme.txt            | 40 ++++++++++++++
 board/firefly/firefly-rk3288/sd-image.cfg          | 22 ++++++++
 configs/firefly_rk3288_defconfig                   | 40 ++++++++++++++
 package/Config.in                                  |  1 +
 ...latform.h-with-framebuffer-instead-of-X11.patch | 39 +++++++++++++
 package/mali-t76x/Config.in                        | 27 +++++++++
 package/mali-t76x/egl.pc                           | 12 ++++
 package/mali-t76x/glesv2.pc                        | 12 ++++
 package/mali-t76x/rockchip-mali.mk                 | 64 ++++++++++++++++++++++
 13 files changed, 290 insertions(+)
 create mode 100755 board/firefly/firefly-rk3288/build_sd_image.sh
 create mode 100644 board/firefly/firefly-rk3288/extlinux.conf
 create mode 100755 board/firefly/firefly-rk3288/post-image.sh
 create mode 100755 board/firefly/firefly-rk3288/pre-image.sh
 create mode 100644 board/firefly/firefly-rk3288/readme.txt
 create mode 100644 board/firefly/firefly-rk3288/sd-image.cfg
 create mode 100644 configs/firefly_rk3288_defconfig
 create mode 100644 package/mali-t76x/0001-use-eglplatform.h-with-framebuffer-instead-of-X11.patch
 create mode 100644 package/mali-t76x/Config.in
 create mode 100644 package/mali-t76x/egl.pc
 create mode 100644 package/mali-t76x/glesv2.pc
 create mode 100644 package/mali-t76x/rockchip-mali.mk

-- 
2.7.0

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/3] mali-t76x: add new package
  2016-01-22 15:53 [Buildroot] [PATCH 0/3] Add support for Firefly RK3288 Ariel D'Alessandro
@ 2016-01-22 15:53 ` Ariel D'Alessandro
  2016-02-10 20:34   ` Peter Korsgaard
  2016-01-22 15:53 ` [Buildroot] [PATCH 2/3] board/firefly_rk3288: add new board Ariel D'Alessandro
  2016-01-22 15:53 ` [Buildroot] [PATCH 3/3] configs/firefly_rk3288: " Ariel D'Alessandro
  2 siblings, 1 reply; 11+ messages in thread
From: Ariel D'Alessandro @ 2016-01-22 15:53 UTC (permalink / raw)
  To: buildroot

Package provides the binary user-space components for the ARM Mali
Midgard T76X GPU.

Note that this package requires a kernel with the ARM Mali Midgard GPU
Kernel Drivers enabled.

Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
---
 package/Config.in                                  |  1 +
 ...latform.h-with-framebuffer-instead-of-X11.patch | 39 +++++++++++++
 package/mali-t76x/Config.in                        | 27 +++++++++
 package/mali-t76x/egl.pc                           | 12 ++++
 package/mali-t76x/glesv2.pc                        | 12 ++++
 package/mali-t76x/rockchip-mali.mk                 | 64 ++++++++++++++++++++++
 6 files changed, 155 insertions(+)
 create mode 100644 package/mali-t76x/0001-use-eglplatform.h-with-framebuffer-instead-of-X11.patch
 create mode 100644 package/mali-t76x/Config.in
 create mode 100644 package/mali-t76x/egl.pc
 create mode 100644 package/mali-t76x/glesv2.pc
 create mode 100644 package/mali-t76x/rockchip-mali.mk

diff --git a/package/Config.in b/package/Config.in
index 09c2b40..274c451 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -398,6 +398,7 @@ endif
 	source "package/lshw/Config.in"
 	source "package/lsuio/Config.in"
 	source "package/lvm2/Config.in"
+	source "package/mali-t76x/Config.in"
 	source "package/mdadm/Config.in"
 	source "package/memtest86/Config.in"
 	source "package/memtester/Config.in"
diff --git a/package/mali-t76x/0001-use-eglplatform.h-with-framebuffer-instead-of-X11.patch b/package/mali-t76x/0001-use-eglplatform.h-with-framebuffer-instead-of-X11.patch
new file mode 100644
index 0000000..9311f18
--- /dev/null
+++ b/package/mali-t76x/0001-use-eglplatform.h-with-framebuffer-instead-of-X11.patch
@@ -0,0 +1,39 @@
+From 90a1279f7d7bf4a584124cf4c20fbd6e0eee0396 Mon Sep 17 00:00:00 2001
+From: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
+Date: Thu, 17 Dec 2015 04:26:05 -0300
+Subject: [PATCH] use eglplatform.h with framebuffer instead of X11
+
+Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
+---
+ eglplatform.h | 15 ++++++++-------
+ 1 file changed, 8 insertions(+), 7 deletions(-)
+
+diff --git a/eglplatform.h b/eglplatform.h
+index 1284089..762fc57 100644
+--- a/eglplatform.h
++++ b/eglplatform.h
+@@ -95,13 +95,14 @@ typedef void*                           EGLNativeDisplayType;
+ 
+ #elif defined(__unix__)
+ 
+-/* X11 (tentative)  */
+-#include <X11/Xlib.h>
+-#include <X11/Xutil.h>
+-
+-typedef Display *EGLNativeDisplayType;
+-typedef Pixmap   EGLNativePixmapType;
+-typedef Window   EGLNativeWindowType;
++struct mali_native_window {
++	unsigned short width;
++	unsigned short height;
++};
++
++typedef void*         EGLNativeDisplayType;
++typedef void*         EGLNativePixmapType;
++typedef struct mali_native_window *EGLNativeWindowType;
+ 
+ #else
+ #error "Platform not recognized"
+-- 
+2.6.4
+
diff --git a/package/mali-t76x/Config.in b/package/mali-t76x/Config.in
new file mode 100644
index 0000000..b87622a
--- /dev/null
+++ b/package/mali-t76x/Config.in
@@ -0,0 +1,27 @@
+config BR2_PACKAGE_MALI_T76X
+	bool "mali-t76x"
+	select BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_HAS_LIBGLES
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_ARM_EABIHF
+	depends on BR2_arm
+	help
+	  Install the binary user-space components for the ARM Mali Midgard
+	  T76X GPU. This package requires a kernel with the ARM Mali Midgard
+	  GPU Kernel Drivers enabled.
+
+	  Source: http://malideveloper.arm.com/resources/drivers/
+
+if BR2_PACKAGE_MALI_T76X
+
+config BR2_PACKAGE_PROVIDES_LIBEGL
+	default "mali-t76x"
+
+config BR2_PACKAGE_PROVIDES_LIBGLES
+	default "mali-t76x"
+
+endif
+
+comment "mali-t76x needs an (e)glibc toolchain with armhf enabled"
+	depends on BR2_arm
+	depends on !BR2_TOOLCHAIN_USES_GLIBC || !BR2_ARM_EABIHF
diff --git a/package/mali-t76x/egl.pc b/package/mali-t76x/egl.pc
new file mode 100644
index 0000000..f9ccf07
--- /dev/null
+++ b/package/mali-t76x/egl.pc
@@ -0,0 +1,12 @@
+prefix=/usr/
+exec_prefix=${prefix}
+libdir=${exec_prefix}/lib
+includedir=${prefix}/include
+
+Name: egl
+Description: ARM Mali implementation of EGL
+Version: 1.5
+Requires:
+Libs: -L${libdir} -lEGL -lGLESv2
+Cflags: -I${includedir}
+
diff --git a/package/mali-t76x/glesv2.pc b/package/mali-t76x/glesv2.pc
new file mode 100644
index 0000000..6910b46
--- /dev/null
+++ b/package/mali-t76x/glesv2.pc
@@ -0,0 +1,12 @@
+prefix=/usr
+exec_prefix=${prefix}
+libdir=${exec_prefix}/lib
+includedir=${prefix}/include
+
+Name: glesv2
+Description: ARM Mali implementation of OpenGL ESv2
+Version: 2.0
+Requires:
+Libs: -L${libdir} -lGLESv2 -lGLESv1_CM
+Cflags: -I${includedir}
+
diff --git a/package/mali-t76x/rockchip-mali.mk b/package/mali-t76x/rockchip-mali.mk
new file mode 100644
index 0000000..3117864
--- /dev/null
+++ b/package/mali-t76x/rockchip-mali.mk
@@ -0,0 +1,64 @@
+################################################################################
+#
+# mali-t76x
+#
+################################################################################
+
+MALI_T76X_VERSION = r5p0-06rel0
+MALI_T76X_SOURCE = mali-t76x_$(MALI_T76X_VERSION)_linux_1+fbdev.tar.gz
+MALI_T76X_SITE = http://malideveloper.arm.com/downloads/drivers/binary/$(MALI_T76X_VERSION)
+
+MALI_T76X_EXTRA_SITE = https://www.khronos.org/registry
+MALI_T76X_EXTRA_DOWNLOADS = \
+	$(MALI_T76X_EXTRA_SITE)/egl/api/EGL/egl.h \
+	$(MALI_T76X_EXTRA_SITE)/egl/api/EGL/eglext.h \
+	$(MALI_T76X_EXTRA_SITE)/egl/api/EGL/eglplatform.h \
+	$(MALI_T76X_EXTRA_SITE)/gles/api/GLES/gl.h \
+	$(MALI_T76X_EXTRA_SITE)/gles/api/GLES/glext.h \
+	$(MALI_T76X_EXTRA_SITE)/gles/api/GLES/glplatform.h \
+	$(MALI_T76X_EXTRA_SITE)/gles/api/old/2.0/gl2.h \
+	$(MALI_T76X_EXTRA_SITE)/gles/api/old/2.0/gl2ext.h \
+	$(MALI_T76X_EXTRA_SITE)/gles/api/old/2.0/gl2platform.h \
+	$(MALI_T76X_EXTRA_SITE)/egl/api/KHR/khrplatform.h
+
+MALI_T76X_INSTALL_STAGING = YES
+MALI_T76X_PROVIDES = libegl libgles
+
+define MALI_T76X_PRE_PATCH
+	cp $(BR2_DL_DIR)/eglplatform.h $(@D)/eglplatform.h
+endef
+
+MALI_T76X_PRE_PATCH_HOOKS += MALI_T76X_PRE_PATCH
+
+define MALI_T76X_INSTALL_STAGING_CMDS
+	$(INSTALL) -m 755 $(@D)/*.so $(STAGING_DIR)/usr/lib/
+
+	$(INSTALL) -D -m 0644 package/mali-t76x/egl.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/egl.pc
+	$(INSTALL) -D -m 0644 package/mali-t76x/glesv2.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/glesv2.pc
+
+	$(INSTALL) -m 755 -d $(STAGING_DIR)/usr/include/EGL
+	$(INSTALL) -D -m 0644 $(BR2_DL_DIR)/egl.h $(STAGING_DIR)/usr/include/EGL
+	$(INSTALL) -D -m 0644 $(BR2_DL_DIR)/eglext.h $(STAGING_DIR)/usr/include/EGL
+	$(INSTALL) -D -m 0644 $(@D)/eglplatform.h $(STAGING_DIR)/usr/include/EGL
+
+	$(INSTALL) -m 755 -d $(STAGING_DIR)/usr/include/GLES
+	$(INSTALL) -D -m 0644 $(BR2_DL_DIR)/gl.h $(STAGING_DIR)/usr/include/GLES
+	$(INSTALL) -D -m 0644 $(BR2_DL_DIR)/glext.h $(STAGING_DIR)/usr/include/GLES
+	$(INSTALL) -D -m 0644 $(BR2_DL_DIR)/glplatform.h $(STAGING_DIR)/usr/include/GLES
+
+	$(INSTALL) -m 755 -d $(STAGING_DIR)/usr/include/GLES2
+	$(INSTALL) -D -m 0644 $(BR2_DL_DIR)/gl2.h $(STAGING_DIR)/usr/include/GLES2
+	$(INSTALL) -D -m 0644 $(BR2_DL_DIR)/gl2ext.h $(STAGING_DIR)/usr/include/GLES2
+	$(INSTALL) -D -m 0644 $(BR2_DL_DIR)/gl2platform.h $(STAGING_DIR)/usr/include/GLES2
+
+	$(INSTALL) -m 755 -d $(STAGING_DIR)/usr/include/KHR
+	$(INSTALL) -D -m 0644 $(BR2_DL_DIR)/khrplatform.h $(STAGING_DIR)/usr/include/KHR
+endef
+
+define MALI_T76X_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 755 $(@D)/*.so $(TARGET_DIR)/usr/lib/
+endef
+
+$(eval $(generic-package))
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/3] board/firefly_rk3288: add new board
  2016-01-22 15:53 [Buildroot] [PATCH 0/3] Add support for Firefly RK3288 Ariel D'Alessandro
  2016-01-22 15:53 ` [Buildroot] [PATCH 1/3] mali-t76x: add new package Ariel D'Alessandro
@ 2016-01-22 15:53 ` Ariel D'Alessandro
  2016-02-10 20:57   ` Peter Korsgaard
  2016-01-22 15:53 ` [Buildroot] [PATCH 3/3] configs/firefly_rk3288: " Ariel D'Alessandro
  2 siblings, 1 reply; 11+ messages in thread
From: Ariel D'Alessandro @ 2016-01-22 15:53 UTC (permalink / raw)
  To: buildroot

More info about the board:
http://en.t-firefly.com/en/firenow/firefly_rk3288/specifications/

Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
---
 board/firefly/firefly-rk3288/build_sd_image.sh | 18 ++++++++++++
 board/firefly/firefly-rk3288/extlinux.conf     |  6 ++++
 board/firefly/firefly-rk3288/post-image.sh     |  6 ++++
 board/firefly/firefly-rk3288/pre-image.sh      |  3 ++
 board/firefly/firefly-rk3288/readme.txt        | 40 ++++++++++++++++++++++++++
 board/firefly/firefly-rk3288/sd-image.cfg      | 22 ++++++++++++++
 6 files changed, 95 insertions(+)
 create mode 100755 board/firefly/firefly-rk3288/build_sd_image.sh
 create mode 100644 board/firefly/firefly-rk3288/extlinux.conf
 create mode 100755 board/firefly/firefly-rk3288/post-image.sh
 create mode 100755 board/firefly/firefly-rk3288/pre-image.sh
 create mode 100644 board/firefly/firefly-rk3288/readme.txt
 create mode 100644 board/firefly/firefly-rk3288/sd-image.cfg

diff --git a/board/firefly/firefly-rk3288/build_sd_image.sh b/board/firefly/firefly-rk3288/build_sd_image.sh
new file mode 100755
index 0000000..ae7fde1
--- /dev/null
+++ b/board/firefly/firefly-rk3288/build_sd_image.sh
@@ -0,0 +1,18 @@
+#!/bin/bash
+
+set -ue
+
+D=board/firefly/firefly-rk3288
+CFG=${D}/sd-image.cfg
+
+T=$(mktemp -d)
+mkdir -p $T/{root,tmp}
+
+$HOST_DIR/usr/bin/genimage		\
+	--rootpath $T/root/			\
+	--tmppath $T/tmp/			\
+	--inputpath $BINARIES_DIR/	\
+	--outputpath $BINARIES_DIR/	\
+	--config ${CFG}				\
+
+rm -rf $T
diff --git a/board/firefly/firefly-rk3288/extlinux.conf b/board/firefly/firefly-rk3288/extlinux.conf
new file mode 100644
index 0000000..65092d2
--- /dev/null
+++ b/board/firefly/firefly-rk3288/extlinux.conf
@@ -0,0 +1,6 @@
+default firefly-rk3288
+
+label firefly-rk3288
+kernel /boot/uImage
+devicetree /boot/rk3288-firefly.dtb
+append console=ttyS2,115200n8 earlyprintk init=/sbin/init root=/dev/mmcblk0p1 rootwait
diff --git a/board/firefly/firefly-rk3288/post-image.sh b/board/firefly/firefly-rk3288/post-image.sh
new file mode 100755
index 0000000..98c2778
--- /dev/null
+++ b/board/firefly/firefly-rk3288/post-image.sh
@@ -0,0 +1,6 @@
+board=board/firefly/firefly-rk3288
+MKIMAGE=$HOST_DIR/usr/bin/mkimage
+
+$MKIMAGE -n rk3288 -T rksd -d $BINARIES_DIR/u-boot-spl-dtb.bin $BINARIES_DIR/u-boot-spl-dtb.img
+
+${board}/build_sd_image.sh
diff --git a/board/firefly/firefly-rk3288/pre-image.sh b/board/firefly/firefly-rk3288/pre-image.sh
new file mode 100755
index 0000000..7770f6b
--- /dev/null
+++ b/board/firefly/firefly-rk3288/pre-image.sh
@@ -0,0 +1,3 @@
+board=board/firefly/firefly-rk3288
+
+install -m 0644 -D $board/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
diff --git a/board/firefly/firefly-rk3288/readme.txt b/board/firefly/firefly-rk3288/readme.txt
new file mode 100644
index 0000000..d621085
--- /dev/null
+++ b/board/firefly/firefly-rk3288/readme.txt
@@ -0,0 +1,40 @@
+Firefly RK3288
+
+How to build it
+===============
+
+  $ make firefly_rk3288_defconfig
+
+Then you can edit the build options using
+
+  $ make menuconfig
+
+Compile all and build rootfs image:
+
+  $ make
+
+Result of the build
+-------------------
+
+After building, you should get a tree like this:
+
+  output/images/
+  ??? rk3288-firefly.dtb
+  ??? rootfs.ext2
+  ??? rootfs.ext4 -> rootfs.ext2
+  ??? sdcard.img
+  ??? u-boot-dtb.img
+  ??? u-boot-spl-dtb.bin
+  ??? u-boot-spl-dtb.img
+  ??? uImage
+
+Prepare your SDCard
+===================
+
+Buildroot generates a ready-to-use SD card image that you can flash directly to
+the card. The image will be in output/images/sdcard.img.
+You can write this image directly to an SD card device (i.e. /dev/xxx):
+
+  $ dd if=output/images/sdcard.img of=/dev/xxx
+
+Finally, you can insert the SD card to the Firefly RK3288 board and boot it.
diff --git a/board/firefly/firefly-rk3288/sd-image.cfg b/board/firefly/firefly-rk3288/sd-image.cfg
new file mode 100644
index 0000000..a9eb9f0
--- /dev/null
+++ b/board/firefly/firefly-rk3288/sd-image.cfg
@@ -0,0 +1,22 @@
+image sdcard.img {
+  hdimage {
+  }
+
+  partition u-boot-spl-dtb {
+    in-partition-table = "no"
+    image = "u-boot-spl-dtb.img"
+    offset = 32K
+  }
+
+  partition u-boot-dtb {
+    in-partition-table = "no"
+    image = "u-boot-dtb.img"
+    offset = 128K
+  }
+
+  partition rootfs {
+    partition-type = 0x83
+    image = "rootfs.ext4"
+    size = 512M
+  }
+}
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 3/3] configs/firefly_rk3288: new board
  2016-01-22 15:53 [Buildroot] [PATCH 0/3] Add support for Firefly RK3288 Ariel D'Alessandro
  2016-01-22 15:53 ` [Buildroot] [PATCH 1/3] mali-t76x: add new package Ariel D'Alessandro
  2016-01-22 15:53 ` [Buildroot] [PATCH 2/3] board/firefly_rk3288: add new board Ariel D'Alessandro
@ 2016-01-22 15:53 ` Ariel D'Alessandro
  2016-02-10 21:08   ` Peter Korsgaard
  2 siblings, 1 reply; 11+ messages in thread
From: Ariel D'Alessandro @ 2016-01-22 15:53 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
---
 configs/firefly_rk3288_defconfig | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 configs/firefly_rk3288_defconfig

diff --git a/configs/firefly_rk3288_defconfig b/configs/firefly_rk3288_defconfig
new file mode 100644
index 0000000..28becfd
--- /dev/null
+++ b/configs/firefly_rk3288_defconfig
@@ -0,0 +1,40 @@
+BR2_arm=y
+BR2_cortex_a15=y
+BR2_ARM_FPU_NEON_VFPV4=y
+BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_TARGET_GENERIC_HOSTNAME="firefly-rk3288"
+BR2_TARGET_GENERIC_ISSUE="Welcome to FIREFLY RK3288!"
+BR2_TARGET_GENERIC_GETTY_PORT="/dev/console"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/firefly/firefly-rk3288/pre-image.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/firefly/firefly-rk3288/post-image.sh"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git at github.com:mmind/linux-rockchip.git"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ccb89e9b5657b4911c16d08e1581121222ee12c4"
+BR2_LINUX_KERNEL_DEFCONFIG="rk3288_veyron"
+BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-firefly"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_PACKAGE_QT5=y
+BR2_PACKAGE_QT5BASE_LICENSE_APPROVED=y
+BR2_PACKAGE_QT5BASE_EXAMPLES=y
+BR2_PACKAGE_QT5BASE_GUI=y
+BR2_PACKAGE_QT5BASE_EGLFS=y
+BR2_PACKAGE_MALI_T76X=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+# BR2_TARGET_ROOTFS_TAR is not set
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_GIT=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://git.denx.de/u-boot.git"
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="v2016.01"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="firefly-rk3288"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin"
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/3] mali-t76x: add new package
  2016-01-22 15:53 ` [Buildroot] [PATCH 1/3] mali-t76x: add new package Ariel D'Alessandro
@ 2016-02-10 20:34   ` Peter Korsgaard
  2016-02-14 18:56     ` Ariel D'Alessandro
  0 siblings, 1 reply; 11+ messages in thread
From: Peter Korsgaard @ 2016-02-10 20:34 UTC (permalink / raw)
  To: buildroot

>>>>> "Ariel" == Ariel D'Alessandro <ariel@vanguardiasur.com.ar> writes:

 > Package provides the binary user-space components for the ARM Mali
 > Midgard T76X GPU.

 > Note that this package requires a kernel with the ARM Mali Midgard GPU
 > Kernel Drivers enabled.

 > Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
 > ---
 >  package/Config.in                                  |  1 +
 >  ...latform.h-with-framebuffer-instead-of-X11.patch | 39 +++++++++++++
 >  package/mali-t76x/Config.in                        | 27 +++++++++
 >  package/mali-t76x/egl.pc                           | 12 ++++
 >  package/mali-t76x/glesv2.pc                        | 12 ++++
 >  package/mali-t76x/rockchip-mali.mk                 | 64 ++++++++++++++++++++++
 >  6 files changed, 155 insertions(+)
 >  create mode 100644 package/mali-t76x/0001-use-eglplatform.h-with-framebuffer-instead-of-X11.patch
 >  create mode 100644 package/mali-t76x/Config.in
 >  create mode 100644 package/mali-t76x/egl.pc
 >  create mode 100644 package/mali-t76x/glesv2.pc
 >  create mode 100644 package/mali-t76x/rockchip-mali.mk

 > diff --git a/package/mali-t76x/rockchip-mali.mk b/package/mali-t76x/rockchip-mali.mk
 > new file mode 100644
 > index 0000000..3117864
 > --- /dev/null
 > +++ b/package/mali-t76x/rockchip-mali.mk

This file should be named mali-t76x.mk to match the directory and
variables.

> @@ -0,0 +1,64 @@
 > +################################################################################
 > +#
 > +# mali-t76x
 > +#
 > +################################################################################
 > +
 > +MALI_T76X_VERSION = r5p0-06rel0
 > +MALI_T76X_SOURCE = mali-t76x_$(MALI_T76X_VERSION)_linux_1+fbdev.tar.gz
 > +MALI_T76X_SITE = http://malideveloper.arm.com/downloads/drivers/binary/$(MALI_T76X_VERSION)

A .hash file listing the sha256sum for this would be nice.

> +
 > +MALI_T76X_EXTRA_SITE = https://www.khronos.org/registry
 > +MALI_T76X_EXTRA_DOWNLOADS = \
 > +	$(MALI_T76X_EXTRA_SITE)/egl/api/EGL/egl.h \
 > +	$(MALI_T76X_EXTRA_SITE)/egl/api/EGL/eglext.h \
 > +	$(MALI_T76X_EXTRA_SITE)/egl/api/EGL/eglplatform.h \
 > +	$(MALI_T76X_EXTRA_SITE)/gles/api/GLES/gl.h \
 > +	$(MALI_T76X_EXTRA_SITE)/gles/api/GLES/glext.h \
 > +	$(MALI_T76X_EXTRA_SITE)/gles/api/GLES/glplatform.h \
 > +	$(MALI_T76X_EXTRA_SITE)/gles/api/old/2.0/gl2.h \
 > +	$(MALI_T76X_EXTRA_SITE)/gles/api/old/2.0/gl2ext.h \
 > +	$(MALI_T76X_EXTRA_SITE)/gles/api/old/2.0/gl2platform.h \
 > +	$(MALI_T76X_EXTRA_SITE)/egl/api/KHR/khrplatform.h

Could this use mesa3d-headers like the nvidia drivers do?

Other than that it looks good.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/3] board/firefly_rk3288: add new board
  2016-01-22 15:53 ` [Buildroot] [PATCH 2/3] board/firefly_rk3288: add new board Ariel D'Alessandro
@ 2016-02-10 20:57   ` Peter Korsgaard
  2016-02-14 18:59     ` Ariel D'Alessandro
  0 siblings, 1 reply; 11+ messages in thread
From: Peter Korsgaard @ 2016-02-10 20:57 UTC (permalink / raw)
  To: buildroot

>>>>> "Ariel" == Ariel D'Alessandro <ariel@vanguardiasur.com.ar> writes:

 > More info about the board:
 > http://en.t-firefly.com/en/firenow/firefly_rk3288/specifications/

 > Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
 > ---
 >  board/firefly/firefly-rk3288/build_sd_image.sh | 18 ++++++++++++
 >  board/firefly/firefly-rk3288/extlinux.conf     |  6 ++++
 >  board/firefly/firefly-rk3288/post-image.sh     |  6 ++++
 >  board/firefly/firefly-rk3288/pre-image.sh      |  3 ++
 >  board/firefly/firefly-rk3288/readme.txt        | 40 ++++++++++++++++++++++++++
 >  board/firefly/firefly-rk3288/sd-image.cfg      | 22 ++++++++++++++

It imho makes sense to squash the defconfig patch together with this
one.

>  6 files changed, 95 insertions(+)
 >  create mode 100755 board/firefly/firefly-rk3288/build_sd_image.sh
 >  create mode 100644 board/firefly/firefly-rk3288/extlinux.conf
 >  create mode 100755 board/firefly/firefly-rk3288/post-image.sh
 >  create mode 100755 board/firefly/firefly-rk3288/pre-image.sh
 >  create mode 100644 board/firefly/firefly-rk3288/readme.txt
 >  create mode 100644 board/firefly/firefly-rk3288/sd-image.cfg

 > diff --git a/board/firefly/firefly-rk3288/build_sd_image.sh b/board/firefly/firefly-rk3288/build_sd_image.sh
 > new file mode 100755
 > index 0000000..ae7fde1
 > --- /dev/null
 > +++ b/board/firefly/firefly-rk3288/build_sd_image.sh
 > @@ -0,0 +1,18 @@
 > +#!/bin/bash
 > +
 > +set -ue
 > +
 > +D=board/firefly/firefly-rk3288
 > +CFG=${D}/sd-image.cfg
 > +
 > +T=$(mktemp -d)
 > +mkdir -p $T/{root,tmp}

Other post-image scripts use ${BUILD_DIR}/genimage.tmp for the temporary
directory, please do as well.

> +
 > +$HOST_DIR/usr/bin/genimage		\
 > +	--rootpath $T/root/			\
 > +	--tmppath $T/tmp/			\
 > +	--inputpath $BINARIES_DIR/	\
 > +	--outputpath $BINARIES_DIR/	\
 > +	--config ${CFG}				\
 > +
 > +rm -rf $T

All our other defconfigs call genimage directly from post-image.sh, and
as this is a very small script would prefer to do that here as well.


> diff --git a/board/firefly/firefly-rk3288/extlinux.conf b/board/firefly/firefly-rk3288/extlinux.conf
 > new file mode 100644
 > index 0000000..65092d2
 > --- /dev/null
 > +++ b/board/firefly/firefly-rk3288/extlinux.conf
 > @@ -0,0 +1,6 @@
 > +default firefly-rk3288
 > +
 > +label firefly-rk3288
 > +kernel /boot/uImage
 > +devicetree /boot/rk3288-firefly.dtb
 > +append console=ttyS2,115200n8 earlyprintk init=/sbin/init root=/dev/mmcblk0p1 rootwait

why the init=? Is earlyprintk really good to use by default?


> diff --git a/board/firefly/firefly-rk3288/post-image.sh b/board/firefly/firefly-rk3288/post-image.sh
 > new file mode 100755
 > index 0000000..98c2778
 > --- /dev/null
 > +++ b/board/firefly/firefly-rk3288/post-image.sh
 > @@ -0,0 +1,6 @@
 > +board=board/firefly/firefly-rk3288

You can use $(dirname $0) instead of hardcoding this.


> +MKIMAGE=$HOST_DIR/usr/bin/mkimage
 > +
 > +$MKIMAGE -n rk3288 -T rksd -d $BINARIES_DIR/u-boot-spl-dtb.bin $BINARIES_DIR/u-boot-spl-dtb.img
 > +
 > +${board}/build_sd_image.sh
 > diff --git a/board/firefly/firefly-rk3288/pre-image.sh b/board/firefly/firefly-rk3288/pre-image.sh

Other boards calls this post-build.sh, please use that as well for
consistency.


> new file mode 100755
 > index 0000000..7770f6b
 > --- /dev/null
 > +++ b/board/firefly/firefly-rk3288/pre-image.sh
 > @@ -0,0 +1,3 @@
 > +board=board/firefly/firefly-rk3288

dirname $0 as well here.

> +
 > +install -m 0644 -D $board/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf

You could simply put this in a rootfs overlay and point
BR2_ROOTFS_OVERLAY to that directory instead of this explicit handling.

Other than that it looks good.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 3/3] configs/firefly_rk3288: new board
  2016-01-22 15:53 ` [Buildroot] [PATCH 3/3] configs/firefly_rk3288: " Ariel D'Alessandro
@ 2016-02-10 21:08   ` Peter Korsgaard
  2016-02-14 19:01     ` Ariel D'Alessandro
  0 siblings, 1 reply; 11+ messages in thread
From: Peter Korsgaard @ 2016-02-10 21:08 UTC (permalink / raw)
  To: buildroot

>>>>> "Ariel" == Ariel D'Alessandro <ariel@vanguardiasur.com.ar> writes:

 > Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
 > ---
 >  configs/firefly_rk3288_defconfig | 40 ++++++++++++++++++++++++++++++++++++++++
 >  1 file changed, 40 insertions(+)
 >  create mode 100644 configs/firefly_rk3288_defconfig

 > diff --git a/configs/firefly_rk3288_defconfig b/configs/firefly_rk3288_defconfig
 > new file mode 100644
 > index 0000000..28becfd
 > --- /dev/null
 > +++ b/configs/firefly_rk3288_defconfig
 > @@ -0,0 +1,40 @@
 > +BR2_arm=y
 > +BR2_cortex_a15=y
 > +BR2_ARM_FPU_NEON_VFPV4=y
 > +BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
 > +BR2_TOOLCHAIN_BUILDROOT_CXX=y

Our defconfigs are normally very minimal, E.G. only a basic busybox
based image and a kernel/bootloader - In other words the basics to start
your own development from.

There has been some discussion about doing more full blown "demo"
defconfigs, so I'm fine with adding a more complicated
firefly_rk3288_demo_defconfig in addition to the basic one.


 > +BR2_TARGET_GENERIC_HOSTNAME="firefly-rk3288"
 > +BR2_TARGET_GENERIC_ISSUE="Welcome to FIREFLY RK3288!"
 > +BR2_TARGET_GENERIC_GETTY_PORT="/dev/console"

The /dev/ should afaik not be there and we default to "console" already,
so this can be dropped.

> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/firefly/firefly-rk3288/pre-image.sh"
 > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/firefly/firefly-rk3288/post-image.sh"
 > +BR2_LINUX_KERNEL=y
 > +BR2_LINUX_KERNEL_CUSTOM_GIT=y
 > +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git at github.com:mmind/linux-rockchip.git"
 > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ccb89e9b5657b4911c16d08e1581121222ee12c4"

Will this commit stay available or is this a branch that gets rebased?

What kernel version is this? I see you don't set the kernel-headers
version.

> +BR2_LINUX_KERNEL_DEFCONFIG="rk3288_veyron"
 > +BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
 > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
 > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-firefly"
 > +BR2_LINUX_KERNEL_INSTALL_TARGET=y
 > +BR2_PACKAGE_QT5=y
 > +BR2_PACKAGE_QT5BASE_LICENSE_APPROVED=y
 > +BR2_PACKAGE_QT5BASE_EXAMPLES=y
 > +BR2_PACKAGE_QT5BASE_GUI=y
 > +BR2_PACKAGE_QT5BASE_EGLFS=y
 > +BR2_PACKAGE_MALI_T76X=y
 > +BR2_TARGET_ROOTFS_EXT2=y
 > +BR2_TARGET_ROOTFS_EXT2_4=y
 > +# BR2_TARGET_ROOTFS_TAR is not set
 > +BR2_TARGET_UBOOT=y
 > +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 > +BR2_TARGET_UBOOT_CUSTOM_GIT=y
 > +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://git.denx.de/u-boot.git"
 > +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="v2016.01"

As this is mainline u-boot you can simply set:

BR2_TARGET_UBOOT_CUSTOM_VERSION=y
BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2016.01"

And Buildroot will download the 2016.01 tarball.

Other than that it looks good, thanks. Care to send updated patches
fixing these issues?

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/3] mali-t76x: add new package
  2016-02-10 20:34   ` Peter Korsgaard
@ 2016-02-14 18:56     ` Ariel D'Alessandro
  0 siblings, 0 replies; 11+ messages in thread
From: Ariel D'Alessandro @ 2016-02-14 18:56 UTC (permalink / raw)
  To: buildroot

Hi Peter,

El 10/02/16 a las 17:34, Peter Korsgaard escribi?:
>>>>>> "Ariel" == Ariel D'Alessandro <ariel@vanguardiasur.com.ar> writes:
> 
>  > Package provides the binary user-space components for the ARM Mali
>  > Midgard T76X GPU.
> 
>  > Note that this package requires a kernel with the ARM Mali Midgard GPU
>  > Kernel Drivers enabled.
> 
>  > Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
>  > ---
>  >  package/Config.in                                  |  1 +
>  >  ...latform.h-with-framebuffer-instead-of-X11.patch | 39 +++++++++++++
>  >  package/mali-t76x/Config.in                        | 27 +++++++++
>  >  package/mali-t76x/egl.pc                           | 12 ++++
>  >  package/mali-t76x/glesv2.pc                        | 12 ++++
>  >  package/mali-t76x/rockchip-mali.mk                 | 64 ++++++++++++++++++++++
>  >  6 files changed, 155 insertions(+)
>  >  create mode 100644 package/mali-t76x/0001-use-eglplatform.h-with-framebuffer-instead-of-X11.patch
>  >  create mode 100644 package/mali-t76x/Config.in
>  >  create mode 100644 package/mali-t76x/egl.pc
>  >  create mode 100644 package/mali-t76x/glesv2.pc
>  >  create mode 100644 package/mali-t76x/rockchip-mali.mk
> 
>  > diff --git a/package/mali-t76x/rockchip-mali.mk b/package/mali-t76x/rockchip-mali.mk
>  > new file mode 100644
>  > index 0000000..3117864
>  > --- /dev/null
>  > +++ b/package/mali-t76x/rockchip-mali.mk
> 
> This file should be named mali-t76x.mk to match the directory and
> variables.

Right, will do that.

> 
>> @@ -0,0 +1,64 @@
>  > +################################################################################
>  > +#
>  > +# mali-t76x
>  > +#
>  > +################################################################################
>  > +
>  > +MALI_T76X_VERSION = r5p0-06rel0
>  > +MALI_T76X_SOURCE = mali-t76x_$(MALI_T76X_VERSION)_linux_1+fbdev.tar.gz
>  > +MALI_T76X_SITE = http://malideveloper.arm.com/downloads/drivers/binary/$(MALI_T76X_VERSION)
> 
> A .hash file listing the sha256sum for this would be nice.

OK, will do.

> 
>> +
>  > +MALI_T76X_EXTRA_SITE = https://www.khronos.org/registry
>  > +MALI_T76X_EXTRA_DOWNLOADS = \
>  > +	$(MALI_T76X_EXTRA_SITE)/egl/api/EGL/egl.h \
>  > +	$(MALI_T76X_EXTRA_SITE)/egl/api/EGL/eglext.h \
>  > +	$(MALI_T76X_EXTRA_SITE)/egl/api/EGL/eglplatform.h \
>  > +	$(MALI_T76X_EXTRA_SITE)/gles/api/GLES/gl.h \
>  > +	$(MALI_T76X_EXTRA_SITE)/gles/api/GLES/glext.h \
>  > +	$(MALI_T76X_EXTRA_SITE)/gles/api/GLES/glplatform.h \
>  > +	$(MALI_T76X_EXTRA_SITE)/gles/api/old/2.0/gl2.h \
>  > +	$(MALI_T76X_EXTRA_SITE)/gles/api/old/2.0/gl2ext.h \
>  > +	$(MALI_T76X_EXTRA_SITE)/gles/api/old/2.0/gl2platform.h \
>  > +	$(MALI_T76X_EXTRA_SITE)/egl/api/KHR/khrplatform.h
> 
> Could this use mesa3d-headers like the nvidia drivers do?

I wasn't aware of the mesa3d-headers. It seems to be just what needed
here, so I'll give a try and modify the package as well.

> 
> Other than that it looks good.
> 

Thanks!

-- 
Ariel D'Alessandro, VanguardiaSur
www.vanguardiasur.com.ar

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/3] board/firefly_rk3288: add new board
  2016-02-10 20:57   ` Peter Korsgaard
@ 2016-02-14 18:59     ` Ariel D'Alessandro
  0 siblings, 0 replies; 11+ messages in thread
From: Ariel D'Alessandro @ 2016-02-14 18:59 UTC (permalink / raw)
  To: buildroot

Peter,

El 10/02/16 a las 17:57, Peter Korsgaard escribi?:
>>>>>> "Ariel" == Ariel D'Alessandro <ariel@vanguardiasur.com.ar> writes:
> 
>  > More info about the board:
>  > http://en.t-firefly.com/en/firenow/firefly_rk3288/specifications/
> 
>  > Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
>  > ---
>  >  board/firefly/firefly-rk3288/build_sd_image.sh | 18 ++++++++++++
>  >  board/firefly/firefly-rk3288/extlinux.conf     |  6 ++++
>  >  board/firefly/firefly-rk3288/post-image.sh     |  6 ++++
>  >  board/firefly/firefly-rk3288/pre-image.sh      |  3 ++
>  >  board/firefly/firefly-rk3288/readme.txt        | 40 ++++++++++++++++++++++++++
>  >  board/firefly/firefly-rk3288/sd-image.cfg      | 22 ++++++++++++++
> 
> It imho makes sense to squash the defconfig patch together with this
> one.

OK, will squash these patches then.

> 
>>  6 files changed, 95 insertions(+)
>  >  create mode 100755 board/firefly/firefly-rk3288/build_sd_image.sh
>  >  create mode 100644 board/firefly/firefly-rk3288/extlinux.conf
>  >  create mode 100755 board/firefly/firefly-rk3288/post-image.sh
>  >  create mode 100755 board/firefly/firefly-rk3288/pre-image.sh
>  >  create mode 100644 board/firefly/firefly-rk3288/readme.txt
>  >  create mode 100644 board/firefly/firefly-rk3288/sd-image.cfg
> 
>  > diff --git a/board/firefly/firefly-rk3288/build_sd_image.sh b/board/firefly/firefly-rk3288/build_sd_image.sh
>  > new file mode 100755
>  > index 0000000..ae7fde1
>  > --- /dev/null
>  > +++ b/board/firefly/firefly-rk3288/build_sd_image.sh
>  > @@ -0,0 +1,18 @@
>  > +#!/bin/bash
>  > +
>  > +set -ue
>  > +
>  > +D=board/firefly/firefly-rk3288
>  > +CFG=${D}/sd-image.cfg
>  > +
>  > +T=$(mktemp -d)
>  > +mkdir -p $T/{root,tmp}
> 
> Other post-image scripts use ${BUILD_DIR}/genimage.tmp for the temporary
> directory, please do as well.

Will do.

> 
>> +
>  > +$HOST_DIR/usr/bin/genimage		\
>  > +	--rootpath $T/root/			\
>  > +	--tmppath $T/tmp/			\
>  > +	--inputpath $BINARIES_DIR/	\
>  > +	--outputpath $BINARIES_DIR/	\
>  > +	--config ${CFG}				\
>  > +
>  > +rm -rf $T
> 
> All our other defconfigs call genimage directly from post-image.sh, and
> as this is a very small script would prefer to do that here as well.

OK, will do that.

> 
> 
>> diff --git a/board/firefly/firefly-rk3288/extlinux.conf b/board/firefly/firefly-rk3288/extlinux.conf
>  > new file mode 100644
>  > index 0000000..65092d2
>  > --- /dev/null
>  > +++ b/board/firefly/firefly-rk3288/extlinux.conf
>  > @@ -0,0 +1,6 @@
>  > +default firefly-rk3288
>  > +
>  > +label firefly-rk3288
>  > +kernel /boot/uImage
>  > +devicetree /boot/rk3288-firefly.dtb
>  > +append console=ttyS2,115200n8 earlyprintk init=/sbin/init root=/dev/mmcblk0p1 rootwait
> 
> why the init=? Is earlyprintk really good to use by default?

None of these options are really needed, so I'll remove them.

> 
> 
>> diff --git a/board/firefly/firefly-rk3288/post-image.sh b/board/firefly/firefly-rk3288/post-image.sh
>  > new file mode 100755
>  > index 0000000..98c2778
>  > --- /dev/null
>  > +++ b/board/firefly/firefly-rk3288/post-image.sh
>  > @@ -0,0 +1,6 @@
>  > +board=board/firefly/firefly-rk3288
> 
> You can use $(dirname $0) instead of hardcoding this.

OK.

> 
> 
>> +MKIMAGE=$HOST_DIR/usr/bin/mkimage
>  > +
>  > +$MKIMAGE -n rk3288 -T rksd -d $BINARIES_DIR/u-boot-spl-dtb.bin $BINARIES_DIR/u-boot-spl-dtb.img
>  > +
>  > +${board}/build_sd_image.sh
>  > diff --git a/board/firefly/firefly-rk3288/pre-image.sh b/board/firefly/firefly-rk3288/pre-image.sh
> 
> Other boards calls this post-build.sh, please use that as well for
> consistency.

OK.

> 
> 
>> new file mode 100755
>  > index 0000000..7770f6b
>  > --- /dev/null
>  > +++ b/board/firefly/firefly-rk3288/pre-image.sh
>  > @@ -0,0 +1,3 @@
>  > +board=board/firefly/firefly-rk3288
> 
> dirname $0 as well here.

OK.

> 
>> +
>  > +install -m 0644 -D $board/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
> 
> You could simply put this in a rootfs overlay and point
> BR2_ROOTFS_OVERLAY to that directory instead of this explicit handling.

Well, if you're OK with this, I'd prefer keeping that as it is now
instead of the overlay.

> 
> Other than that it looks good.
> 

Thanks!

-- 
Ariel D'Alessandro, VanguardiaSur
www.vanguardiasur.com.ar

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 3/3] configs/firefly_rk3288: new board
  2016-02-10 21:08   ` Peter Korsgaard
@ 2016-02-14 19:01     ` Ariel D'Alessandro
  2016-02-14 19:29       ` Peter Korsgaard
  0 siblings, 1 reply; 11+ messages in thread
From: Ariel D'Alessandro @ 2016-02-14 19:01 UTC (permalink / raw)
  To: buildroot

Peter,

El 10/02/16 a las 18:08, Peter Korsgaard escribi?:
>>>>>> "Ariel" == Ariel D'Alessandro <ariel@vanguardiasur.com.ar> writes:
> 
>  > Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
>  > ---
>  >  configs/firefly_rk3288_defconfig | 40 ++++++++++++++++++++++++++++++++++++++++
>  >  1 file changed, 40 insertions(+)
>  >  create mode 100644 configs/firefly_rk3288_defconfig
> 
>  > diff --git a/configs/firefly_rk3288_defconfig b/configs/firefly_rk3288_defconfig
>  > new file mode 100644
>  > index 0000000..28becfd
>  > --- /dev/null
>  > +++ b/configs/firefly_rk3288_defconfig
>  > @@ -0,0 +1,40 @@
>  > +BR2_arm=y
>  > +BR2_cortex_a15=y
>  > +BR2_ARM_FPU_NEON_VFPV4=y
>  > +BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
>  > +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> 
> Our defconfigs are normally very minimal, E.G. only a basic busybox
> based image and a kernel/bootloader - In other words the basics to start
> your own development from.
> 
> There has been some discussion about doing more full blown "demo"
> defconfigs, so I'm fine with adding a more complicated
> firefly_rk3288_demo_defconfig in addition to the basic one.

I see. So, I could submit a firefly_rk3288_demo_defconfig with Qt5
enabled and a firefly_rk3288_defconfig without it, just the minimal
stuff. Do you agree?

> 
> 
>  > +BR2_TARGET_GENERIC_HOSTNAME="firefly-rk3288"
>  > +BR2_TARGET_GENERIC_ISSUE="Welcome to FIREFLY RK3288!"
>  > +BR2_TARGET_GENERIC_GETTY_PORT="/dev/console"
> 
> The /dev/ should afaik not be there and we default to "console" already,
> so this can be dropped.

OK, will drop it.

> 
>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/firefly/firefly-rk3288/pre-image.sh"
>  > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/firefly/firefly-rk3288/post-image.sh"
>  > +BR2_LINUX_KERNEL=y
>  > +BR2_LINUX_KERNEL_CUSTOM_GIT=y
>  > +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git at github.com:mmind/linux-rockchip.git"
>  > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ccb89e9b5657b4911c16d08e1581121222ee12c4"
> 
> Will this commit stay available or is this a branch that gets rebased?

It's a devel branch from Heiko, so it will rebased almost for sure.
However, this commit is probably to stay available as it isn't one of
the latest ones.

Of course, the right thing to do here is to take the kernel from
mainline and patch it with the Midgard stuff. I'm planning doing this in
the future, but just for now I think that building from that Heiko's
commit won't cause any trouble.

> 
> What kernel version is this? I see you don't set the kernel-headers
> version.

It's a 4.4.0-rc5 kernel. Missed that, I'll set the proper kernel-headers
for this version.

> 
>> +BR2_LINUX_KERNEL_DEFCONFIG="rk3288_veyron"
>  > +BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
>  > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
>  > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-firefly"
>  > +BR2_LINUX_KERNEL_INSTALL_TARGET=y
>  > +BR2_PACKAGE_QT5=y
>  > +BR2_PACKAGE_QT5BASE_LICENSE_APPROVED=y
>  > +BR2_PACKAGE_QT5BASE_EXAMPLES=y
>  > +BR2_PACKAGE_QT5BASE_GUI=y
>  > +BR2_PACKAGE_QT5BASE_EGLFS=y
>  > +BR2_PACKAGE_MALI_T76X=y
>  > +BR2_TARGET_ROOTFS_EXT2=y
>  > +BR2_TARGET_ROOTFS_EXT2_4=y
>  > +# BR2_TARGET_ROOTFS_TAR is not set
>  > +BR2_TARGET_UBOOT=y
>  > +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>  > +BR2_TARGET_UBOOT_CUSTOM_GIT=y
>  > +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://git.denx.de/u-boot.git"
>  > +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="v2016.01"
> 
> As this is mainline u-boot you can simply set:
> 
> BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2016.01"
> 
> And Buildroot will download the 2016.01 tarball.

Right, will do.

> 
> Other than that it looks good, thanks. Care to send updated patches
> fixing these issues?
> 

Yeah, I'm sending a patchset v2 ASAP. Thanks!

-- 
Ariel D'Alessandro, VanguardiaSur
www.vanguardiasur.com.ar

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 3/3] configs/firefly_rk3288: new board
  2016-02-14 19:01     ` Ariel D'Alessandro
@ 2016-02-14 19:29       ` Peter Korsgaard
  0 siblings, 0 replies; 11+ messages in thread
From: Peter Korsgaard @ 2016-02-14 19:29 UTC (permalink / raw)
  To: buildroot

>>>>> "Ariel" == Ariel D'Alessandro <ariel@vanguardiasur.com.ar> writes:

Hi,

>> Our defconfigs are normally very minimal, E.G. only a basic busybox
 >> based image and a kernel/bootloader - In other words the basics to start
 >> your own development from.
 >> 
 >> There has been some discussion about doing more full blown "demo"
 >> defconfigs, so I'm fine with adding a more complicated
 >> firefly_rk3288_demo_defconfig in addition to the basic one.

 > I see. So, I could submit a firefly_rk3288_demo_defconfig with Qt5
 > enabled and a firefly_rk3288_defconfig without it, just the minimal
 > stuff. Do you agree?

Yes, that's fine!

 >>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/firefly/firefly-rk3288/pre-image.sh"
 >> > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/firefly/firefly-rk3288/post-image.sh"
 >> > +BR2_LINUX_KERNEL=y
 >> > +BR2_LINUX_KERNEL_CUSTOM_GIT=y
 >> > +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git at github.com:mmind/linux-rockchip.git"
 >> > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ccb89e9b5657b4911c16d08e1581121222ee12c4"
 >> 
 >> Will this commit stay available or is this a branch that gets rebased?

 > It's a devel branch from Heiko, so it will rebased almost for sure.
 > However, this commit is probably to stay available as it isn't one of
 > the latest ones.

 > Of course, the right thing to do here is to take the kernel from
 > mainline and patch it with the Midgard stuff. I'm planning doing this in
 > the future, but just for now I think that building from that Heiko's
 > commit won't cause any trouble.

Ok. It would be good to hear from Heiko if we can expect this commit to
stay. Heiko, what do you say?

 >> Other than that it looks good, thanks. Care to send updated patches
 >> fixing these issues?
 >> 

 > Yeah, I'm sending a patchset v2 ASAP. Thanks!

Great, thanks!

-- 
Venlig hilsen,
Peter Korsgaard 

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-02-14 19:29 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-22 15:53 [Buildroot] [PATCH 0/3] Add support for Firefly RK3288 Ariel D'Alessandro
2016-01-22 15:53 ` [Buildroot] [PATCH 1/3] mali-t76x: add new package Ariel D'Alessandro
2016-02-10 20:34   ` Peter Korsgaard
2016-02-14 18:56     ` Ariel D'Alessandro
2016-01-22 15:53 ` [Buildroot] [PATCH 2/3] board/firefly_rk3288: add new board Ariel D'Alessandro
2016-02-10 20:57   ` Peter Korsgaard
2016-02-14 18:59     ` Ariel D'Alessandro
2016-01-22 15:53 ` [Buildroot] [PATCH 3/3] configs/firefly_rk3288: " Ariel D'Alessandro
2016-02-10 21:08   ` Peter Korsgaard
2016-02-14 19:01     ` Ariel D'Alessandro
2016-02-14 19:29       ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.