* [PATCH V4 07/11] of: Add bindings of hw-trip-points for soctherm
@ 2016-01-25 10:46 ` Wei Ni
0 siblings, 0 replies; 6+ messages in thread
From: Wei Ni @ 2016-01-25 10:46 UTC (permalink / raw)
To: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w, rui.zhang-ral2JQCrhuEAvxtiuMwx3w
Cc: MLongnecker-DDmLM1+adcrQT0dZR+AlfA,
swarren-3lzwWm7+Weoh9ZMKESR00Q, mikko.perttunen-/1wQRMveznE,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Wei Ni
Add hw-trips sub-node for soctherm, which is
used to describe the hardware trip points for
each soctherm sensors.
Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
.../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
index 6b68cd150405..75dc9dbe7e1a 100644
--- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
+++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
@@ -26,6 +26,15 @@ Required properties :
of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a
list of valid values when referring to thermal sensors.
+Optional properties:
+- hw-trip-points : A sub-node which is a container of hardware trip points
+ for each sensors.
+ * sensors: Sub-nodes which are used to describe the HW trip points info,
+ must be named as "cpu", "gpu", "mem", "pll".
+ Properties:
+ - thermtrip-temperature : Shutdown or reset temperature in millicelsius,
+ once the temperature of this sensor is higher than the
+ thermtrip-temperature, the system will be shutdown or reset.
Example :
@@ -40,6 +49,21 @@ Example :
reset-names = "soctherm";
#thermal-sensor-cells = <1>;
+
+ hw-trip-points {
+ cpu {
+ thermtrip-temperature = <103000>;
+ };
+ gpu {
+ thermtrip-temperature = <103500>;
+ };
+ mem {
+ thermtrip-temperature = <103500>;
+ };
+ pll {
+ thermtrip-temperature = <105000>;
+ };
+ };
};
Example: referring to thermal sensors :
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V4 07/11] of: Add bindings of hw-trip-points for soctherm
@ 2016-01-25 10:46 ` Wei Ni
0 siblings, 0 replies; 6+ messages in thread
From: Wei Ni @ 2016-01-25 10:46 UTC (permalink / raw)
To: thierry.reding, rui.zhang
Cc: MLongnecker, swarren, mikko.perttunen, linux-tegra, linux-kernel,
devicetree, Wei Ni
Add hw-trips sub-node for soctherm, which is
used to describe the hardware trip points for
each soctherm sensors.
Signed-off-by: Wei Ni <wni@nvidia.com>
---
.../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
index 6b68cd150405..75dc9dbe7e1a 100644
--- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
+++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
@@ -26,6 +26,15 @@ Required properties :
of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a
list of valid values when referring to thermal sensors.
+Optional properties:
+- hw-trip-points : A sub-node which is a container of hardware trip points
+ for each sensors.
+ * sensors: Sub-nodes which are used to describe the HW trip points info,
+ must be named as "cpu", "gpu", "mem", "pll".
+ Properties:
+ - thermtrip-temperature : Shutdown or reset temperature in millicelsius,
+ once the temperature of this sensor is higher than the
+ thermtrip-temperature, the system will be shutdown or reset.
Example :
@@ -40,6 +49,21 @@ Example :
reset-names = "soctherm";
#thermal-sensor-cells = <1>;
+
+ hw-trip-points {
+ cpu {
+ thermtrip-temperature = <103000>;
+ };
+ gpu {
+ thermtrip-temperature = <103500>;
+ };
+ mem {
+ thermtrip-temperature = <103500>;
+ };
+ pll {
+ thermtrip-temperature = <105000>;
+ };
+ };
};
Example: referring to thermal sensors :
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V4 07/11] of: Add bindings of hw-trip-points for soctherm
2016-01-25 10:46 ` Wei Ni
@ 2016-01-26 2:41 ` Rob Herring
-1 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2016-01-26 2:41 UTC (permalink / raw)
To: Wei Ni
Cc: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
rui.zhang-ral2JQCrhuEAvxtiuMwx3w,
MLongnecker-DDmLM1+adcrQT0dZR+AlfA,
swarren-3lzwWm7+Weoh9ZMKESR00Q, mikko.perttunen-/1wQRMveznE,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
On Mon, Jan 25, 2016 at 06:46:36PM +0800, Wei Ni wrote:
> Add hw-trips sub-node for soctherm, which is
> used to describe the hardware trip points for
> each soctherm sensors.
This seems like something that should be common. There was a hwmon
binding just the other day with temperature set points.
> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> index 6b68cd150405..75dc9dbe7e1a 100644
> --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> @@ -26,6 +26,15 @@ Required properties :
> of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a
> list of valid values when referring to thermal sensors.
>
> +Optional properties:
> +- hw-trip-points : A sub-node which is a container of hardware trip points
> + for each sensors.
> + * sensors: Sub-nodes which are used to describe the HW trip points info,
> + must be named as "cpu", "gpu", "mem", "pll".
> + Properties:
> + - thermtrip-temperature : Shutdown or reset temperature in millicelsius,
> + once the temperature of this sensor is higher than the
> + thermtrip-temperature, the system will be shutdown or reset.
Append units and temperature is a bit redundant. Something like
thermtrip-mC or thermtrip-milliC
You could easily have multiple levels of trip points, so perhaps the
name needs to reflect the action (i.e. shutdown).
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V4 07/11] of: Add bindings of hw-trip-points for soctherm
@ 2016-01-26 2:41 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2016-01-26 2:41 UTC (permalink / raw)
To: Wei Ni
Cc: thierry.reding, rui.zhang, MLongnecker, swarren, mikko.perttunen,
linux-tegra, linux-kernel, devicetree
On Mon, Jan 25, 2016 at 06:46:36PM +0800, Wei Ni wrote:
> Add hw-trips sub-node for soctherm, which is
> used to describe the hardware trip points for
> each soctherm sensors.
This seems like something that should be common. There was a hwmon
binding just the other day with temperature set points.
> Signed-off-by: Wei Ni <wni@nvidia.com>
> ---
> .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> index 6b68cd150405..75dc9dbe7e1a 100644
> --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> @@ -26,6 +26,15 @@ Required properties :
> of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a
> list of valid values when referring to thermal sensors.
>
> +Optional properties:
> +- hw-trip-points : A sub-node which is a container of hardware trip points
> + for each sensors.
> + * sensors: Sub-nodes which are used to describe the HW trip points info,
> + must be named as "cpu", "gpu", "mem", "pll".
> + Properties:
> + - thermtrip-temperature : Shutdown or reset temperature in millicelsius,
> + once the temperature of this sensor is higher than the
> + thermtrip-temperature, the system will be shutdown or reset.
Append units and temperature is a bit redundant. Something like
thermtrip-mC or thermtrip-milliC
You could easily have multiple levels of trip points, so perhaps the
name needs to reflect the action (i.e. shutdown).
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V4 07/11] of: Add bindings of hw-trip-points for soctherm
2016-01-26 2:41 ` Rob Herring
@ 2016-01-26 6:11 ` Wei Ni
-1 siblings, 0 replies; 6+ messages in thread
From: Wei Ni @ 2016-01-26 6:11 UTC (permalink / raw)
To: Rob Herring
Cc: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
rui.zhang-ral2JQCrhuEAvxtiuMwx3w,
MLongnecker-DDmLM1+adcrQT0dZR+AlfA,
swarren-3lzwWm7+Weoh9ZMKESR00Q, mikko.perttunen-/1wQRMveznE,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
On 2016年01月26日 10:41, Rob Herring wrote:
> On Mon, Jan 25, 2016 at 06:46:36PM +0800, Wei Ni wrote:
>> Add hw-trips sub-node for soctherm, which is
>> used to describe the hardware trip points for
>> each soctherm sensors.
>
> This seems like something that should be common. There was a hwmon
> binding just the other day with temperature set points.
I have checked the thermal_hwmon.c, but we can't use it. Because we use
of-thermal to register thermal zone, but it doesn't support to register to
hwmon. And it only support to show the critical temperature.
I think this sub-node is used for Tegra's soctherm specifically. And it's not
only for shutdown/reset, it also will be used to describe the hw-throttle
function in next serial patches (I'm preparing it, didn't send out yet).
BTW, I didn't find the hwmon binding to introduce the hw trips in TOT
kernel-next, could you show me it?
>
>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
>> index 6b68cd150405..75dc9dbe7e1a 100644
>> --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
>> +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
>> @@ -26,6 +26,15 @@ Required properties :
>> of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a
>> list of valid values when referring to thermal sensors.
>>
>> +Optional properties:
>> +- hw-trip-points : A sub-node which is a container of hardware trip points
>> + for each sensors.
>> + * sensors: Sub-nodes which are used to describe the HW trip points info,
>> + must be named as "cpu", "gpu", "mem", "pll".
>> + Properties:
>> + - thermtrip-temperature : Shutdown or reset temperature in millicelsius,
>> + once the temperature of this sensor is higher than the
>> + thermtrip-temperature, the system will be shutdown or reset.
>
> Append units and temperature is a bit redundant. Something like
> thermtrip-mC or thermtrip-milliC
Hmm, got it, will change it in next version.
>
> You could easily have multiple levels of trip points, so perhaps the
> name needs to reflect the action (i.e. shutdown).
This temperature can trigger shutdown or reset, it depends on the platform
design, and the Tegra's SPEC call it as thermtrip, so I use this name. I prefer
to use "thermtgrip-mC".
>
> Rob
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V4 07/11] of: Add bindings of hw-trip-points for soctherm
@ 2016-01-26 6:11 ` Wei Ni
0 siblings, 0 replies; 6+ messages in thread
From: Wei Ni @ 2016-01-26 6:11 UTC (permalink / raw)
To: Rob Herring
Cc: thierry.reding, rui.zhang, MLongnecker, swarren, mikko.perttunen,
linux-tegra, linux-kernel, devicetree
On 2016年01月26日 10:41, Rob Herring wrote:
> On Mon, Jan 25, 2016 at 06:46:36PM +0800, Wei Ni wrote:
>> Add hw-trips sub-node for soctherm, which is
>> used to describe the hardware trip points for
>> each soctherm sensors.
>
> This seems like something that should be common. There was a hwmon
> binding just the other day with temperature set points.
I have checked the thermal_hwmon.c, but we can't use it. Because we use
of-thermal to register thermal zone, but it doesn't support to register to
hwmon. And it only support to show the critical temperature.
I think this sub-node is used for Tegra's soctherm specifically. And it's not
only for shutdown/reset, it also will be used to describe the hw-throttle
function in next serial patches (I'm preparing it, didn't send out yet).
BTW, I didn't find the hwmon binding to introduce the hw trips in TOT
kernel-next, could you show me it?
>
>> Signed-off-by: Wei Ni <wni@nvidia.com>
>> ---
>> .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
>> index 6b68cd150405..75dc9dbe7e1a 100644
>> --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
>> +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
>> @@ -26,6 +26,15 @@ Required properties :
>> of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a
>> list of valid values when referring to thermal sensors.
>>
>> +Optional properties:
>> +- hw-trip-points : A sub-node which is a container of hardware trip points
>> + for each sensors.
>> + * sensors: Sub-nodes which are used to describe the HW trip points info,
>> + must be named as "cpu", "gpu", "mem", "pll".
>> + Properties:
>> + - thermtrip-temperature : Shutdown or reset temperature in millicelsius,
>> + once the temperature of this sensor is higher than the
>> + thermtrip-temperature, the system will be shutdown or reset.
>
> Append units and temperature is a bit redundant. Something like
> thermtrip-mC or thermtrip-milliC
Hmm, got it, will change it in next version.
>
> You could easily have multiple levels of trip points, so perhaps the
> name needs to reflect the action (i.e. shutdown).
This temperature can trigger shutdown or reset, it depends on the platform
design, and the Tegra's SPEC call it as thermtrip, so I use this name. I prefer
to use "thermtgrip-mC".
>
> Rob
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-26 6:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-25 10:46 [PATCH V4 07/11] of: Add bindings of hw-trip-points for soctherm Wei Ni
2016-01-25 10:46 ` Wei Ni
[not found] ` <1453718796-4393-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-01-26 2:41 ` Rob Herring
2016-01-26 2:41 ` Rob Herring
2016-01-26 6:11 ` Wei Ni
2016-01-26 6:11 ` Wei Ni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.