All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rtc: mt6397: add IRQ domain dependency
@ 2016-01-25 16:04 ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2016-01-25 16:04 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: linux-arm-kernel, Wei-Ning Huang, Eddie Huang, Tianping Fang,
	Henry Chen, Arnd Bergmann, Alessandro Zummo, rtc-linux,
	linux-kernel

The mt6397 RTC driver can be built either when the MFD_MT6397 driver
is enabled (which selects IRQ_DOMAIN), or when compile testing.
The latter however fails without IRQ domains:

drivers/rtc/rtc-mt6397.c: In function 'mtk_rtc_probe':
drivers/rtc/rtc-mt6397.c:326:13: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
  rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);

This adds an explicit dependency for the COMPILE_TEST case.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/rtc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 376322f71fd5..4395608bf7fc 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1603,7 +1603,7 @@ config RTC_DRV_MOXART
 
 config RTC_DRV_MT6397
 	tristate "Mediatek Real Time Clock driver"
-	depends on MFD_MT6397 || COMPILE_TEST
+	depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN)
 	help
 	  This selects the Mediatek(R) RTC driver. RTC is part of Mediatek
 	  MT6397 PMIC. You should enable MT6397 PMIC MFD before select
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [rtc-linux] [PATCH] rtc: mt6397: add IRQ domain dependency
@ 2016-01-25 16:04 ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2016-01-25 16:04 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: linux-arm-kernel, Wei-Ning Huang, Eddie Huang, Tianping Fang,
	Henry Chen, Arnd Bergmann, Alessandro Zummo, rtc-linux,
	linux-kernel

The mt6397 RTC driver can be built either when the MFD_MT6397 driver
is enabled (which selects IRQ_DOMAIN), or when compile testing.
The latter however fails without IRQ domains:

drivers/rtc/rtc-mt6397.c: In function 'mtk_rtc_probe':
drivers/rtc/rtc-mt6397.c:326:13: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
  rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);

This adds an explicit dependency for the COMPILE_TEST case.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/rtc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 376322f71fd5..4395608bf7fc 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1603,7 +1603,7 @@ config RTC_DRV_MOXART
 
 config RTC_DRV_MT6397
 	tristate "Mediatek Real Time Clock driver"
-	depends on MFD_MT6397 || COMPILE_TEST
+	depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN)
 	help
 	  This selects the Mediatek(R) RTC driver. RTC is part of Mediatek
 	  MT6397 PMIC. You should enable MT6397 PMIC MFD before select
-- 
2.7.0

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] rtc: mt6397: add IRQ domain dependency
@ 2016-01-25 16:04 ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2016-01-25 16:04 UTC (permalink / raw)
  To: linux-arm-kernel

The mt6397 RTC driver can be built either when the MFD_MT6397 driver
is enabled (which selects IRQ_DOMAIN), or when compile testing.
The latter however fails without IRQ domains:

drivers/rtc/rtc-mt6397.c: In function 'mtk_rtc_probe':
drivers/rtc/rtc-mt6397.c:326:13: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
  rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);

This adds an explicit dependency for the COMPILE_TEST case.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/rtc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 376322f71fd5..4395608bf7fc 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1603,7 +1603,7 @@ config RTC_DRV_MOXART
 
 config RTC_DRV_MT6397
 	tristate "Mediatek Real Time Clock driver"
-	depends on MFD_MT6397 || COMPILE_TEST
+	depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN)
 	help
 	  This selects the Mediatek(R) RTC driver. RTC is part of Mediatek
 	  MT6397 PMIC. You should enable MT6397 PMIC MFD before select
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] rtc: mt6397: add IRQ domain dependency
  2016-01-25 16:04 ` [rtc-linux] " Arnd Bergmann
  (?)
@ 2016-01-26  4:54   ` Eddie Huang
  -1 siblings, 0 replies; 9+ messages in thread
From: Eddie Huang @ 2016-01-26  4:54 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Alexandre Belloni, linux-arm-kernel, Wei-Ning Huang,
	Tianping Fang, Henry Chen, Alessandro Zummo, rtc-linux,
	linux-kernel

On Mon, 2016-01-25 at 17:04 +0100, Arnd Bergmann wrote:
> The mt6397 RTC driver can be built either when the MFD_MT6397 driver
> is enabled (which selects IRQ_DOMAIN), or when compile testing.
> The latter however fails without IRQ domains:
> 
> drivers/rtc/rtc-mt6397.c: In function 'mtk_rtc_probe':
> drivers/rtc/rtc-mt6397.c:326:13: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
>   rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);
> 
> This adds an explicit dependency for the COMPILE_TEST case.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/rtc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 376322f71fd5..4395608bf7fc 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1603,7 +1603,7 @@ config RTC_DRV_MOXART
>  
>  config RTC_DRV_MT6397
>  	tristate "Mediatek Real Time Clock driver"
> -	depends on MFD_MT6397 || COMPILE_TEST
> +	depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN)
>  	help
>  	  This selects the Mediatek(R) RTC driver. RTC is part of Mediatek
>  	  MT6397 PMIC. You should enable MT6397 PMIC MFD before select

Hi Arnd,

Thanks your correction.
Acked-by: Eddie Huang <eddie.huang@mediatek.com>

Regards,
Eddie

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: mt6397: add IRQ domain dependency
@ 2016-01-26  4:54   ` Eddie Huang
  0 siblings, 0 replies; 9+ messages in thread
From: Eddie Huang @ 2016-01-26  4:54 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Alexandre Belloni, linux-arm-kernel, Wei-Ning Huang,
	Tianping Fang, Henry Chen, Alessandro Zummo, rtc-linux,
	linux-kernel

On Mon, 2016-01-25 at 17:04 +0100, Arnd Bergmann wrote:
> The mt6397 RTC driver can be built either when the MFD_MT6397 driver
> is enabled (which selects IRQ_DOMAIN), or when compile testing.
> The latter however fails without IRQ domains:
> 
> drivers/rtc/rtc-mt6397.c: In function 'mtk_rtc_probe':
> drivers/rtc/rtc-mt6397.c:326:13: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
>   rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);
> 
> This adds an explicit dependency for the COMPILE_TEST case.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/rtc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 376322f71fd5..4395608bf7fc 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1603,7 +1603,7 @@ config RTC_DRV_MOXART
>  
>  config RTC_DRV_MT6397
>  	tristate "Mediatek Real Time Clock driver"
> -	depends on MFD_MT6397 || COMPILE_TEST
> +	depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN)
>  	help
>  	  This selects the Mediatek(R) RTC driver. RTC is part of Mediatek
>  	  MT6397 PMIC. You should enable MT6397 PMIC MFD before select

Hi Arnd,

Thanks your correction.
Acked-by: Eddie Huang <eddie.huang@mediatek.com>

Regards,
Eddie


-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] rtc: mt6397: add IRQ domain dependency
@ 2016-01-26  4:54   ` Eddie Huang
  0 siblings, 0 replies; 9+ messages in thread
From: Eddie Huang @ 2016-01-26  4:54 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, 2016-01-25 at 17:04 +0100, Arnd Bergmann wrote:
> The mt6397 RTC driver can be built either when the MFD_MT6397 driver
> is enabled (which selects IRQ_DOMAIN), or when compile testing.
> The latter however fails without IRQ domains:
> 
> drivers/rtc/rtc-mt6397.c: In function 'mtk_rtc_probe':
> drivers/rtc/rtc-mt6397.c:326:13: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
>   rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);
> 
> This adds an explicit dependency for the COMPILE_TEST case.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/rtc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 376322f71fd5..4395608bf7fc 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1603,7 +1603,7 @@ config RTC_DRV_MOXART
>  
>  config RTC_DRV_MT6397
>  	tristate "Mediatek Real Time Clock driver"
> -	depends on MFD_MT6397 || COMPILE_TEST
> +	depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN)
>  	help
>  	  This selects the Mediatek(R) RTC driver. RTC is part of Mediatek
>  	  MT6397 PMIC. You should enable MT6397 PMIC MFD before select

Hi Arnd,

Thanks your correction.
Acked-by: Eddie Huang <eddie.huang@mediatek.com>

Regards,
Eddie

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] rtc: mt6397: add IRQ domain dependency
  2016-01-25 16:04 ` [rtc-linux] " Arnd Bergmann
  (?)
@ 2016-01-26  8:23   ` Alexandre Belloni
  -1 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2016-01-26  8:23 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: linux-arm-kernel, Wei-Ning Huang, Eddie Huang, Tianping Fang,
	Henry Chen, Alessandro Zummo, rtc-linux, linux-kernel

On 25/01/2016 at 17:04:46 +0100, Arnd Bergmann wrote :
> The mt6397 RTC driver can be built either when the MFD_MT6397 driver
> is enabled (which selects IRQ_DOMAIN), or when compile testing.
> The latter however fails without IRQ domains:
> 
> drivers/rtc/rtc-mt6397.c: In function 'mtk_rtc_probe':
> drivers/rtc/rtc-mt6397.c:326:13: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
>   rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);
> 
> This adds an explicit dependency for the COMPILE_TEST case.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: mt6397: add IRQ domain dependency
@ 2016-01-26  8:23   ` Alexandre Belloni
  0 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2016-01-26  8:23 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: linux-arm-kernel, Wei-Ning Huang, Eddie Huang, Tianping Fang,
	Henry Chen, Alessandro Zummo, rtc-linux, linux-kernel

On 25/01/2016 at 17:04:46 +0100, Arnd Bergmann wrote :
> The mt6397 RTC driver can be built either when the MFD_MT6397 driver
> is enabled (which selects IRQ_DOMAIN), or when compile testing.
> The latter however fails without IRQ domains:
> 
> drivers/rtc/rtc-mt6397.c: In function 'mtk_rtc_probe':
> drivers/rtc/rtc-mt6397.c:326:13: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
>   rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);
> 
> This adds an explicit dependency for the COMPILE_TEST case.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] rtc: mt6397: add IRQ domain dependency
@ 2016-01-26  8:23   ` Alexandre Belloni
  0 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2016-01-26  8:23 UTC (permalink / raw)
  To: linux-arm-kernel

On 25/01/2016 at 17:04:46 +0100, Arnd Bergmann wrote :
> The mt6397 RTC driver can be built either when the MFD_MT6397 driver
> is enabled (which selects IRQ_DOMAIN), or when compile testing.
> The latter however fails without IRQ domains:
> 
> drivers/rtc/rtc-mt6397.c: In function 'mtk_rtc_probe':
> drivers/rtc/rtc-mt6397.c:326:13: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
>   rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);
> 
> This adds an explicit dependency for the COMPILE_TEST case.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-01-26  8:23 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-25 16:04 [PATCH] rtc: mt6397: add IRQ domain dependency Arnd Bergmann
2016-01-25 16:04 ` Arnd Bergmann
2016-01-25 16:04 ` [rtc-linux] " Arnd Bergmann
2016-01-26  4:54 ` Eddie Huang
2016-01-26  4:54   ` Eddie Huang
2016-01-26  4:54   ` [rtc-linux] " Eddie Huang
2016-01-26  8:23 ` Alexandre Belloni
2016-01-26  8:23   ` Alexandre Belloni
2016-01-26  8:23   ` [rtc-linux] " Alexandre Belloni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.