* [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain
@ 2016-01-26 22:44 Bernd Kuhls
2016-01-26 22:44 ` [Buildroot] [PATCH 2/2] package/kodi: reorder select/depends Bernd Kuhls
2016-01-27 8:22 ` [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Bernd Kuhls @ 2016-01-26 22:44 UTC (permalink / raw)
To: buildroot
The build stops with
configure: error: unsupported host (i586-buildroot-linux-musl)
due to musl not being supported in
https://github.com/xbmc/xbmc/blob/Isengard/m4/xbmc_arch.m4
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/kodi/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index e697b52..ed90ed6 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -2,10 +2,11 @@ config BR2_PACKAGE_KODI_ARCH_SUPPORTS
bool
default y if (BR2_arm || (BR2_mipsel && BR2_TOOLCHAIN_USES_GLIBC) || BR2_i386 || BR2_x86_64) && BR2_PACKAGE_BOOST_ARCH_SUPPORTS
-comment "kodi needs a toolchain w/ C++, threads, wchar, dynamic library"
+comment "kodi needs a uClibc or (e)glibc toolchain w/ C++, threads, wchar, dynamic library"
depends on BR2_PACKAGE_KODI_ARCH_SUPPORTS
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \
- || !BR2_USE_WCHAR || BR2_STATIC_LIBS
+ || !BR2_USE_WCHAR || BR2_STATIC_LIBS \
+ || BR2_TOOLCHAIN_USES_MUSL
depends on BR2_USE_MMU
config BR2_PACKAGE_KODI_EGL_GLES
@@ -89,6 +90,7 @@ menuconfig BR2_PACKAGE_KODI
select BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY if BR2_TOOLCHAIN_USES_GLIBC # runtime UTF conversion support
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_HAS_THREADS
+ depends on !BR2_TOOLCHAIN_USES_MUSL
depends on BR2_PACKAGE_KODI_EGL_GLES || BR2_PACKAGE_KODI_GL
depends on BR2_USE_MMU # python
depends on BR2_USE_WCHAR
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/kodi: reorder select/depends
2016-01-26 22:44 [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain Bernd Kuhls
@ 2016-01-26 22:44 ` Bernd Kuhls
2016-01-27 8:22 ` [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Bernd Kuhls @ 2016-01-26 22:44 UTC (permalink / raw)
To: buildroot
From [1]:
"Even though the ordering has absolutely no consequences in Kconfig, it
is not logical (when reading). It is more logical and far easier to
understand when depends come first, followed by the selects."
Also, the Config.in example in the manual suggests to use this coding
style [2].
[1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
[2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/kodi/Config.in | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index ed90ed6..f1236f7 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -32,6 +32,14 @@ comment "kodi requires an OpenGL ES and EGL backend"
menuconfig BR2_PACKAGE_KODI
bool "kodi"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_PACKAGE_KODI_ARCH_SUPPORTS
+ depends on BR2_PACKAGE_KODI_EGL_GLES || BR2_PACKAGE_KODI_GL
+ depends on !BR2_STATIC_LIBS # python
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ depends on !BR2_TOOLCHAIN_USES_MUSL
+ depends on BR2_USE_MMU # python
+ depends on BR2_USE_WCHAR
select BR2_NEEDS_HOST_JAVA
select BR2_PACKAGE_BOOST
select BR2_PACKAGE_BOOST_THREAD
@@ -88,14 +96,6 @@ menuconfig BR2_PACKAGE_KODI
select BR2_PACKAGE_YAJL
select BR2_PACKAGE_ZLIB
select BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY if BR2_TOOLCHAIN_USES_GLIBC # runtime UTF conversion support
- depends on BR2_INSTALL_LIBSTDCPP
- depends on BR2_TOOLCHAIN_HAS_THREADS
- depends on !BR2_TOOLCHAIN_USES_MUSL
- depends on BR2_PACKAGE_KODI_EGL_GLES || BR2_PACKAGE_KODI_GL
- depends on BR2_USE_MMU # python
- depends on BR2_USE_WCHAR
- depends on !BR2_STATIC_LIBS # python
- depends on BR2_PACKAGE_KODI_ARCH_SUPPORTS
help
Kodi is an award-winning free and open source (GPL) software
media player and entertainment hub for digital media.
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain
2016-01-26 22:44 [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain Bernd Kuhls
2016-01-26 22:44 ` [Buildroot] [PATCH 2/2] package/kodi: reorder select/depends Bernd Kuhls
@ 2016-01-27 8:22 ` Thomas Petazzoni
2016-01-27 20:17 ` Bernd Kuhls
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-01-27 8:22 UTC (permalink / raw)
To: buildroot
Dear Bernd Kuhls,
On Tue, 26 Jan 2016 23:44:45 +0100, Bernd Kuhls wrote:
> The build stops with
> configure: error: unsupported host (i586-buildroot-linux-musl)
> due to musl not being supported in
> https://github.com/xbmc/xbmc/blob/Isengard/m4/xbmc_arch.m4
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
And what happens if you add an additional case to support musl ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain
2016-01-27 8:22 ` [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain Thomas Petazzoni
@ 2016-01-27 20:17 ` Bernd Kuhls
2016-01-27 20:30 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Bernd Kuhls @ 2016-01-27 20:17 UTC (permalink / raw)
To: buildroot
Am Wed, 27 Jan 2016 09:22:55 +0100 schrieb Thomas Petazzoni:
> Dear Bernd Kuhls,
>
> On Tue, 26 Jan 2016 23:44:45 +0100, Bernd Kuhls wrote:
>> The build stops with configure: error: unsupported host
>> (i586-buildroot-linux-musl)
>> due to musl not being supported in
>> https://github.com/xbmc/xbmc/blob/Isengard/m4/xbmc_arch.m4
>>
>> Signed-off-by: Bernd Kuhls
>> <bernd.kuhls@t-online.de>
>
> And what happens if you add an additional case to support musl ?
Hi Thomas,
the build will fail:
In file included from emu_msvcrt.cpp:64:0:
emu_msvcrt.h:93:3: error: ?__off64_t? does not name a type
__off64_t dll_lseeki64(int fd, __off64_t lPos, int iWhence);
^
emu_msvcrt.h:94:3: error: ?__off_t? does not name a type
__off_t dll_lseek(int fd, __off_t lPos, int iWhence);
^
I know these problems are fixable and the voidlinux projects seems to
have done it already for 15.2-Isengard: https://github.com/voidlinux/void-
packages/tree/99f74705bc6520297d689fae4bcc9606c71ad34f/srcpkgs/kodi/
patches
Since Kodi 16.0-Jarvis is already at rc1 stage and the 15.x-branch being
closed upstream as "final"[1] version I will put no effort providing a
musl-compilable package for the current Kodi package, hence my patch ;)
Regards, Bernd
[1] https://github.com/xbmc/xbmc/commits/Isengard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain
2016-01-27 20:17 ` Bernd Kuhls
@ 2016-01-27 20:30 ` Thomas Petazzoni
2016-04-24 11:14 ` Bernd Kuhls
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-01-27 20:30 UTC (permalink / raw)
To: buildroot
Hello Bernd,
On Wed, 27 Jan 2016 21:17:40 +0100, Bernd Kuhls wrote:
> Am Wed, 27 Jan 2016 09:22:55 +0100 schrieb Thomas Petazzoni:
>
> > Dear Bernd Kuhls,
> >
> > On Tue, 26 Jan 2016 23:44:45 +0100, Bernd Kuhls wrote:
> >> The build stops with configure: error: unsupported host
> >> (i586-buildroot-linux-musl)
> >> due to musl not being supported in
> >> https://github.com/xbmc/xbmc/blob/Isengard/m4/xbmc_arch.m4
> >>
> >> Signed-off-by: Bernd Kuhls
> >> <bernd.kuhls@t-online.de>
> >
> > And what happens if you add an additional case to support musl ?
>
> Hi Thomas,
>
> the build will fail:
>
> In file included from emu_msvcrt.cpp:64:0:
> emu_msvcrt.h:93:3: error: ?__off64_t? does not name a type
> __off64_t dll_lseeki64(int fd, __off64_t lPos, int iWhence);
> ^
> emu_msvcrt.h:94:3: error: ?__off_t? does not name a type
> __off_t dll_lseek(int fd, __off_t lPos, int iWhence);
> ^
>
> I know these problems are fixable and the voidlinux projects seems to
> have done it already for 15.2-Isengard: https://github.com/voidlinux/void-
> packages/tree/99f74705bc6520297d689fae4bcc9606c71ad34f/srcpkgs/kodi/
> patches
>
> Since Kodi 16.0-Jarvis is already at rc1 stage and the 15.x-branch being
> closed upstream as "final"[1] version I will put no effort providing a
> musl-compilable package for the current Kodi package, hence my patch ;)
Thanks for the explanation. Ideally, this should have been part of the
commit log from the beginning, so that we keep in the git history the
real reason for disabling Kodi on musl.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain
2016-01-27 20:30 ` Thomas Petazzoni
@ 2016-04-24 11:14 ` Bernd Kuhls
0 siblings, 0 replies; 6+ messages in thread
From: Bernd Kuhls @ 2016-04-24 11:14 UTC (permalink / raw)
To: buildroot
Am Wed, 27 Jan 2016 21:30:46 +0100 schrieb Thomas Petazzoni:
>> > And what happens if you add an additional case to support musl ?
>>
>> Hi Thomas,
>>
>> the build will fail:
[...]
>>
>> I know these problems are fixable and the voidlinux projects seems to
>> have done it already for 15.2-Isengard:
>> https://github.com/voidlinux/void-
>> packages/tree/99f74705bc6520297d689fae4bcc9606c71ad34f/srcpkgs/kodi/
>> patches
>>
[...]
>
> Thanks for the explanation. Ideally, this should have been part of the
> commit log from the beginning, so that we keep in the git history the
> real reason for disabling Kodi on musl.
Hi Thomas,
with my latest PR I started the process to add musl support to Kodi:
https://github.com/xbmc/xbmc/pull/9672
I am curious for the reaction from upstream ;)
Regards, Bernd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-24 11:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-26 22:44 [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain Bernd Kuhls
2016-01-26 22:44 ` [Buildroot] [PATCH 2/2] package/kodi: reorder select/depends Bernd Kuhls
2016-01-27 8:22 ` [Buildroot] [PATCH 1/2] package/kodi: not available using a musl-based toolchain Thomas Petazzoni
2016-01-27 20:17 ` Bernd Kuhls
2016-01-27 20:30 ` Thomas Petazzoni
2016-04-24 11:14 ` Bernd Kuhls
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.