From: tixy@linaro.org (Jon Medhurst (Tixy)) To: linux-arm-kernel@lists.infradead.org Subject: Problem with component helpers and probe deferral in 4.5-rc1 Date: Wed, 27 Jan 2016 09:18:44 +0000 [thread overview] Message-ID: <1453886324.2847.12.camel@linaro.org> (raw) In-Reply-To: <20160126223551.GU10826@n2100.arm.linux.org.uk> On Tue, 2016-01-26 at 22:35 +0000, Russell King - ARM Linux wrote: > On Tue, Jan 26, 2016 at 05:59:13PM +0000, Jon Medhurst (Tixy) wrote: > > I believe I've found a problem with the component helpers and/or how > > drivers use them. I discovered this whilst trying to get ARM's HDLCD > > driver [1] working on 4.5-rc1, however I believe that code is following > > a pattern used by drivers already in 4.5 and the problem isn't specific > > to it. This is what I have observed... > > Hmm, it all looks plausible, and I'm again left wondering how the code > passed testing over the last year (I've been running this code for > ages both on iMX6 and Dove, where deferred probing does happen.) It depends on the order of things. To go wrong, components must already be there before the master is added, then the master needs to defer probing from it's bind callback. So, components deferring won't trigger the issue, neither will master deferring before any components have been added. > Your patch looks like the right thing to do, so I'll add it to the > component tree shortly - it should end up in linux-next in a few days > time. Thanks. I wasn't sure if that patch was correct as I hadn't looked at any of this code before this week. -- Tixy
WARNING: multiple messages have this Message-ID (diff)
From: "Jon Medhurst (Tixy)" <tixy@linaro.org> To: Russell King - ARM Linux <linux@arm.linux.org.uk> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Liviu Dudau <liviu.dudau@arm.com>, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: Problem with component helpers and probe deferral in 4.5-rc1 Date: Wed, 27 Jan 2016 09:18:44 +0000 [thread overview] Message-ID: <1453886324.2847.12.camel@linaro.org> (raw) In-Reply-To: <20160126223551.GU10826@n2100.arm.linux.org.uk> On Tue, 2016-01-26 at 22:35 +0000, Russell King - ARM Linux wrote: > On Tue, Jan 26, 2016 at 05:59:13PM +0000, Jon Medhurst (Tixy) wrote: > > I believe I've found a problem with the component helpers and/or how > > drivers use them. I discovered this whilst trying to get ARM's HDLCD > > driver [1] working on 4.5-rc1, however I believe that code is following > > a pattern used by drivers already in 4.5 and the problem isn't specific > > to it. This is what I have observed... > > Hmm, it all looks plausible, and I'm again left wondering how the code > passed testing over the last year (I've been running this code for > ages both on iMX6 and Dove, where deferred probing does happen.) It depends on the order of things. To go wrong, components must already be there before the master is added, then the master needs to defer probing from it's bind callback. So, components deferring won't trigger the issue, neither will master deferring before any components have been added. > Your patch looks like the right thing to do, so I'll add it to the > component tree shortly - it should end up in linux-next in a few days > time. Thanks. I wasn't sure if that patch was correct as I hadn't looked at any of this code before this week. -- Tixy
next prev parent reply other threads:[~2016-01-27 9:18 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-26 17:59 Problem with component helpers and probe deferral in 4.5-rc1 Jon Medhurst (Tixy) 2016-01-26 17:59 ` Jon Medhurst (Tixy) 2016-01-26 22:35 ` Russell King - ARM Linux 2016-01-26 22:35 ` Russell King - ARM Linux 2016-01-27 9:18 ` Jon Medhurst (Tixy) [this message] 2016-01-27 9:18 ` Jon Medhurst (Tixy) 2016-01-27 9:50 ` Jon Medhurst (Tixy) 2016-01-27 9:50 ` Jon Medhurst (Tixy)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1453886324.2847.12.camel@linaro.org \ --to=tixy@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.