* [PATCH alsa-plugins] pph: include config.h from rate_speexrate.c
@ 2016-01-27 11:45 Tanu Kaskinen
2016-01-28 6:22 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Tanu Kaskinen @ 2016-01-27 11:45 UTC (permalink / raw)
To: alsa-devel; +Cc: Takashi Iwai
Fixes compilation against libspeexdsp 1.2rc3.
rate_speexrate.c includes speex_resampler.h, which depends on config.h
by referencing the HAVE_SPEEX_SPEEXDSP_TYPES_H macro. AFAIK it's not
a good idea to include config.h from headers (I don't know/remember
why, though), which is why I include config.h from rate_speexrate.c
instead of speex_resampler.h.
Signed-off-by: Tanu Kaskinen <tanuk@iki.fi>
---
pph/rate_speexrate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/pph/rate_speexrate.c b/pph/rate_speexrate.c
index 0a1325c..8fc4cef 100644
--- a/pph/rate_speexrate.c
+++ b/pph/rate_speexrate.c
@@ -28,6 +28,7 @@
POSSIBILITY OF SUCH DAMAGE.
*/
+#include "config.h"
#include <stdio.h>
#include <alsa/asoundlib.h>
#include <alsa/pcm_rate.h>
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH alsa-plugins] pph: include config.h from rate_speexrate.c
2016-01-27 11:45 [PATCH alsa-plugins] pph: include config.h from rate_speexrate.c Tanu Kaskinen
@ 2016-01-28 6:22 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-01-28 6:22 UTC (permalink / raw)
To: Tanu Kaskinen; +Cc: alsa-devel
On Wed, 27 Jan 2016 12:45:51 +0100,
Tanu Kaskinen wrote:
>
> Fixes compilation against libspeexdsp 1.2rc3.
>
> rate_speexrate.c includes speex_resampler.h, which depends on config.h
> by referencing the HAVE_SPEEX_SPEEXDSP_TYPES_H macro. AFAIK it's not
> a good idea to include config.h from headers (I don't know/remember
> why, though), which is why I include config.h from rate_speexrate.c
> instead of speex_resampler.h.
>
> Signed-off-by: Tanu Kaskinen <tanuk@iki.fi>
Applied, thanks.
Takashi
> ---
> pph/rate_speexrate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/pph/rate_speexrate.c b/pph/rate_speexrate.c
> index 0a1325c..8fc4cef 100644
> --- a/pph/rate_speexrate.c
> +++ b/pph/rate_speexrate.c
> @@ -28,6 +28,7 @@
> POSSIBILITY OF SUCH DAMAGE.
> */
>
> +#include "config.h"
> #include <stdio.h>
> #include <alsa/asoundlib.h>
> #include <alsa/pcm_rate.h>
> --
> 2.7.0.rc3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-28 6:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-27 11:45 [PATCH alsa-plugins] pph: include config.h from rate_speexrate.c Tanu Kaskinen
2016-01-28 6:22 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.