From: Arnd Bergmann <arnd@arndb.de> To: "Martin K. Petersen" <martin.petersen@oracle.com>, James.Bottomley@HansenPartnership.com Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>, linux-scsi@vger.kernel.org, "James E.J. Bottomley" <JBottomley@odin.com>, Russell King <linux@arm.linux.org.uk>, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] scsi: fas216: avoid fas216_log_setup for loadable module Date: Wed, 27 Jan 2016 16:57:20 +0100 [thread overview] Message-ID: <1453910247-3447628-5-git-send-email-arnd@arndb.de> (raw) In-Reply-To: <1453910247-3447628-1-git-send-email-arnd@arndb.de> We get a warning for the fas216 driver when it is compiled as a loadable module, as the __setup() functions are never called then: scsi/arm/fas216.c:101:19: warning: 'fas216_log_setup' defined but not used [-Wunused-function] static int __init fas216_log_setup(char *str) This adds an #ifndef MODULE around the definition to shut up the warning and clarify for the reader when it is used or not. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/scsi/arm/fas216.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c index decdc71b6b86..24388795ee9a 100644 --- a/drivers/scsi/arm/fas216.c +++ b/drivers/scsi/arm/fas216.c @@ -98,6 +98,7 @@ static int level_mask = LOG_ERROR; module_param(level_mask, int, 0644); +#ifndef MODULE static int __init fas216_log_setup(char *str) { char *s; @@ -138,6 +139,7 @@ static int __init fas216_log_setup(char *str) } __setup("fas216_logging=", fas216_log_setup); +#endif static inline unsigned char fas216_readb(FAS216_Info *info, unsigned int reg) { -- 2.7.0
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/7] scsi: fas216: avoid fas216_log_setup for loadable module Date: Wed, 27 Jan 2016 16:57:20 +0100 [thread overview] Message-ID: <1453910247-3447628-5-git-send-email-arnd@arndb.de> (raw) In-Reply-To: <1453910247-3447628-1-git-send-email-arnd@arndb.de> We get a warning for the fas216 driver when it is compiled as a loadable module, as the __setup() functions are never called then: scsi/arm/fas216.c:101:19: warning: 'fas216_log_setup' defined but not used [-Wunused-function] static int __init fas216_log_setup(char *str) This adds an #ifndef MODULE around the definition to shut up the warning and clarify for the reader when it is used or not. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/scsi/arm/fas216.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c index decdc71b6b86..24388795ee9a 100644 --- a/drivers/scsi/arm/fas216.c +++ b/drivers/scsi/arm/fas216.c @@ -98,6 +98,7 @@ static int level_mask = LOG_ERROR; module_param(level_mask, int, 0644); +#ifndef MODULE static int __init fas216_log_setup(char *str) { char *s; @@ -138,6 +139,7 @@ static int __init fas216_log_setup(char *str) } __setup("fas216_logging=", fas216_log_setup); +#endif static inline unsigned char fas216_readb(FAS216_Info *info, unsigned int reg) { -- 2.7.0
next prev parent reply other threads:[~2016-01-27 15:59 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-27 15:57 [PATCH 0/7] SCSI bug fixes for 4.6 Arnd Bergmann 2016-01-27 15:57 ` Arnd Bergmann 2016-01-27 15:57 ` [PATCH 1/7] scsi: fdomain: drop fdomain_pci_tbl when built-in Arnd Bergmann 2016-01-27 15:57 ` Arnd Bergmann 2016-01-27 15:57 ` [PATCH 2/7] mptfusion: hide unused seq_mpt_print_ioc_summary function Arnd Bergmann 2016-01-27 15:57 ` Arnd Bergmann 2016-01-27 15:57 ` [PATCH 3/7] scsi: acornscsi: mark calc_sync_xfer as __maybe_unused Arnd Bergmann 2016-01-27 15:57 ` Arnd Bergmann 2016-01-27 15:57 ` Arnd Bergmann [this message] 2016-01-27 15:57 ` [PATCH 4/7] scsi: fas216: avoid fas216_log_setup for loadable module Arnd Bergmann 2016-01-27 15:57 ` [PATCH 5/7] scsi: qla4xxx: shut up warning for rd_reg_indirect Arnd Bergmann 2016-01-27 15:57 ` Arnd Bergmann 2016-02-01 8:17 ` Nilesh Javali 2016-02-01 8:17 ` Nilesh Javali 2016-02-01 8:17 ` Nilesh Javali 2016-01-27 15:57 ` [PATCH 6/7] scsi: aha1542: avoid uninitialized variable warnings Arnd Bergmann 2016-01-27 15:57 ` Arnd Bergmann 2016-01-27 15:57 ` [PATCH 7/7] scsi_dh: force modular build if SCSI is a module Arnd Bergmann 2016-01-27 15:57 ` Arnd Bergmann 2016-02-11 1:24 ` [PATCH 0/7] SCSI bug fixes for 4.6 Martin K. Petersen 2016-02-11 1:24 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1453910247-3447628-5-git-send-email-arnd@arndb.de \ --to=arnd@arndb.de \ --cc=JBottomley@odin.com \ --cc=James.Bottomley@HansenPartnership.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=martin.petersen@oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.