All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 21/26] mkimage: Bring data into the FIT before processing
Date: Thu, 28 Jan 2016 09:39:41 -0700	[thread overview]
Message-ID: <1453999186-18747-22-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1453999186-18747-1-git-send-email-sjg@chromium.org>

Since we now support data outside the FIT image, bring it into the FIT image
first before we do any processing. This avoids adding new functionality to
the core FIT code for now.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/fit_image.c | 97 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 97 insertions(+)

diff --git a/tools/fit_image.c b/tools/fit_image.c
index 5d087e3..5407b9d 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -455,6 +455,98 @@ err:
 	return ret;
 }
 
+static int fit_import_data(struct image_tool_params *params, const char *fname)
+{
+	void *fdt, *old_fdt;
+	int fit_size, new_size, size, data_base;
+	int fd;
+	struct stat sbuf;
+	int ret;
+	int images;
+	int node;
+
+	fd = mmap_fdt(params->cmdname, fname, 0, &old_fdt, &sbuf, false);
+	if (fd < 0)
+		return -EIO;
+	fit_size = fdt_totalsize(old_fdt);
+	data_base = (fit_size + 3) & ~3;
+
+	/* Allocate space to hold the new FIT */
+	size = sbuf.st_size + 16384;
+	fdt = malloc(size);
+	if (!fdt) {
+		fprintf(stderr, "%s: Failed to allocate memory (%d bytes)\n",
+			__func__, size);
+		ret = -ENOMEM;
+		goto err;
+	}
+	ret = fdt_open_into(old_fdt, fdt, size);
+	if (ret) {
+		debug("%s: Failed to expand FIT: %s\n", __func__,
+		      fdt_strerror(errno));
+		ret = -EINVAL;
+		goto err;
+	}
+
+	images = fdt_path_offset(fdt, FIT_IMAGES_PATH);
+	if (images < 0) {
+		debug("%s: Cannot find /images node: %d\n", __func__, images);
+		ret = -EINVAL;
+		goto err;
+	}
+
+	for (node = fdt_first_subnode(fdt, images);
+	     node >= 0;
+	     node = fdt_next_subnode(fdt, node)) {
+		int buf_ptr;
+		int len;
+
+		buf_ptr = fdtdec_get_int(fdt, node, "data-offset", -1);
+		len = fdtdec_get_int(fdt, node, "data-size", -1);
+		if (buf_ptr == -1 || len == -1)
+			continue;
+		debug("Importing data size %x\n", len);
+
+		ret = fdt_setprop(fdt, node, "data", fdt + data_base + buf_ptr,
+				  len);
+		if (ret) {
+			debug("%s: Failed to write property: %s\n", __func__,
+			      fdt_strerror(ret));
+			ret = -EINVAL;
+			goto err;
+		}
+	}
+
+	munmap(fdt, sbuf.st_size);
+	close(fd);
+
+	/* Pack the FDT and place the data after it */
+	fdt_pack(fdt);
+
+	new_size = fdt_totalsize(fdt);
+	debug("Size expanded from %x to %x\n", fit_size, new_size);
+
+	fd = open(fname, O_RDWR | O_CREAT | O_TRUNC | O_BINARY, 0666);
+	if (fd < 0) {
+		fprintf(stderr, "%s: Can't open %s: %s\n",
+			params->cmdname, fname, strerror(errno));
+		goto err;
+	}
+	if (write(fd, fdt, new_size) != new_size) {
+		debug("%s: Failed to write external data to file %s\n",
+		      __func__, strerror(errno));
+		ret = -EIO;
+		goto err;
+	}
+	close(fd);
+
+	ret = 0;
+
+err:
+	close(fd);
+	return ret;
+}
+
 /**
  * fit_handle_file - main FIT file processing function
  *
@@ -510,6 +602,11 @@ static int fit_handle_file(struct image_tool_params *params)
 		goto err_system;
 	}
 
+	/* Move the data so it is internal to the FIT, if needed */
+	ret = fit_import_data(params, tmpfile);
+	if (ret)
+		goto err_system;
+
 	/*
 	 * Set hashes for images in the blob. Unfortunately we may need more
 	 * space in either FDT, so keep trying until we succeed.
-- 
2.7.0.rc3.207.g0ac5344

  parent reply	other threads:[~2016-01-28 16:39 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 16:39 [U-Boot] [PATCH 00/26] spl: Support loading a FIT image containing U-Boot Simon Glass
2016-01-28 16:39 ` Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 01/26] mkimage: Move argument processing into its own function Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 02/26] mkimage: Convert to use getopt() Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 03/26] mkimage: Sort the option processing code by option Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 04/26] mkimage: Move usage() up to the top Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 05/26] mkimage: Show an error message when usage() is called Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 06/26] mkimage: Make 'params' static Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 07/26] libfdt: Add a function to write a property placeholder Simon Glass
2016-01-28 16:39   ` Simon Glass
2016-01-29  5:29   ` [U-Boot] " David Gibson
2016-01-29  5:29     ` David Gibson
2016-01-29 18:23     ` [U-Boot] " Simon Glass
2016-01-29 18:23       ` Simon Glass
2016-01-31  9:55       ` [U-Boot] " David Gibson
2016-01-31  9:55         ` David Gibson
2016-01-28 16:39 ` [U-Boot] [PATCH 08/26] Correct defconfig ordering Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 09/26] Move CONFIG_OF_LIBFDT to Kconfig Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 10/26] Kconfig: Move CONFIG_FIT and CONFIG_OF_*_SETUP " Simon Glass
2016-01-29  5:52   ` Heiko Schocher
2016-01-28 16:39 ` [U-Boot] [PATCH 11/26] fdt: Adjust DEFAULT_DEVICE_TREE to device on OF_CONTROL Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 12/26] fdt: Allow libfdt to be used in SPL Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 13/26] sunxi: Display the board model on start-up Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 14/26] tools: Include fdt_sw.o in libfdt for mkimage Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 15/26] mkimage: Allow a FIT to include an image of any type Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 16/26] tools: Add a function to obtain the size of a file Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 17/26] image: Add functions to obtain short names Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 18/26] mkimage: Support automatic creating of a FIT without a .its Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 19/26] mkimage: Support adding device tree files to a FIT Simon Glass
2016-02-11 16:36   ` Tom Rini
2016-02-12 15:54     ` Simon Glass
2016-02-12 16:03       ` Tom Rini
2016-01-28 16:39 ` [U-Boot] [PATCH 20/26] mkimage: Support placing data outside the FIT Simon Glass
2016-01-28 16:39 ` Simon Glass [this message]
2016-01-28 16:39 ` [U-Boot] [PATCH 22/26] spl: Add a way for boards to select which device tree to load Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 23/26] spl: Add an option to load a FIT containing U-Boot Simon Glass
2016-02-04 15:00   ` Stefano Babic
2016-02-22  4:46     ` Simon Glass
2016-02-22  6:45       ` Stefano Babic
2016-01-28 16:39 ` [U-Boot] [PATCH 24/26] spl: Add a way to specify a list of device trees to include Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 25/26] spl: Support loading a FIT from MMC Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 26/26] RFC: sunxi: Enable SPL FIT support Simon Glass
2016-02-16 11:34 ` [U-Boot] [PATCH 00/26] spl: Support loading a FIT image containing U-Boot Masahiro Yamada
2016-02-16 11:34   ` Masahiro Yamada
2016-02-16 12:17   ` [U-Boot] " Tom Rini
2016-02-16 12:17     ` Tom Rini
2016-02-16 12:30     ` Masahiro Yamada
2016-02-16 12:30       ` Masahiro Yamada
2016-02-16 13:33       ` Tom Rini
2016-02-16 13:33         ` Tom Rini
2016-02-17 11:00 ` Belisko Marek
2016-02-17 11:00   ` Belisko Marek
2016-02-19 20:55   ` Simon Glass
2016-02-19 20:55     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453999186-18747-22-git-send-email-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.