All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 19/26] mkimage: Support adding device tree files to a FIT
Date: Fri, 12 Feb 2016 08:54:09 -0700	[thread overview]
Message-ID: <CAPnjgZ2Bn28gkvzMrokDmq4V4Ep5oC7agh0HvwM5_p=_7B3q2Q@mail.gmail.com> (raw)
In-Reply-To: <20160211163609.GR23166@bill-the-cat>

Hi Tom,

On 11 February 2016 at 09:36, Tom Rini <trini@konsulko.com> wrote:
> On Thu, Jan 28, 2016 at 09:39:39AM -0700, Simon Glass wrote:
>
>> To make the auto-FIT feature useful we need to be able to provide a list of
>> device tree files on the command line for mkimage to add into the FIT. Add
>> support for this feature.
> [snip]
>> +.BI "\-b
>> +Specifies that the following arguments are device tree binary files (.dtb).
>> +
>> +.TP
>>  .BI "\-c [" "comment" "]"
>>  Specifies a comment to be added when signing. This is typically a useful
>>  message which describes how the image was signed or some other useful
>> @@ -125,6 +129,10 @@ This can be used to sign images with additional keys after initial image
>>  creation.
>>
>>  .TP
>> +.BI "\-i
>> +Specifies that the following arguments are image files.
>> +
>> +.TP
>>  .BI "\-k [" "key_directory" "]"
>>  Specifies the directory containing keys to use for signing. This directory
>>  should contain a private key file <name>.key for use with signing and a
>> @@ -191,6 +199,15 @@ is required.
>>  .br
>>  .B -c """Kernel 4.4 image for production devices""" -d vmlinuz kernel.itb
>>  .fi
>> +.P
>> +Create a FIT image containing a kernel and some device tree files, using
>> +automatic mode. No .its file is required.
>> +.nf
>> +.B mkimage -f auto -A arm -O linux -T kernel -C none -a 43e00000 -e 0 \\\\
>> +.br
>> +.B -c """Kernel 4.4 image for production devices""" -d vmlinuz \\\\
>> +.B -b rk3288-firefly.dts rk3288-jerry.dts -i kernel.itb
>> +.fi
>
> OK, I'm confused in a few ways here.  First, we don't need quotes around
> the space separated list of dts files?

No, the -b option introduces the list, which can be as long as needed.
I want to make it possible to specify a list easily.

> Second, we need dts not dtb?

Eek, no, it should be dtb.

> Third, I think this would be a better example if (as I suspect we need
> really) it was a full path to the output rather than assuming that we've
> copied the files to $PWD.

OK

> Fourth, -i is inputs or outputs?  The help
> reads like inputs and is where I assume we would say vmlinuz here and
> not use -d and then end with our output of kernel.itb.  Thanks!

-i introduces the image file, whic his an output. The -d provides the
datafile, which is the file that is is put inside the FIT.

Maybe we can change things to make this a bit clearer. We could
perhaps have an option to end the list of dtb files, instead of the
option to signal the output file is next? Or maybe we can avoid -i
altogether since the last arg should be the output file.

Regards,
Simon

  reply	other threads:[~2016-02-12 15:54 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 16:39 [U-Boot] [PATCH 00/26] spl: Support loading a FIT image containing U-Boot Simon Glass
2016-01-28 16:39 ` Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 01/26] mkimage: Move argument processing into its own function Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 02/26] mkimage: Convert to use getopt() Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 03/26] mkimage: Sort the option processing code by option Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 04/26] mkimage: Move usage() up to the top Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 05/26] mkimage: Show an error message when usage() is called Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 06/26] mkimage: Make 'params' static Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 07/26] libfdt: Add a function to write a property placeholder Simon Glass
2016-01-28 16:39   ` Simon Glass
2016-01-29  5:29   ` [U-Boot] " David Gibson
2016-01-29  5:29     ` David Gibson
2016-01-29 18:23     ` [U-Boot] " Simon Glass
2016-01-29 18:23       ` Simon Glass
2016-01-31  9:55       ` [U-Boot] " David Gibson
2016-01-31  9:55         ` David Gibson
2016-01-28 16:39 ` [U-Boot] [PATCH 08/26] Correct defconfig ordering Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 09/26] Move CONFIG_OF_LIBFDT to Kconfig Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 10/26] Kconfig: Move CONFIG_FIT and CONFIG_OF_*_SETUP " Simon Glass
2016-01-29  5:52   ` Heiko Schocher
2016-01-28 16:39 ` [U-Boot] [PATCH 11/26] fdt: Adjust DEFAULT_DEVICE_TREE to device on OF_CONTROL Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 12/26] fdt: Allow libfdt to be used in SPL Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 13/26] sunxi: Display the board model on start-up Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 14/26] tools: Include fdt_sw.o in libfdt for mkimage Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 15/26] mkimage: Allow a FIT to include an image of any type Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 16/26] tools: Add a function to obtain the size of a file Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 17/26] image: Add functions to obtain short names Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 18/26] mkimage: Support automatic creating of a FIT without a .its Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 19/26] mkimage: Support adding device tree files to a FIT Simon Glass
2016-02-11 16:36   ` Tom Rini
2016-02-12 15:54     ` Simon Glass [this message]
2016-02-12 16:03       ` Tom Rini
2016-01-28 16:39 ` [U-Boot] [PATCH 20/26] mkimage: Support placing data outside the FIT Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 21/26] mkimage: Bring data into the FIT before processing Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 22/26] spl: Add a way for boards to select which device tree to load Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 23/26] spl: Add an option to load a FIT containing U-Boot Simon Glass
2016-02-04 15:00   ` Stefano Babic
2016-02-22  4:46     ` Simon Glass
2016-02-22  6:45       ` Stefano Babic
2016-01-28 16:39 ` [U-Boot] [PATCH 24/26] spl: Add a way to specify a list of device trees to include Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 25/26] spl: Support loading a FIT from MMC Simon Glass
2016-01-28 16:39 ` [U-Boot] [PATCH 26/26] RFC: sunxi: Enable SPL FIT support Simon Glass
2016-02-16 11:34 ` [U-Boot] [PATCH 00/26] spl: Support loading a FIT image containing U-Boot Masahiro Yamada
2016-02-16 11:34   ` Masahiro Yamada
2016-02-16 12:17   ` [U-Boot] " Tom Rini
2016-02-16 12:17     ` Tom Rini
2016-02-16 12:30     ` Masahiro Yamada
2016-02-16 12:30       ` Masahiro Yamada
2016-02-16 13:33       ` Tom Rini
2016-02-16 13:33         ` Tom Rini
2016-02-17 11:00 ` Belisko Marek
2016-02-17 11:00   ` Belisko Marek
2016-02-19 20:55   ` Simon Glass
2016-02-19 20:55     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ2Bn28gkvzMrokDmq4V4Ep5oC7agh0HvwM5_p=_7B3q2Q@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.