* [U-Boot] [PATCH] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure
@ 2016-01-29 2:39 Peng Fan
2016-01-29 9:24 ` Fabio Estevam
2016-01-29 9:30 ` Stefano Babic
0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan @ 2016-01-29 2:39 UTC (permalink / raw)
To: u-boot
From: Ye Li <ye.li@nxp.com>
The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card.
Fixed the value to correct one.
The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting
to 2015.04.
Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
---
board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index d20953d..42f89ab 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -638,7 +638,7 @@ static const struct boot_mode board_boot_modes[] = {
{"sd2", MAKE_CFGVAL(0x40, 0x28, 0x00, 0x00)},
{"sd3", MAKE_CFGVAL(0x40, 0x30, 0x00, 0x00)},
/* 8 bit bus width */
- {"emmc", MAKE_CFGVAL(0x40, 0x38, 0x00, 0x00)},
+ {"emmc", MAKE_CFGVAL(0x60, 0x58, 0x00, 0x00)},
{NULL, 0},
};
#endif
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure
2016-01-29 2:39 [U-Boot] [PATCH] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure Peng Fan
@ 2016-01-29 9:24 ` Fabio Estevam
2016-01-29 9:30 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-01-29 9:24 UTC (permalink / raw)
To: u-boot
Hi Peng,
On Fri, Jan 29, 2016 at 12:39 AM, Peng Fan <van.freenix@gmail.com> wrote:
> From: Ye Li <ye.li@nxp.com>
>
> The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card.
> Fixed the value to correct one.
>
> The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting
> to 2015.04.
I would remove this last sentence as it applies to NXP U-boot release, right?
Otherwise the patch looks good.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure
2016-01-29 2:39 [U-Boot] [PATCH] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure Peng Fan
2016-01-29 9:24 ` Fabio Estevam
@ 2016-01-29 9:30 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2016-01-29 9:30 UTC (permalink / raw)
To: u-boot
On 29/01/2016 03:39, Peng Fan wrote:
> From: Ye Li <ye.li@nxp.com>
>
> The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card.
> Fixed the value to correct one.
>
> The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting
> to 2015.04.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
> index d20953d..42f89ab 100644
> --- a/board/freescale/mx6sabresd/mx6sabresd.c
> +++ b/board/freescale/mx6sabresd/mx6sabresd.c
> @@ -638,7 +638,7 @@ static const struct boot_mode board_boot_modes[] = {
> {"sd2", MAKE_CFGVAL(0x40, 0x28, 0x00, 0x00)},
> {"sd3", MAKE_CFGVAL(0x40, 0x30, 0x00, 0x00)},
> /* 8 bit bus width */
> - {"emmc", MAKE_CFGVAL(0x40, 0x38, 0x00, 0x00)},
> + {"emmc", MAKE_CFGVAL(0x60, 0x58, 0x00, 0x00)},
> {NULL, 0},
> };
> #endif
>
Reviewed-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-29 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-29 2:39 [U-Boot] [PATCH] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure Peng Fan
2016-01-29 9:24 ` Fabio Estevam
2016-01-29 9:30 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.