[PATCH phosphor-networkd v2] Enable DHCP

[PATCH phosphor-networkd v2] Enable DHCP

[OpenBMC Patches]

Enable DHCP when network service starts by creating an 80-dhcp.network
file. Only setup if file doesn't exist already, this allows for a one
time setup.

https://github.com/openbmc/phosphor-networkd/pull/3

Adriana Kobylak (1):
  Fix typos

 netman.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.6.4

[PATCH phosphor-networkd v2] Fix typos

[OpenBMC Patches]

From: Adriana Kobylak <anoo@us.ibm.com>

Fix argument typos.
---
 netman.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/netman.py b/netman.py
index 9544d07..8f0fb80 100755
--- a/netman.py
+++ b/netman.py
@@ -54,7 +54,7 @@ class NetMan (dbus.service.Object):
     def setNetworkProvider(self, provider):
         self.provider = provider
 
-    def _setAddr (self, op, device, ipaddr, netmask, family, flags, scope, ateway):
+    def _setAddr (self, op, device, ipaddr, netmask, family, flags, scope, gateway):
         netprov     = network_providers [self.provider]
         bus_name    = netprov ['bus_name']
         obj_path    = netprov ['ip_object_name']
@@ -63,10 +63,10 @@ class NetMan (dbus.service.Object):
         obj = self.bus.get_object(bus_name, obj_path)
         intf = dbus.Interface(obj, intf_name)
         if (op == "add"):
-            return intf.AddAddress (device, ipaddr, netmask, family, flags, cope, gateway)
+            return intf.AddAddress (device, ipaddr, netmask, family, flags, scope, gateway)
 
         if (op == "del"):
-            return intf.DelAddress (device, ipaddr, netmask, family, flags, cope, gateway)
+            return intf.DelAddress (device, ipaddr, netmask, family, flags, scope, gateway)
 
     def _getAddr (self, target, device):
         netprov     = network_providers [self.provider]
@@ -143,4 +143,4 @@ def main():
     mainloop.run()
 
 if __name__ == '__main__':
-    sys.exit(main())
\ No newline at end of file
+    sys.exit(main())
-- 
2.6.4

Re: [PATCH phosphor-networkd v2] Enable DHCP

[Daniel Axtens]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

OpenBMC Patches <openbmc-patches@stwcx.xyz> writes:

> Enable DHCP when network service starts by creating an 80-dhcp.network
> file. Only setup if file doesn't exist already, this allows for a one
> time setup.

This description...

>
> https://github.com/openbmc/phosphor-networkd/pull/3
>
> Adriana Kobylak (1):
>   Fix typos
... doesn't match this patch.

What did you intend to do?

Regards,
Daniel

>
>  netman.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> -- 
> 2.6.4
>
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 859 bytes --]