All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Peer Stats fixes for rx duration
@ 2016-02-03 15:37 ` Mohammed Shafi Shajakhan
  0 siblings, 0 replies; 8+ messages in thread
From: Mohammed Shafi Shajakhan @ 2016-02-03 15:37 UTC (permalink / raw)
  To: ath10k; +Cc: Kalle Valo, linux-wireless, Mohammed Shafi Shajakhan

From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>

This is a small patchset that fixes:

1. Updating rx duration per station (part of mac80211 STA debugfs)
irrespective user does a cat fw_stats in ath10k debugfs

2. Remove updating peer stats list (which is completely useless)
when we recieve periodic update of peer stats for updating rx_duration

Mohammed Shafi Shajakhan (2):
  ath10k: Fix updating peer stats rx duration
  ath10k: Fix pointless update of peer stats list

 drivers/net/wireless/ath/ath10k/debug.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 0/2] Peer Stats fixes for rx duration
@ 2016-02-03 15:37 ` Mohammed Shafi Shajakhan
  0 siblings, 0 replies; 8+ messages in thread
From: Mohammed Shafi Shajakhan @ 2016-02-03 15:37 UTC (permalink / raw)
  To: ath10k; +Cc: Kalle Valo, linux-wireless, Mohammed Shafi Shajakhan

From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>

This is a small patchset that fixes:

1. Updating rx duration per station (part of mac80211 STA debugfs)
irrespective user does a cat fw_stats in ath10k debugfs

2. Remove updating peer stats list (which is completely useless)
when we recieve periodic update of peer stats for updating rx_duration

Mohammed Shafi Shajakhan (2):
  ath10k: Fix updating peer stats rx duration
  ath10k: Fix pointless update of peer stats list

 drivers/net/wireless/ath/ath10k/debug.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

-- 
1.7.9.5


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 1/2] ath10k: Fix updating peer stats rx duration
  2016-02-03 15:37 ` Mohammed Shafi Shajakhan
@ 2016-02-03 15:37   ` Mohammed Shafi Shajakhan
  -1 siblings, 0 replies; 8+ messages in thread
From: Mohammed Shafi Shajakhan @ 2016-02-03 15:37 UTC (permalink / raw)
  To: ath10k; +Cc: Kalle Valo, linux-wireless, Mohammed Shafi Shajakhan

From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>

We are not updating peer stats rx_duration periodically
unless the user one polls for fw_stats, this is because
we discard the update event since pdev list is empty. Fix
this by updating rx duration periodically irrepective of checks
for pdev list (irrespective of ping-pong response)

Fixes: 856e7c3 ("ath10k: add debugfs support for Per STA total rx duration")
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
---
 drivers/net/wireless/ath/ath10k/debug.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index 8d4148a..d80a44e 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -348,6 +348,9 @@ void ath10k_debug_fw_stats_process(struct ath10k *ar, struct sk_buff *skb)
 	 */
 
 	peer_stats_svc = test_bit(WMI_SERVICE_PEER_STATS, ar->wmi.svc_map);
+	if (peer_stats_svc)
+		ath10k_sta_update_rx_duration(ar, &stats.peers);
+
 	if (ar->debug.fw_stats_done && !peer_stats_svc) {
 		ath10k_warn(ar, "received unsolicited stats update event\n");
 		goto free;
@@ -384,9 +387,6 @@ void ath10k_debug_fw_stats_process(struct ath10k *ar, struct sk_buff *skb)
 			goto free;
 		}
 
-		if (peer_stats_svc)
-			ath10k_sta_update_rx_duration(ar, &stats.peers);
-
 		list_splice_tail_init(&stats.peers, &ar->debug.fw_stats.peers);
 		list_splice_tail_init(&stats.vdevs, &ar->debug.fw_stats.vdevs);
 	}
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 1/2] ath10k: Fix updating peer stats rx duration
@ 2016-02-03 15:37   ` Mohammed Shafi Shajakhan
  0 siblings, 0 replies; 8+ messages in thread
From: Mohammed Shafi Shajakhan @ 2016-02-03 15:37 UTC (permalink / raw)
  To: ath10k; +Cc: Kalle Valo, linux-wireless, Mohammed Shafi Shajakhan

From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>

We are not updating peer stats rx_duration periodically
unless the user one polls for fw_stats, this is because
we discard the update event since pdev list is empty. Fix
this by updating rx duration periodically irrepective of checks
for pdev list (irrespective of ping-pong response)

Fixes: 856e7c3 ("ath10k: add debugfs support for Per STA total rx duration")
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
---
 drivers/net/wireless/ath/ath10k/debug.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index 8d4148a..d80a44e 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -348,6 +348,9 @@ void ath10k_debug_fw_stats_process(struct ath10k *ar, struct sk_buff *skb)
 	 */
 
 	peer_stats_svc = test_bit(WMI_SERVICE_PEER_STATS, ar->wmi.svc_map);
+	if (peer_stats_svc)
+		ath10k_sta_update_rx_duration(ar, &stats.peers);
+
 	if (ar->debug.fw_stats_done && !peer_stats_svc) {
 		ath10k_warn(ar, "received unsolicited stats update event\n");
 		goto free;
@@ -384,9 +387,6 @@ void ath10k_debug_fw_stats_process(struct ath10k *ar, struct sk_buff *skb)
 			goto free;
 		}
 
-		if (peer_stats_svc)
-			ath10k_sta_update_rx_duration(ar, &stats.peers);
-
 		list_splice_tail_init(&stats.peers, &ar->debug.fw_stats.peers);
 		list_splice_tail_init(&stats.vdevs, &ar->debug.fw_stats.vdevs);
 	}
-- 
1.7.9.5


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 2/2] ath10k: Fix pointless update of peer stats list
  2016-02-03 15:37 ` Mohammed Shafi Shajakhan
@ 2016-02-03 15:37   ` Mohammed Shafi Shajakhan
  -1 siblings, 0 replies; 8+ messages in thread
From: Mohammed Shafi Shajakhan @ 2016-02-03 15:37 UTC (permalink / raw)
  To: ath10k; +Cc: Kalle Valo, linux-wireless, Mohammed Shafi Shajakhan

From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>

We periodically receive f/w stats event for updating
the rx duration and there is no reason to keep on appending
the f/w stats peer list, as this gets completely cleaned up when
the user polls for f/w stats {pdev, vdev, peer stats}. Only don't
print the warning message in the case PEER_STATS service is enabled

Fixes: 856e7c3 ("ath10k: add debugfs support for Per STA total rx duration")
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
---
 drivers/net/wireless/ath/ath10k/debug.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index d80a44e..06581fa 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -351,8 +351,10 @@ void ath10k_debug_fw_stats_process(struct ath10k *ar, struct sk_buff *skb)
 	if (peer_stats_svc)
 		ath10k_sta_update_rx_duration(ar, &stats.peers);
 
-	if (ar->debug.fw_stats_done && !peer_stats_svc) {
-		ath10k_warn(ar, "received unsolicited stats update event\n");
+	if (ar->debug.fw_stats_done) {
+		if (!peer_stats_svc)
+			ath10k_warn(ar, "received unsolicited stats update event\n");
+
 		goto free;
 	}
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 2/2] ath10k: Fix pointless update of peer stats list
@ 2016-02-03 15:37   ` Mohammed Shafi Shajakhan
  0 siblings, 0 replies; 8+ messages in thread
From: Mohammed Shafi Shajakhan @ 2016-02-03 15:37 UTC (permalink / raw)
  To: ath10k; +Cc: Kalle Valo, linux-wireless, Mohammed Shafi Shajakhan

From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>

We periodically receive f/w stats event for updating
the rx duration and there is no reason to keep on appending
the f/w stats peer list, as this gets completely cleaned up when
the user polls for f/w stats {pdev, vdev, peer stats}. Only don't
print the warning message in the case PEER_STATS service is enabled

Fixes: 856e7c3 ("ath10k: add debugfs support for Per STA total rx duration")
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
---
 drivers/net/wireless/ath/ath10k/debug.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index d80a44e..06581fa 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -351,8 +351,10 @@ void ath10k_debug_fw_stats_process(struct ath10k *ar, struct sk_buff *skb)
 	if (peer_stats_svc)
 		ath10k_sta_update_rx_duration(ar, &stats.peers);
 
-	if (ar->debug.fw_stats_done && !peer_stats_svc) {
-		ath10k_warn(ar, "received unsolicited stats update event\n");
+	if (ar->debug.fw_stats_done) {
+		if (!peer_stats_svc)
+			ath10k_warn(ar, "received unsolicited stats update event\n");
+
 		goto free;
 	}
 
-- 
1.7.9.5


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] Peer Stats fixes for rx duration
  2016-02-03 15:37 ` Mohammed Shafi Shajakhan
@ 2016-03-04  8:40   ` Valo, Kalle
  -1 siblings, 0 replies; 8+ messages in thread
From: Valo, Kalle @ 2016-03-04  8:40 UTC (permalink / raw)
  To: Shajakhan, Mohammed Shafi (Mohammed Shafi); +Cc: ath10k, linux-wireless

Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> writes:

> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
>
> This is a small patchset that fixes:
>
> 1. Updating rx duration per station (part of mac80211 STA debugfs)
> irrespective user does a cat fw_stats in ath10k debugfs
>
> 2. Remove updating peer stats list (which is completely useless)
> when we recieve periodic update of peer stats for updating rx_duration
>
> Mohammed Shafi Shajakhan (2):
>   ath10k: Fix updating peer stats rx duration
>   ath10k: Fix pointless update of peer stats list

Both applied, thanks.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] Peer Stats fixes for rx duration
@ 2016-03-04  8:40   ` Valo, Kalle
  0 siblings, 0 replies; 8+ messages in thread
From: Valo, Kalle @ 2016-03-04  8:40 UTC (permalink / raw)
  To: Shajakhan, Mohammed Shafi (Mohammed Shafi); +Cc: linux-wireless, ath10k

Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> writes:

> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
>
> This is a small patchset that fixes:
>
> 1. Updating rx duration per station (part of mac80211 STA debugfs)
> irrespective user does a cat fw_stats in ath10k debugfs
>
> 2. Remove updating peer stats list (which is completely useless)
> when we recieve periodic update of peer stats for updating rx_duration
>
> Mohammed Shafi Shajakhan (2):
>   ath10k: Fix updating peer stats rx duration
>   ath10k: Fix pointless update of peer stats list

Both applied, thanks.

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-03-04  8:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-03 15:37 [PATCH 0/2] Peer Stats fixes for rx duration Mohammed Shafi Shajakhan
2016-02-03 15:37 ` Mohammed Shafi Shajakhan
2016-02-03 15:37 ` [PATCH 1/2] ath10k: Fix updating peer stats " Mohammed Shafi Shajakhan
2016-02-03 15:37   ` Mohammed Shafi Shajakhan
2016-02-03 15:37 ` [PATCH 2/2] ath10k: Fix pointless update of peer stats list Mohammed Shafi Shajakhan
2016-02-03 15:37   ` Mohammed Shafi Shajakhan
2016-03-04  8:40 ` [PATCH 0/2] Peer Stats fixes for rx duration Valo, Kalle
2016-03-04  8:40   ` Valo, Kalle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.