From: Joshua Clayton <stillcompiling@gmail.com> To: Alexandre Belloni <alexandre.belloni@free-electrons.com>, Alessandro Zummo <a.zummo@towertech.it> Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Joshua Clayton <stillcompiling@gmail.com> Subject: [PATCH v3 2/3] rtc: implement a sysfs interface for clock offset Date: Wed, 3 Feb 2016 09:16:43 -0800 [thread overview] Message-ID: <1454519804-13770-2-git-send-email-stillcompiling@gmail.com> (raw) In-Reply-To: <1454519804-13770-1-git-send-email-stillcompiling@gmail.com> In-Reply-To: <20160202104111.GU20165@piout.net> clock offset may be set and read in decimal parts per billion attribute is /sys/class/rtc/rtcN/offset The attribute is only visible for rtcs that have set_offset implemented. Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- Documentation/rtc.txt | 6 ++++++ drivers/rtc/rtc-sysfs.c | 35 ++++++++++++++++++++++++++++++++++- 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/Documentation/rtc.txt b/Documentation/rtc.txt index 8446f1e..ddc3660 100644 --- a/Documentation/rtc.txt +++ b/Documentation/rtc.txt @@ -157,6 +157,12 @@ wakealarm: The time at which the clock will generate a system wakeup the epoch by default, or if there's a leading +, seconds in the future, or if there is a leading +=, seconds ahead of the current alarm. +offset: The amount which the rtc clock has been adjusted in firmware. + Visible only if the driver supports clock offset adjustment. + The unit is parts per billion, i.e. The number of clock ticks + which are added to or removed from the rtc's base clock per + billion ticks. A positive value makes a day pass more slowly, + longer, and a negative value makes a day pass more quickly. IOCTL INTERFACE --------------- diff --git a/drivers/rtc/rtc-sysfs.c b/drivers/rtc/rtc-sysfs.c index 463e286..f8d7f8d 100644 --- a/drivers/rtc/rtc-sysfs.c +++ b/drivers/rtc/rtc-sysfs.c @@ -218,6 +218,34 @@ wakealarm_store(struct device *dev, struct device_attribute *attr, } static DEVICE_ATTR_RW(wakealarm); +static ssize_t +offset_show(struct device *dev, struct device_attribute *attr, char *buf) +{ + ssize_t retval; + long offset; + + retval = rtc_read_offset(to_rtc_device(dev), &offset); + if (retval == 0) + retval = sprintf(buf, "%ld\n", offset); + + return retval; +} + +static ssize_t +offset_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t n) +{ + ssize_t retval; + long offset; + + retval = kstrtol(buf, 10, &offset); + if (retval == 0) + retval = rtc_set_offset(to_rtc_device(dev), offset); + + return (retval < 0) ? retval : n; +} +static DEVICE_ATTR_RW(offset); + static struct attribute *rtc_attrs[] = { &dev_attr_name.attr, &dev_attr_date.attr, @@ -226,6 +254,7 @@ static struct attribute *rtc_attrs[] = { &dev_attr_max_user_freq.attr, &dev_attr_hctosys.attr, &dev_attr_wakealarm.attr, + &dev_attr_offset.attr, NULL, }; @@ -249,9 +278,13 @@ static umode_t rtc_attr_is_visible(struct kobject *kobj, struct rtc_device *rtc = to_rtc_device(dev); umode_t mode = attr->mode; - if (attr == &dev_attr_wakealarm.attr) + if (attr == &dev_attr_wakealarm.attr) { if (!rtc_does_wakealarm(rtc)) mode = 0; + } else if (attr == &dev_attr_offset.attr) { + if (!rtc->ops->set_offset) + mode = 0; + } return mode; } -- 2.5.0
WARNING: multiple messages have this Message-ID (diff)
From: Joshua Clayton <stillcompiling@gmail.com> To: Alexandre Belloni <alexandre.belloni@free-electrons.com>, Alessandro Zummo <a.zummo@towertech.it> Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Joshua Clayton <stillcompiling@gmail.com> Subject: [rtc-linux] [PATCH v3 2/3] rtc: implement a sysfs interface for clock offset Date: Wed, 3 Feb 2016 09:16:43 -0800 [thread overview] Message-ID: <1454519804-13770-2-git-send-email-stillcompiling@gmail.com> (raw) In-Reply-To: <1454519804-13770-1-git-send-email-stillcompiling@gmail.com> In-Reply-To: <20160202104111.GU20165@piout.net> clock offset may be set and read in decimal parts per billion attribute is /sys/class/rtc/rtcN/offset The attribute is only visible for rtcs that have set_offset implemented. Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- Documentation/rtc.txt | 6 ++++++ drivers/rtc/rtc-sysfs.c | 35 ++++++++++++++++++++++++++++++++++- 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/Documentation/rtc.txt b/Documentation/rtc.txt index 8446f1e..ddc3660 100644 --- a/Documentation/rtc.txt +++ b/Documentation/rtc.txt @@ -157,6 +157,12 @@ wakealarm: The time at which the clock will generate a system wakeup the epoch by default, or if there's a leading +, seconds in the future, or if there is a leading +=, seconds ahead of the current alarm. +offset: The amount which the rtc clock has been adjusted in firmware. + Visible only if the driver supports clock offset adjustment. + The unit is parts per billion, i.e. The number of clock ticks + which are added to or removed from the rtc's base clock per + billion ticks. A positive value makes a day pass more slowly, + longer, and a negative value makes a day pass more quickly. IOCTL INTERFACE --------------- diff --git a/drivers/rtc/rtc-sysfs.c b/drivers/rtc/rtc-sysfs.c index 463e286..f8d7f8d 100644 --- a/drivers/rtc/rtc-sysfs.c +++ b/drivers/rtc/rtc-sysfs.c @@ -218,6 +218,34 @@ wakealarm_store(struct device *dev, struct device_attribute *attr, } static DEVICE_ATTR_RW(wakealarm); +static ssize_t +offset_show(struct device *dev, struct device_attribute *attr, char *buf) +{ + ssize_t retval; + long offset; + + retval = rtc_read_offset(to_rtc_device(dev), &offset); + if (retval == 0) + retval = sprintf(buf, "%ld\n", offset); + + return retval; +} + +static ssize_t +offset_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t n) +{ + ssize_t retval; + long offset; + + retval = kstrtol(buf, 10, &offset); + if (retval == 0) + retval = rtc_set_offset(to_rtc_device(dev), offset); + + return (retval < 0) ? retval : n; +} +static DEVICE_ATTR_RW(offset); + static struct attribute *rtc_attrs[] = { &dev_attr_name.attr, &dev_attr_date.attr, @@ -226,6 +254,7 @@ static struct attribute *rtc_attrs[] = { &dev_attr_max_user_freq.attr, &dev_attr_hctosys.attr, &dev_attr_wakealarm.attr, + &dev_attr_offset.attr, NULL, }; @@ -249,9 +278,13 @@ static umode_t rtc_attr_is_visible(struct kobject *kobj, struct rtc_device *rtc = to_rtc_device(dev); umode_t mode = attr->mode; - if (attr == &dev_attr_wakealarm.attr) + if (attr == &dev_attr_wakealarm.attr) { if (!rtc_does_wakealarm(rtc)) mode = 0; + } else if (attr == &dev_attr_offset.attr) { + if (!rtc->ops->set_offset) + mode = 0; + } return mode; } -- 2.5.0 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-02-03 17:17 UTC|newest] Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-04 18:31 [PATCH v2 0/8] rtc: enable adjustment of clock offset Joshua Clayton 2016-01-04 18:31 ` [rtc-linux] " Joshua Clayton [not found] ` <0000-cover-letter.patch> 2016-01-04 18:31 ` [PATCH v2 1/8] rtc-pcf2123: define registers and bit macros Joshua Clayton 2016-01-04 18:31 ` [rtc-linux] " Joshua Clayton 2016-01-04 18:31 ` [PATCH v2 2/8] rtc-pcf2123: clean up reads from the chip Joshua Clayton 2016-01-04 18:31 ` [rtc-linux] " Joshua Clayton 2016-01-04 18:31 ` [PATCH v2 3/8] rtc-pcf2123: clean up writes to the rtc chip Joshua Clayton 2016-01-04 18:31 ` [rtc-linux] " Joshua Clayton 2016-01-04 18:31 ` [PATCH v2 4/8] rtc-pcf2123: refactor chip reset into a function Joshua Clayton 2016-01-04 18:31 ` [rtc-linux] " Joshua Clayton 2016-01-04 18:31 ` [PATCH v2 5/8] rtc-pcf2123: avoid resetting the clock if possible Joshua Clayton 2016-01-04 18:31 ` [rtc-linux] " Joshua Clayton 2016-01-04 18:31 ` [PATCH v2 6/8] rtc: Add functions to set and read clock offset Joshua Clayton 2016-01-04 18:31 ` [rtc-linux] " Joshua Clayton 2016-01-04 18:31 ` [PATCH v2 7/8] rtc: implement a sysfs interface for " Joshua Clayton 2016-01-04 18:31 ` [rtc-linux] " Joshua Clayton 2016-01-31 11:41 ` Alexandre Belloni 2016-01-31 11:41 ` [rtc-linux] " Alexandre Belloni 2016-02-01 20:56 ` Joshua Clayton 2016-02-01 20:56 ` [rtc-linux] " Joshua Clayton 2016-02-02 10:41 ` Alexandre Belloni 2016-02-02 10:41 ` [rtc-linux] " Alexandre Belloni 2016-02-03 17:16 ` [PATCH v3 1/3] rtc: Add functions to set and read rtc offset Joshua Clayton 2016-02-03 17:16 ` [rtc-linux] " Joshua Clayton 2016-02-04 22:07 ` Alexandre Belloni 2016-02-04 22:07 ` [rtc-linux] " Alexandre Belloni 2016-02-04 23:32 ` Joshua Clayton 2016-02-04 23:32 ` [rtc-linux] " Joshua Clayton 2016-02-05 14:39 ` Alexandre Belloni 2016-02-05 14:39 ` [rtc-linux] " Alexandre Belloni 2016-02-05 20:41 ` [PATCH v4 " Joshua Clayton 2016-02-05 20:41 ` [rtc-linux] " Joshua Clayton 2016-02-05 20:41 ` [PATCH v4 2/3] rtc: implement a sysfs interface for clock offset Joshua Clayton 2016-02-05 20:41 ` [rtc-linux] " Joshua Clayton 2016-02-05 20:41 ` [PATCH v4 3/3] rtc-pcf2123: implement read_offset and set_offset Joshua Clayton 2016-02-05 20:41 ` [rtc-linux] " Joshua Clayton 2016-02-23 18:47 ` [PATCH v4 1/3] rtc: Add functions to set and read rtc offset Joshua Clayton 2016-02-23 18:47 ` [rtc-linux] " Joshua Clayton 2016-02-23 21:44 ` Alexandre Belloni 2016-02-23 21:44 ` [rtc-linux] " Alexandre Belloni 2016-02-03 17:16 ` Joshua Clayton [this message] 2016-02-03 17:16 ` [rtc-linux] [PATCH v3 2/3] rtc: implement a sysfs interface for clock offset Joshua Clayton 2016-02-04 22:12 ` Alexandre Belloni 2016-02-04 22:12 ` [rtc-linux] " Alexandre Belloni 2016-02-03 17:16 ` [PATCH v3 3/3] rtc-pcf2123: implement read_offset and set_offset Joshua Clayton 2016-02-03 17:16 ` [rtc-linux] " Joshua Clayton 2016-01-04 18:31 ` [PATCH v2 8/8] " Joshua Clayton 2016-01-04 18:31 ` [rtc-linux] " Joshua Clayton 2016-01-29 18:21 ` [PATCH v6 1/8] eal: pci: add api to rd/wr pci bar region Santosh Shukla 2016-01-29 18:21 ` [PATCH v6 2/8] linuxapp/vfio: ignore mapping for ioport region Santosh Shukla 2016-01-29 18:21 ` [PATCH v6 3/8] eal/linux: never check iopl for arm Santosh Shukla 2016-01-29 18:21 ` [PATCH v6 4/8] virtio: Introduce config RTE_VIRTIO_INC_VECTOR Santosh Shukla 2016-01-29 18:21 ` [PATCH v6 5/8] virtio: move io header and api from virtio_pci.h Santosh Shukla 2016-01-29 18:21 ` [PATCH v6 6/8] virtio: add vfio api to rd/wr ioport space Santosh Shukla 2016-02-01 12:48 ` Yuanhan Liu 2016-02-02 4:30 ` Santosh Shukla 2016-02-02 5:19 ` Yuanhan Liu 2016-02-02 6:02 ` Santosh Shukla 2016-01-29 18:21 ` [PATCH v6 7/8] virtio: extend pci rw api for vfio Santosh Shukla 2016-01-29 18:21 ` [PATCH v6 8/8] virtio: do not parse if interface is vfio Santosh Shukla 2016-02-01 13:48 ` [PATCH v6 1/8] eal: pci: add api to rd/wr pci bar region Yuanhan Liu 2016-02-02 4:14 ` Santosh Shukla 2016-02-02 5:43 ` Yuanhan Liu 2016-02-02 5:50 ` David Marchand 2016-02-02 8:49 ` Yuanhan Liu 2016-02-02 15:51 ` Santosh Shukla 2016-02-02 16:18 ` Santosh Shukla 2016-02-03 9:50 ` Santosh Shukla 2016-02-03 11:50 ` Yuanhan Liu 2016-02-05 17:56 ` David Marchand 2016-02-03 11:43 ` Yuanhan Liu 2016-02-02 7:00 ` Santosh Shukla 2016-02-02 7:01 ` Santosh Shukla 2016-02-08 10:03 ` [PATCH v8 3/4] eal/linux: vfio: ignore mapping for ioport region Santosh Shukla 2016-02-08 10:03 ` [PATCH v8 4/4] eal/linux: vfio: add pci ioport support Santosh Shukla 2016-02-08 14:13 ` Burakov, Anatoly 2016-02-09 9:04 ` David Marchand 2016-02-18 5:25 ` Santosh Shukla 2016-02-18 14:00 ` Thomas Monjalon 2016-01-26 14:56 ` [PATCH v2 0/8] rtc: enable adjustment of clock offset Joshua Clayton 2016-01-26 14:56 ` [rtc-linux] " Joshua Clayton 2016-01-26 16:00 ` Alexandre Belloni 2016-01-26 16:00 ` [rtc-linux] " Alexandre Belloni 2016-01-31 11:29 ` Alexandre Belloni 2016-01-31 11:29 ` [rtc-linux] " Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1454519804-13770-2-git-send-email-stillcompiling@gmail.com \ --to=stillcompiling@gmail.com \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@free-electrons.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rtc-linux@googlegroups.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.