[meta-oe][PATCH] dhcpcd: add recipe for dhcpcd

[meta-oe][PATCH] dhcpcd: add recipe for dhcpcd

[Nate Karstens]

Adds a new recipe for dhcpcd. Modifies the configure script to keep the
host system header files from being used instead of the target system.

Signed-off-by: Nate Karstens <nate.karstens@garmin.com>
---
 .../dhcpcd/dhcpcd-6.9.4/configure.patch               | 12 ++++++++++++
 .../recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb       | 19 +++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100644 meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch
 create mode 100644 meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb

diff --git a/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch
new file mode 100644
index 0000000..d61b05e
--- /dev/null
+++ b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch
@@ -0,0 +1,12 @@
+--- ./configure
++++ ./configure
+@@ -316,9 +316,6 @@
+ if [ "$STATIC" = yes ]; then
+ 	echo "LDFLAGS+=	-static" >>$CONFIG_MK
+ fi
+-for x in $INCLUDEDIR; do
+-	echo "CPPFLAGS+=	-I$x" >>$CONFIG_MK
+-done
+
+ if [ -z "$DEBUG" -a -f .fslckout ]; then
+ 	printf "Found fossil checkout ... "
diff --git a/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
new file mode 100644
index 0000000..1c0aff4
--- /dev/null
+++ b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
@@ -0,0 +1,19 @@
+SECTION = "console/network"
+SUMMARY = "dhcpcd - a DHCP client"
+DESCRIPTION = "dhcpcd runs on your machine and silently configures your computer to work on the attached networks without trouble and mostly without configuration."
+
+HOMEPAGE = "http://roy.marples.name/projects/dhcpcd/"
+
+LICENSE = "BSD-2-Clause"
+LIC_FILES_CHKSUM = "file://dhcpcd.c;endline=26;md5=7daf225c91b8065ecc974fc594b2a7de"
+
+SRC_URI = "http://roy.marples.name/downloads/${BPN}/${BPN}-${PV}.tar.xz \
+           file://configure.patch"
+
+SRC_URI[md5sum] = "02f5043a415cd4b6d089631a0cd95f5b"
+SRC_URI[sha256sum] = "c3f3ff7473ef158a1e71db9aea7424df2c3477ad064e2b542f27948a5abc9ba0"
+
+inherit autotools
+
+B = "${S}"
+EXTRA_OECONF = "--enable-ipv4 --enable-ipv6"
-- 
1.9.1

Re: [meta-oe][PATCH] dhcpcd: add recipe for dhcpcd

[Khem Raj]

On Thu, Dec 24, 2015 at 2:50 AM, Nate Karstens <nate.karstens@garmin.com> wrote:
> Adds a new recipe for dhcpcd. Modifies the configure script to keep the
> host system header files from being used instead of the target system.
>

Can you also see how you differ with
https://github.com/sarnold/meta-alt-desktop-extras/blob/master/recipes-connectivity/dhcpcd/dhcpcd_1.3.22-pl4.bb

and I would prefer you to send a removal patch to above layer and let
it use it from meta-networking.

> Signed-off-by: Nate Karstens <nate.karstens@garmin.com>
> ---
>  .../dhcpcd/dhcpcd-6.9.4/configure.patch               | 12 ++++++++++++
>  .../recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb       | 19 +++++++++++++++++++
>  2 files changed, 31 insertions(+)
>  create mode 100644 meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch
>  create mode 100644 meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
>
> diff --git a/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch
> new file mode 100644
> index 0000000..d61b05e
> --- /dev/null
> +++ b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch
> @@ -0,0 +1,12 @@
> +--- ./configure
> ++++ ./configure
> +@@ -316,9 +316,6 @@
> + if [ "$STATIC" = yes ]; then
> +       echo "LDFLAGS+= -static" >>$CONFIG_MK
> + fi
> +-for x in $INCLUDEDIR; do
> +-      echo "CPPFLAGS+=        -I$x" >>$CONFIG_MK
> +-done
> +
> + if [ -z "$DEBUG" -a -f .fslckout ]; then
> +       printf "Found fossil checkout ... "
> diff --git a/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
> new file mode 100644
> index 0000000..1c0aff4
> --- /dev/null
> +++ b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
> @@ -0,0 +1,19 @@
> +SECTION = "console/network"
> +SUMMARY = "dhcpcd - a DHCP client"
> +DESCRIPTION = "dhcpcd runs on your machine and silently configures your computer to work on the attached networks without trouble and mostly without configuration."
> +
> +HOMEPAGE = "http://roy.marples.name/projects/dhcpcd/"
> +
> +LICENSE = "BSD-2-Clause"
> +LIC_FILES_CHKSUM = "file://dhcpcd.c;endline=26;md5=7daf225c91b8065ecc974fc594b2a7de"
> +
> +SRC_URI = "http://roy.marples.name/downloads/${BPN}/${BPN}-${PV}.tar.xz \
> +           file://configure.patch"
> +
> +SRC_URI[md5sum] = "02f5043a415cd4b6d089631a0cd95f5b"
> +SRC_URI[sha256sum] = "c3f3ff7473ef158a1e71db9aea7424df2c3477ad064e2b542f27948a5abc9ba0"
> +
> +inherit autotools
> +
> +B = "${S}"
> +EXTRA_OECONF = "--enable-ipv4 --enable-ipv6"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe][PATCH] dhcpcd: add recipe for dhcpcd

[Karstens, Nate]

Sorry for the delay. I contacted the author and he pointed me to the following page:

http://roy.marples.name/projects/dhcpcd/wiki?name=history

To summarize, this recipe is for a fork of the original project that has been entirely rewritten.

Rather than removing the old recipe entirely, do you think it makes sense to move it to meta-networking and allow users to use PREFERRED_VERSION to choose which version of the program they want?

I can submit a separate patch to move or delete the old recipe, depending on your preference. Do you want that done before proceeding with this patch?

Nate

-----Original Message-----
From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Khem Raj
Sent: Thursday, December 24, 2015 12:43 PM
To: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [oe] [meta-oe][PATCH] dhcpcd: add recipe for dhcpcd

On Thu, Dec 24, 2015 at 2:50 AM, Nate Karstens <nate.karstens@garmin.com> wrote:
> Adds a new recipe for dhcpcd. Modifies the configure script to keep
> the host system header files from being used instead of the target system.
>

Can you also see how you differ with
https://github.com/sarnold/meta-alt-desktop-extras/blob/master/recipes-connectivity/dhcpcd/dhcpcd_1.3.22-pl4.bb

and I would prefer you to send a removal patch to above layer and let it use it from meta-networking.

> Signed-off-by: Nate Karstens <nate.karstens@garmin.com>
> ---
>  .../dhcpcd/dhcpcd-6.9.4/configure.patch               | 12 ++++++++++++
>  .../recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb       | 19 +++++++++++++++++++
>  2 files changed, 31 insertions(+)
>  create mode 100644
> meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.pat
> ch  create mode 100644
> meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
>
> diff --git
> a/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.p
> atch
> b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.p
> atch
> new file mode 100644
> index 0000000..d61b05e
> --- /dev/null
> +++ b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configu
> +++ re.patch
> @@ -0,0 +1,12 @@
> +--- ./configure
> ++++ ./configure
> +@@ -316,9 +316,6 @@
> + if [ "$STATIC" = yes ]; then
> +       echo "LDFLAGS+= -static" >>$CONFIG_MK  fi -for x in
> +$INCLUDEDIR; do
> +-      echo "CPPFLAGS+=        -I$x" >>$CONFIG_MK
> +-done
> +
> + if [ -z "$DEBUG" -a -f .fslckout ]; then
> +       printf "Found fossil checkout ... "
> diff --git
> a/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
> b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
> new file mode 100644
> index 0000000..1c0aff4
> --- /dev/null
> +++ b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
> @@ -0,0 +1,19 @@
> +SECTION = "console/network"
> +SUMMARY = "dhcpcd - a DHCP client"
> +DESCRIPTION = "dhcpcd runs on your machine and silently configures your computer to work on the attached networks without trouble and mostly without configuration."
> +
> +HOMEPAGE = "http://roy.marples.name/projects/dhcpcd/"
> +
> +LICENSE = "BSD-2-Clause"
> +LIC_FILES_CHKSUM = "file://dhcpcd.c;endline=26;md5=7daf225c91b8065ecc974fc594b2a7de"
> +
> +SRC_URI = "http://roy.marples.name/downloads/${BPN}/${BPN}-${PV}.tar.xz \
> +           file://configure.patch"
> +
> +SRC_URI[md5sum] = "02f5043a415cd4b6d089631a0cd95f5b"
> +SRC_URI[sha256sum] = "c3f3ff7473ef158a1e71db9aea7424df2c3477ad064e2b542f27948a5abc9ba0"
> +
> +inherit autotools
> +
> +B = "${S}"
> +EXTRA_OECONF = "--enable-ipv4 --enable-ipv6"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be confidential and/or legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.

Re: [meta-oe][PATCH] dhcpcd: add recipe for dhcpcd

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 5027 bytes --]


> On Jan 5, 2016, at 5:37 AM, Karstens, Nate <Nate.Karstens@garmin.com> wrote:
> 
> Sorry for the delay. I contacted the author and he pointed me to the following page:
> 
> http://roy.marples.name/projects/dhcpcd/wiki?name=history
> 
> To summarize, this recipe is for a fork of the original project that has been entirely rewritten.
> 
> Rather than removing the old recipe entirely, do you think it makes sense to move it to meta-networking and allow users to use PREFERRED_VERSION to choose which version of the program they want?
> 
> I can submit a separate patch to move or delete the old recipe, depending on your preference. Do you want that done before proceeding with this patch?


having a single recipe is preferred. If Steve can confirm that what your recipe is doing is sufficient for his usecase then we should go with deletion
and moving this into meta-networking.

> 
> Nate
> 
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Khem Raj
> Sent: Thursday, December 24, 2015 12:43 PM
> To: openembeded-devel <openembedded-devel@lists.openembedded.org>
> Subject: Re: [oe] [meta-oe][PATCH] dhcpcd: add recipe for dhcpcd
> 
> On Thu, Dec 24, 2015 at 2:50 AM, Nate Karstens <nate.karstens@garmin.com> wrote:
>> Adds a new recipe for dhcpcd. Modifies the configure script to keep
>> the host system header files from being used instead of the target system.
>> 
> 
> Can you also see how you differ with
> https://github.com/sarnold/meta-alt-desktop-extras/blob/master/recipes-connectivity/dhcpcd/dhcpcd_1.3.22-pl4.bb
> 
> and I would prefer you to send a removal patch to above layer and let it use it from meta-networking.
> 
>> Signed-off-by: Nate Karstens <nate.karstens@garmin.com>
>> ---
>> .../dhcpcd/dhcpcd-6.9.4/configure.patch               | 12 ++++++++++++
>> .../recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb       | 19 +++++++++++++++++++
>> 2 files changed, 31 insertions(+)
>> create mode 100644
>> meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.pat
>> ch  create mode 100644
>> meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
>> 
>> diff --git
>> a/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.p
>> atch
>> b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.p
>> atch
>> new file mode 100644
>> index 0000000..d61b05e
>> --- /dev/null
>> +++ b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configu
>> +++ re.patch
>> @@ -0,0 +1,12 @@
>> +--- ./configure
>> ++++ ./configure
>> +@@ -316,9 +316,6 @@
>> + if [ "$STATIC" = yes ]; then
>> +       echo "LDFLAGS+= -static" >>$CONFIG_MK  fi -for x in
>> +$INCLUDEDIR; do
>> +-      echo "CPPFLAGS+=        -I$x" >>$CONFIG_MK
>> +-done
>> +
>> + if [ -z "$DEBUG" -a -f .fslckout ]; then
>> +       printf "Found fossil checkout ... "
>> diff --git
>> a/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
>> b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
>> new file mode 100644
>> index 0000000..1c0aff4
>> --- /dev/null
>> +++ b/meta-networking/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
>> @@ -0,0 +1,19 @@
>> +SECTION = "console/network"
>> +SUMMARY = "dhcpcd - a DHCP client"
>> +DESCRIPTION = "dhcpcd runs on your machine and silently configures your computer to work on the attached networks without trouble and mostly without configuration."
>> +
>> +HOMEPAGE = "http://roy.marples.name/projects/dhcpcd/"
>> +
>> +LICENSE = "BSD-2-Clause"
>> +LIC_FILES_CHKSUM = "file://dhcpcd.c;endline=26;md5=7daf225c91b8065ecc974fc594b2a7de"
>> +
>> +SRC_URI = "http://roy.marples.name/downloads/${BPN}/${BPN}-${PV}.tar.xz \
>> +           file://configure.patch"
>> +
>> +SRC_URI[md5sum] = "02f5043a415cd4b6d089631a0cd95f5b"
>> +SRC_URI[sha256sum] = "c3f3ff7473ef158a1e71db9aea7424df2c3477ad064e2b542f27948a5abc9ba0"
>> +
>> +inherit autotools
>> +
>> +B = "${S}"
>> +EXTRA_OECONF = "--enable-ipv4 --enable-ipv6"
>> --
>> 1.9.1
>> 
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> ________________________________
> 
> CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be confidential and/or legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [meta-oe][PATCH] dhcpcd: add recipe for dhcpcd

[Stephen Arnold]

On Tue, 5 Jan 2016 13:37:35 +0000
"Karstens, Nate" <Nate.Karstens@garmin.com> wrote:

Me too, I sent this earlier from a non-subscribed address...

Steve

> Sorry for the delay. I contacted the author and he pointed me to
> the following page:
>
> http://roy.marples.name/projects/dhcpcd/wiki?name=history
>
> To summarize, this recipe is for a fork of the original project
> that has been entirely rewritten.
>
> Rather than removing the old recipe entirely, do you think it
> makes sense to move it to meta-networking and allow users to use
> PREFERRED_VERSION to choose which version of the program they
> want?

TBH, since I didn't put anything in the commit msg I don't remember
where I got that recipe (nor do I recognize the upstream).  OTOH,
we use Roy's dhcpcd as primary Gentoo package upstream, so I'm fine
with that (bonus it's maintained and has all the cool kid features).

Not sure why I didn't do it that way in the first place...

As for meta-networking dependency, I'm not sure about that one
either; I'm currently having network startup issues in a fresh image
(fsl+neo hacks) that I need to look into and it mostly seems to
point at dhcp so far (the default network config doesn't start on
boot but starts fine manually after that).  I didn't see that in my
last BBB or imx28 builds.

Note the neo minimal image started up dhcp/ssh as expected, but then
started going goofy with core-image-full-cmdline and some local.conf
tweaks.  But I still need to diagnose the OE neo image stuff; all I
can say is everything (network-wise) works fine on neo with my
Gentoo card.

My vote would be whatever is the most stable/reliable should be in
the core layers rather than an "extra" layer people need to add to
bblayers manually.

Steve

> I can submit a separate patch to move or delete the old recipe,
> depending on your preference. Do you want that done before
> proceeding with this patch?
>
> Nate
>
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On
> Behalf Of Khem Raj Sent: Thursday, December 24, 2015 12:43 PM To:
> openembeded-devel <openembedded-devel@lists.openembedded.org>
> Subject: Re: [oe] [meta-oe][PATCH] dhcpcd: add recipe for dhcpcd
>
> On Thu, Dec 24, 2015 at 2:50 AM, Nate Karstens
> <nate.karstens@garmin.com> wrote:
> > Adds a new recipe for dhcpcd. Modifies the configure script to
> > keep the host system header files from being used instead of
> > the target system.
>
> Can you also see how you differ with
> https://github.com/sarnold/meta-alt-desktop-extras/blob/master/recipes-connectivity/dhcpcd/dhcpcd_1.3.22-pl4.bb
>
> and I would prefer you to send a removal patch to above layer and
> let it use it from meta-networking.
[snip]

Re: [meta-oe][PATCH] dhcpcd: add recipe for dhcpcd

[Trevor Woerner]

On 01/05/16 16:55, Stephen Arnold wrote:
> My vote would be whatever is the most stable/reliable should be in
> the core layers rather than an "extra" layer people need to add to
> bblayers manually.

But there's always "bitbake-layers add-layer" and "bitbake-layers
layerindex-fetch" to help :-)

Re: [meta-oe][PATCH] dhcpcd: add recipe for dhcpcd

[Stephen Arnold]

I never said my vote counted...  ;)  But we do have it in "system" in
Gentoo as the default in all the stage builds.  So for me I'd like any
image with a network interface to Just Work using the (sometimes very)
basic manual readme steps in random BSP layers with minimal deps.  And
I haven't seen one yet with a bitbake-layers add-layer step to add
networking...

Steve

On Tue, Jan 5, 2016 at 2:04 PM, Trevor Woerner <twoerner@gmail.com> wrote:
> On 01/05/16 16:55, Stephen Arnold wrote:
>> My vote would be whatever is the most stable/reliable should be in
>> the core layers rather than an "extra" layer people need to add to
>> bblayers manually.
>
> But there's always "bitbake-layers add-layer" and "bitbake-layers
> layerindex-fetch" to help :-)
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel