[PATCH net v4] r8169: Disabling multiple invocation on rtl_try_msi function.

[PATCH net v4] r8169: Disabling multiple invocation on rtl_try_msi function.

[Corcodel Marian]

This patch set MSI on probe stage without this patch MSI is set when rtl_open occur.
 Do not need to run rtl_try_msi on multiple times.

Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>
---
 drivers/net/ethernet/realtek/r8169.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 30eed0d..b0b43b7 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -8248,6 +8248,9 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	/* Identify chip attached to board */
 	rtl8169_get_mac_version(tp, dev, cfg->default_ver);
+	RTL_W8(Cfg9346, Cfg9346_Unlock);
+	tp->features = rtl_try_msi(tp, cfg);
+	RTL_W8(Cfg9346, Cfg9346_Lock);
 
 	rtl_init_rxcfg(tp);
 
@@ -8303,7 +8306,6 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	}
 	if ((RTL_R8(Config5) & (UWF | BWF | MWF)) != 0)
 		tp->features |= RTL_FEATURE_WOL;
-	tp->features |= rtl_try_msi(tp, cfg);
 	RTL_W8(Cfg9346, Cfg9346_Lock);
 
 	if (rtl_tbi_enabled(tp)) {
-- 
2.5.0

Re: [PATCH net v4] r8169: Disabling multiple invocation on rtl_try_msi function.

[Corcodel Marian]

On Thu, 2016-02-04 at 11:35 +0200, Corcodel Marian wrote:
> This patch set MSI on probe stage without this patch MSI is set when
> rtl_open occur.
>  Do not need to run rtl_try_msi on multiple times.
> 
> Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>
> ---
>  drivers/net/ethernet/realtek/r8169.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c
> b/drivers/net/ethernet/realtek/r8169.c
> index 30eed0d..b0b43b7 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -8248,6 +8248,9 @@ static int rtl_init_one(struct pci_dev *pdev,
> const struct pci_device_id *ent)
>  
>  	/* Identify chip attached to board */
>  	rtl8169_get_mac_version(tp, dev, cfg->default_ver);
> +	RTL_W8(Cfg9346, Cfg9346_Unlock);
> +	tp->features = rtl_try_msi(tp, cfg);
> +	RTL_W8(Cfg9346, Cfg9346_Lock);
>  
>  	rtl_init_rxcfg(tp);
>  
> @@ -8303,7 +8306,6 @@ static int rtl_init_one(struct pci_dev *pdev,
> const struct pci_device_id *ent)
>  	}
>  	if ((RTL_R8(Config5) & (UWF | BWF | MWF)) != 0)
>  		tp->features |= RTL_FEATURE_WOL;
> -	tp->features |= rtl_try_msi(tp, cfg);
>  	RTL_W8(Cfg9346, Cfg9346_Lock);
>  
>  	if (rtl_tbi_enabled(tp)) {


Sorry here patch is good but explications is bad.
Is about set first order to run rtl_try_msi and others.