From: Himanshu Madhani <himanshu.madhani@qlogic.com>
To: target-devel@vger.kernel.org, nab@linux-iscsi.org
Cc: giridhar.malavali@qlogic.com, linux-scsi@vger.kernel.org,
himanshu.madhani@qlogic.com
Subject: [PATCH 2/4] qla2xxx: Use ATIO type to send correct tmr response
Date: Thu, 4 Feb 2016 11:45:17 -0500 [thread overview]
Message-ID: <1454604319-27947-3-git-send-email-himanshu.madhani@qlogic.com> (raw)
In-Reply-To: <1454604319-27947-1-git-send-email-himanshu.madhani@qlogic.com>
From: Swapnil Nagle <swapnil.nagle@purestorage.com>
The function value inside se_cmd can change if the TMR is cancelled.
Use original ATIO Type to correctly determine CTIO response.
Signed-off-by: Swapnil Nagle <swapnil.nagle@purestroage.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 74eb776..46c6679 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -1756,7 +1756,7 @@ void qlt_xmit_tm_rsp(struct qla_tgt_mgmt_cmd *mcmd)
qlt_send_notify_ack(vha, &mcmd->orig_iocb.imm_ntfy,
0, 0, 0, 0, 0, 0);
else {
- if (mcmd->se_cmd.se_tmr_req->function == TMR_ABORT_TASK)
+ if (mcmd->orig_iocb.atio.u.raw.entry_type == ABTS_RECV_24XX)
qlt_24xx_send_abts_resp(vha, &mcmd->orig_iocb.abts,
mcmd->fc_tm_rsp, false);
else
--
1.7.7
next prev parent reply other threads:[~2016-02-04 16:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 16:45 [PATCH 0/4] qla2xxx: Patches for target-pending branch Himanshu Madhani
2016-02-04 16:45 ` [PATCH 1/4] qla2xxx: Fix stale pointer access Himanshu Madhani
2016-02-04 16:45 ` Himanshu Madhani [this message]
2016-02-04 16:45 ` [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list Himanshu Madhani
2016-02-04 18:16 ` Bart Van Assche
2016-02-05 17:26 ` Himanshu Madhani
2016-02-05 20:00 ` Bart Van Assche
2016-02-05 20:17 ` Giridhar Malavali
2016-02-07 4:44 ` Nicholas A. Bellinger
2016-02-07 4:40 ` Nicholas A. Bellinger
2016-02-07 5:00 ` Nicholas A. Bellinger
2016-02-09 18:01 ` Himanshu Madhani
2016-02-08 17:43 ` Himanshu Madhani
2016-02-09 5:49 ` Nicholas A. Bellinger
2016-02-09 21:30 ` Himanshu Madhani
2016-02-04 16:45 ` [PATCH 4/4] qla2xxx: Add DebugFS node to show irq vector's cpuid Himanshu Madhani
2016-02-04 18:20 ` Bart Van Assche
2016-02-05 18:49 ` Quinn Tran
2016-02-05 19:42 ` Bart Van Assche
2016-02-05 21:52 ` Quinn Tran
2016-02-07 4:31 ` [PATCH 0/4] qla2xxx: Patches for target-pending branch Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454604319-27947-3-git-send-email-himanshu.madhani@qlogic.com \
--to=himanshu.madhani@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.