All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/2] xenoprof: fix up ability to disable it
@ 2016-02-09  4:15 Doug Goldstein
  2016-02-09  4:15 ` [PATCH v2 2/2] build: convert xenoprof to Kconfig Doug Goldstein
  2016-02-09 10:05 ` [PATCH v2 1/2] xenoprof: fix up ability to disable it Andrew Cooper
  0 siblings, 2 replies; 6+ messages in thread
From: Doug Goldstein @ 2016-02-09  4:15 UTC (permalink / raw)
  To: xen-devel
  Cc: Kevin Tian, Keir Fraser, Jan Beulich, Jun Nakajima,
	Andrew Cooper, Doug Goldstein, Aravind Gopalakrishnan,
	Suravee Suthikulpanit, Boris Ostrovsky

Allow Xenoprof to be fully disabled when toggling the option off.

CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
CC: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
change since v1:
- switch to #define empty 'functions' as suggested by Andrew Cooper
---
 xen/arch/x86/Makefile              | 2 +-
 xen/arch/x86/Rules.mk              | 2 ++
 xen/arch/x86/x86_64/compat/entry.S | 4 ++++
 xen/arch/x86/x86_64/entry.S        | 4 ++++
 xen/include/asm-x86/config.h       | 1 -
 xen/include/asm-x86/vpmu.h         | 9 +++++++++
 xen/include/asm-x86/xenoprof.h     | 7 +++++++
 xen/include/xen/xenoprof.h         | 4 ++++
 8 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index 8e6e901..434d985 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -3,7 +3,7 @@ subdir-y += cpu
 subdir-y += genapic
 subdir-y += hvm
 subdir-y += mm
-subdir-y += oprofile
+subdir-$(xenoprof) += oprofile
 subdir-y += x86_64
 
 obj-bin-y += alternative.init.o
diff --git a/xen/arch/x86/Rules.mk b/xen/arch/x86/Rules.mk
index a1cdae0..94e4efd 100644
--- a/xen/arch/x86/Rules.mk
+++ b/xen/arch/x86/Rules.mk
@@ -10,6 +10,8 @@ CFLAGS += -I$(BASEDIR)/include/asm-x86/mach-generic
 CFLAGS += -I$(BASEDIR)/include/asm-x86/mach-default
 CFLAGS += '-D__OBJECT_LABEL__=$(subst /,$$,$(subst -,_,$(subst $(BASEDIR)/,,$(CURDIR))/$@))'
 
+CFLAGS-$(xenoprof) += -DCONFIG_XENOPROF
+
 # Prevent floating-point variables from creeping into Xen.
 CFLAGS += -msoft-float
 
diff --git a/xen/arch/x86/x86_64/compat/entry.S b/xen/arch/x86/x86_64/compat/entry.S
index 3088aa7..6424ed0 100644
--- a/xen/arch/x86/x86_64/compat/entry.S
+++ b/xen/arch/x86/x86_64/compat/entry.S
@@ -394,6 +394,10 @@ compat_crash_page_fault:
 #define compat_kexec_op do_ni_hypercall
 #endif
 
+#ifndef CONFIG_XENOPROF
+#define compat_xenoprof_op do_ni_hypercall
+#endif
+
 ENTRY(compat_hypercall_table)
         .quad compat_set_trap_table     /*  0 */
         .quad do_mmu_update
diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S
index 94a54aa..0a73878 100644
--- a/xen/arch/x86/x86_64/entry.S
+++ b/xen/arch/x86/x86_64/entry.S
@@ -727,6 +727,10 @@ ENTRY(exception_table)
 #define do_kexec_op do_ni_hypercall
 #endif
 
+#ifndef CONFIG_XENOPROF
+#define do_xenoprof_op do_ni_hypercall
+#endif
+
 ENTRY(hypercall_table)
         .quad do_set_trap_table     /*  0 */
         .quad do_mmu_update
diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h
index d97877d..a45d3ee 100644
--- a/xen/include/asm-x86/config.h
+++ b/xen/include/asm-x86/config.h
@@ -47,7 +47,6 @@
 #define CONFIG_VGA 1
 #define CONFIG_VIDEO 1
 
-#define CONFIG_XENOPROF 1
 #define CONFIG_WATCHDOG 1
 
 #define CONFIG_MULTIBOOT 1
diff --git a/xen/include/asm-x86/vpmu.h b/xen/include/asm-x86/vpmu.h
index 67e73dc..4750a1f 100644
--- a/xen/include/asm-x86/vpmu.h
+++ b/xen/include/asm-x86/vpmu.h
@@ -89,10 +89,14 @@ static inline void vpmu_clear(struct vpmu_struct *vpmu)
 {
     vpmu->flags = 0;
 }
+#ifdef CONFIG_XENOPROF
 static inline bool_t vpmu_is_set(const struct vpmu_struct *vpmu, const u32 mask)
 {
     return !!(vpmu->flags & mask);
 }
+#else
+#define vpmu_is_set(x, y) (!!0)
+#endif
 static inline bool_t vpmu_are_all_set(const struct vpmu_struct *vpmu,
                                       const u32 mask)
 {
@@ -121,8 +125,13 @@ static inline int vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
     return vpmu_do_msr(msr, msr_content, 0, 0);
 }
 
+#ifdef CONFIG_XENOPROF
 extern int acquire_pmu_ownership(int pmu_ownership);
 extern void release_pmu_ownership(int pmu_ownership);
+#else
+#define acquire_pmu_ownership(x) (1)
+#define release_pmu_ownership(x)
+#endif
 
 extern unsigned int vpmu_mode;
 extern unsigned int vpmu_features;
diff --git a/xen/include/asm-x86/xenoprof.h b/xen/include/asm-x86/xenoprof.h
index b006ddc..9574f33 100644
--- a/xen/include/asm-x86/xenoprof.h
+++ b/xen/include/asm-x86/xenoprof.h
@@ -67,9 +67,16 @@ void xenoprof_backtrace(struct vcpu *, const struct cpu_user_regs *,
                  "xenoprof/x86 with autotranslated mode enabled"    \
                  "isn't supported yet\n");                          \
     } while (0)
+
+#ifdef CONFIG_XENOPROF
 int passive_domain_do_rdmsr(unsigned int msr, uint64_t *msr_content);
 int passive_domain_do_wrmsr(unsigned int msr, uint64_t msr_content);
 void passive_domain_destroy(struct vcpu *v);
+#else
+#define passive_domain_do_rdmsr(x, y) (0)
+#define passive_domain_do_wrmsr(x, y) (0)
+#define passive_domain_destroy(x)
+#endif
 
 #endif /* __ASM_X86_XENOPROF_H__ */
 
diff --git a/xen/include/xen/xenoprof.h b/xen/include/xen/xenoprof.h
index 7804e69..2dd084a 100644
--- a/xen/include/xen/xenoprof.h
+++ b/xen/include/xen/xenoprof.h
@@ -74,7 +74,11 @@ int xenoprof_add_trace(struct vcpu *, uint64_t pc, int mode);
 #define PMU_OWNER_XENOPROF      1
 #define PMU_OWNER_HVM           2
 int acquire_pmu_ownship(int pmu_ownership);
+#ifdef CONFIG_XENOPROF
 void release_pmu_ownship(int pmu_ownership);
+#else
+#define release_pmu_ownship(x)
+#endif
 
 void xenoprof_log_event(struct vcpu *, const struct cpu_user_regs *,
                         uint64_t pc, int mode, int event);
-- 
2.4.10

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/2] build: convert xenoprof to Kconfig
  2016-02-09  4:15 [PATCH v2 1/2] xenoprof: fix up ability to disable it Doug Goldstein
@ 2016-02-09  4:15 ` Doug Goldstein
  2016-02-09 12:03   ` Jan Beulich
  2016-02-09 10:05 ` [PATCH v2 1/2] xenoprof: fix up ability to disable it Andrew Cooper
  1 sibling, 1 reply; 6+ messages in thread
From: Doug Goldstein @ 2016-02-09  4:15 UTC (permalink / raw)
  To: xen-devel; +Cc: Keir Fraser, Doug Goldstein, Jan Beulich, Andrew Cooper

Convert the xenoprof x86 build time option to Kconfig.

CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
change since v1:
- fix name of Kconfig entry as suggested by Andrew Cooper
---
 xen/arch/x86/Makefile |  2 +-
 xen/arch/x86/Rules.mk |  3 ---
 xen/common/Kconfig    | 13 +++++++++++++
 xen/common/Makefile   |  2 +-
 4 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index 434d985..1bcb08b 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -3,7 +3,7 @@ subdir-y += cpu
 subdir-y += genapic
 subdir-y += hvm
 subdir-y += mm
-subdir-$(xenoprof) += oprofile
+subdir-$(CONFIG_XENOPROF) += oprofile
 subdir-y += x86_64
 
 obj-bin-y += alternative.init.o
diff --git a/xen/arch/x86/Rules.mk b/xen/arch/x86/Rules.mk
index 94e4efd..14519e3 100644
--- a/xen/arch/x86/Rules.mk
+++ b/xen/arch/x86/Rules.mk
@@ -3,15 +3,12 @@
 
 HAS_NUMA := y
 HAS_CORE_PARKING := y
-xenoprof := y
 
 CFLAGS += -I$(BASEDIR)/include 
 CFLAGS += -I$(BASEDIR)/include/asm-x86/mach-generic
 CFLAGS += -I$(BASEDIR)/include/asm-x86/mach-default
 CFLAGS += '-D__OBJECT_LABEL__=$(subst /,$$,$(subst -,_,$(subst $(BASEDIR)/,,$(CURDIR))/$@))'
 
-CFLAGS-$(xenoprof) += -DCONFIG_XENOPROF
-
 # Prevent floating-point variables from creeping into Xen.
 CFLAGS += -msoft-float
 
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index 6f404b4..8b06dfb 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -84,6 +84,19 @@ config LATE_HWDOM
 
 	  If unsure, say N.
 
+# Adds support for Xenoprof
+config XENOPROF
+	bool "Xen Oprofile Support"
+	default y
+	depends on X86
+	---help---
+	  Xen OProfile (Xenoprof) is a system-wide profiler for Xen virtual
+	  machine environments, capable of profiling the Xen virtual machine
+	  monitor, multiple Linux guest operating systems, and applications
+	  running on them.
+
+	  If unsure, say Y.
+
 # Enable/Disable XSM support
 config XSM
 	bool "Xen Security Modules support"
diff --git a/xen/common/Makefile b/xen/common/Makefile
index 6e82b33..126d373 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -62,7 +62,7 @@ obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma unlzo unlz4
 
 obj-$(perfc)       += perfc.o
 obj-$(crash_debug) += gdbstub.o
-obj-$(xenoprof)    += xenoprof.o
+obj-$(CONFIG_XENOPROF)    += xenoprof.o
 
 obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o kernel.o memory.o multicall.o tmem_xen.o xlat.o)
 
-- 
2.4.10

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] xenoprof: fix up ability to disable it
  2016-02-09  4:15 [PATCH v2 1/2] xenoprof: fix up ability to disable it Doug Goldstein
  2016-02-09  4:15 ` [PATCH v2 2/2] build: convert xenoprof to Kconfig Doug Goldstein
@ 2016-02-09 10:05 ` Andrew Cooper
  2016-02-09 10:07   ` Andrew Cooper
  2016-02-09 13:54   ` Boris Ostrovsky
  1 sibling, 2 replies; 6+ messages in thread
From: Andrew Cooper @ 2016-02-09 10:05 UTC (permalink / raw)
  To: Doug Goldstein, xen-devel
  Cc: Kevin Tian, Keir Fraser, Jan Beulich, Aravind Gopalakrishnan,
	Jun Nakajima, Boris Ostrovsky, Suravee Suthikulpanit

On 09/02/16 04:15, Doug Goldstein wrote:
> diff --git a/xen/include/asm-x86/vpmu.h b/xen/include/asm-x86/vpmu.h
> index 67e73dc..4750a1f 100644
> --- a/xen/include/asm-x86/vpmu.h
> +++ b/xen/include/asm-x86/vpmu.h
> @@ -89,10 +89,14 @@ static inline void vpmu_clear(struct vpmu_struct *vpmu)
>  {
>      vpmu->flags = 0;
>  }
> +#ifdef CONFIG_XENOPROF
>  static inline bool_t vpmu_is_set(const struct vpmu_struct *vpmu, const u32 mask)
>  {
>      return !!(vpmu->flags & mask);
>  }
> +#else
> +#define vpmu_is_set(x, y) (!!0)

Why vpmu_is_set()?  this wasn't guarded in v1.

> +#endif
>  static inline bool_t vpmu_are_all_set(const struct vpmu_struct *vpmu,
>                                        const u32 mask)
>  {
> @@ -121,8 +125,13 @@ static inline int vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
>      return vpmu_do_msr(msr, msr_content, 0, 0);
>  }
>  
> +#ifdef CONFIG_XENOPROF
>  extern int acquire_pmu_ownership(int pmu_ownership);
>  extern void release_pmu_ownership(int pmu_ownership);
> +#else
> +#define acquire_pmu_ownership(x) (1)
> +#define release_pmu_ownership(x)

Yikes - we have two externs of acquire_pmu_ownership().  This is plain
wrong and needs fixing as a separate patch.

These are xenoprof functions, so the externs in xenoprof.h are correct. 
These ones in vpmu.h should be deleted, and code should include
xenoprof.h instead.

> +#endif
>  
>  extern unsigned int vpmu_mode;
>  extern unsigned int vpmu_features;
> diff --git a/xen/include/asm-x86/xenoprof.h b/xen/include/asm-x86/xenoprof.h
> index b006ddc..9574f33 100644
> --- a/xen/include/asm-x86/xenoprof.h
> +++ b/xen/include/asm-x86/xenoprof.h
> @@ -67,9 +67,16 @@ void xenoprof_backtrace(struct vcpu *, const struct cpu_user_regs *,
>                   "xenoprof/x86 with autotranslated mode enabled"    \
>                   "isn't supported yet\n");                          \
>      } while (0)
> +
> +#ifdef CONFIG_XENOPROF
>  int passive_domain_do_rdmsr(unsigned int msr, uint64_t *msr_content);
>  int passive_domain_do_wrmsr(unsigned int msr, uint64_t msr_content);
>  void passive_domain_destroy(struct vcpu *v);
> +#else
> +#define passive_domain_do_rdmsr(x, y) (0)
> +#define passive_domain_do_wrmsr(x, y) (0)
> +#define passive_domain_destroy(x)
> +#endif

This looks much neater - Thanks.

However, please make static inline functions rather than macros, so that
the arguments still get typechecked and evaluated even if !CONFIG_XENOPROF

passive_domain_destroy() is particular is problematic if one were to
have a construct such as "if ( passive_domain_destroy() )" (although
that specific one is not a good example in this case).

~Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] xenoprof: fix up ability to disable it
  2016-02-09 10:05 ` [PATCH v2 1/2] xenoprof: fix up ability to disable it Andrew Cooper
@ 2016-02-09 10:07   ` Andrew Cooper
  2016-02-09 13:54   ` Boris Ostrovsky
  1 sibling, 0 replies; 6+ messages in thread
From: Andrew Cooper @ 2016-02-09 10:07 UTC (permalink / raw)
  To: Doug Goldstein, xen-devel
  Cc: Kevin Tian, Keir Fraser, Jan Beulich, Aravind Gopalakrishnan,
	Jun Nakajima, Boris Ostrovsky, Suravee Suthikulpanit

On 09/02/16 10:05, Andrew Cooper wrote:
> On 09/02/16 04:15, Doug Goldstein wrote:
>> diff --git a/xen/include/asm-x86/vpmu.h b/xen/include/asm-x86/vpmu.h
>> index 67e73dc..4750a1f 100644
>> --- a/xen/include/asm-x86/vpmu.h
>> +++ b/xen/include/asm-x86/vpmu.h
>> @@ -89,10 +89,14 @@ static inline void vpmu_clear(struct vpmu_struct *vpmu)
>>  {
>>      vpmu->flags = 0;
>>  }
>> +#ifdef CONFIG_XENOPROF
>>  static inline bool_t vpmu_is_set(const struct vpmu_struct *vpmu, const u32 mask)
>>  {
>>      return !!(vpmu->flags & mask);
>>  }
>> +#else
>> +#define vpmu_is_set(x, y) (!!0)
> Why vpmu_is_set()?  this wasn't guarded in v1.
>
>> +#endif
>>  static inline bool_t vpmu_are_all_set(const struct vpmu_struct *vpmu,
>>                                        const u32 mask)
>>  {
>> @@ -121,8 +125,13 @@ static inline int vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
>>      return vpmu_do_msr(msr, msr_content, 0, 0);
>>  }
>>  
>> +#ifdef CONFIG_XENOPROF
>>  extern int acquire_pmu_ownership(int pmu_ownership);
>>  extern void release_pmu_ownership(int pmu_ownership);
>> +#else
>> +#define acquire_pmu_ownership(x) (1)
>> +#define release_pmu_ownership(x)
> Yikes - we have two externs of acquire_pmu_ownership().  This is plain
> wrong and needs fixing as a separate patch.
>
> These are xenoprof functions, so the externs in xenoprof.h are correct. 
> These ones in vpmu.h should be deleted, and code should include
> xenoprof.h instead.
>
>> +#endif
>>  
>>  extern unsigned int vpmu_mode;
>>  extern unsigned int vpmu_features;
>> diff --git a/xen/include/asm-x86/xenoprof.h b/xen/include/asm-x86/xenoprof.h
>> index b006ddc..9574f33 100644
>> --- a/xen/include/asm-x86/xenoprof.h
>> +++ b/xen/include/asm-x86/xenoprof.h
>> @@ -67,9 +67,16 @@ void xenoprof_backtrace(struct vcpu *, const struct cpu_user_regs *,
>>                   "xenoprof/x86 with autotranslated mode enabled"    \
>>                   "isn't supported yet\n");                          \
>>      } while (0)
>> +
>> +#ifdef CONFIG_XENOPROF
>>  int passive_domain_do_rdmsr(unsigned int msr, uint64_t *msr_content);
>>  int passive_domain_do_wrmsr(unsigned int msr, uint64_t msr_content);
>>  void passive_domain_destroy(struct vcpu *v);
>> +#else
>> +#define passive_domain_do_rdmsr(x, y) (0)
>> +#define passive_domain_do_wrmsr(x, y) (0)
>> +#define passive_domain_destroy(x)
>> +#endif
> This looks much neater - Thanks.
>
> However, please make static inline functions rather than macros, so that
> the arguments still get typechecked and evaluated even if !CONFIG_XENOPROF
>
> passive_domain_destroy() is particular is problematic if one were to
> have a construct such as "if ( passive_domain_destroy() )" (although
> that specific one is not a good example in this case).
>
> ~Andrew

One final thing to say.  Most of the header file should be inside an
#ifdef CONFIG_XENOPROF, with only the stub inlines in the else clause. 
This way none of the other internals are exposed to other Xen code if
CONFIG_XENOPROF is enabled.

~Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/2] build: convert xenoprof to Kconfig
  2016-02-09  4:15 ` [PATCH v2 2/2] build: convert xenoprof to Kconfig Doug Goldstein
@ 2016-02-09 12:03   ` Jan Beulich
  0 siblings, 0 replies; 6+ messages in thread
From: Jan Beulich @ 2016-02-09 12:03 UTC (permalink / raw)
  To: Doug Goldstein; +Cc: Andrew Cooper, Keir Fraser, xen-devel

>>> On 09.02.16 at 05:15, <cardoe@cardoe.com> wrote:
> Convert the xenoprof x86 build time option to Kconfig.

First of all it's not clear to me whether this really was ever meant to
be a build time option. It's using := (not ?= ), and without there being
a clear indication that this was intended I'm inclined to assume this
is just the result of someone doing something in a, well, slightly
broken way. Nevertheless I can see the point of wanting to disable
this code, but I think that ...

> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -84,6 +84,19 @@ config LATE_HWDOM
>  
>  	  If unsure, say N.
>  
> +# Adds support for Xenoprof
> +config XENOPROF
> +	bool "Xen Oprofile Support"
> +	default y
> +	depends on X86

... this should then also depend on EXPERT.

Jan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] xenoprof: fix up ability to disable it
  2016-02-09 10:05 ` [PATCH v2 1/2] xenoprof: fix up ability to disable it Andrew Cooper
  2016-02-09 10:07   ` Andrew Cooper
@ 2016-02-09 13:54   ` Boris Ostrovsky
  1 sibling, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2016-02-09 13:54 UTC (permalink / raw)
  To: Andrew Cooper, Doug Goldstein, xen-devel
  Cc: Kevin Tian, Keir Fraser, Jan Beulich, Aravind Gopalakrishnan,
	Jun Nakajima, Suravee Suthikulpanit

On 02/09/2016 05:05 AM, Andrew Cooper wrote:
> On 09/02/16 04:15, Doug Goldstein wrote:
>> diff --git a/xen/include/asm-x86/vpmu.h b/xen/include/asm-x86/vpmu.h
>> index 67e73dc..4750a1f 100644
>> --- a/xen/include/asm-x86/vpmu.h
>> +++ b/xen/include/asm-x86/vpmu.h
>> @@ -89,10 +89,14 @@ static inline void vpmu_clear(struct vpmu_struct *vpmu)
>>   {
>>       vpmu->flags = 0;
>>   }
>> +#ifdef CONFIG_XENOPROF
>>   static inline bool_t vpmu_is_set(const struct vpmu_struct *vpmu, const u32 mask)
>>   {
>>       return !!(vpmu->flags & mask);
>>   }
>> +#else
>> +#define vpmu_is_set(x, y) (!!0)
> Why vpmu_is_set()?  this wasn't guarded in v1.

This looks wrong to me. vpmu_is_set() is almost exclusively used by VPMU 
code.

>
>> +#endif
>>   static inline bool_t vpmu_are_all_set(const struct vpmu_struct *vpmu,
>>                                         const u32 mask)
>>   {
>> @@ -121,8 +125,13 @@ static inline int vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
>>       return vpmu_do_msr(msr, msr_content, 0, 0);
>>   }
>>   
>> +#ifdef CONFIG_XENOPROF
>>   extern int acquire_pmu_ownership(int pmu_ownership);
>>   extern void release_pmu_ownership(int pmu_ownership);
>> +#else
>> +#define acquire_pmu_ownership(x) (1)
>> +#define release_pmu_ownership(x)

Hmm... acquire_pmu_ownship() vs acquire_pmu_ownership() and 
release_pmu_ownship() vs. release_pmu_ownership().

Since you are working with this code, can you also clean that up? It 
looks to me that at some point names got messed up.

-boris

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-02-09 13:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-09  4:15 [PATCH v2 1/2] xenoprof: fix up ability to disable it Doug Goldstein
2016-02-09  4:15 ` [PATCH v2 2/2] build: convert xenoprof to Kconfig Doug Goldstein
2016-02-09 12:03   ` Jan Beulich
2016-02-09 10:05 ` [PATCH v2 1/2] xenoprof: fix up ability to disable it Andrew Cooper
2016-02-09 10:07   ` Andrew Cooper
2016-02-09 13:54   ` Boris Ostrovsky

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.