* [PATCH] mfd: mt6397: Add platform device ID table
@ 2016-02-09 11:10 Javier Martinez Canillas
2016-02-10 16:19 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2016-02-09 11:10 UTC (permalink / raw)
To: linux-kernel; +Cc: Javier Martinez Canillas, Lee Jones
The platform bus_type .match callback attempts to match the platform device
name with an entry on the .id_table if provided and fallbacks to match with
the driver's name if a table is not provided.
Using a platform device ID to match is more explicit, allows the driver to
support more than one device and also the MODULE_DEVICE_TABLE macro can be
used to export the module aliases information instead of the MODULE_ALIAS.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mfd/mt6397-core.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
index 1749c1c9f405..11c28caf4e5a 100644
--- a/drivers/mfd/mt6397-core.c
+++ b/drivers/mfd/mt6397-core.c
@@ -275,6 +275,12 @@ static const struct of_device_id mt6397_of_match[] = {
};
MODULE_DEVICE_TABLE(of, mt6397_of_match);
+static const struct platform_device_id mt6397_id[] = {
+ {"mt6397", 0},
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(platform, mt6397_id);
+
static struct platform_driver mt6397_driver = {
.probe = mt6397_probe,
.remove = mt6397_remove,
@@ -283,6 +289,7 @@ static struct platform_driver mt6397_driver = {
.of_match_table = of_match_ptr(mt6397_of_match),
.pm = &mt6397_pm_ops,
},
+ .id_table = mt6397_id,
};
module_platform_driver(mt6397_driver);
@@ -290,4 +297,3 @@ module_platform_driver(mt6397_driver);
MODULE_AUTHOR("Flora Fu, MediaTek");
MODULE_DESCRIPTION("Driver for MediaTek MT6397 PMIC");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:mt6397");
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: mt6397: Add platform device ID table
2016-02-09 11:10 [PATCH] mfd: mt6397: Add platform device ID table Javier Martinez Canillas
@ 2016-02-10 16:19 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2016-02-10 16:19 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel
On Tue, 09 Feb 2016, Javier Martinez Canillas wrote:
> The platform bus_type .match callback attempts to match the platform device
> name with an entry on the .id_table if provided and fallbacks to match with
> the driver's name if a table is not provided.
>
> Using a platform device ID to match is more explicit, allows the driver to
> support more than one device and also the MODULE_DEVICE_TABLE macro can be
> used to export the module aliases information instead of the MODULE_ALIAS.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/mfd/mt6397-core.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 1749c1c9f405..11c28caf4e5a 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -275,6 +275,12 @@ static const struct of_device_id mt6397_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, mt6397_of_match);
>
> +static const struct platform_device_id mt6397_id[] = {
> + {"mt6397", 0},
Please insert spaces at both ends.
> + { /* sentinel */ },
We know what a NULL entry does. No need for the comment.
> +};
> +MODULE_DEVICE_TABLE(platform, mt6397_id);
> +
> static struct platform_driver mt6397_driver = {
> .probe = mt6397_probe,
> .remove = mt6397_remove,
> @@ -283,6 +289,7 @@ static struct platform_driver mt6397_driver = {
> .of_match_table = of_match_ptr(mt6397_of_match),
> .pm = &mt6397_pm_ops,
> },
> + .id_table = mt6397_id,
> };
>
> module_platform_driver(mt6397_driver);
> @@ -290,4 +297,3 @@ module_platform_driver(mt6397_driver);
> MODULE_AUTHOR("Flora Fu, MediaTek");
> MODULE_DESCRIPTION("Driver for MediaTek MT6397 PMIC");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:mt6397");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-10 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-09 11:10 [PATCH] mfd: mt6397: Add platform device ID table Javier Martinez Canillas
2016-02-10 16:19 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.