* [PATCH] drm: fixes when bridge mode_fixup is null.
@ 2016-02-10 11:03 Carlos Palminha
2016-02-10 11:11 ` Fabio Estevam
2016-02-10 11:21 ` [PATCH v2] " Carlos Palminha
0 siblings, 2 replies; 5+ messages in thread
From: Carlos Palminha @ 2016-02-10 11:03 UTC (permalink / raw)
To: dri-devel, Daniel Vetter, Lars-Peter Clausen, Laurent Pinchart
Cc: CARLOS.PALMINHA
Avoid drivers to copy/past code to implement functions that will only return
true.
---
drivers/gpu/drm/drm_bridge.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index bd93453..4133e51 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -161,6 +161,8 @@ bool drm_bridge_mode_fixup(struct drm_bridge *bridge,
if (bridge->funcs->mode_fixup)
ret = bridge->funcs->mode_fixup(bridge, mode, adjusted_mode);
+ else
+ return true;
ret = ret && drm_bridge_mode_fixup(bridge->next, mode, adjusted_mode);
--
2.5.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: fixes when bridge mode_fixup is null.
2016-02-10 11:03 [PATCH] drm: fixes when bridge mode_fixup is null Carlos Palminha
@ 2016-02-10 11:11 ` Fabio Estevam
2016-02-10 11:21 ` [PATCH v2] " Carlos Palminha
1 sibling, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2016-02-10 11:11 UTC (permalink / raw)
To: Carlos Palminha; +Cc: Daniel Vetter, Laurent Pinchart, DRI mailing list
On Wed, Feb 10, 2016 at 9:03 AM, Carlos Palminha
<CARLOS.PALMINHA@synopsys.com> wrote:
> Avoid drivers to copy/past code to implement functions that will only return
> true.
> ---
You missed your Signed-off-by.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drm: fixes when bridge mode_fixup is null.
2016-02-10 11:03 [PATCH] drm: fixes when bridge mode_fixup is null Carlos Palminha
2016-02-10 11:11 ` Fabio Estevam
@ 2016-02-10 11:21 ` Carlos Palminha
2016-02-10 12:22 ` Daniel Vetter
1 sibling, 1 reply; 5+ messages in thread
From: Carlos Palminha @ 2016-02-10 11:21 UTC (permalink / raw)
To: dri-devel, Daniel Vetter, Lars-Peter Clausen, Laurent Pinchart
Cc: CARLOS.PALMINHA
Avoid drivers to copy/past code to implement functions that will only return
true.
Changes v1->v2:
* Added Signed off by
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/drm_bridge.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index bd93453..4133e51 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -161,6 +161,8 @@ bool drm_bridge_mode_fixup(struct drm_bridge *bridge,
if (bridge->funcs->mode_fixup)
ret = bridge->funcs->mode_fixup(bridge, mode, adjusted_mode);
+ else
+ return true;
ret = ret && drm_bridge_mode_fixup(bridge->next, mode, adjusted_mode);
--
2.5.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm: fixes when bridge mode_fixup is null.
2016-02-10 11:21 ` [PATCH v2] " Carlos Palminha
@ 2016-02-10 12:22 ` Daniel Vetter
2016-02-10 12:26 ` Carlos Palminha
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2016-02-10 12:22 UTC (permalink / raw)
To: Carlos Palminha; +Cc: Daniel Vetter, Laurent Pinchart, dri-devel
On Wed, Feb 10, 2016 at 11:21:16AM +0000, Carlos Palminha wrote:
> Avoid drivers to copy/past code to implement functions that will only return
> true.
>
> Changes v1->v2:
> * Added Signed off by
>
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
> drivers/gpu/drm/drm_bridge.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index bd93453..4133e51 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/drm_bridge.c
> @@ -161,6 +161,8 @@ bool drm_bridge_mode_fixup(struct drm_bridge *bridge,
>
> if (bridge->funcs->mode_fixup)
> ret = bridge->funcs->mode_fixup(bridge, mode, adjusted_mode);
> + else
> + return true;
Ok, this doesn't make sense - if there's no fixup function for this bridge
we should still call any fixup functions of bridges further down the
chain. And ret is initialized already to true, so this should work.
Where/how exactly do you see this blow up?
Aside: dw-hdmi has a dummy mode_fixup function in it's bridge vtable, can
you pls create a patch to remove that one? All other bridge drivers don't
have a mode_fixup function at all.
-Daniel
>
> ret = ret && drm_bridge_mode_fixup(bridge->next, mode, adjusted_mode);
>
> --
> 2.5.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm: fixes when bridge mode_fixup is null.
2016-02-10 12:22 ` Daniel Vetter
@ 2016-02-10 12:26 ` Carlos Palminha
0 siblings, 0 replies; 5+ messages in thread
From: Carlos Palminha @ 2016-02-10 12:26 UTC (permalink / raw)
To: Daniel Vetter, Carlos Palminha; +Cc: Daniel Vetter, Laurent Pinchart, dri-devel
I'll send a v3 patch with the removal for dw-hdmi
On 10-02-2016 12:22, Daniel Vetter wrote:
> On Wed, Feb 10, 2016 at 11:21:16AM +0000, Carlos Palminha wrote:
>> Avoid drivers to copy/past code to implement functions that will only return
>> true.
>>
>> Changes v1->v2:
>> * Added Signed off by
>>
>> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
>> ---
>> drivers/gpu/drm/drm_bridge.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
>> index bd93453..4133e51 100644
>> --- a/drivers/gpu/drm/drm_bridge.c
>> +++ b/drivers/gpu/drm/drm_bridge.c
>> @@ -161,6 +161,8 @@ bool drm_bridge_mode_fixup(struct drm_bridge *bridge,
>>
>> if (bridge->funcs->mode_fixup)
>> ret = bridge->funcs->mode_fixup(bridge, mode, adjusted_mode);
>> + else
>> + return true;
>
> Ok, this doesn't make sense - if there's no fixup function for this bridge
> we should still call any fixup functions of bridges further down the
> chain. And ret is initialized already to true, so this should work.
>
> Where/how exactly do you see this blow up?
>
> Aside: dw-hdmi has a dummy mode_fixup function in it's bridge vtable, can
> you pls create a patch to remove that one? All other bridge drivers don't
> have a mode_fixup function at all.
> -Daniel
>
>>
>> ret = ret && drm_bridge_mode_fixup(bridge->next, mode, adjusted_mode);
>>
>> --
>> 2.5.0
>>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-10 12:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 11:03 [PATCH] drm: fixes when bridge mode_fixup is null Carlos Palminha
2016-02-10 11:11 ` Fabio Estevam
2016-02-10 11:21 ` [PATCH v2] " Carlos Palminha
2016-02-10 12:22 ` Daniel Vetter
2016-02-10 12:26 ` Carlos Palminha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.