* [PATCH v2 0/8] arm64: dts: apq8016 dt patches (Set2).
@ 2016-02-10 11:36 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:36 UTC (permalink / raw)
To: Andy Gross
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
Srinivas Kandagatla
Hi Andy,
Here are few more dt patches (set2) which enables usb and lpass,
with some fixes. I have tested these patches with few changes
to defconfig on DB410C + a usb phy fix.
Thanks,
srini
Changes since v1:
- moved usb usb2513 and usb_id nodes out of soc
as suggested by Stephen Boyd.
- fixed lpass node name, spotted by Stephen Boyd.
- added new patch to enable bam dma
- added a fix from Ivan on led mpp pins.
Ivan T. Ivanov (1):
arm64: dts: qcom: Fix MPP's function used for LED control
Srinivas Kandagatla (7):
arm64: dts: qcom: add manual pullup setting to otg.
arm64: dts: qcom: apq8016-sbc: add usb support
arm64: dts: qcom: add audio pinctrls
arm64: dts: qcom: add lpass node
arm64: dts: qcom: apq8016-sbc: enable lpass on DB410c
arm64: dts: qcom: fix usb digital voltage levels
arm64: dts: qcom: apq8016-sbc: enable bam dma node.
.../arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi | 2 +-
arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 43 ++++
arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 216 +++++++++++++++++++++
arch/arm64/boot/dts/qcom/msm8916.dtsi | 29 ++-
5 files changed, 303 insertions(+), 2 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v2 0/8] arm64: dts: apq8016 dt patches (Set2).
@ 2016-02-10 11:36 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:36 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andy,
Here are few more dt patches (set2) which enables usb and lpass,
with some fixes. I have tested these patches with few changes
to defconfig on DB410C + a usb phy fix.
Thanks,
srini
Changes since v1:
- moved usb usb2513 and usb_id nodes out of soc
as suggested by Stephen Boyd.
- fixed lpass node name, spotted by Stephen Boyd.
- added new patch to enable bam dma
- added a fix from Ivan on led mpp pins.
Ivan T. Ivanov (1):
arm64: dts: qcom: Fix MPP's function used for LED control
Srinivas Kandagatla (7):
arm64: dts: qcom: add manual pullup setting to otg.
arm64: dts: qcom: apq8016-sbc: add usb support
arm64: dts: qcom: add audio pinctrls
arm64: dts: qcom: add lpass node
arm64: dts: qcom: apq8016-sbc: enable lpass on DB410c
arm64: dts: qcom: fix usb digital voltage levels
arm64: dts: qcom: apq8016-sbc: enable bam dma node.
.../arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi | 2 +-
arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 43 ++++
arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 216 +++++++++++++++++++++
arch/arm64/boot/dts/qcom/msm8916.dtsi | 29 ++-
5 files changed, 303 insertions(+), 2 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v2 1/8] arm64: dts: qcom: add manual pullup setting to otg.
2016-02-10 11:36 ` Srinivas Kandagatla
@ 2016-02-10 11:36 ` Srinivas Kandagatla
-1 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:36 UTC (permalink / raw)
To: Andy Gross
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
Srinivas Kandagatla
This patch adds manual pull up setting for usb otg indicating that the
vbus is vbus is not routed to USB controller/phy therefore enables
pull-up explicitly before starting controller.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index ff7ca44..c1592d4 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -399,6 +399,7 @@
qcom,phy-init-sequence = <0x44 0x6B 0x24 0x13>;
dr_mode = "peripheral";
qcom,otg-control = <2>; // PMIC
+ qcom,manual-pullup;
clocks = <&gcc GCC_USB_HS_AHB_CLK>,
<&gcc GCC_USB_HS_SYSTEM_CLK>,
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 1/8] arm64: dts: qcom: add manual pullup setting to otg.
@ 2016-02-10 11:36 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:36 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds manual pull up setting for usb otg indicating that the
vbus is vbus is not routed to USB controller/phy therefore enables
pull-up explicitly before starting controller.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index ff7ca44..c1592d4 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -399,6 +399,7 @@
qcom,phy-init-sequence = <0x44 0x6B 0x24 0x13>;
dr_mode = "peripheral";
qcom,otg-control = <2>; // PMIC
+ qcom,manual-pullup;
clocks = <&gcc GCC_USB_HS_AHB_CLK>,
<&gcc GCC_USB_HS_SYSTEM_CLK>,
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support
2016-02-10 11:36 ` Srinivas Kandagatla
@ 2016-02-10 11:36 ` Srinivas Kandagatla
-1 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:36 UTC (permalink / raw)
To: Andy Gross
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
Srinivas Kandagatla
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++++++++++
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 35 ++++++++++++++++++++++
2 files changed, 50 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
index cbeee0b..4a79dd9 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
@@ -10,4 +10,19 @@
output-low;
};
};
+
+ usb_id_default: usb_id_default {
+ pinmux {
+ function = "gpio";
+ pins = "gpio121";
+ };
+
+ pinconf {
+ pins = "gpio121";
+ function = "gpio";
+ drive-strength = <8>;
+ input-enable;
+ bias-pull-up;
+ };
+ };
};
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 9a6c595..23ba95a 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -151,6 +151,41 @@
cd-gpios = <&msmgpio 38 0x1>;
status = "okay";
};
+
+ usb@78d9000 {
+ extcon = <&usb_id>, <&usb_id>;
+ status = "okay";
+ };
+
+ ehci@78d9000 {
+ status = "okay";
+ };
+
+ phy@78d9000 {
+ v1p8-supply = <&pm8916_l7>;
+ v3p3-supply = <&pm8916_l13>;
+ vddcx-supply = <&pm8916_s1>;
+ extcon = <&usb_id>, <&usb_id>;
+ dr_mode = "otg";
+ status = "okay";
+ switch-gpio = <&pm8916_gpios 4 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb_sw_sel_pm>;
+ };
+ };
+
+ usb2513 {
+ compatible = "smsc,usb3503";
+ reset-gpios = <&pm8916_gpios 3 GPIO_ACTIVE_LOW>;
+ initial-mode = <1>;
+ };
+
+ usb_id: usb-id {
+ interrupt-parent = <&msmgpio>;
+ compatible = "linux,extcon-usb-gpio";
+ id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb_id_default>;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support
@ 2016-02-10 11:36 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:36 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++++++++++
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 35 ++++++++++++++++++++++
2 files changed, 50 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
index cbeee0b..4a79dd9 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
@@ -10,4 +10,19 @@
output-low;
};
};
+
+ usb_id_default: usb_id_default {
+ pinmux {
+ function = "gpio";
+ pins = "gpio121";
+ };
+
+ pinconf {
+ pins = "gpio121";
+ function = "gpio";
+ drive-strength = <8>;
+ input-enable;
+ bias-pull-up;
+ };
+ };
};
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 9a6c595..23ba95a 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -151,6 +151,41 @@
cd-gpios = <&msmgpio 38 0x1>;
status = "okay";
};
+
+ usb at 78d9000 {
+ extcon = <&usb_id>, <&usb_id>;
+ status = "okay";
+ };
+
+ ehci at 78d9000 {
+ status = "okay";
+ };
+
+ phy at 78d9000 {
+ v1p8-supply = <&pm8916_l7>;
+ v3p3-supply = <&pm8916_l13>;
+ vddcx-supply = <&pm8916_s1>;
+ extcon = <&usb_id>, <&usb_id>;
+ dr_mode = "otg";
+ status = "okay";
+ switch-gpio = <&pm8916_gpios 4 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb_sw_sel_pm>;
+ };
+ };
+
+ usb2513 {
+ compatible = "smsc,usb3503";
+ reset-gpios = <&pm8916_gpios 3 GPIO_ACTIVE_LOW>;
+ initial-mode = <1>;
+ };
+
+ usb_id: usb-id {
+ interrupt-parent = <&msmgpio>;
+ compatible = "linux,extcon-usb-gpio";
+ id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb_id_default>;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 3/8] arm64: dts: qcom: add audio pinctrls
2016-02-10 11:36 ` Srinivas Kandagatla
@ 2016-02-10 11:36 ` Srinivas Kandagatla
-1 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:36 UTC (permalink / raw)
To: Andy Gross
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
Srinivas Kandagatla
This patch adds pinctrls required for digital and analog audio via lpass.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 216 +++++++++++++++++++++++++++++
1 file changed, 216 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
index 8d05005..e9ea5ca 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
@@ -504,4 +504,220 @@
};
};
};
+
+ ext-codec-lines {
+ ext_codec_lines_act: lines_on {
+ pinmux {
+ function = "gpio";
+ pins = "gpio67";
+ };
+ pinconf {
+ pins = "gpio67";
+ drive-strength = <8>;
+ bias-disable;
+ output-high;
+ };
+ };
+ ext_codec_lines_sus: lines_off {
+ pinmux {
+ function = "gpio";
+ pins = "gpio67";
+ };
+ pinconf {
+ pins = "gpio67";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ cdc-pdm-lines {
+ cdc_pdm_lines_act: pdm_lines_on {
+ pinmux {
+ function = "cdc_pdm0";
+ pins = "gpio63", "gpio64", "gpio65", "gpio66",
+ "gpio67", "gpio68";
+ };
+ pinconf {
+ pins = "gpio63", "gpio64", "gpio65", "gpio66",
+ "gpio67", "gpio68";
+ drive-strength = <8>;
+ bias-pull-none;
+ };
+ };
+ cdc_pdm_lines_sus: pdm_lines_off {
+ pinmux {
+ function = "cdc_pdm0";
+ pins = "gpio63", "gpio64", "gpio65", "gpio66",
+ "gpio67", "gpio68";
+ };
+ pinconf {
+ pins = "gpio63", "gpio64", "gpio65", "gpio66",
+ "gpio67", "gpio68";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ ext-pri-tlmm-lines {
+ ext_pri_tlmm_lines_act: ext_pa_on {
+ pinmux {
+ function = "pri_mi2s";
+ pins = "gpio113", "gpio114", "gpio115",
+ "gpio116";
+ };
+ pinconf {
+ pins = "gpio113", "gpio114", "gpio115",
+ "gpio116";
+ drive-strength = <8>;
+ bias-pull-none;
+ };
+ };
+
+ ext_pri_tlmm_lines_sus: ext_pa_off {
+ pinmux {
+ function = "pri_mi2s";
+ pins = "gpio113", "gpio114", "gpio115",
+ "gpio116";
+ };
+ pinconf {
+ pins = "gpio113", "gpio114", "gpio115",
+ "gpio116";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ ext-pri-ws-line {
+ ext_pri_ws_act: ext_pa_on {
+ pinmux {
+ function = "pri_mi2s_ws";
+ pins = "gpio110";
+ };
+ pinconf {
+ pins = "gpio110";
+ drive-strength = <8>;
+ bias-pull-none;
+ };
+ };
+
+ ext_pri_ws_sus: ext_pa_off {
+ pinmux {
+ function = "pri_mi2s_ws";
+ pins = "gpio110";
+ };
+ pinconf {
+ pins = "gpio110";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ ext-mclk-tlmm-lines {
+ ext_mclk_tlmm_lines_act: mclk_lines_on {
+ pinmux {
+ function = "pri_mi2s";
+ pins = "gpio116";
+ };
+ pinconf {
+ pins = "gpio116";
+ drive-strength = <8>;
+ bias-pull-none;
+ };
+ };
+ ext_mclk_tlmm_lines_sus: mclk_lines_off {
+ pinmux {
+ function = "pri_mi2s";
+ pins = "gpio116";
+ };
+ pinconf {
+ pins = "gpio116";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ /* secondary Mi2S */
+ ext-sec-tlmm-lines {
+ ext_sec_tlmm_lines_act: tlmm_lines_on {
+ pinmux {
+ function = "sec_mi2s";
+ pins = "gpio112", "gpio117", "gpio118",
+ "gpio119";
+ };
+ pinconf {
+ pins = "gpio112", "gpio117", "gpio118",
+ "gpio119";
+ drive-strength = <8>;
+ bias-pull-none;
+ };
+ };
+ ext_sec_tlmm_lines_sus: tlmm_lines_off {
+ pinmux {
+ function = "sec_mi2s";
+ pins = "gpio112", "gpio117", "gpio118",
+ "gpio119";
+ };
+ pinconf {
+ pins = "gpio112", "gpio117", "gpio118",
+ "gpio119";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ cdc-dmic-lines {
+ cdc_dmic_lines_act: dmic_lines_on {
+ pinmux_dmic0_clk {
+ function = "dmic0_clk";
+ pins = "gpio0";
+ };
+ pinmux_dmic0_data {
+ function = "dmic0_data";
+ pins = "gpio1";
+ };
+ pinconf {
+ pins = "gpio0", "gpio1";
+ drive-strength = <8>;
+ };
+ };
+ cdc_dmic_lines_sus: dmic_lines_off {
+ pinconf {
+ pins = "gpio0", "gpio1";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ cross-conn-det {
+ cross_conn_det_act: lines_on {
+ pinmux {
+ function = "gpio";
+ pins = "gpio120";
+ };
+ pinconf {
+ pins = "gpio120";
+ drive-strength = <8>;
+ output-low;
+ bias-pull-down;
+ };
+ };
+ cross_conn_det_sus: lines_off {
+ pinmux {
+ function = "gpio";
+ pins = "gpio120";
+ };
+ pinconf {
+ pins = "gpio120";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
};
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 3/8] arm64: dts: qcom: add audio pinctrls
@ 2016-02-10 11:36 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:36 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds pinctrls required for digital and analog audio via lpass.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 216 +++++++++++++++++++++++++++++
1 file changed, 216 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
index 8d05005..e9ea5ca 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
@@ -504,4 +504,220 @@
};
};
};
+
+ ext-codec-lines {
+ ext_codec_lines_act: lines_on {
+ pinmux {
+ function = "gpio";
+ pins = "gpio67";
+ };
+ pinconf {
+ pins = "gpio67";
+ drive-strength = <8>;
+ bias-disable;
+ output-high;
+ };
+ };
+ ext_codec_lines_sus: lines_off {
+ pinmux {
+ function = "gpio";
+ pins = "gpio67";
+ };
+ pinconf {
+ pins = "gpio67";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ cdc-pdm-lines {
+ cdc_pdm_lines_act: pdm_lines_on {
+ pinmux {
+ function = "cdc_pdm0";
+ pins = "gpio63", "gpio64", "gpio65", "gpio66",
+ "gpio67", "gpio68";
+ };
+ pinconf {
+ pins = "gpio63", "gpio64", "gpio65", "gpio66",
+ "gpio67", "gpio68";
+ drive-strength = <8>;
+ bias-pull-none;
+ };
+ };
+ cdc_pdm_lines_sus: pdm_lines_off {
+ pinmux {
+ function = "cdc_pdm0";
+ pins = "gpio63", "gpio64", "gpio65", "gpio66",
+ "gpio67", "gpio68";
+ };
+ pinconf {
+ pins = "gpio63", "gpio64", "gpio65", "gpio66",
+ "gpio67", "gpio68";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ ext-pri-tlmm-lines {
+ ext_pri_tlmm_lines_act: ext_pa_on {
+ pinmux {
+ function = "pri_mi2s";
+ pins = "gpio113", "gpio114", "gpio115",
+ "gpio116";
+ };
+ pinconf {
+ pins = "gpio113", "gpio114", "gpio115",
+ "gpio116";
+ drive-strength = <8>;
+ bias-pull-none;
+ };
+ };
+
+ ext_pri_tlmm_lines_sus: ext_pa_off {
+ pinmux {
+ function = "pri_mi2s";
+ pins = "gpio113", "gpio114", "gpio115",
+ "gpio116";
+ };
+ pinconf {
+ pins = "gpio113", "gpio114", "gpio115",
+ "gpio116";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ ext-pri-ws-line {
+ ext_pri_ws_act: ext_pa_on {
+ pinmux {
+ function = "pri_mi2s_ws";
+ pins = "gpio110";
+ };
+ pinconf {
+ pins = "gpio110";
+ drive-strength = <8>;
+ bias-pull-none;
+ };
+ };
+
+ ext_pri_ws_sus: ext_pa_off {
+ pinmux {
+ function = "pri_mi2s_ws";
+ pins = "gpio110";
+ };
+ pinconf {
+ pins = "gpio110";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ ext-mclk-tlmm-lines {
+ ext_mclk_tlmm_lines_act: mclk_lines_on {
+ pinmux {
+ function = "pri_mi2s";
+ pins = "gpio116";
+ };
+ pinconf {
+ pins = "gpio116";
+ drive-strength = <8>;
+ bias-pull-none;
+ };
+ };
+ ext_mclk_tlmm_lines_sus: mclk_lines_off {
+ pinmux {
+ function = "pri_mi2s";
+ pins = "gpio116";
+ };
+ pinconf {
+ pins = "gpio116";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ /* secondary Mi2S */
+ ext-sec-tlmm-lines {
+ ext_sec_tlmm_lines_act: tlmm_lines_on {
+ pinmux {
+ function = "sec_mi2s";
+ pins = "gpio112", "gpio117", "gpio118",
+ "gpio119";
+ };
+ pinconf {
+ pins = "gpio112", "gpio117", "gpio118",
+ "gpio119";
+ drive-strength = <8>;
+ bias-pull-none;
+ };
+ };
+ ext_sec_tlmm_lines_sus: tlmm_lines_off {
+ pinmux {
+ function = "sec_mi2s";
+ pins = "gpio112", "gpio117", "gpio118",
+ "gpio119";
+ };
+ pinconf {
+ pins = "gpio112", "gpio117", "gpio118",
+ "gpio119";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ cdc-dmic-lines {
+ cdc_dmic_lines_act: dmic_lines_on {
+ pinmux_dmic0_clk {
+ function = "dmic0_clk";
+ pins = "gpio0";
+ };
+ pinmux_dmic0_data {
+ function = "dmic0_data";
+ pins = "gpio1";
+ };
+ pinconf {
+ pins = "gpio0", "gpio1";
+ drive-strength = <8>;
+ };
+ };
+ cdc_dmic_lines_sus: dmic_lines_off {
+ pinconf {
+ pins = "gpio0", "gpio1";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
+
+ cross-conn-det {
+ cross_conn_det_act: lines_on {
+ pinmux {
+ function = "gpio";
+ pins = "gpio120";
+ };
+ pinconf {
+ pins = "gpio120";
+ drive-strength = <8>;
+ output-low;
+ bias-pull-down;
+ };
+ };
+ cross_conn_det_sus: lines_off {
+ pinmux {
+ function = "gpio";
+ pins = "gpio120";
+ };
+ pinconf {
+ pins = "gpio120";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+ };
};
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 4/8] arm64: dts: qcom: add lpass node
2016-02-10 11:36 ` Srinivas Kandagatla
@ 2016-02-10 11:36 ` Srinivas Kandagatla
-1 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:36 UTC (permalink / raw)
To: Andy Gross
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
Srinivas Kandagatla
This patch adds lpass node to the SOC.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index c1592d4..a6fddce 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -343,6 +343,32 @@
status = "disabled";
};
+ lpass: lpass@07708000 {
+ status = "disabled";
+ compatible = "qcom,lpass-cpu-apq8016";
+ clocks = <&gcc GCC_ULTAUDIO_AHBFABRIC_IXFABRIC_CLK>,
+ <&gcc GCC_ULTAUDIO_PCNOC_MPORT_CLK>,
+ <&gcc GCC_ULTAUDIO_PCNOC_SWAY_CLK>,
+ <&gcc GCC_ULTAUDIO_LPAIF_PRI_I2S_CLK>,
+ <&gcc GCC_ULTAUDIO_LPAIF_SEC_I2S_CLK>,
+ <&gcc GCC_ULTAUDIO_LPAIF_SEC_I2S_CLK>,
+ <&gcc GCC_ULTAUDIO_LPAIF_AUX_I2S_CLK>;
+
+ clock-names = "ahbix-clk",
+ "pcnoc-mport-clk",
+ "pcnoc-sway-clk",
+ "mi2s-bit-clk0",
+ "mi2s-bit-clk1",
+ "mi2s-bit-clk2",
+ "mi2s-bit-clk3";
+ #sound-dai-cells = <1>;
+
+ interrupts = <0 160 0>;
+ interrupt-names = "lpass-irq-lpaif";
+ reg = <0x07708000 0x10000>;
+ reg-names = "lpass-lpaif";
+ };
+
sdhc_1: sdhci@07824000 {
compatible = "qcom,sdhci-msm-v4";
reg = <0x07824900 0x11c>, <0x07824000 0x800>;
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 4/8] arm64: dts: qcom: add lpass node
@ 2016-02-10 11:36 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:36 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds lpass node to the SOC.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index c1592d4..a6fddce 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -343,6 +343,32 @@
status = "disabled";
};
+ lpass: lpass at 07708000 {
+ status = "disabled";
+ compatible = "qcom,lpass-cpu-apq8016";
+ clocks = <&gcc GCC_ULTAUDIO_AHBFABRIC_IXFABRIC_CLK>,
+ <&gcc GCC_ULTAUDIO_PCNOC_MPORT_CLK>,
+ <&gcc GCC_ULTAUDIO_PCNOC_SWAY_CLK>,
+ <&gcc GCC_ULTAUDIO_LPAIF_PRI_I2S_CLK>,
+ <&gcc GCC_ULTAUDIO_LPAIF_SEC_I2S_CLK>,
+ <&gcc GCC_ULTAUDIO_LPAIF_SEC_I2S_CLK>,
+ <&gcc GCC_ULTAUDIO_LPAIF_AUX_I2S_CLK>;
+
+ clock-names = "ahbix-clk",
+ "pcnoc-mport-clk",
+ "pcnoc-sway-clk",
+ "mi2s-bit-clk0",
+ "mi2s-bit-clk1",
+ "mi2s-bit-clk2",
+ "mi2s-bit-clk3";
+ #sound-dai-cells = <1>;
+
+ interrupts = <0 160 0>;
+ interrupt-names = "lpass-irq-lpaif";
+ reg = <0x07708000 0x10000>;
+ reg-names = "lpass-lpaif";
+ };
+
sdhc_1: sdhci at 07824000 {
compatible = "qcom,sdhci-msm-v4";
reg = <0x07824900 0x11c>, <0x07824000 0x800>;
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 5/8] arm64: dts: qcom: apq8016-sbc: enable lpass on DB410c
2016-02-10 11:36 ` Srinivas Kandagatla
@ 2016-02-10 11:37 ` Srinivas Kandagatla
-1 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:37 UTC (permalink / raw)
To: Andy Gross
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
Srinivas Kandagatla
This patch enables the lpass on DB410C. LPASS is used as cpu dai for
both analog and digital audio.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 23ba95a..8ab87e7 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -172,6 +172,10 @@
pinctrl-names = "default";
pinctrl-0 = <&usb_sw_sel_pm>;
};
+
+ lpass@07708000 {
+ status = "okay";
+ };
};
usb2513 {
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 5/8] arm64: dts: qcom: apq8016-sbc: enable lpass on DB410c
@ 2016-02-10 11:37 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:37 UTC (permalink / raw)
To: linux-arm-kernel
This patch enables the lpass on DB410C. LPASS is used as cpu dai for
both analog and digital audio.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 23ba95a..8ab87e7 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -172,6 +172,10 @@
pinctrl-names = "default";
pinctrl-0 = <&usb_sw_sel_pm>;
};
+
+ lpass at 07708000 {
+ status = "okay";
+ };
};
usb2513 {
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 6/8] arm64: dts: qcom: fix usb digital voltage levels
2016-02-10 11:36 ` Srinivas Kandagatla
@ 2016-02-10 11:37 ` Srinivas Kandagatla
-1 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:37 UTC (permalink / raw)
To: Andy Gross
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
Srinivas Kandagatla
This patch updates the digital voltage levels from corner values to
microvolts as we are going to use s1 regulator directly for vddcx
instead of s1_corner.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index a6fddce..2f40fdd 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -421,7 +421,7 @@
interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_BOTH>,
<GIC_SPI 140 IRQ_TYPE_EDGE_RISING>;
- qcom,vdd-levels = <1 5 7>;
+ qcom,vdd-levels = <500000 1000000 1320000>;
qcom,phy-init-sequence = <0x44 0x6B 0x24 0x13>;
dr_mode = "peripheral";
qcom,otg-control = <2>; // PMIC
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 6/8] arm64: dts: qcom: fix usb digital voltage levels
@ 2016-02-10 11:37 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:37 UTC (permalink / raw)
To: linux-arm-kernel
This patch updates the digital voltage levels from corner values to
microvolts as we are going to use s1 regulator directly for vddcx
instead of s1_corner.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index a6fddce..2f40fdd 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -421,7 +421,7 @@
interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_BOTH>,
<GIC_SPI 140 IRQ_TYPE_EDGE_RISING>;
- qcom,vdd-levels = <1 5 7>;
+ qcom,vdd-levels = <500000 1000000 1320000>;
qcom,phy-init-sequence = <0x44 0x6B 0x24 0x13>;
dr_mode = "peripheral";
qcom,otg-control = <2>; // PMIC
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 7/8] arm64: dts: qcom: apq8016-sbc: enable bam dma node.
2016-02-10 11:36 ` Srinivas Kandagatla
@ 2016-02-10 11:37 ` Srinivas Kandagatla
-1 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:37 UTC (permalink / raw)
To: Andy Gross
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
Srinivas Kandagatla
This patch enables bam dma node, dma is used for both tx and rx on spi
and on high speed serial.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 8ab87e7..a1a39d0 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -33,6 +33,10 @@
};
soc {
+ dma@7884000 {
+ status = "okay";
+ };
+
serial@78af000 {
label = "LS-UART0";
status = "okay";
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 7/8] arm64: dts: qcom: apq8016-sbc: enable bam dma node.
@ 2016-02-10 11:37 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:37 UTC (permalink / raw)
To: linux-arm-kernel
This patch enables bam dma node, dma is used for both tx and rx on spi
and on high speed serial.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 8ab87e7..a1a39d0 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -33,6 +33,10 @@
};
soc {
+ dma at 7884000 {
+ status = "okay";
+ };
+
serial at 78af000 {
label = "LS-UART0";
status = "okay";
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 8/8] arm64: dts: qcom: Fix MPP's function used for LED control
2016-02-10 11:36 ` Srinivas Kandagatla
@ 2016-02-10 11:37 ` Srinivas Kandagatla
-1 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:37 UTC (permalink / raw)
To: Andy Gross
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
Ivan T. Ivanov
From: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
The qcom-spmi-mpp driver is now using string "digital" to denote
old "normal" functionality. Update DTS file.
Also update the powersource.
Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi
index e03c11d..f881437 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi
@@ -33,7 +33,7 @@
pm8916_mpps_leds: pm8916_mpps_leds {
pinconf {
pins = "mpp2", "mpp3";
- function = PMIC_GPIO_FUNC_NORMAL;
+ function = "digital";
output-low;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 8/8] arm64: dts: qcom: Fix MPP's function used for LED control
@ 2016-02-10 11:37 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-10 11:37 UTC (permalink / raw)
To: linux-arm-kernel
From: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
The qcom-spmi-mpp driver is now using string "digital" to denote
old "normal" functionality. Update DTS file.
Also update the powersource.
Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi
index e03c11d..f881437 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-pmic-pins.dtsi
@@ -33,7 +33,7 @@
pm8916_mpps_leds: pm8916_mpps_leds {
pinconf {
pins = "mpp2", "mpp3";
- function = PMIC_GPIO_FUNC_NORMAL;
+ function = "digital";
output-low;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support
2016-02-10 11:36 ` Srinivas Kandagatla
@ 2016-02-22 5:51 ` Bjorn Andersson
-1 siblings, 0 replies; 23+ messages in thread
From: Bjorn Andersson @ 2016-02-22 5:51 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Andy Gross, devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm
On Wed 10 Feb 03:36 PST 2016, Srinivas Kandagatla wrote:
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++++++++++
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 35 ++++++++++++++++++++++
> 2 files changed, 50 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
> index cbeee0b..4a79dd9 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
> @@ -10,4 +10,19 @@
> output-low;
> };
> };
> +
> + usb_id_default: usb_id_default {
Labels are built with _, node names with -.
> + pinmux {
> + function = "gpio";
> + pins = "gpio121";
> + };
You don't need a separate node to specify function...
> +
> + pinconf {
> + pins = "gpio121";
> + function = "gpio";
...but if you really want it, then you shouldn't specify the function
here.
> + drive-strength = <8>;
> + input-enable;
> + bias-pull-up;
> + };
> + };
> };
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
[..]
> +
> + usb_id: usb-id {
> + interrupt-parent = <&msmgpio>;
interrupt-parent is part of specifying an interrupt. You're not doing
that here, so no need to specify a parent.
> + compatible = "linux,extcon-usb-gpio";
> + id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb_id_default>;
> };
> };
Apart from these two nits
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support
@ 2016-02-22 5:51 ` Bjorn Andersson
0 siblings, 0 replies; 23+ messages in thread
From: Bjorn Andersson @ 2016-02-22 5:51 UTC (permalink / raw)
To: linux-arm-kernel
On Wed 10 Feb 03:36 PST 2016, Srinivas Kandagatla wrote:
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++++++++++
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 35 ++++++++++++++++++++++
> 2 files changed, 50 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
> index cbeee0b..4a79dd9 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
> @@ -10,4 +10,19 @@
> output-low;
> };
> };
> +
> + usb_id_default: usb_id_default {
Labels are built with _, node names with -.
> + pinmux {
> + function = "gpio";
> + pins = "gpio121";
> + };
You don't need a separate node to specify function...
> +
> + pinconf {
> + pins = "gpio121";
> + function = "gpio";
...but if you really want it, then you shouldn't specify the function
here.
> + drive-strength = <8>;
> + input-enable;
> + bias-pull-up;
> + };
> + };
> };
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
[..]
> +
> + usb_id: usb-id {
> + interrupt-parent = <&msmgpio>;
interrupt-parent is part of specifying an interrupt. You're not doing
that here, so no need to specify a parent.
> + compatible = "linux,extcon-usb-gpio";
> + id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb_id_default>;
> };
> };
Apart from these two nits
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support
2016-02-22 5:51 ` Bjorn Andersson
(?)
@ 2016-02-22 10:20 ` Srinivas Kandagatla
-1 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-22 10:20 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA
Thanks for the review,
On 22/02/16 05:51, Bjorn Andersson wrote:
> On Wed 10 Feb 03:36 PST 2016, Srinivas Kandagatla wrote:
>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>> arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++++++++++
>> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 35 ++++++++++++++++++++++
>> 2 files changed, 50 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> index cbeee0b..4a79dd9 100644
>> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> @@ -10,4 +10,19 @@
>> output-low;
>> };
>> };
>> +
>> + usb_id_default: usb_id_default {
>
> Labels are built with _, node names with -.
>
>> + pinmux {
>> + function = "gpio";
>> + pins = "gpio121";
>> + };
>
> You don't need a separate node to specify function...
>
>> +
>> + pinconf {
>> + pins = "gpio121";
>> + function = "gpio";
>
> ...but if you really want it, then you shouldn't specify the function
> here.
Oops, Will remove this and resend the patch.
>
>> + drive-strength = <8>;
>> + input-enable;
>> + bias-pull-up;
>> + };
>> + };
>> };
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> [..]
>> +
>> + usb_id: usb-id {
>> + interrupt-parent = <&msmgpio>;
>
> interrupt-parent is part of specifying an interrupt. You're not doing
> that here, so no need to specify a parent.
Yep, will clean this up in next version.
>
>> + compatible = "linux,extcon-usb-gpio";
>> + id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&usb_id_default>;
>> };
>> };
>
> Apart from these two nits
>
> Acked-by: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Thanks,
srini
>
> Regards,
> Bjorn
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support
@ 2016-02-22 10:20 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-22 10:20 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm
Thanks for the review,
On 22/02/16 05:51, Bjorn Andersson wrote:
> On Wed 10 Feb 03:36 PST 2016, Srinivas Kandagatla wrote:
>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++++++++++
>> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 35 ++++++++++++++++++++++
>> 2 files changed, 50 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> index cbeee0b..4a79dd9 100644
>> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> @@ -10,4 +10,19 @@
>> output-low;
>> };
>> };
>> +
>> + usb_id_default: usb_id_default {
>
> Labels are built with _, node names with -.
>
>> + pinmux {
>> + function = "gpio";
>> + pins = "gpio121";
>> + };
>
> You don't need a separate node to specify function...
>
>> +
>> + pinconf {
>> + pins = "gpio121";
>> + function = "gpio";
>
> ...but if you really want it, then you shouldn't specify the function
> here.
Oops, Will remove this and resend the patch.
>
>> + drive-strength = <8>;
>> + input-enable;
>> + bias-pull-up;
>> + };
>> + };
>> };
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> [..]
>> +
>> + usb_id: usb-id {
>> + interrupt-parent = <&msmgpio>;
>
> interrupt-parent is part of specifying an interrupt. You're not doing
> that here, so no need to specify a parent.
Yep, will clean this up in next version.
>
>> + compatible = "linux,extcon-usb-gpio";
>> + id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&usb_id_default>;
>> };
>> };
>
> Apart from these two nits
>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Thanks,
srini
>
> Regards,
> Bjorn
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support
@ 2016-02-22 10:20 ` Srinivas Kandagatla
0 siblings, 0 replies; 23+ messages in thread
From: Srinivas Kandagatla @ 2016-02-22 10:20 UTC (permalink / raw)
To: linux-arm-kernel
Thanks for the review,
On 22/02/16 05:51, Bjorn Andersson wrote:
> On Wed 10 Feb 03:36 PST 2016, Srinivas Kandagatla wrote:
>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++++++++++
>> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 35 ++++++++++++++++++++++
>> 2 files changed, 50 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> index cbeee0b..4a79dd9 100644
>> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> @@ -10,4 +10,19 @@
>> output-low;
>> };
>> };
>> +
>> + usb_id_default: usb_id_default {
>
> Labels are built with _, node names with -.
>
>> + pinmux {
>> + function = "gpio";
>> + pins = "gpio121";
>> + };
>
> You don't need a separate node to specify function...
>
>> +
>> + pinconf {
>> + pins = "gpio121";
>> + function = "gpio";
>
> ...but if you really want it, then you shouldn't specify the function
> here.
Oops, Will remove this and resend the patch.
>
>> + drive-strength = <8>;
>> + input-enable;
>> + bias-pull-up;
>> + };
>> + };
>> };
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> [..]
>> +
>> + usb_id: usb-id {
>> + interrupt-parent = <&msmgpio>;
>
> interrupt-parent is part of specifying an interrupt. You're not doing
> that here, so no need to specify a parent.
Yep, will clean this up in next version.
>
>> + compatible = "linux,extcon-usb-gpio";
>> + id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&usb_id_default>;
>> };
>> };
>
> Apart from these two nits
>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Thanks,
srini
>
> Regards,
> Bjorn
>
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2016-02-22 10:20 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 11:36 [PATCH v2 0/8] arm64: dts: apq8016 dt patches (Set2) Srinivas Kandagatla
2016-02-10 11:36 ` Srinivas Kandagatla
2016-02-10 11:36 ` [PATCH v2 1/8] arm64: dts: qcom: add manual pullup setting to otg Srinivas Kandagatla
2016-02-10 11:36 ` Srinivas Kandagatla
2016-02-10 11:36 ` [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support Srinivas Kandagatla
2016-02-10 11:36 ` Srinivas Kandagatla
2016-02-22 5:51 ` Bjorn Andersson
2016-02-22 5:51 ` Bjorn Andersson
2016-02-22 10:20 ` Srinivas Kandagatla
2016-02-22 10:20 ` Srinivas Kandagatla
2016-02-22 10:20 ` Srinivas Kandagatla
2016-02-10 11:36 ` [PATCH v2 3/8] arm64: dts: qcom: add audio pinctrls Srinivas Kandagatla
2016-02-10 11:36 ` Srinivas Kandagatla
2016-02-10 11:36 ` [PATCH v2 4/8] arm64: dts: qcom: add lpass node Srinivas Kandagatla
2016-02-10 11:36 ` Srinivas Kandagatla
2016-02-10 11:37 ` [PATCH v2 5/8] arm64: dts: qcom: apq8016-sbc: enable lpass on DB410c Srinivas Kandagatla
2016-02-10 11:37 ` Srinivas Kandagatla
2016-02-10 11:37 ` [PATCH v2 6/8] arm64: dts: qcom: fix usb digital voltage levels Srinivas Kandagatla
2016-02-10 11:37 ` Srinivas Kandagatla
2016-02-10 11:37 ` [PATCH v2 7/8] arm64: dts: qcom: apq8016-sbc: enable bam dma node Srinivas Kandagatla
2016-02-10 11:37 ` Srinivas Kandagatla
2016-02-10 11:37 ` [PATCH v2 8/8] arm64: dts: qcom: Fix MPP's function used for LED control Srinivas Kandagatla
2016-02-10 11:37 ` Srinivas Kandagatla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.