All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] test/py: fix CONFIG_SPL test
@ 2016-02-10 19:39 Stephen Warren
  2016-02-15  1:19 ` Simon Glass
  2016-02-15 22:36 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Warren @ 2016-02-10 19:39 UTC (permalink / raw)
  To: u-boot

From: Stephen Warren <swarren@nvidia.com>

The Python ini file parser that's used to parse .config converts all keys
to lower-case. Hence, all queries against the results must use lower-case.
Fix u_boot_console.ensure_spawned() to test CONFIG_SPL correctly, or the
connection will fail for boards that have SPL.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 test/py/u_boot_console_base.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
index 7e1e9d430ffa..58575704adf5 100644
--- a/test/py/u_boot_console_base.py
+++ b/test/py/u_boot_console_base.py
@@ -303,7 +303,7 @@ class ConsoleBase(object):
             if not self.config.gdbserver:
                 self.p.timeout = 30000
             self.p.logfile_read = self.logstream
-            if self.config.buildconfig.get('CONFIG_SPL', False) == 'y':
+            if self.config.buildconfig.get('config_spl', False) == 'y':
                 m = self.p.expect([pattern_u_boot_spl_signon] + self.bad_patterns)
                 if m != 0:
                     raise Exception('Bad pattern found on console: ' +
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] test/py: fix CONFIG_SPL test
  2016-02-10 19:39 [U-Boot] [PATCH] test/py: fix CONFIG_SPL test Stephen Warren
@ 2016-02-15  1:19 ` Simon Glass
  2016-02-15 22:36 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2016-02-15  1:19 UTC (permalink / raw)
  To: u-boot

On 10 February 2016 at 12:39, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The Python ini file parser that's used to parse .config converts all keys
> to lower-case. Hence, all queries against the results must use lower-case.
> Fix u_boot_console.ensure_spawned() to test CONFIG_SPL correctly, or the
> connection will fail for boards that have SPL.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  test/py/u_boot_console_base.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] test/py: fix CONFIG_SPL test
  2016-02-10 19:39 [U-Boot] [PATCH] test/py: fix CONFIG_SPL test Stephen Warren
  2016-02-15  1:19 ` Simon Glass
@ 2016-02-15 22:36 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-02-15 22:36 UTC (permalink / raw)
  To: u-boot

On Wed, Feb 10, 2016 at 12:39:30PM -0700, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> The Python ini file parser that's used to parse .config converts all keys
> to lower-case. Hence, all queries against the results must use lower-case.
> Fix u_boot_console.ensure_spawned() to test CONFIG_SPL correctly, or the
> connection will fail for boards that have SPL.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160215/b87af944/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-15 22:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 19:39 [U-Boot] [PATCH] test/py: fix CONFIG_SPL test Stephen Warren
2016-02-15  1:19 ` Simon Glass
2016-02-15 22:36 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.