All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] test/py: print summary in test order
@ 2016-02-10 20:47 Stephen Warren
  2016-02-15  1:19 ` Simon Glass
  2016-02-15 22:36 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Warren @ 2016-02-10 20:47 UTC (permalink / raw)
  To: u-boot

From: Stephen Warren <swarren@nvidia.com>

Use lists rather than sets to record the status of tests. This causes
the test summary in the HTML file to be generated in the same order as
the tests are (or would have been) run. This makes it easier to locate
the first failed test. The log for this test might have interesting
first clues re: interaction with the environment (e.g. hardware flashing,
serial console, ...) and may help tracking down external issues.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 test/py/conftest.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/test/py/conftest.py b/test/py/conftest.py
index 1ec096e24182..449f98bee39c 100644
--- a/test/py/conftest.py
+++ b/test/py/conftest.py
@@ -312,12 +312,12 @@ def u_boot_console(request):
     return console
 
 anchors = {}
-tests_not_run = set()
-tests_failed = set()
-tests_xpassed = set()
-tests_xfailed = set()
-tests_skipped = set()
-tests_passed = set()
+tests_not_run = []
+tests_failed = []
+tests_xpassed = []
+tests_xfailed = []
+tests_skipped = []
+tests_passed = []
 
 def pytest_itemcollected(item):
     """pytest hook: Called once for each test found during collection.
@@ -332,7 +332,7 @@ def pytest_itemcollected(item):
         Nothing.
     """
 
-    tests_not_run.add(item.name)
+    tests_not_run.append(item.name)
 
 def cleanup():
     """Clean up all global state.
@@ -493,7 +493,7 @@ def pytest_runtest_protocol(item, nextitem):
     if failure_cleanup:
         console.drain_console()
 
-    test_list.add(item.name)
+    test_list.append(item.name)
     tests_not_run.remove(item.name)
 
     try:
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] test/py: print summary in test order
  2016-02-10 20:47 [U-Boot] [PATCH] test/py: print summary in test order Stephen Warren
@ 2016-02-15  1:19 ` Simon Glass
  2016-02-15 22:36 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2016-02-15  1:19 UTC (permalink / raw)
  To: u-boot

On 10 February 2016 at 13:47, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Use lists rather than sets to record the status of tests. This causes
> the test summary in the HTML file to be generated in the same order as
> the tests are (or would have been) run. This makes it easier to locate
> the first failed test. The log for this test might have interesting
> first clues re: interaction with the environment (e.g. hardware flashing,
> serial console, ...) and may help tracking down external issues.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  test/py/conftest.py | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Acked-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] test/py: print summary in test order
  2016-02-10 20:47 [U-Boot] [PATCH] test/py: print summary in test order Stephen Warren
  2016-02-15  1:19 ` Simon Glass
@ 2016-02-15 22:36 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-02-15 22:36 UTC (permalink / raw)
  To: u-boot

On Wed, Feb 10, 2016 at 01:47:37PM -0700, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> Use lists rather than sets to record the status of tests. This causes
> the test summary in the HTML file to be generated in the same order as
> the tests are (or would have been) run. This makes it easier to locate
> the first failed test. The log for this test might have interesting
> first clues re: interaction with the environment (e.g. hardware flashing,
> serial console, ...) and may help tracking down external issues.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160215/3c1266c5/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-15 22:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 20:47 [U-Boot] [PATCH] test/py: print summary in test order Stephen Warren
2016-02-15  1:19 ` Simon Glass
2016-02-15 22:36 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.