All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/3] package/dovecot: Remove bzip2 and zlib options
@ 2016-02-10 20:58 Bernd Kuhls
  2016-02-10 20:58 ` [Buildroot] [PATCH 2/3] package/dovecot: add optional support for xz Bernd Kuhls
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Bernd Kuhls @ 2016-02-10 20:58 UTC (permalink / raw)
  To: buildroot

The next patch of this series will add optional xz and lz4 support, to
avoid adding new options for these compression packages simplify the
configuration of dovecot by removing the options handling optional
compression support.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 Config.in.legacy           | 14 ++++++++++++++
 package/dovecot/Config.in  | 12 ------------
 package/dovecot/dovecot.mk |  4 ++--
 3 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/Config.in.legacy b/Config.in.legacy
index 3677f86..fb149f6 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -145,6 +145,20 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2016.02"
 
+config BR2_PACKAGE_DOVECOT_BZIP2
+	bool "bzip2 support option has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_BZIP2
+	help
+	  Bzip2 support is built if the bzip2 package is selected.
+
+config BR2_PACKAGE_DOVECOT_ZLIB
+	bool "zlib support option has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_ZLIB
+	help
+	  Zlib support is built if the zlib package is selected.
+
 config BR2_PACKAGE_OPENPOWERLINK_DEBUG_LEVEL
 	bool "openpowerlink debug option has been removed"
 	select BR2_LEGACY
diff --git a/package/dovecot/Config.in b/package/dovecot/Config.in
index 3baae6e..194efb6 100644
--- a/package/dovecot/Config.in
+++ b/package/dovecot/Config.in
@@ -13,12 +13,6 @@ config BR2_PACKAGE_DOVECOT
 
 if BR2_PACKAGE_DOVECOT
 
-config BR2_PACKAGE_DOVECOT_BZIP2
-	bool "bzip2 support"
-	select BR2_PACKAGE_BZIP2
-	help
-	  Enable bzip2 support.
-
 config BR2_PACKAGE_DOVECOT_MYSQL
 	bool "mysql support"
 	select BR2_PACKAGE_MYSQL
@@ -43,12 +37,6 @@ config BR2_PACKAGE_DOVECOT_SQLITE
 	help
 	  Enable SQLite support.
 
-config BR2_PACKAGE_DOVECOT_ZLIB
-	bool "zlib support"
-	select BR2_PACKAGE_ZLIB
-	help
-	  Enable zlib support.
-
 source package/dovecot-pigeonhole/Config.in
 
 endif # BR2_PACKAGE_DOVECOT
diff --git a/package/dovecot/dovecot.mk b/package/dovecot/dovecot.mk
index 8451e52..eea9efc 100644
--- a/package/dovecot/dovecot.mk
+++ b/package/dovecot/dovecot.mk
@@ -33,7 +33,7 @@ ifeq ($(BR2_PACKAGE_DOVECOT_MYSQL)$(BR2_PACKAGE_DOVECOT_SQLITE),)
 DOVECOT_CONF_OPTS += --without-sql
 endif
 
-ifeq ($(BR2_PACKAGE_DOVECOT_BZIP2),y)
+ifeq ($(BR2_PACKAGE_BZIP2),y)
 DOVECOT_CONF_OPTS += --with-bzlib
 DOVECOT_DEPENDENCIES += bzip2
 else
@@ -76,7 +76,7 @@ else
 DOVECOT_CONF_OPTS += --without-sqlite
 endif
 
-ifeq ($(BR2_PACKAGE_DOVECOT_ZLIB),y)
+ifeq ($(BR2_PACKAGE_ZLIB),y)
 DOVECOT_CONF_OPTS += --with-zlib
 DOVECOT_DEPENDENCIES += zlib
 else
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/3] package/dovecot: add optional support for xz
  2016-02-10 20:58 [Buildroot] [PATCH 1/3] package/dovecot: Remove bzip2 and zlib options Bernd Kuhls
@ 2016-02-10 20:58 ` Bernd Kuhls
  2016-02-10 20:58 ` [Buildroot] [PATCH 3/3] package/dovecot: add optional support for lz4 Bernd Kuhls
  2016-02-16 22:07 ` [Buildroot] [PATCH 1/3] package/dovecot: Remove bzip2 and zlib options Thomas Petazzoni
  2 siblings, 0 replies; 4+ messages in thread
From: Bernd Kuhls @ 2016-02-10 20:58 UTC (permalink / raw)
  To: buildroot

When xz was compiled before, dovecot will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/dovecot/lib30_imap_zlib_plugin.so | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [liblz4.so.1]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]

(lz4 support will be added with the next patch of this series)

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/dovecot/dovecot.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/dovecot/dovecot.mk b/package/dovecot/dovecot.mk
index eea9efc..dbf2dab 100644
--- a/package/dovecot/dovecot.mk
+++ b/package/dovecot/dovecot.mk
@@ -76,6 +76,13 @@ else
 DOVECOT_CONF_OPTS += --without-sqlite
 endif
 
+ifeq ($(BR2_PACKAGE_XZ),y)
+DOVECOT_CONF_OPTS += --with-lzma
+DOVECOT_DEPENDENCIES += xz
+else
+DOVECOT_CONF_OPTS += --without-lzma
+endif
+
 ifeq ($(BR2_PACKAGE_ZLIB),y)
 DOVECOT_CONF_OPTS += --with-zlib
 DOVECOT_DEPENDENCIES += zlib
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 3/3] package/dovecot: add optional support for lz4
  2016-02-10 20:58 [Buildroot] [PATCH 1/3] package/dovecot: Remove bzip2 and zlib options Bernd Kuhls
  2016-02-10 20:58 ` [Buildroot] [PATCH 2/3] package/dovecot: add optional support for xz Bernd Kuhls
@ 2016-02-10 20:58 ` Bernd Kuhls
  2016-02-16 22:07 ` [Buildroot] [PATCH 1/3] package/dovecot: Remove bzip2 and zlib options Thomas Petazzoni
  2 siblings, 0 replies; 4+ messages in thread
From: Bernd Kuhls @ 2016-02-10 20:58 UTC (permalink / raw)
  To: buildroot

When lz4 was compiled before, dovecot will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/dovecot/lib30_imap_zlib_plugin.so | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [liblz4.so.1]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/dovecot/dovecot.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/dovecot/dovecot.mk b/package/dovecot/dovecot.mk
index dbf2dab..6b69329 100644
--- a/package/dovecot/dovecot.mk
+++ b/package/dovecot/dovecot.mk
@@ -76,6 +76,13 @@ else
 DOVECOT_CONF_OPTS += --without-sqlite
 endif
 
+ifeq ($(BR2_PACKAGE_LZ4),y)
+DOVECOT_CONF_OPTS += --with-lz4
+DOVECOT_DEPENDENCIES += lz4
+else
+DOVECOT_CONF_OPTS += --without-lz4
+endif
+
 ifeq ($(BR2_PACKAGE_XZ),y)
 DOVECOT_CONF_OPTS += --with-lzma
 DOVECOT_DEPENDENCIES += xz
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/3] package/dovecot: Remove bzip2 and zlib options
  2016-02-10 20:58 [Buildroot] [PATCH 1/3] package/dovecot: Remove bzip2 and zlib options Bernd Kuhls
  2016-02-10 20:58 ` [Buildroot] [PATCH 2/3] package/dovecot: add optional support for xz Bernd Kuhls
  2016-02-10 20:58 ` [Buildroot] [PATCH 3/3] package/dovecot: add optional support for lz4 Bernd Kuhls
@ 2016-02-16 22:07 ` Thomas Petazzoni
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-02-16 22:07 UTC (permalink / raw)
  To: buildroot

Dear Bernd Kuhls,

On Wed, 10 Feb 2016 21:58:17 +0100, Bernd Kuhls wrote:
> The next patch of this series will add optional xz and lz4 support, to
> avoid adding new options for these compression packages simplify the
> configuration of dovecot by removing the options handling optional
> compression support.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  Config.in.legacy           | 14 ++++++++++++++
>  package/dovecot/Config.in  | 12 ------------
>  package/dovecot/dovecot.mk |  4 ++--
>  3 files changed, 16 insertions(+), 14 deletions(-)

All three patches applied on master, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-02-16 22:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 20:58 [Buildroot] [PATCH 1/3] package/dovecot: Remove bzip2 and zlib options Bernd Kuhls
2016-02-10 20:58 ` [Buildroot] [PATCH 2/3] package/dovecot: add optional support for xz Bernd Kuhls
2016-02-10 20:58 ` [Buildroot] [PATCH 3/3] package/dovecot: add optional support for lz4 Bernd Kuhls
2016-02-16 22:07 ` [Buildroot] [PATCH 1/3] package/dovecot: Remove bzip2 and zlib options Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.