* [PATCH v2] hpet: drop stale link
@ 2016-02-10 23:05 Michael S. Tsirkin
2016-02-12 3:22 ` Greg Kroah-Hartman
2016-02-17 12:14 ` [tip:x86/urgent] hpet: Drop stale URLs tip-bot for Michael S. Tsirkin
0 siblings, 2 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2016-02-10 23:05 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Gleixner, Clemens Ladisch, Jonathan Corbet, Ingo Molnar,
H. Peter Anvin, x86, Arnd Bergmann, Greg Kroah-Hartman,
linux-doc
Looks like the HPET spec at intel.com got moved.
It isn't hard to find so drop the link, just mention
the revision assumed.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Changes from v1:
actually drop the links, just say "revision 1"
in case a new one ever comes out.
drivers/char/hpet.c | 2 +-
Documentation/timers/hpet.txt | 4 +---
arch/x86/Kconfig | 4 ++--
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 240b6cf..be54e53 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -42,7 +42,7 @@
/*
* The High Precision Event Timer driver.
* This driver is closely modelled after the rtc.c driver.
- * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+ * See HPET spec revision 1.
*/
#define HPET_USER_FREQ (64)
#define HPET_DRIFT (500)
diff --git a/Documentation/timers/hpet.txt b/Documentation/timers/hpet.txt
index 767392f..a484d2c 100644
--- a/Documentation/timers/hpet.txt
+++ b/Documentation/timers/hpet.txt
@@ -1,9 +1,7 @@
High Precision Event Timer Driver for Linux
The High Precision Event Timer (HPET) hardware follows a specification
-by Intel and Microsoft which can be found at
-
- http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+by Intel and Microsoft, revision 1.
Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
and up to 32 comparators. Normally three or more comparators are provided,
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 9af2e63..ae79bab 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -777,8 +777,8 @@ config HPET_TIMER
HPET is the next generation timer replacing legacy 8254s.
The HPET provides a stable time base on SMP
systems, unlike the TSC, but it is more expensive to access,
- as it is off-chip. You can find the HPET spec at
- <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
+ as it is off-chip. The interface used is documented
+ in the HPET spec, revision 1.
You can safely choose Y here. However, HPET will only be
activated if the platform and the BIOS support this feature.
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] hpet: drop stale link
2016-02-10 23:05 [PATCH v2] hpet: drop stale link Michael S. Tsirkin
@ 2016-02-12 3:22 ` Greg Kroah-Hartman
2016-02-17 12:14 ` [tip:x86/urgent] hpet: Drop stale URLs tip-bot for Michael S. Tsirkin
1 sibling, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2016-02-12 3:22 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Thomas Gleixner, Clemens Ladisch, Jonathan Corbet,
Ingo Molnar, H. Peter Anvin, x86, Arnd Bergmann, linux-doc
On Thu, Feb 11, 2016 at 01:05:01AM +0200, Michael S. Tsirkin wrote:
> Looks like the HPET spec at intel.com got moved.
> It isn't hard to find so drop the link, just mention
> the revision assumed.
>
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Changes from v1:
> actually drop the links, just say "revision 1"
> in case a new one ever comes out.
>
> drivers/char/hpet.c | 2 +-
> Documentation/timers/hpet.txt | 4 +---
> arch/x86/Kconfig | 4 ++--
> 3 files changed, 4 insertions(+), 6 deletions(-)
>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/urgent] hpet: Drop stale URLs
2016-02-10 23:05 [PATCH v2] hpet: drop stale link Michael S. Tsirkin
2016-02-12 3:22 ` Greg Kroah-Hartman
@ 2016-02-17 12:14 ` tip-bot for Michael S. Tsirkin
2016-02-18 6:40 ` Andreas Mohr
1 sibling, 1 reply; 4+ messages in thread
From: tip-bot for Michael S. Tsirkin @ 2016-02-17 12:14 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, arnd, mingo, linux-kernel, tglx, corbet, hpa, clemens,
mst, gregkh, torvalds
Commit-ID: 4e7f9df25874cedbbc604a5c5c2e7a6efe662387
Gitweb: http://git.kernel.org/tip/4e7f9df25874cedbbc604a5c5c2e7a6efe662387
Author: Michael S. Tsirkin <mst@redhat.com>
AuthorDate: Thu, 11 Feb 2016 01:05:01 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 17 Feb 2016 09:39:56 +0100
hpet: Drop stale URLs
Looks like the HPET spec at intel.com got moved.
It isn't hard to find so drop the link, just mention
the revision assumed.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Clemens Ladisch <clemens@ladisch.de>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: linux-doc@vger.kernel.org
Link: http://lkml.kernel.org/r/1455145462-3877-1-git-send-email-mst@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
Documentation/timers/hpet.txt | 4 +---
arch/x86/Kconfig | 4 ++--
drivers/char/hpet.c | 2 +-
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/timers/hpet.txt b/Documentation/timers/hpet.txt
index 767392f..a484d2c 100644
--- a/Documentation/timers/hpet.txt
+++ b/Documentation/timers/hpet.txt
@@ -1,9 +1,7 @@
High Precision Event Timer Driver for Linux
The High Precision Event Timer (HPET) hardware follows a specification
-by Intel and Microsoft which can be found at
-
- http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+by Intel and Microsoft, revision 1.
Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
and up to 32 comparators. Normally three or more comparators are provided,
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index ab2ed53..c46662f 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -778,8 +778,8 @@ config HPET_TIMER
HPET is the next generation timer replacing legacy 8254s.
The HPET provides a stable time base on SMP
systems, unlike the TSC, but it is more expensive to access,
- as it is off-chip. You can find the HPET spec at
- <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
+ as it is off-chip. The interface used is documented
+ in the HPET spec, revision 1.
You can safely choose Y here. However, HPET will only be
activated if the platform and the BIOS support this feature.
diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 240b6cf..be54e53 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -42,7 +42,7 @@
/*
* The High Precision Event Timer driver.
* This driver is closely modelled after the rtc.c driver.
- * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+ * See HPET spec revision 1.
*/
#define HPET_USER_FREQ (64)
#define HPET_DRIFT (500)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [tip:x86/urgent] hpet: Drop stale URLs
2016-02-17 12:14 ` [tip:x86/urgent] hpet: Drop stale URLs tip-bot for Michael S. Tsirkin
@ 2016-02-18 6:40 ` Andreas Mohr
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Mohr @ 2016-02-18 6:40 UTC (permalink / raw)
To: clemens, hpa, linux-kernel, tglx, corbet, arnd, peterz, mingo,
gregkh, torvalds, mst
Cc: linux-tip-commits
Hi,
On Wed, Feb 17, 2016 at 04:14:54AM -0800, tip-bot for Michael S. Tsirkin wrote:
> Commit-ID: 4e7f9df25874cedbbc604a5c5c2e7a6efe662387
> Gitweb: http://git.kernel.org/tip/4e7f9df25874cedbbc604a5c5c2e7a6efe662387
> Author: Michael S. Tsirkin <mst@redhat.com>
> AuthorDate: Thu, 11 Feb 2016 01:05:01 +0200
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Wed, 17 Feb 2016 09:39:56 +0100
>
> hpet: Drop stale URLs
>
> Looks like the HPET spec at intel.com got moved.
> It isn't hard to find so drop the link, just mention
> the revision assumed.
While URLs unfortunately often are less permanent than possibly intended
(details see useful entire sub content of
"Aw: Re: Checkout hangs on invalid external URL"
http://svn.haxx.se/users/archive-2015-11/0027.shtml)
and thus too often need to be updated or even removed as a consequence,
I feel that once an URL as a very reliable reference has been lost,
naming of a file likely is the next most reliable fallback reference
(to at least have feeding into an Internet search engine
as the next fallback step).
An alternative/second reference
would have been listing the full title of this existing document, too.
Thus I'm questioning whether the exact file name
should in fact be removed here (at 3 locations even) by this commit,
while at least usefully adding
a (albeit somewhat weak) reference of "revision 1".
> The High Precision Event Timer (HPET) hardware follows a specification
> -by Intel and Microsoft which can be found at
> -
> - http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> +by Intel and Microsoft, revision 1.
Oh, and I noticed as a curiosity (or so I thought)
that this cleanup-style work is (to be made?) part of "x86/urgent",
which I didn't expect to be defined as topically related.
Thanks,
Andreas Mohr
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-18 6:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 23:05 [PATCH v2] hpet: drop stale link Michael S. Tsirkin
2016-02-12 3:22 ` Greg Kroah-Hartman
2016-02-17 12:14 ` [tip:x86/urgent] hpet: Drop stale URLs tip-bot for Michael S. Tsirkin
2016-02-18 6:40 ` Andreas Mohr
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.