[PATCH] Staging: wilc1000: Fixed a coding style error of preference

[PATCH] Staging: wilc1000: Fixed a coding style error of preference

[Rakhi Sharma]

This patch fixes the following warning: __packed is preferred over
__attribute__((packed))

Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
---
 drivers/staging/wilc1000/linux_mon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
index e550027..284dfb0 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers/staging/wilc1000/linux_mon.c
@@ -15,14 +15,14 @@
 struct wilc_wfi_radiotap_hdr {
 	struct ieee80211_radiotap_header hdr;
 	u8 rate;
-} __attribute__((packed));
+} __packed;
 
 struct wilc_wfi_radiotap_cb_hdr {
 	struct ieee80211_radiotap_header hdr;
 	u8 rate;
 	u8 dump;
 	u16 tx_flags;
-} __attribute__((packed));
+} __packed;
 
 static struct net_device *wilc_wfi_mon; /* global monitor netdev */
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: wilc1000: Fixed a coding style error of preference

[Vaishali Thakkar]

On Sat, Feb 13, 2016 at 1:04 PM, Rakhi Sharma <rakhish1994@gmail.com> wrote:
> This patch fixes the following warning: __packed is preferred over
> __attribute__((packed))

Hi,

I think it would be good if you can use more reasonable subject and
commit log.

For example, for this patch you can use something like this:

" Staging: wilc1000: Use __packed instead of __attribute__((packed))"

Then in the commit log you can explain the reason for the fix. Like what you
have done and why the change is correct. And then to give a credit to the tool,
you can add something like 'Problem found using checkpatch.pl'.

You can also go for reading this for the better idea:
http://kernelnewbies.org/PatchPhilosophy

Thank you.

> Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
> ---
>  drivers/staging/wilc1000/linux_mon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
> index e550027..284dfb0 100644
> --- a/drivers/staging/wilc1000/linux_mon.c
> +++ b/drivers/staging/wilc1000/linux_mon.c
> @@ -15,14 +15,14 @@
>  struct wilc_wfi_radiotap_hdr {
>         struct ieee80211_radiotap_header hdr;
>         u8 rate;
> -} __attribute__((packed));
> +} __packed;
>
>  struct wilc_wfi_radiotap_cb_hdr {
>         struct ieee80211_radiotap_header hdr;
>         u8 rate;
>         u8 dump;
>         u16 tx_flags;
> -} __attribute__((packed));
> +} __packed;
>
>  static struct net_device *wilc_wfi_mon; /* global monitor netdev */
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1455348872-8892-1-git-send-email-rakhish1994%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Vaishali

Re: [Outreachy kernel] [PATCH] Staging: wilc1000: Fixed a coding style error of preference

[RAKHI SHARMA]

[-- Attachment #1: Type: text/plain, Size: 2359 bytes --]

On Sat, Feb 13, 2016 at 2:00 PM, Vaishali Thakkar <vthakkar1994@gmail.com>
wrote:

> On Sat, Feb 13, 2016 at 1:04 PM, Rakhi Sharma <rakhish1994@gmail.com>
> wrote:
> > This patch fixes the following warning: __packed is preferred over
> > __attribute__((packed))
>
> Hi,
>
> I think it would be good if you can use more reasonable subject and
> commit log.
>
> For example, for this patch you can use something like this:
>
> " Staging: wilc1000: Use __packed instead of __attribute__((packed))"
>
> Then in the commit log you can explain the reason for the fix. Like what
> you
> have done and why the change is correct. And then to give a credit to the
> tool,
> you can add something like 'Problem found using checkpatch.pl'.
>
> Sorry , I am jsut sending a v2 for this :)

Rakhi

> You can also go for reading this for the better idea:
> http://kernelnewbies.org/PatchPhilosophy
>
> Thank you.
>
> > Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
> > ---
> >  drivers/staging/wilc1000/linux_mon.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/wilc1000/linux_mon.c
> b/drivers/staging/wilc1000/linux_mon.c
> > index e550027..284dfb0 100644
> > --- a/drivers/staging/wilc1000/linux_mon.c
> > +++ b/drivers/staging/wilc1000/linux_mon.c
> > @@ -15,14 +15,14 @@
> >  struct wilc_wfi_radiotap_hdr {
> >         struct ieee80211_radiotap_header hdr;
> >         u8 rate;
> > -} __attribute__((packed));
> > +} __packed;
> >
> >  struct wilc_wfi_radiotap_cb_hdr {
> >         struct ieee80211_radiotap_header hdr;
> >         u8 rate;
> >         u8 dump;
> >         u16 tx_flags;
> > -} __attribute__((packed));
> > +} __packed;
> >
> >  static struct net_device *wilc_wfi_mon; /* global monitor netdev */
> >
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/1455348872-8892-1-git-send-email-rakhish1994%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
>
>
>
> --
> Vaishali
>

[-- Attachment #2: Type: text/html, Size: 3892 bytes --]

Re: [Outreachy kernel] [PATCH] Staging: wilc1000: Fixed a coding style error of preference

[Vaishali Thakkar]

On Sat, Feb 13, 2016 at 2:02 PM, RAKHI SHARMA <rakhish1994@gmail.com> wrote:
> On Sat, Feb 13, 2016 at 2:00 PM, Vaishali Thakkar <vthakkar1994@gmail.com>
> wrote:
>>
>> On Sat, Feb 13, 2016 at 1:04 PM, Rakhi Sharma <rakhish1994@gmail.com>
>> wrote:
>> > This patch fixes the following warning: __packed is preferred over
>> > __attribute__((packed))
>>
>> Hi,
>>
>> I think it would be good if you can use more reasonable subject and
>> commit log.
>>
>> For example, for this patch you can use something like this:
>>
>> " Staging: wilc1000: Use __packed instead of __attribute__((packed))"
>>
>> Then in the commit log you can explain the reason for the fix. Like what
>> you
>> have done and why the change is correct. And then to give a credit to the
>> tool,
>> you can add something like 'Problem found using checkpatch.pl'.
>>
> Sorry , I am jsut sending a v2 for this :)

Don't be sorry for that. :)

By the way, this patch is already in staging-testing branch.
https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=d8c7d2b35d156e4faccfe2742b6c58492b60d065

You need to update your branch.

> Rakhi
>>
>> You can also go for reading this for the better idea:
>> http://kernelnewbies.org/PatchPhilosophy
>>
>> Thank you.
>>
>> > Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
>> > ---
>> >  drivers/staging/wilc1000/linux_mon.c | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/staging/wilc1000/linux_mon.c
>> > b/drivers/staging/wilc1000/linux_mon.c
>> > index e550027..284dfb0 100644
>> > --- a/drivers/staging/wilc1000/linux_mon.c
>> > +++ b/drivers/staging/wilc1000/linux_mon.c
>> > @@ -15,14 +15,14 @@
>> >  struct wilc_wfi_radiotap_hdr {
>> >         struct ieee80211_radiotap_header hdr;
>> >         u8 rate;
>> > -} __attribute__((packed));
>> > +} __packed;
>> >
>> >  struct wilc_wfi_radiotap_cb_hdr {
>> >         struct ieee80211_radiotap_header hdr;
>> >         u8 rate;
>> >         u8 dump;
>> >         u16 tx_flags;
>> > -} __attribute__((packed));
>> > +} __packed;
>> >
>> >  static struct net_device *wilc_wfi_mon; /* global monitor netdev */
>> >
>> > --
>> > 1.9.1
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> > Groups "outreachy-kernel" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> > an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> > To post to this group, send email to outreachy-kernel@googlegroups.com.
>> > To view this discussion on the web visit
>> > https://groups.google.com/d/msgid/outreachy-kernel/1455348872-8892-1-git-send-email-rakhish1994%40gmail.com.
>> > For more options, visit https://groups.google.com/d/optout.
>>
>>
>>
>> --
>> Vaishali
>
>



-- 
Vaishali