* [PATCH] drivers/staging/android: don't use modular references in sync_debug.c
@ 2016-02-13 23:20 Paul Gortmaker
0 siblings, 0 replies; only message in thread
From: Paul Gortmaker @ 2016-02-13 23:20 UTC (permalink / raw)
To: linux-kernel
Cc: devel, Arve Hjønnevåg, Riley Andrews, Paul Gortmaker,
Gustavo Padovan, Maarten Lankhorst, Greg Kroah-Hartman
In commit 8a0044846115e74552b671a7073cffeec14b9316 ("staging/android:
create a 'sync' dir for debugfs information"), modular references were
introduced to this file. However if we look, we find:
drivers/staging/android/Makefile:obj-$(CONFIG_SYNC) += sync.o sync_debug.o
drivers/staging/android/Kconfig:config SYNC
drivers/staging/android/Kconfig: bool "Synchronization framework"
This file isn't currently buildable as a module, and hence the code
for module_exit is just dead code. Remove it and the module.h include.
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/staging/android/sync_debug.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/android/sync_debug.c b/drivers/staging/android/sync_debug.c
index fd13f1e885e5..5a7ec58fbc09 100644
--- a/drivers/staging/android/sync_debug.c
+++ b/drivers/staging/android/sync_debug.c
@@ -15,7 +15,6 @@
*/
#include <linux/debugfs.h>
-#include <linux/module.h>
#include <linux/export.h>
#include <linux/file.h>
#include <linux/fs.h>
@@ -335,13 +334,6 @@ static __init int sync_debugfs_init(void)
}
late_initcall(sync_debugfs_init);
-static __exit void sync_debugfs_exit(void)
-{
- if (dbgfs)
- debugfs_remove_recursive(dbgfs);
-}
-module_exit(sync_debugfs_exit);
-
#define DUMP_CHUNK 256
static char sync_dump_buf[64 * 1024];
void sync_dump(void)
--
2.6.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-02-13 23:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-13 23:20 [PATCH] drivers/staging/android: don't use modular references in sync_debug.c Paul Gortmaker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.