All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 14/16] sandbox: spi: Remove an incorrect free()
Date: Sun, 14 Feb 2016 18:36:58 -0700	[thread overview]
Message-ID: <1455500220-1324-15-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1455500220-1324-1-git-send-email-sjg@chromium.org>

We must not free data that is managed by driver mode. Remove this line,
which is a hangover from the pre-driver-model code.

This fixes a problem where 'sf probe' crashes U-Boot if the backing file
for the SPI flash cannot be found.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 drivers/mtd/spi/sandbox.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/spi/sandbox.c b/drivers/mtd/spi/sandbox.c
index ec07be7..53470b9 100644
--- a/drivers/mtd/spi/sandbox.c
+++ b/drivers/mtd/spi/sandbox.c
@@ -187,7 +187,6 @@ static int sandbox_sf_probe(struct udevice *dev)
 
 	sbsf->fd = os_open(pdata->filename, 02);
 	if (sbsf->fd == -1) {
-		free(sbsf);
 		printf("%s: unable to open file '%s'\n", __func__,
 		       pdata->filename);
 		ret = -EIO;
-- 
2.7.0.rc3.207.g0ac5344

  parent reply	other threads:[~2016-02-15  1:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15  1:36 [U-Boot] [PATCH 00/16] image: Fix various test failures Simon Glass
2016-02-15  1:36 ` [U-Boot] [PATCH 01/16] image: Correct the OS location code to work on sandbox Simon Glass
2016-02-15  1:36 ` [U-Boot] [PATCH 02/16] Revert "image-fit: Fix signature checking" Simon Glass
2016-02-15  1:36 ` [U-Boot] [PATCH 03/16] image: Fix FIT and vboot tests to exit sandbox correctly Simon Glass
2016-02-15  1:36 ` [U-Boot] [PATCH 04/16] trace: Fix compiler warnings in trace Simon Glass
2016-02-16  9:21   ` Bin Meng
2016-02-15  1:36 ` [U-Boot] [PATCH 05/16] lib: Don't instrument the div64 function Simon Glass
2016-02-16  9:21   ` Bin Meng
2016-02-15  1:36 ` [U-Boot] [PATCH 06/16] trace: Improve the trace test number recognition Simon Glass
2016-02-15  1:36 ` [U-Boot] [PATCH 07/16] timer: Support tracing fully Simon Glass
2016-02-16  9:21   ` Bin Meng
2016-02-23  6:37     ` Simon Glass
2016-02-15  1:36 ` [U-Boot] [PATCH 08/16] timer: Provide an early timer Simon Glass
2016-02-16  9:21   ` Bin Meng
2016-02-23  6:37     ` Simon Glass
2016-02-15  1:36 ` [U-Boot] [PATCH 09/16] timer: Set up the real timer after driver model is available Simon Glass
2016-02-16  9:21   ` Bin Meng
2016-02-15  1:36 ` [U-Boot] [PATCH 10/16] sandbox: timer: Support the early timer Simon Glass
2016-02-16  9:22   ` Bin Meng
2016-02-23  6:37     ` Simon Glass
2016-02-15  1:36 ` [U-Boot] [PATCH 11/16] sandbox: Correct ordering of defconfig Simon Glass
2016-02-15  1:36 ` [U-Boot] [PATCH 12/16] sandbox: Enable the early timer Simon Glass
2016-02-16  9:22   ` Bin Meng
2016-02-15  1:36 ` [U-Boot] [PATCH 13/16] sandbox: spi: Add more debugging to SPI emulation Simon Glass
2016-02-15 19:01   ` Jagan Teki
2016-02-15  1:36 ` Simon Glass [this message]
2016-02-15 19:02   ` [U-Boot] [PATCH 14/16] sandbox: spi: Remove an incorrect free() Jagan Teki
2016-02-15 22:37   ` Tom Rini
2016-02-15  1:36 ` [U-Boot] [PATCH 15/16] spi: Correct two error return values Simon Glass
2016-02-15 19:10   ` Jagan Teki
2016-02-15  1:37 ` [U-Boot] [PATCH 16/16] spi: Re-enable the SPI flash tests Simon Glass
2016-02-15 19:10   ` Jagan Teki
2016-02-16 22:03 ` [U-Boot] [PATCH 00/16] image: Fix various test failures Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455500220-1324-15-git-send-email-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.