From: Andrew Jones <drjones@redhat.com> To: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org Cc: thuth@redhat.com, dgibson@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de, lvivier@redhat.com, pbonzini@redhat.com Subject: [kvm-unit-tests PATCH v4 01/17] arm/arm64: trivial: another assert fix Date: Mon, 15 Feb 2016 14:49:10 +0100 [thread overview] Message-ID: <1455544166-19766-2-git-send-email-drjones@redhat.com> (raw) In-Reply-To: <1455544166-19766-1-git-send-email-drjones@redhat.com> Signed-off-by: Andrew Jones <drjones@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Thomas Huth <thuth@redhat.com> --- Unrelated to the powerpc initial drop, but found it while working on that, so just posting it now. Anyway, it's a trivial fix. --- lib/arm/io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/arm/io.c b/lib/arm/io.c index a08d394e4aa1c..a111530f4802d 100644 --- a/lib/arm/io.c +++ b/lib/arm/io.c @@ -50,7 +50,8 @@ static void uart0_init(void) } } else { - assert(dt_pbus_translate_node(ret, 0, &base) == 0); + ret = dt_pbus_translate_node(ret, 0, &base); + assert(ret == 0); } uart0_base = ioremap(base.addr, base.size); -- 2.4.3
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <drjones@redhat.com> To: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org Cc: thuth@redhat.com, dgibson@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de, lvivier@redhat.com, pbonzini@redhat.com Subject: [kvm-unit-tests PATCH v4 01/17] arm/arm64: trivial: another assert fix Date: Mon, 15 Feb 2016 13:49:10 +0000 [thread overview] Message-ID: <1455544166-19766-2-git-send-email-drjones@redhat.com> (raw) In-Reply-To: <1455544166-19766-1-git-send-email-drjones@redhat.com> Signed-off-by: Andrew Jones <drjones@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Thomas Huth <thuth@redhat.com> --- Unrelated to the powerpc initial drop, but found it while working on that, so just posting it now. Anyway, it's a trivial fix. --- lib/arm/io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/arm/io.c b/lib/arm/io.c index a08d394e4aa1c..a111530f4802d 100644 --- a/lib/arm/io.c +++ b/lib/arm/io.c @@ -50,7 +50,8 @@ static void uart0_init(void) } } else { - assert(dt_pbus_translate_node(ret, 0, &base) = 0); + ret = dt_pbus_translate_node(ret, 0, &base); + assert(ret = 0); } uart0_base = ioremap(base.addr, base.size); -- 2.4.3
next prev parent reply other threads:[~2016-02-15 13:49 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-15 13:49 [kvm-unit-tests PATCH v4 00/17] ppc64: initial drop Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-15 13:49 ` Andrew Jones [this message] 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 01/17] arm/arm64: trivial: another assert fix Andrew Jones 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 02/17] Makefile: cscope: also look in arch shared asm Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 03/17] lib: asm-generic: add missing casts Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 04/17] devicetree: fix dt_get_memory_params Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-16 6:11 ` David Gibson 2016-02-16 6:11 ` David Gibson 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 05/17] arm/arm64: setup improvements Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-16 6:15 ` David Gibson 2016-02-16 6:15 ` David Gibson 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 06/17] lib: share arm-selftest utility functions Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-17 0:14 ` David Gibson 2016-02-17 0:14 ` David Gibson 2016-02-17 12:17 ` Andrew Jones 2016-02-17 12:17 ` Andrew Jones 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 07/17] config: no need to mix arch makefiles Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-17 1:18 ` David Gibson 2016-02-17 1:18 ` David Gibson 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 08/17] powerpc/ppc64: start skeleton framework Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 09/17] powerpc/ppc64: ppc-ify makefiles and linker script Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-17 1:45 ` David Gibson 2016-02-17 1:45 ` David Gibson 2016-02-17 12:21 ` Andrew Jones 2016-02-17 12:21 ` Andrew Jones 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 10/17] powerpc/ppc64: add a boot rom Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-17 1:50 ` David Gibson 2016-02-17 1:50 ` David Gibson 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 11/17] powerpc/ppc64: add hcall support and putchar Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-17 2:04 ` David Gibson 2016-02-17 2:04 ` David Gibson 2016-02-17 12:34 ` Andrew Jones 2016-02-17 12:34 ` Andrew Jones 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 12/17] powerpc/ppc64: adapt arm's setup Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-17 2:11 ` David Gibson 2016-02-17 2:11 ` David Gibson 2016-02-17 12:45 ` Andrew Jones 2016-02-17 12:45 ` Andrew Jones 2016-02-17 17:34 ` Andrew Jones 2016-02-17 17:34 ` Andrew Jones 2016-02-18 0:05 ` David Gibson 2016-02-18 0:05 ` David Gibson 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 13/17] powerpc/ppc64: relocate linker VMAs Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-17 2:14 ` David Gibson 2016-02-17 2:14 ` David Gibson 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 14/17] powerpc/ppc64: add run script and unittests.cfg Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 15/17] mkstandalone: add support for powerpc Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-17 12:51 ` Andrew Jones 2016-02-17 12:51 ` Andrew Jones 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 16/17] powerpc/ppc64: add RTAS support Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 17/17] powerpc/ppc64: make a fake debug-exit Andrew Jones 2016-02-15 13:49 ` Andrew Jones 2016-02-16 17:32 ` [kvm-unit-tests PATCH v4 00/17] ppc64: initial drop Paolo Bonzini 2016-02-16 17:32 ` Paolo Bonzini 2016-02-16 17:44 ` Andrew Jones 2016-02-16 17:44 ` Andrew Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1455544166-19766-2-git-send-email-drjones@redhat.com \ --to=drjones@redhat.com \ --cc=agraf@suse.de \ --cc=david@gibson.dropbear.id.au \ --cc=dgibson@redhat.com \ --cc=kvm-ppc@vger.kernel.org \ --cc=kvm@vger.kernel.org \ --cc=lvivier@redhat.com \ --cc=pbonzini@redhat.com \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.