All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan <gnomes@lxorguk.ukuu.org.uk>,
	hare@suse.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] aic7xxx: Fix queue depth handling
Date: Mon, 15 Feb 2016 11:01:18 -0800	[thread overview]
Message-ID: <1455562878.2371.15.camel@HansenPartnership.com> (raw)
In-Reply-To: <20160215185301.27731.20754.stgit@localhost.localdomain>

On Mon, 2016-02-15 at 18:53 +0000, Alan wrote:
> We were setting the queue depth correctly, then setting it back to 
> two. If you hit this as a bisection point then please send me an 
> email as it would imply we've been hiding other bugs with this one.
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>  drivers/scsi/aic7xxx/aic7xxx_osm.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> index b846a46..fc6a831 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> @@ -1336,6 +1336,7 @@ ahc_platform_set_tags(struct ahc_softc *ahc,
> struct scsi_device *sdev,
>  	case AHC_DEV_Q_TAGGED:
>  		scsi_change_queue_depth(sdev,
>  				dev->openings + dev->active);
> +		break;
>  	default:
>  		

Heh, that's a bit of an oopsie.  I'll add a cc to stable to see what
happens with older kernels.

James



  reply	other threads:[~2016-02-15 19:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15 18:53 [PATCH] aic7xxx: Fix queue depth handling Alan
2016-02-15 19:01 ` James Bottomley [this message]
2016-02-16  6:51 ` Hannes Reinecke
2016-02-18  0:16 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455562878.2371.15.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=hare@suse.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.