From: Hannes Reinecke <hare@suse.com>
To: Alan <gnomes@lxorguk.ukuu.org.uk>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] aic7xxx: Fix queue depth handling
Date: Tue, 16 Feb 2016 07:51:47 +0100 [thread overview]
Message-ID: <56C2C703.7080803@suse.com> (raw)
In-Reply-To: <20160215185301.27731.20754.stgit@localhost.localdomain>
On 02/15/2016 07:53 PM, Alan wrote:
> We were setting the queue depth correctly, then setting it back to two. If
> you hit this as a bisection point then please send me an email as it would
> imply we've been hiding other bugs with this one.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> drivers/scsi/aic7xxx/aic7xxx_osm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> index b846a46..fc6a831 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> @@ -1336,6 +1336,7 @@ ahc_platform_set_tags(struct ahc_softc *ahc, struct scsi_device *sdev,
> case AHC_DEV_Q_TAGGED:
> scsi_change_queue_depth(sdev,
> dev->openings + dev->active);
> + break;
> default:
> /*
> * We allow the OS to queue 2 untagged transactions to
>
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.com +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-16 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 18:53 [PATCH] aic7xxx: Fix queue depth handling Alan
2016-02-15 19:01 ` James Bottomley
2016-02-16 6:51 ` Hannes Reinecke [this message]
2016-02-18 0:16 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C2C703.7080803@suse.com \
--to=hare@suse.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.