From: Tomasz Nowicki <tn@semihalf.com> To: helgaas@kernel.org, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rafael@kernel.org, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jiang.liu@linux.intel.com, jchandra@broadcom.com, Stefano.Stabellini@eu.citrix.com Cc: robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jcm@redhat.com, Tomasz Nowicki <tn@semihalf.com> Subject: [PATCH V5 14/15] arm64, pci, acpi: Assign legacy IRQs once device is enable. Date: Tue, 16 Feb 2016 14:53:44 +0100 [thread overview] Message-ID: <1455630825-27253-15-git-send-email-tn@semihalf.com> (raw) In-Reply-To: <1455630825-27253-1-git-send-email-tn@semihalf.com> This is the last step before enabling generic ACPI PCI host controller for ARM64. We need to take care of legacy IRQ mapping for non-MSI(X) PCI devices. pcibios_alloc_irq() evaluation is not sensitive to ACPI device enumeration order, so it is the best place to assign device's IRQs for ACPI boot method. Also, it does not hurt DT to be initialized form the same place. NOTE: *This is going to be temporary solution*. There is ongoing work which aims for cleaning legacy IRQ allocation from arch specific code. We can consider this patch as the necessary evil which will be removed once cleanup series lands in mailnline in the near future. Signed-off-by: Tomasz Nowicki <tn@semihalf.com> Suggested-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> --- arch/arm64/kernel/pci.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c index 023b983..6e77e1b 100644 --- a/arch/arm64/kernel/pci.c +++ b/arch/arm64/kernel/pci.c @@ -52,11 +52,16 @@ int pcibios_enable_device(struct pci_dev *dev, int mask) } /* - * Try to assign the IRQ number from DT when adding a new device + * Try to assign the IRQ number when probing a new device */ -int pcibios_add_device(struct pci_dev *dev) +int pcibios_alloc_irq(struct pci_dev *dev) { - dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); + if (acpi_disabled) + dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); +#ifdef CONFIG_ACPI + else + return acpi_pci_irq_enable(dev); +#endif return 0; } -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: tn@semihalf.com (Tomasz Nowicki) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V5 14/15] arm64, pci, acpi: Assign legacy IRQs once device is enable. Date: Tue, 16 Feb 2016 14:53:44 +0100 [thread overview] Message-ID: <1455630825-27253-15-git-send-email-tn@semihalf.com> (raw) In-Reply-To: <1455630825-27253-1-git-send-email-tn@semihalf.com> This is the last step before enabling generic ACPI PCI host controller for ARM64. We need to take care of legacy IRQ mapping for non-MSI(X) PCI devices. pcibios_alloc_irq() evaluation is not sensitive to ACPI device enumeration order, so it is the best place to assign device's IRQs for ACPI boot method. Also, it does not hurt DT to be initialized form the same place. NOTE: *This is going to be temporary solution*. There is ongoing work which aims for cleaning legacy IRQ allocation from arch specific code. We can consider this patch as the necessary evil which will be removed once cleanup series lands in mailnline in the near future. Signed-off-by: Tomasz Nowicki <tn@semihalf.com> Suggested-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> --- arch/arm64/kernel/pci.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c index 023b983..6e77e1b 100644 --- a/arch/arm64/kernel/pci.c +++ b/arch/arm64/kernel/pci.c @@ -52,11 +52,16 @@ int pcibios_enable_device(struct pci_dev *dev, int mask) } /* - * Try to assign the IRQ number from DT when adding a new device + * Try to assign the IRQ number when probing a new device */ -int pcibios_add_device(struct pci_dev *dev) +int pcibios_alloc_irq(struct pci_dev *dev) { - dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); + if (acpi_disabled) + dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); +#ifdef CONFIG_ACPI + else + return acpi_pci_irq_enable(dev); +#endif return 0; } -- 1.9.1
next prev parent reply other threads:[~2016-02-16 13:54 UTC|newest] Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-16 13:53 [PATCH V5 00/15] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-17 11:00 ` Lorenzo Pieralisi 2016-02-17 11:00 ` Lorenzo Pieralisi 2016-02-18 12:25 ` [Linaro-acpi] " liudongdong (C) 2016-02-18 12:25 ` liudongdong (C) 2016-02-18 12:25 ` liudongdong (C) 2016-02-18 13:20 ` Lorenzo Pieralisi 2016-02-18 13:20 ` Lorenzo Pieralisi 2016-03-03 22:51 ` Bjorn Helgaas 2016-03-03 22:51 ` Bjorn Helgaas 2016-03-04 8:35 ` Jayachandran Chandrashekaran Nair 2016-03-04 8:35 ` Jayachandran Chandrashekaran Nair 2016-03-04 8:35 ` Jayachandran Chandrashekaran Nair 2016-03-05 4:14 ` Bjorn Helgaas 2016-03-05 4:14 ` Bjorn Helgaas 2016-03-05 4:14 ` Bjorn Helgaas 2016-03-09 9:13 ` Tomasz Nowicki 2016-03-09 9:13 ` Tomasz Nowicki 2016-03-09 9:13 ` Tomasz Nowicki 2016-03-09 9:14 ` Tomasz Nowicki 2016-03-09 9:14 ` Tomasz Nowicki 2016-03-09 9:14 ` Tomasz Nowicki 2016-03-09 10:10 ` Jayachandran Chandrashekaran Nair 2016-03-09 10:10 ` Jayachandran Chandrashekaran Nair 2016-03-09 10:10 ` Jayachandran Chandrashekaran Nair 2016-03-09 10:50 ` Tomasz Nowicki 2016-03-09 10:50 ` Tomasz Nowicki 2016-03-09 10:50 ` Tomasz Nowicki 2016-03-10 13:08 ` Jayachandran Chandrashekaran Nair 2016-03-10 13:08 ` Jayachandran Chandrashekaran Nair 2016-03-10 13:08 ` Jayachandran Chandrashekaran Nair 2016-03-17 20:18 ` [RFC PATCH 0/4] ACPI based PCI host driver with generic ECAM Jayachandran C 2016-03-17 20:18 ` Jayachandran C 2016-03-17 20:18 ` Jayachandran C 2016-03-18 17:47 ` Jayachandran C 2016-03-18 17:47 ` Jayachandran C 2016-03-23 10:22 ` Gabriele Paoloni 2016-03-23 10:22 ` Gabriele Paoloni 2016-03-23 10:22 ` Gabriele Paoloni 2016-03-23 10:22 ` Gabriele Paoloni 2016-03-28 13:42 ` Sinan Kaya 2016-03-28 13:42 ` Sinan Kaya 2016-03-28 13:42 ` Sinan Kaya 2016-03-28 13:42 ` Sinan Kaya 2016-03-28 18:01 ` Jayachandran C 2016-03-28 18:01 ` Jayachandran C 2016-03-28 18:01 ` Jayachandran C 2016-03-17 20:18 ` [RFC PATCH 1/4] PCI: Provide generic ECAM mapping functions Jayachandran C 2016-03-17 20:18 ` Jayachandran C 2016-03-17 20:18 ` Jayachandran C 2016-03-17 20:18 ` [RFC PATCH 2/4] PCI: generic,thunder: Use generic config functions Jayachandran C 2016-03-17 20:18 ` Jayachandran C 2016-03-17 20:18 ` Jayachandran C 2016-03-17 20:18 ` [RFC PATCH 3/4] ACPI: PCI: Add generic PCI host controller Jayachandran C 2016-03-17 20:18 ` Jayachandran C 2016-03-17 20:18 ` Jayachandran C 2016-03-17 20:18 ` [RFC PATCH 4/4] ACPI: PCI: Add raw_pci_read/write operations Jayachandran C 2016-03-17 20:18 ` Jayachandran C 2016-03-17 20:18 ` Jayachandran C 2016-04-05 14:11 ` [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi Tomasz Nowicki 2016-04-05 14:11 ` Tomasz Nowicki 2016-04-05 14:11 ` Tomasz Nowicki 2016-04-05 16:41 ` Bjorn Helgaas 2016-04-05 16:41 ` Bjorn Helgaas 2016-04-05 16:41 ` Bjorn Helgaas 2016-04-05 18:07 ` Tomasz Nowicki 2016-04-05 18:07 ` Tomasz Nowicki 2016-04-05 18:07 ` Tomasz Nowicki 2016-04-05 18:50 ` Jayachandran C 2016-04-05 18:50 ` Jayachandran C 2016-03-04 9:27 ` Tomasz Nowicki 2016-03-04 9:27 ` Tomasz Nowicki 2016-02-16 13:53 ` [PATCH V5 02/15] acpi, pci, mcfg: Provide default RAW ACPI PCI config space accessors Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-17 12:39 ` Lorenzo Pieralisi 2016-02-17 12:39 ` Lorenzo Pieralisi 2016-02-16 13:53 ` [PATCH V5 03/15] arm64, acpi: Use MCFG library and empty PCI config space accessors from pci_mcfg.c file Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` [PATCH V5 04/15] pci, acpi, ecam: Add flag to indicate whether ECAM region was hot added or not Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-18 12:32 ` Lorenzo Pieralisi 2016-02-18 12:32 ` Lorenzo Pieralisi 2016-02-16 13:53 ` [PATCH V5 05/15] x86, pci: Cleanup platform specific MCFG data by using ECAM hot_added flag Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` [PATCH V5 06/15] pci, acpi, x86, ia64: Move ACPI host bridge device companion assignment to core code Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` [PATCH V5 07/15] pci, acpi: Provide generic way to assign bus domain number Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-17 13:44 ` Jayachandran Chandrashekaran Nair 2016-02-17 13:44 ` Jayachandran Chandrashekaran Nair 2016-02-17 13:44 ` Jayachandran Chandrashekaran Nair 2016-02-17 14:07 ` Tomasz Nowicki 2016-02-17 14:07 ` Tomasz Nowicki 2016-02-17 14:07 ` Tomasz Nowicki 2016-02-17 14:21 ` Jayachandran Chandrashekaran Nair 2016-02-17 14:21 ` Jayachandran Chandrashekaran Nair 2016-02-17 14:21 ` Jayachandran Chandrashekaran Nair 2016-02-17 15:05 ` Tomasz Nowicki 2016-02-17 15:05 ` Tomasz Nowicki 2016-02-17 15:05 ` Tomasz Nowicki 2016-02-17 15:21 ` Jayachandran Chandrashekaran Nair 2016-02-17 15:21 ` Jayachandran Chandrashekaran Nair 2016-02-17 15:21 ` Jayachandran Chandrashekaran Nair 2016-02-17 15:35 ` Tomasz Nowicki 2016-02-17 15:35 ` Tomasz Nowicki 2016-02-17 15:35 ` Tomasz Nowicki 2016-02-17 17:45 ` Lorenzo Pieralisi 2016-02-17 17:45 ` Lorenzo Pieralisi 2016-02-17 17:45 ` Lorenzo Pieralisi 2016-02-16 13:53 ` [PATCH V5 08/15] x86, ia64: Include acpi_pci_{add|remove}_bus to the default pcibios_{add|remove}_bus implementation Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` [PATCH V5 09/15] acpi, mcfg: Add default PCI config accessors implementation and initial support for related quirks Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-17 18:39 ` Lorenzo Pieralisi 2016-02-17 18:39 ` Lorenzo Pieralisi 2016-02-16 13:53 ` [PATCH V5 10/15] pci, of: Move the PCI I/O space management to PCI core code Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` [PATCH V5 11/15] drivers: pci: add generic code to claim bus resources Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` [PATCH V5 12/15] pci, acpi: Support for ACPI based generic PCI host controller initialization Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-16 13:53 ` [PATCH V5 13/15] pci, acpi: Match PCI config space accessors against platfrom specific quirks Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-03-18 15:49 ` Mark Salter 2016-03-18 15:49 ` Mark Salter 2016-03-18 15:49 ` Mark Salter 2016-03-22 10:26 ` Tomasz Nowicki 2016-03-22 10:26 ` Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki [this message] 2016-02-16 13:53 ` [PATCH V5 14/15] arm64, pci, acpi: Assign legacy IRQs once device is enable Tomasz Nowicki 2016-02-17 18:18 ` Lorenzo Pieralisi 2016-02-17 18:18 ` Lorenzo Pieralisi 2016-02-16 13:53 ` [PATCH V5 15/15] arm64, pci, acpi: Start using ACPI based PCI host bridge driver for ARM64 Tomasz Nowicki 2016-02-16 13:53 ` Tomasz Nowicki 2016-02-18 12:59 ` [PATCH V5 00/15] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Lorenzo Pieralisi 2016-02-18 12:59 ` Lorenzo Pieralisi 2016-02-29 19:03 ` Sinan Kaya 2016-02-29 19:03 ` Sinan Kaya 2016-03-03 11:23 ` Lorenzo Pieralisi 2016-03-03 11:23 ` Lorenzo Pieralisi 2016-03-03 14:24 ` Sinan Kaya 2016-03-03 14:24 ` Sinan Kaya 2016-03-04 10:55 ` Lorenzo Pieralisi 2016-03-04 10:55 ` Lorenzo Pieralisi 2016-03-04 12:01 ` Tomasz Nowicki 2016-03-04 12:01 ` Tomasz Nowicki 2016-03-04 14:52 ` Sinan Kaya 2016-03-04 14:52 ` Sinan Kaya 2016-03-04 17:37 ` Lorenzo Pieralisi 2016-03-04 17:37 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1455630825-27253-15-git-send-email-tn@semihalf.com \ --to=tn@semihalf.com \ --cc=Liviu.Dudau@arm.com \ --cc=Lorenzo.Pieralisi@arm.com \ --cc=Stefano.Stabellini@eu.citrix.com \ --cc=Suravee.Suthikulpanit@amd.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=ddaney@caviumnetworks.com \ --cc=hanjun.guo@linaro.org \ --cc=helgaas@kernel.org \ --cc=jchandra@broadcom.com \ --cc=jcm@redhat.com \ --cc=jiang.liu@linux.intel.com \ --cc=linaro-acpi@lists.linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=msalter@redhat.com \ --cc=mw@semihalf.com \ --cc=okaya@codeaurora.org \ --cc=rafael@kernel.org \ --cc=robert.richter@caviumnetworks.com \ --cc=wangyijing@huawei.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.