* [PATCH v2] x86/head64: no need to define early_idt_ripmsg only if CONFIG_KALLSYMS=n
@ 2016-02-18 7:58 Alexander Kuleshov
2016-02-18 13:36 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Kuleshov @ 2016-02-18 7:58 UTC (permalink / raw)
To: Ingo Molnar
Cc: Thomas Gleixner, H . Peter Anvin, x86, Andy Lutomirski,
Borislav Petkov, Alexander Popov, Denys Vlasenko, linux-kernel,
Alexander Kuleshov
We have definition of the early_idt_ripmsg which represents string header
for the output of the kernel symbols during early exception. But the
header with kernel symbols will be printed in a case if the CONFIG_KALLSYMS=y.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
Changelog:
v2: commit message fixed and comment added.
arch/x86/kernel/head_64.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
index ffdc0e8..f93997f 100644
--- a/arch/x86/kernel/head_64.S
+++ b/arch/x86/kernel/head_64.S
@@ -433,8 +433,10 @@ early_recursion_flag:
#ifdef CONFIG_EARLY_PRINTK
early_idt_msg:
.asciz "PANIC: early exception %02lx rip %lx:%lx error %lx cr2 %lx\n"
+#ifdef CONFIG_KALLSYMS
early_idt_ripmsg:
.asciz "RIP %s\n"
+#endif /* CONFIG_KALLSYMS */
#endif /* CONFIG_EARLY_PRINTK */
#define NEXT_PAGE(name) \
--
2.7.0.364.g4943984
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] x86/head64: no need to define early_idt_ripmsg only if CONFIG_KALLSYMS=n
2016-02-18 7:58 [PATCH v2] x86/head64: no need to define early_idt_ripmsg only if CONFIG_KALLSYMS=n Alexander Kuleshov
@ 2016-02-18 13:36 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2016-02-18 13:36 UTC (permalink / raw)
To: Alexander Kuleshov
Cc: Ingo Molnar, Thomas Gleixner, H . Peter Anvin, x86,
Andy Lutomirski, Alexander Popov, Denys Vlasenko, linux-kernel
On Thu, Feb 18, 2016 at 01:58:15PM +0600, Alexander Kuleshov wrote:
> We have definition of the early_idt_ripmsg which represents string header
> for the output of the kernel symbols during early exception. But the
> header with kernel symbols will be printed in a case if the CONFIG_KALLSYMS=y.
And this is a problem because... ?
Also, try to search how many distros and configs enable KALLSYMS. That
might clear some uncertainties when deciding to add one more ifdef to an
already hard to read code.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-18 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-18 7:58 [PATCH v2] x86/head64: no need to define early_idt_ripmsg only if CONFIG_KALLSYMS=n Alexander Kuleshov
2016-02-18 13:36 ` Borislav Petkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.