* [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
@ 2016-02-18 13:07 ` Peter Rosin
0 siblings, 0 replies; 8+ messages in thread
From: Peter Rosin @ 2016-02-18 13:07 UTC (permalink / raw)
To: Dirk Eibach
Cc: Peter Rosin, Jean Delvare, Guenter Roeck, lm-sensors,
linux-kernel, stable, Peter Rosin
From: Peter Rosin <peda@axentia.se>
Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
dividends when the divisor is unsigned.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/hwmon/ads1015.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
index f155b8380481..2b3105c8aed3 100644
--- a/drivers/hwmon/ads1015.c
+++ b/drivers/hwmon/ads1015.c
@@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel,
struct ads1015_data *data = i2c_get_clientdata(client);
unsigned int pga = data->channel_data[channel].pga;
int fullscale = fullscale_table[pga];
- const unsigned mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
+ const int mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
return DIV_ROUND_CLOSEST(reg * fullscale, mask);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [lm-sensors] [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
@ 2016-02-18 13:07 ` Peter Rosin
0 siblings, 0 replies; 8+ messages in thread
From: Peter Rosin @ 2016-02-18 13:07 UTC (permalink / raw)
To: Dirk Eibach
Cc: Peter Rosin, Jean Delvare, Guenter Roeck, lm-sensors,
linux-kernel, stable, Peter Rosin
From: Peter Rosin <peda@axentia.se>
Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
dividends when the divisor is unsigned.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/hwmon/ads1015.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
index f155b8380481..2b3105c8aed3 100644
--- a/drivers/hwmon/ads1015.c
+++ b/drivers/hwmon/ads1015.c
@@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel,
struct ads1015_data *data = i2c_get_clientdata(client);
unsigned int pga = data->channel_data[channel].pga;
int fullscale = fullscale_table[pga];
- const unsigned mask = data->id = ads1115 ? 0x7fff : 0x7ff0;
+ const int mask = data->id = ads1115 ? 0x7fff : 0x7ff0;
return DIV_ROUND_CLOSEST(reg * fullscale, mask);
}
--
2.1.4
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
2016-02-18 13:07 ` [lm-sensors] " Peter Rosin
@ 2016-02-18 23:13 ` Peter Rosin
-1 siblings, 0 replies; 8+ messages in thread
From: Peter Rosin @ 2016-02-18 23:13 UTC (permalink / raw)
To: Dirk Eibach
Cc: Peter Rosin, Jean Delvare, Guenter Roeck, lm-sensors, linux-kernel
Hi!
Sorry for the noise, but...
On 2016-02-18 14:07, Peter Rosin wrote:
> From: Peter Rosin <peda@axentia.se>
>
> Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
> dividends when the divisor is unsigned.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
...I forgot to add this to the commit message
Cc: stable@vger.kernel.org
I also didn't explicitly mention any example platform where this
bug causes real problems; it was triggered on ARM (atmel sama5d).
Cheers,
Peter
> ---
> drivers/hwmon/ads1015.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
> index f155b8380481..2b3105c8aed3 100644
> --- a/drivers/hwmon/ads1015.c
> +++ b/drivers/hwmon/ads1015.c
> @@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel,
> struct ads1015_data *data = i2c_get_clientdata(client);
> unsigned int pga = data->channel_data[channel].pga;
> int fullscale = fullscale_table[pga];
> - const unsigned mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
> + const int mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
>
> return DIV_ROUND_CLOSEST(reg * fullscale, mask);
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
@ 2016-02-18 23:13 ` Peter Rosin
0 siblings, 0 replies; 8+ messages in thread
From: Peter Rosin @ 2016-02-18 23:13 UTC (permalink / raw)
To: Dirk Eibach
Cc: Peter Rosin, Jean Delvare, Guenter Roeck, lm-sensors, linux-kernel
Hi!
Sorry for the noise, but...
On 2016-02-18 14:07, Peter Rosin wrote:
> From: Peter Rosin <peda@axentia.se>
>
> Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
> dividends when the divisor is unsigned.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
...I forgot to add this to the commit message
Cc: stable@vger.kernel.org
I also didn't explicitly mention any example platform where this
bug causes real problems; it was triggered on ARM (atmel sama5d).
Cheers,
Peter
> ---
> drivers/hwmon/ads1015.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
> index f155b8380481..2b3105c8aed3 100644
> --- a/drivers/hwmon/ads1015.c
> +++ b/drivers/hwmon/ads1015.c
> @@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel,
> struct ads1015_data *data = i2c_get_clientdata(client);
> unsigned int pga = data->channel_data[channel].pga;
> int fullscale = fullscale_table[pga];
> - const unsigned mask = data->id = ads1115 ? 0x7fff : 0x7ff0;
> + const int mask = data->id = ads1115 ? 0x7fff : 0x7ff0;
>
> return DIV_ROUND_CLOSEST(reg * fullscale, mask);
> }
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
2016-02-18 23:13 ` [lm-sensors] " Peter Rosin
@ 2016-02-19 3:16 ` Guenter Roeck
-1 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2016-02-19 3:16 UTC (permalink / raw)
To: Peter Rosin
Cc: Dirk Eibach, Peter Rosin, Jean Delvare, lm-sensors, linux-kernel
On Fri, Feb 19, 2016 at 12:13:43AM +0100, Peter Rosin wrote:
> Hi!
>
> Sorry for the noise, but...
>
> On 2016-02-18 14:07, Peter Rosin wrote:
> > From: Peter Rosin <peda@axentia.se>
> >
> > Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
> > dividends when the divisor is unsigned.
> >
> > Signed-off-by: Peter Rosin <peda@axentia.se>
>
> ...I forgot to add this to the commit message
> Cc: stable@vger.kernel.org
>
No problem, I prefer to do that myself anyway.
Patch applied.
Thanks,
Guenter
> I also didn't explicitly mention any example platform where this
> bug causes real problems; it was triggered on ARM (atmel sama5d).
>
> Cheers,
> Peter
>
> > ---
> > drivers/hwmon/ads1015.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
> > index f155b8380481..2b3105c8aed3 100644
> > --- a/drivers/hwmon/ads1015.c
> > +++ b/drivers/hwmon/ads1015.c
> > @@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel,
> > struct ads1015_data *data = i2c_get_clientdata(client);
> > unsigned int pga = data->channel_data[channel].pga;
> > int fullscale = fullscale_table[pga];
> > - const unsigned mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
> > + const int mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
> >
> > return DIV_ROUND_CLOSEST(reg * fullscale, mask);
> > }
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
@ 2016-02-19 3:16 ` Guenter Roeck
0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2016-02-19 3:16 UTC (permalink / raw)
To: Peter Rosin
Cc: Dirk Eibach, Peter Rosin, Jean Delvare, lm-sensors, linux-kernel
On Fri, Feb 19, 2016 at 12:13:43AM +0100, Peter Rosin wrote:
> Hi!
>
> Sorry for the noise, but...
>
> On 2016-02-18 14:07, Peter Rosin wrote:
> > From: Peter Rosin <peda@axentia.se>
> >
> > Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
> > dividends when the divisor is unsigned.
> >
> > Signed-off-by: Peter Rosin <peda@axentia.se>
>
> ...I forgot to add this to the commit message
> Cc: stable@vger.kernel.org
>
No problem, I prefer to do that myself anyway.
Patch applied.
Thanks,
Guenter
> I also didn't explicitly mention any example platform where this
> bug causes real problems; it was triggered on ARM (atmel sama5d).
>
> Cheers,
> Peter
>
> > ---
> > drivers/hwmon/ads1015.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
> > index f155b8380481..2b3105c8aed3 100644
> > --- a/drivers/hwmon/ads1015.c
> > +++ b/drivers/hwmon/ads1015.c
> > @@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel,
> > struct ads1015_data *data = i2c_get_clientdata(client);
> > unsigned int pga = data->channel_data[channel].pga;
> > int fullscale = fullscale_table[pga];
> > - const unsigned mask = data->id = ads1115 ? 0x7fff : 0x7ff0;
> > + const int mask = data->id = ads1115 ? 0x7fff : 0x7ff0;
> >
> > return DIV_ROUND_CLOSEST(reg * fullscale, mask);
> > }
> >
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
2016-02-18 13:07 ` [lm-sensors] " Peter Rosin
@ 2016-02-19 22:26 ` Greg KH
-1 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2016-02-19 22:26 UTC (permalink / raw)
To: Peter Rosin
Cc: Dirk Eibach, Peter Rosin, Jean Delvare, Guenter Roeck,
lm-sensors, linux-kernel, stable
On Thu, Feb 18, 2016 at 02:07:52PM +0100, Peter Rosin wrote:
> From: Peter Rosin <peda@axentia.se>
>
> Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
> dividends when the divisor is unsigned.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/hwmon/ads1015.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
@ 2016-02-19 22:26 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2016-02-19 22:26 UTC (permalink / raw)
To: Peter Rosin
Cc: Dirk Eibach, Peter Rosin, Jean Delvare, Guenter Roeck,
lm-sensors, linux-kernel, stable
On Thu, Feb 18, 2016 at 02:07:52PM +0100, Peter Rosin wrote:
> From: Peter Rosin <peda@axentia.se>
>
> Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
> dividends when the divisor is unsigned.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/hwmon/ads1015.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-19 22:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-18 13:07 [PATCH] hwmon: (ads1015) Handle negative conversion values correctly Peter Rosin
2016-02-18 13:07 ` [lm-sensors] " Peter Rosin
2016-02-18 23:13 ` Peter Rosin
2016-02-18 23:13 ` [lm-sensors] " Peter Rosin
2016-02-19 3:16 ` Guenter Roeck
2016-02-19 3:16 ` [lm-sensors] " Guenter Roeck
2016-02-19 22:26 ` Greg KH
2016-02-19 22:26 ` [lm-sensors] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.