* [PATCH v2] dmaengine: pl330: fix to support the burst mode
@ 2016-02-25 1:00 Caesar Wang
2016-03-01 3:42 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Caesar Wang @ 2016-02-25 1:00 UTC (permalink / raw)
To: vinod.koul
Cc: dan.j.williams, dmaengine, linux-kernel, shawn.lin, al.kochet,
dinguyen, b.zolnierkie, heiko, dianders, sonnyrao,
linux-rockchip, Caesar Wang
This patch fixes the burst mode that will break DMA uart on SoCFPGA.
In some cases, some SoCS didn't support the multi-burst
even if the devices who use the pl330 claim support the maxburst.
Fixes: commit 848e977
"dmaengine: pl330: support burst mode for dev-to-mem and mem-to-dev transmit"
Reported-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Tested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tested-by: Dinh Nguyen <dinguyen@opensource.altera.com>
---
Changes in v2:
- s/brust/burst
- add Dinh and Bartlomiej test tags.
drivers/dma/pl330.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 1b0453b..372b435 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -1161,7 +1161,7 @@ static inline int _ldst_devtomem(struct pl330_dmac *pl330, unsigned dry_run,
if (pl330->quirks & PL330_QUIRK_BROKEN_NO_FLUSHP)
cond = BURST;
else
- cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST;
+ cond = SINGLE;
while (cyc--) {
off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri);
@@ -1186,8 +1186,7 @@ static inline int _ldst_memtodev(struct pl330_dmac *pl330,
if (pl330->quirks & PL330_QUIRK_BROKEN_NO_FLUSHP)
cond = BURST;
else
- cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST;
-
+ cond = SINGLE;
while (cyc--) {
off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri);
@@ -2598,7 +2597,7 @@ static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic(
desc->rqtype = direction;
desc->rqcfg.brst_size = pch->burst_sz;
- desc->rqcfg.brst_len = pch->burst_len;
+ desc->rqcfg.brst_len = 1;
desc->bytes_requested = period_len;
fill_px(&desc->px, dst, src, period_len);
@@ -2743,7 +2742,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
}
desc->rqcfg.brst_size = pch->burst_sz;
- desc->rqcfg.brst_len = pch->burst_len;
+ desc->rqcfg.brst_len = 1;
desc->rqtype = direction;
desc->bytes_requested = sg_dma_len(sg);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dmaengine: pl330: fix to support the burst mode
2016-02-25 1:00 [PATCH v2] dmaengine: pl330: fix to support the burst mode Caesar Wang
@ 2016-03-01 3:42 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2016-03-01 3:42 UTC (permalink / raw)
To: Caesar Wang
Cc: dan.j.williams, dmaengine, linux-kernel, shawn.lin, al.kochet,
dinguyen, b.zolnierkie, heiko, dianders, sonnyrao,
linux-rockchip
On Thu, Feb 25, 2016 at 09:00:53AM +0800, Caesar Wang wrote:
> This patch fixes the burst mode that will break DMA uart on SoCFPGA.
>
> In some cases, some SoCS didn't support the multi-burst
> even if the devices who use the pl330 claim support the maxburst.
Applied now and merged topic/pl330 back to -next
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-01 3:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-25 1:00 [PATCH v2] dmaengine: pl330: fix to support the burst mode Caesar Wang
2016-03-01 3:42 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.