All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] SATA: rcar: add device tree support for r8a7792
@ 2016-02-25  1:16 Simon Horman
  2016-02-25  9:40 ` Simon Horman
  2016-03-08  1:32 ` Simon Horman
  0 siblings, 2 replies; 3+ messages in thread
From: Simon Horman @ 2016-02-25  1:16 UTC (permalink / raw)
  To: Tejun Heo
  Cc: linux-ide, linux-renesas-soc, Magnus Damm, devicetree, Simon Horman

Simply document new compatibility string.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.

By documenting this compat sting it may be used in DTSs shipped, for
example as part of ROMs. It must be used in conjunction with the Gen2
fallback compat string. At this time there are no known differences between
the r8a7792 IP block and that implemented by the driver for the Gen2
fallback compat string. Thus there is no need to update the driver as the
use of the Gen2 fallback compat string will activate the correct code in
the current driver while leaving the option for r8a7792-specific driver
code to be activated in an updated driver should the need arise.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 Documentation/devicetree/bindings/ata/sata_rcar.txt | 1 +
 1 file changed, 1 insertion(+)

 Based on the for-next branch of the libata tree

diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt b/Documentation/devicetree/bindings/ata/sata_rcar.txt
index 0764f9ab63dc..539dbdfba8de 100644
--- a/Documentation/devicetree/bindings/ata/sata_rcar.txt
+++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt
@@ -7,6 +7,7 @@ Required properties:
 			  - "renesas,sata-r8a7790-es1" for R-Car H2 ES1
 			  - "renesas,sata-r8a7790" for R-Car H2 other than ES1
 			  - "renesas,sata-r8a7791" for R-Car M2-W
+			  - "renesas,sata-r8a7792" for R-Car V2H
 			  - "renesas,sata-r8a7793" for R-Car M2-N
 			  - "renesas,sata-r8a7795" for R-Car H3
 - reg			: address and length of the SATA registers;
-- 
2.7.0.rc3.207.g0ac5344


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] SATA: rcar: add device tree support for r8a7792
  2016-02-25  1:16 [PATCH] SATA: rcar: add device tree support for r8a7792 Simon Horman
@ 2016-02-25  9:40 ` Simon Horman
  2016-03-08  1:32 ` Simon Horman
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2016-02-25  9:40 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-ide, linux-renesas-soc, Magnus Damm, devicetree

On Thu, Feb 25, 2016 at 10:16:25AM +0900, Simon Horman wrote:
> Simply document new compatibility string.
> As a previous patch adds a generic R-Car Gen2 compatibility string
> there appears to be no need for a driver updates.
> 
> By documenting this compat sting it may be used in DTSs shipped, for
> example as part of ROMs. It must be used in conjunction with the Gen2
> fallback compat string. At this time there are no known differences between
> the r8a7792 IP block and that implemented by the driver for the Gen2
> fallback compat string. Thus there is no need to update the driver as the
> use of the Gen2 fallback compat string will activate the correct code in
> the current driver while leaving the option for r8a7792-specific driver
> code to be activated in an updated driver should the need arise.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  Documentation/devicetree/bindings/ata/sata_rcar.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
>  Based on the for-next branch of the libata tree

I seem to have omitted the patch to add the fallback binding.
I'll respin. In the mean time please ignore this patch.

> diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt b/Documentation/devicetree/bindings/ata/sata_rcar.txt
> index 0764f9ab63dc..539dbdfba8de 100644
> --- a/Documentation/devicetree/bindings/ata/sata_rcar.txt
> +++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt
> @@ -7,6 +7,7 @@ Required properties:
>  			  - "renesas,sata-r8a7790-es1" for R-Car H2 ES1
>  			  - "renesas,sata-r8a7790" for R-Car H2 other than ES1
>  			  - "renesas,sata-r8a7791" for R-Car M2-W
> +			  - "renesas,sata-r8a7792" for R-Car V2H
>  			  - "renesas,sata-r8a7793" for R-Car M2-N
>  			  - "renesas,sata-r8a7795" for R-Car H3
>  - reg			: address and length of the SATA registers;
> -- 
> 2.7.0.rc3.207.g0ac5344

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] SATA: rcar: add device tree support for r8a7792
  2016-02-25  1:16 [PATCH] SATA: rcar: add device tree support for r8a7792 Simon Horman
  2016-02-25  9:40 ` Simon Horman
@ 2016-03-08  1:32 ` Simon Horman
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2016-03-08  1:32 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-ide, linux-renesas-soc, Magnus Damm, devicetree

On Thu, Feb 25, 2016 at 10:16:25AM +0900, Simon Horman wrote:
> Simply document new compatibility string.
> As a previous patch adds a generic R-Car Gen2 compatibility string
> there appears to be no need for a driver updates.
> 
> By documenting this compat sting it may be used in DTSs shipped, for
> example as part of ROMs. It must be used in conjunction with the Gen2
> fallback compat string. At this time there are no known differences between
> the r8a7792 IP block and that implemented by the driver for the Gen2
> fallback compat string. Thus there is no need to update the driver as the
> use of the Gen2 fallback compat string will activate the correct code in
> the current driver while leaving the option for r8a7792-specific driver
> code to be activated in an updated driver should the need arise.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  Documentation/devicetree/bindings/ata/sata_rcar.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
>  Based on the for-next branch of the libata tree

I would like to withdraw this patch.

On closer inspection of the documentation the SATA IP block does
not appear to be present on the r8a7792. I am now searching for
an appropriately sized brown paper bag.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-03-08  1:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-25  1:16 [PATCH] SATA: rcar: add device tree support for r8a7792 Simon Horman
2016-02-25  9:40 ` Simon Horman
2016-03-08  1:32 ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.