[PATCH] staging: android: Remove unused variable ret for immediate return result.

[PATCH] staging: android: Remove unused variable ret for immediate return result.

[Rakhi Sharma]

This patch remove unused ret variable and merge two line for immediate
result.
This is done using Coccinelle.Semantic patch used is:

@@
expression ret;
identifier f;
@@

-ret =
+return
     f(...);
-return ret;

Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
---
 drivers/staging/android/ion/hisilicon/hi6220_ion.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
index e3c07b2..9922710 100644
--- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
+++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
@@ -216,8 +216,7 @@ static int __init hi6220_ion_init(void)
 {
 	int ret;
 
-	ret = platform_driver_register(&hi6220_ion_driver);
-	return ret;
+	return platform_driver_register(&hi6220_ion_driver);
 }
 
 subsys_initcall(hi6220_ion_init);
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] staging: android: Remove unused variable ret for immediate return result.

[Greg KH]

On Sat, Feb 27, 2016 at 06:05:05PM +0530, Rakhi Sharma wrote:
> This patch remove unused ret variable and merge two line for immediate
> result.
> This is done using Coccinelle.Semantic patch used is:
> 
> @@
> expression ret;
> identifier f;
> @@
> 
> -ret =
> +return
>      f(...);
> -return ret;
> 
> Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
> ---
>  drivers/staging/android/ion/hisilicon/hi6220_ion.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> index e3c07b2..9922710 100644
> --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> @@ -216,8 +216,7 @@ static int __init hi6220_ion_init(void)
>  {
>  	int ret;
>  
> -	ret = platform_driver_register(&hi6220_ion_driver);
> -	return ret;
> +	return platform_driver_register(&hi6220_ion_driver);

And now you have a build warning :(

Please always test-build your patches...