From: Arnd Bergmann <arnd@arndb.de>
To: Karsten Keil <isdn@linux-pingi.de>
Cc: linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] isdn: icn: remove a #warning
Date: Wed, 2 Mar 2016 20:06:45 +0100 [thread overview]
Message-ID: <1456945629-1793533-1-git-send-email-arnd@arndb.de> (raw)
The icn driver currently produces an unconditional #warning whenever
we build it, introduced by Karsten Keil back in 2003:
#warning TODO test headroom or use skb->nb to flag ACK
Karsten's original commit (from BitKeeper) contains this description:
- here are lot of bugs left, so ISDN is not stable yet but
I think it's really time to fix it, even if it need some cycles
to get it right (normally I'm only send patches if it works 100% for
me).
- I add some additional #warnings to address places which need fixing
(I hope that some of the other ISDN developer jump in)
Apparently this has not happened, and it is unlikely that it ever will,
given that the driver doesn't seem to work. No substantial bug fixes
other than janitorial cleanups have happened in the driver since then,
and I see no indication that anyone who patched it had the hardware.
We should probably either remove the driver, or remove all of i4l,
but for now, this shuts up the distracting #warning by turning it
into a comment.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: http://git.meleeweb.net/linux.git/commit/?id=b0deac0886b0056765afd149e9834373b38e096b
---
drivers/isdn/icn/icn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/icn/icn.c b/drivers/isdn/icn/icn.c
index 358a574d9e8b..46d957c34be1 100644
--- a/drivers/isdn/icn/icn.c
+++ b/drivers/isdn/icn/icn.c
@@ -718,7 +718,7 @@ icn_sendbuf(int channel, int ack, struct sk_buff *skb, icn_card *card)
return 0;
if (card->sndcount[channel] > ICN_MAX_SQUEUE)
return 0;
-#warning TODO test headroom or use skb->nb to flag ACK
+ /* TODO test headroom or use skb->nb to flag ACK */
nskb = skb_clone(skb, GFP_ATOMIC);
if (nskb) {
/* Push ACK flag as one
--
2.7.0
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] isdn: icn: remove a #warning
Date: Wed, 2 Mar 2016 20:06:45 +0100 [thread overview]
Message-ID: <1456945629-1793533-1-git-send-email-arnd@arndb.de> (raw)
The icn driver currently produces an unconditional #warning whenever
we build it, introduced by Karsten Keil back in 2003:
#warning TODO test headroom or use skb->nb to flag ACK
Karsten's original commit (from BitKeeper) contains this description:
- here are lot of bugs left, so ISDN is not stable yet but
I think it's really time to fix it, even if it need some cycles
to get it right (normally I'm only send patches if it works 100% for
me).
- I add some additional #warnings to address places which need fixing
(I hope that some of the other ISDN developer jump in)
Apparently this has not happened, and it is unlikely that it ever will,
given that the driver doesn't seem to work. No substantial bug fixes
other than janitorial cleanups have happened in the driver since then,
and I see no indication that anyone who patched it had the hardware.
We should probably either remove the driver, or remove all of i4l,
but for now, this shuts up the distracting #warning by turning it
into a comment.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: http://git.meleeweb.net/linux.git/commit/?id=b0deac0886b0056765afd149e9834373b38e096b
---
drivers/isdn/icn/icn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/icn/icn.c b/drivers/isdn/icn/icn.c
index 358a574d9e8b..46d957c34be1 100644
--- a/drivers/isdn/icn/icn.c
+++ b/drivers/isdn/icn/icn.c
@@ -718,7 +718,7 @@ icn_sendbuf(int channel, int ack, struct sk_buff *skb, icn_card *card)
return 0;
if (card->sndcount[channel] > ICN_MAX_SQUEUE)
return 0;
-#warning TODO test headroom or use skb->nb to flag ACK
+ /* TODO test headroom or use skb->nb to flag ACK */
nskb = skb_clone(skb, GFP_ATOMIC);
if (nskb) {
/* Push ACK flag as one
--
2.7.0
next reply other threads:[~2016-03-02 19:07 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 19:06 Arnd Bergmann [this message]
2016-03-02 19:06 ` [PATCH 1/2] isdn: icn: remove a #warning Arnd Bergmann
2016-03-02 19:06 ` [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging Arnd Bergmann
2016-03-02 19:06 ` Arnd Bergmann
2016-03-03 8:30 ` isdn
2016-03-03 8:30 ` isdn at linux-pingi.de
2016-03-04 15:24 ` Arnd Bergmann
2016-03-04 15:24 ` Arnd Bergmann
2016-03-04 16:18 ` Paul Bolle
2016-03-04 16:18 ` Paul Bolle
2016-03-04 16:32 ` Arnd Bergmann
2016-03-04 16:32 ` Arnd Bergmann
2016-03-07 8:33 ` Paul Bolle
2016-03-07 8:33 ` Paul Bolle
2016-03-05 13:08 ` Tilman Schmidt
2016-03-05 13:08 ` Tilman Schmidt
2016-03-07 8:48 ` Paul Bolle
2016-03-07 8:48 ` Paul Bolle
2016-03-09 22:10 ` Tilman Schmidt
2016-03-09 22:10 ` Tilman Schmidt
2016-03-10 10:53 ` isdn
2016-03-10 10:53 ` isdn at linux-pingi.de
2016-03-10 10:53 ` isdn
2016-03-10 12:58 ` Paul Bolle
2016-03-10 12:58 ` Paul Bolle
2016-03-10 16:41 ` isdn
2016-03-10 16:41 ` isdn at linux-pingi.de
2016-03-10 16:41 ` isdn
2016-03-11 20:04 ` Tilman Schmidt
2016-03-11 20:04 ` Tilman Schmidt
2016-03-11 20:04 ` Tilman Schmidt
2016-03-04 18:18 ` isdn
2016-03-04 18:18 ` isdn at linux-pingi.de
2016-03-04 21:00 ` Arnd Bergmann
2016-03-04 21:00 ` Arnd Bergmann
2016-03-07 6:57 ` Holger Schurig
2016-03-07 6:57 ` Holger Schurig
2016-03-19 10:27 ` Tilman Schmidt
2016-03-19 10:27 ` Tilman Schmidt
2016-03-19 10:27 ` Tilman Schmidt
2016-03-03 22:22 ` David Miller
2016-03-03 22:22 ` David Miller
2016-03-03 22:33 ` Greg KH
2016-03-03 22:33 ` Greg KH
2016-03-03 22:33 ` Greg KH
2016-03-05 3:19 ` kbuild test robot
2016-03-05 3:19 ` kbuild test robot
2017-01-03 15:24 ` Greg Kroah-Hartman
2017-01-03 15:24 ` Greg Kroah-Hartman
2017-01-03 15:24 ` Greg Kroah-Hartman
2017-01-03 21:19 ` Arnd Bergmann
2017-01-03 21:19 ` Arnd Bergmann
2017-01-03 21:54 ` Paul Bolle
2017-01-03 21:54 ` Paul Bolle
2017-01-03 22:25 ` Arnd Bergmann
2017-01-03 22:25 ` Arnd Bergmann
2017-01-03 22:57 ` Paul Bolle
2017-01-03 22:57 ` Paul Bolle
2017-01-03 23:03 ` Arnd Bergmann
2017-01-03 23:03 ` Arnd Bergmann
2017-01-03 23:03 ` Arnd Bergmann
2017-01-05 21:19 ` Greg Kroah-Hartman
2017-01-05 21:19 ` Greg Kroah-Hartman
2017-01-05 21:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456945629-1793533-1-git-send-email-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.