* [PATCH v2 0/2] phy: rcar-gen2, rcar-gen3-usb2: add fallback binding @ 2016-03-03 0:38 Simon Horman 2016-03-03 0:38 ` Simon Horman 2016-03-03 0:38 ` [PATCH v2 2/2] phy: rcar-gen3-usb2: " Simon Horman 0 siblings, 2 replies; 13+ messages in thread From: Simon Horman @ 2016-03-03 0:38 UTC (permalink / raw) To: Kishon Vijay Abraham I Cc: Yoshihiro Shimoda, Magnus Damm, linux-kernel, linux-renesas-soc, Geert Uytterhoeven, devicetree, Simon Horman Add fallback compatibility strings for rcar phy drivers. In the case of Renesas R-Car hardware we know that there are generations of SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the relationship between IP blocks might be. For example, I believe that r8a7790 is older than r8a7791 but that doesn't imply that the latter is a descendant of the former or vice versa. We can, however, by examining the documentation and behaviour of the hardware at run-time observe that the current driver implementation appears to be compatible with the IP blocks on SoCs within a given generation. For the above reasons and convenience when enabling new SoCs a per-generation fallback compatibility string scheme being adopted for drivers for Renesas SoCs. Changes since v1: * Update new compatibility strings to match the preferred scheme for ordering elements * Rebase Based on linux-phy/next Simon Horman (2): phy: rcar-gen2: add fallback binding phy: rcar-gen3-usb2: add fallback binding Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 8 +++++++- Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 10 ++++++++-- drivers/phy/phy-rcar-gen2.c | 1 + drivers/phy/phy-rcar-gen3-usb2.c | 1 + 4 files changed, 17 insertions(+), 3 deletions(-) -- 2.1.4 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 1/2] phy: rcar-gen2: add fallback binding @ 2016-03-03 0:38 ` Simon Horman 0 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2016-03-03 0:38 UTC (permalink / raw) To: Kishon Vijay Abraham I Cc: Yoshihiro Shimoda, Magnus Damm, linux-kernel, linux-renesas-soc, Geert Uytterhoeven, devicetree, Simon Horman In the case of Renesas R-Car hardware we know that there are generations of SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the relationship between IP blocks might be. For example, I believe that r8a7790 is older than r8a7791 but that doesn't imply that the latter is a descendant of the former or vice versa. We can, however, by examining the documentation and behaviour of the hardware at run-time observe that the current driver implementation appears to be compatible with the IP blocks on SoCs within a given generation. For the above reasons and convenience when enabling new SoCs a per-generation fallback compatibility string scheme being adopted for drivers for Renesas SoCs. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2 * Use renesas,rcar-gen2-usb-phy rather than renesas,usb-phy-gen2 as the new compatibility string to fit in with the preferred scheme for new compatibility string names. --- Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 8 +++++++- drivers/phy/phy-rcar-gen2.c | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt index d564ba4f1cf6..feb1c3c102c2 100644 --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt @@ -7,6 +7,12 @@ Required properties: - compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. + "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 compatible device. + + When compatible with the generic version, nodes must list the + SoC-specific version corresponding to the platform first + followed by the generic version. + - reg: offset and length of the register block. - #address-cells: number of address cells for the USB channel subnodes, must be <1>. @@ -34,7 +40,7 @@ the USB channel; see the selector meanings below: Example (Lager board): usb-phy@e6590100 { - compatible = "renesas,usb-phy-r8a7790"; + compatible = "renesas,usb-phy-r8a7790","renesas,rcar-gen2-usb-phy"; reg = <0 0xe6590100 0 0x100>; #address-cells = <1>; #size-cells = <0>; diff --git a/drivers/phy/phy-rcar-gen2.c b/drivers/phy/phy-rcar-gen2.c index c7a05996d5c1..97d4dd6ea924 100644 --- a/drivers/phy/phy-rcar-gen2.c +++ b/drivers/phy/phy-rcar-gen2.c @@ -195,6 +195,7 @@ static const struct of_device_id rcar_gen2_phy_match_table[] = { { .compatible = "renesas,usb-phy-r8a7790" }, { .compatible = "renesas,usb-phy-r8a7791" }, { .compatible = "renesas,usb-phy-r8a7794" }, + { .compatible = "renesas,rcar-gen2-usb-phy" }, { } }; MODULE_DEVICE_TABLE(of, rcar_gen2_phy_match_table); -- 2.1.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 1/2] phy: rcar-gen2: add fallback binding @ 2016-03-03 0:38 ` Simon Horman 0 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2016-03-03 0:38 UTC (permalink / raw) To: Kishon Vijay Abraham I Cc: Yoshihiro Shimoda, Magnus Damm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven, devicetree-u79uwXL29TY76Z2rM5mHXA, Simon Horman In the case of Renesas R-Car hardware we know that there are generations of SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the relationship between IP blocks might be. For example, I believe that r8a7790 is older than r8a7791 but that doesn't imply that the latter is a descendant of the former or vice versa. We can, however, by examining the documentation and behaviour of the hardware at run-time observe that the current driver implementation appears to be compatible with the IP blocks on SoCs within a given generation. For the above reasons and convenience when enabling new SoCs a per-generation fallback compatibility string scheme being adopted for drivers for Renesas SoCs. Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> --- v2 * Use renesas,rcar-gen2-usb-phy rather than renesas,usb-phy-gen2 as the new compatibility string to fit in with the preferred scheme for new compatibility string names. --- Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 8 +++++++- drivers/phy/phy-rcar-gen2.c | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt index d564ba4f1cf6..feb1c3c102c2 100644 --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt @@ -7,6 +7,12 @@ Required properties: - compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. + "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 compatible device. + + When compatible with the generic version, nodes must list the + SoC-specific version corresponding to the platform first + followed by the generic version. + - reg: offset and length of the register block. - #address-cells: number of address cells for the USB channel subnodes, must be <1>. @@ -34,7 +40,7 @@ the USB channel; see the selector meanings below: Example (Lager board): usb-phy@e6590100 { - compatible = "renesas,usb-phy-r8a7790"; + compatible = "renesas,usb-phy-r8a7790","renesas,rcar-gen2-usb-phy"; reg = <0 0xe6590100 0 0x100>; #address-cells = <1>; #size-cells = <0>; diff --git a/drivers/phy/phy-rcar-gen2.c b/drivers/phy/phy-rcar-gen2.c index c7a05996d5c1..97d4dd6ea924 100644 --- a/drivers/phy/phy-rcar-gen2.c +++ b/drivers/phy/phy-rcar-gen2.c @@ -195,6 +195,7 @@ static const struct of_device_id rcar_gen2_phy_match_table[] = { { .compatible = "renesas,usb-phy-r8a7790" }, { .compatible = "renesas,usb-phy-r8a7791" }, { .compatible = "renesas,usb-phy-r8a7794" }, + { .compatible = "renesas,rcar-gen2-usb-phy" }, { } }; MODULE_DEVICE_TABLE(of, rcar_gen2_phy_match_table); -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] phy: rcar-gen2: add fallback binding 2016-03-03 0:38 ` Simon Horman (?) @ 2016-03-03 8:12 ` Geert Uytterhoeven -1 siblings, 0 replies; 13+ messages in thread From: Geert Uytterhoeven @ 2016-03-03 8:12 UTC (permalink / raw) To: Simon Horman Cc: Kishon Vijay Abraham I, Yoshihiro Shimoda, Magnus Damm, linux-kernel, linux-renesas-soc, devicetree On Thu, Mar 3, 2016 at 1:38 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > relationship between IP blocks might be. For example, I believe that > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a > descendant of the former or vice versa. > > We can, however, by examining the documentation and behaviour of the > hardware at run-time observe that the current driver implementation appears > to be compatible with the IP blocks on SoCs within a given generation. > > For the above reasons and convenience when enabling new SoCs a > per-generation fallback compatibility string scheme being adopted for > drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] phy: rcar-gen2: add fallback binding @ 2016-03-05 4:27 ` Rob Herring 0 siblings, 0 replies; 13+ messages in thread From: Rob Herring @ 2016-03-05 4:27 UTC (permalink / raw) To: Simon Horman Cc: Kishon Vijay Abraham I, Yoshihiro Shimoda, Magnus Damm, linux-kernel, linux-renesas-soc, Geert Uytterhoeven, devicetree On Thu, Mar 03, 2016 at 09:38:37AM +0900, Simon Horman wrote: > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > relationship between IP blocks might be. For example, I believe that > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a > descendant of the former or vice versa. > > We can, however, by examining the documentation and behaviour of the > hardware at run-time observe that the current driver implementation appears > to be compatible with the IP blocks on SoCs within a given generation. > > For the above reasons and convenience when enabling new SoCs a > per-generation fallback compatibility string scheme being adopted for > drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > v2 > * Use renesas,rcar-gen2-usb-phy rather than renesas,usb-phy-gen2 as > the new compatibility string to fit in with the preferred scheme > for new compatibility string names. > --- > Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 8 +++++++- > drivers/phy/phy-rcar-gen2.c | 1 + > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > index d564ba4f1cf6..feb1c3c102c2 100644 > --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > @@ -7,6 +7,12 @@ Required properties: > - compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. > "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. > "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. > + "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 compatible device. > + > + When compatible with the generic version, nodes must list the > + SoC-specific version corresponding to the platform first > + followed by the generic version. > + > - reg: offset and length of the register block. > - #address-cells: number of address cells for the USB channel subnodes, must > be <1>. > @@ -34,7 +40,7 @@ the USB channel; see the selector meanings below: > Example (Lager board): > > usb-phy@e6590100 { > - compatible = "renesas,usb-phy-r8a7790"; > + compatible = "renesas,usb-phy-r8a7790","renesas,rcar-gen2-usb-phy"; Space here ^ Otherwise, Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] phy: rcar-gen2: add fallback binding @ 2016-03-05 4:27 ` Rob Herring 0 siblings, 0 replies; 13+ messages in thread From: Rob Herring @ 2016-03-05 4:27 UTC (permalink / raw) To: Simon Horman Cc: Kishon Vijay Abraham I, Yoshihiro Shimoda, Magnus Damm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven, devicetree-u79uwXL29TY76Z2rM5mHXA On Thu, Mar 03, 2016 at 09:38:37AM +0900, Simon Horman wrote: > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > relationship between IP blocks might be. For example, I believe that > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a > descendant of the former or vice versa. > > We can, however, by examining the documentation and behaviour of the > hardware at run-time observe that the current driver implementation appears > to be compatible with the IP blocks on SoCs within a given generation. > > For the above reasons and convenience when enabling new SoCs a > per-generation fallback compatibility string scheme being adopted for > drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> > --- > v2 > * Use renesas,rcar-gen2-usb-phy rather than renesas,usb-phy-gen2 as > the new compatibility string to fit in with the preferred scheme > for new compatibility string names. > --- > Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 8 +++++++- > drivers/phy/phy-rcar-gen2.c | 1 + > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > index d564ba4f1cf6..feb1c3c102c2 100644 > --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > @@ -7,6 +7,12 @@ Required properties: > - compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. > "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. > "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. > + "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 compatible device. > + > + When compatible with the generic version, nodes must list the > + SoC-specific version corresponding to the platform first > + followed by the generic version. > + > - reg: offset and length of the register block. > - #address-cells: number of address cells for the USB channel subnodes, must > be <1>. > @@ -34,7 +40,7 @@ the USB channel; see the selector meanings below: > Example (Lager board): > > usb-phy@e6590100 { > - compatible = "renesas,usb-phy-r8a7790"; > + compatible = "renesas,usb-phy-r8a7790","renesas,rcar-gen2-usb-phy"; Space here ^ Otherwise, Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 2/2] phy: rcar-gen3-usb2: add fallback binding 2016-03-03 0:38 [PATCH v2 0/2] phy: rcar-gen2, rcar-gen3-usb2: add fallback binding Simon Horman 2016-03-03 0:38 ` Simon Horman @ 2016-03-03 0:38 ` Simon Horman 2016-03-03 8:13 ` Geert Uytterhoeven 2016-03-05 4:28 ` Rob Herring 1 sibling, 2 replies; 13+ messages in thread From: Simon Horman @ 2016-03-03 0:38 UTC (permalink / raw) To: Kishon Vijay Abraham I Cc: Yoshihiro Shimoda, Magnus Damm, linux-kernel, linux-renesas-soc, Geert Uytterhoeven, devicetree, Simon Horman In the case of Renesas R-Car hardware we know that there are generations of SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the relationship between IP blocks might be. For example, I believe that r8a7790 is older than r8a7791 but that doesn't imply that the latter is a descendant of the former or vice versa. We can, however, by examining the documentation and behaviour of the hardware at run-time observe that the current driver implementation appears to be compatible with the IP blocks on SoCs within a given generation. For the above reasons and convenience when enabling new SoCs a per-generation fallback compatibility string scheme being adopted for drivers for Renesas SoCs. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2 * Use renesas,rcar-gen3-usb-phy rather than renesas,usb-phy-gen3 as the new compatibility string to fit in with the preferred scheme for new compatibility string names. --- Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 10 ++++++++-- drivers/phy/phy-rcar-gen3-usb2.c | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt index eaf7e9b7ce6b..86826ca2fdef 100644 --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt @@ -6,6 +6,12 @@ This file provides information on what the device node for the R-Car generation Required properties: - compatible: "renesas,usb2-phy-r8a7795" if the device is a part of an R8A7795 SoC. + "renesas,rcar-gen3-usb2-phy" for a generic R-Car Gen3 compatible device. + + When compatible with the generic version, nodes must list the + SoC-specific version corresponding to the platform first + followed by the generic version. + - reg: offset and length of the partial USB 2.0 Host register block. - clocks: clock phandle and specifier pair(s). - #phy-cells: see phy-bindings.txt in the same directory, must be <0>. @@ -19,14 +25,14 @@ channel as USB OTG: Example (R-Car H3): usb-phy@ee080200 { - compatible = "renesas,usb2-phy-r8a7795"; + compatible = "renesas,usb2-phy-r8a7795","renesas,rcar-gen3-usb2-phy"; reg = <0 0xee080200 0 0x700>; interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp7_clks R8A7795_CLK_EHCI0>; }; usb-phy@ee0a0200 { - compatible = "renesas,usb2-phy-r8a7795"; + compatible = "renesas,usb2-phy-r8a7795","renesas,rcar-gen3-usb2-phy"; reg = <0 0xee0a0200 0 0x700>; clocks = <&mstp7_clks R8A7795_CLK_EHCI0>; }; diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c index bc4f7dd821aa..257be74f93f5 100644 --- a/drivers/phy/phy-rcar-gen3-usb2.c +++ b/drivers/phy/phy-rcar-gen3-usb2.c @@ -251,6 +251,7 @@ static irqreturn_t rcar_gen3_phy_usb2_irq(int irq, void *_ch) static const struct of_device_id rcar_gen3_phy_usb2_match_table[] = { { .compatible = "renesas,usb2-phy-r8a7795" }, + { .compatible = "renesas,rcar-gen3-usb2-phy" }, { } }; MODULE_DEVICE_TABLE(of, rcar_gen3_phy_usb2_match_table); -- 2.1.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] phy: rcar-gen3-usb2: add fallback binding 2016-03-03 0:38 ` [PATCH v2 2/2] phy: rcar-gen3-usb2: " Simon Horman @ 2016-03-03 8:13 ` Geert Uytterhoeven 2016-03-05 4:28 ` Rob Herring 1 sibling, 0 replies; 13+ messages in thread From: Geert Uytterhoeven @ 2016-03-03 8:13 UTC (permalink / raw) To: Simon Horman Cc: Kishon Vijay Abraham I, Yoshihiro Shimoda, Magnus Damm, linux-kernel, linux-renesas-soc, devicetree On Thu, Mar 3, 2016 at 1:38 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > relationship between IP blocks might be. For example, I believe that > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a > descendant of the former or vice versa. > > We can, however, by examining the documentation and behaviour of the > hardware at run-time observe that the current driver implementation appears > to be compatible with the IP blocks on SoCs within a given generation. > > For the above reasons and convenience when enabling new SoCs a > per-generation fallback compatibility string scheme being adopted for > drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v2 > * Use renesas,rcar-gen3-usb-phy rather than renesas,usb-phy-gen3 as FWIW, "renesas,rcar-gen3-usb2-phy" ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] phy: rcar-gen3-usb2: add fallback binding @ 2016-03-03 8:13 ` Geert Uytterhoeven 0 siblings, 0 replies; 13+ messages in thread From: Geert Uytterhoeven @ 2016-03-03 8:13 UTC (permalink / raw) To: Simon Horman Cc: Kishon Vijay Abraham I, Yoshihiro Shimoda, Magnus Damm, linux-kernel, linux-renesas-soc, devicetree On Thu, Mar 3, 2016 at 1:38 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > relationship between IP blocks might be. For example, I believe that > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a > descendant of the former or vice versa. > > We can, however, by examining the documentation and behaviour of the > hardware at run-time observe that the current driver implementation appears > to be compatible with the IP blocks on SoCs within a given generation. > > For the above reasons and convenience when enabling new SoCs a > per-generation fallback compatibility string scheme being adopted for > drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v2 > * Use renesas,rcar-gen3-usb-phy rather than renesas,usb-phy-gen3 as FWIW, "renesas,rcar-gen3-usb2-phy" ;-) Gr{oetje,eeting}s, Geert ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH v2 2/2] phy: rcar-gen3-usb2: add fallback binding @ 2016-03-03 9:23 ` Yoshihiro Shimoda 0 siblings, 0 replies; 13+ messages in thread From: Yoshihiro Shimoda @ 2016-03-03 9:23 UTC (permalink / raw) To: Simon Horman Cc: Kishon Vijay Abraham I, Magnus Damm, linux-kernel, linux-renesas-soc, devicetree, Geert Uytterhoeven Hi Simon-san, > Sent: Thursday, March 03, 2016 5:13 PM > > On Thu, Mar 3, 2016 at 1:38 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > > In the case of Renesas R-Car hardware we know that there are generations of > > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > > relationship between IP blocks might be. For example, I believe that > > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a > > descendant of the former or vice versa. > > > > We can, however, by examining the documentation and behaviour of the > > hardware at run-time observe that the current driver implementation appears > > to be compatible with the IP blocks on SoCs within a given generation. > > > > For the above reasons and convenience when enabling new SoCs a > > per-generation fallback compatibility string scheme being adopted for > > drivers for Renesas SoCs. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH v2 2/2] phy: rcar-gen3-usb2: add fallback binding @ 2016-03-03 9:23 ` Yoshihiro Shimoda 0 siblings, 0 replies; 13+ messages in thread From: Yoshihiro Shimoda @ 2016-03-03 9:23 UTC (permalink / raw) To: Simon Horman Cc: Kishon Vijay Abraham I, Magnus Damm, linux-kernel, linux-renesas-soc, devicetree, Geert Uytterhoeven Hi Simon-san, > Sent: Thursday, March 03, 2016 5:13 PM > > On Thu, Mar 3, 2016 at 1:38 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > > In the case of Renesas R-Car hardware we know that there are generations of > > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > > relationship between IP blocks might be. For example, I believe that > > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a > > descendant of the former or vice versa. > > > > We can, however, by examining the documentation and behaviour of the > > hardware at run-time observe that the current driver implementation appears > > to be compatible with the IP blocks on SoCs within a given generation. > > > > For the above reasons and convenience when enabling new SoCs a > > per-generation fallback compatibility string scheme being adopted for > > drivers for Renesas SoCs. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH v2 2/2] phy: rcar-gen3-usb2: add fallback binding @ 2016-03-03 9:23 ` Yoshihiro Shimoda 0 siblings, 0 replies; 13+ messages in thread From: Yoshihiro Shimoda @ 2016-03-03 9:23 UTC (permalink / raw) To: Simon Horman Cc: Kishon Vijay Abraham I, Magnus Damm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1280 bytes --] Hi Simon-san, > Sent: Thursday, March 03, 2016 5:13 PM > > On Thu, Mar 3, 2016 at 1:38 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > > In the case of Renesas R-Car hardware we know that there are generations of > > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > > relationship between IP blocks might be. For example, I believe that > > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a > > descendant of the former or vice versa. > > > > We can, however, by examining the documentation and behaviour of the > > hardware at run-time observe that the current driver implementation appears > > to be compatible with the IP blocks on SoCs within a given generation. > > > > For the above reasons and convenience when enabling new SoCs a > > per-generation fallback compatibility string scheme being adopted for > > drivers for Renesas SoCs. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda N§²æìr¸yúèØb²X¬¶Ç§vØ^)Þº{.nÇ+·zøzÚÞz)í æèw*\x1fjg¬±¨\x1e¶Ý¢j.ïÛ°\½½MúgjÌæa×\x02' ©Þ¢¸\f¢·¦j:+v¨wèjØm¶ÿ¾\a«êçzZ+ùÝ¢j"ú!¶i ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] phy: rcar-gen3-usb2: add fallback binding 2016-03-03 0:38 ` [PATCH v2 2/2] phy: rcar-gen3-usb2: " Simon Horman 2016-03-03 8:13 ` Geert Uytterhoeven @ 2016-03-05 4:28 ` Rob Herring 1 sibling, 0 replies; 13+ messages in thread From: Rob Herring @ 2016-03-05 4:28 UTC (permalink / raw) To: Simon Horman Cc: Kishon Vijay Abraham I, Yoshihiro Shimoda, Magnus Damm, linux-kernel, linux-renesas-soc, Geert Uytterhoeven, devicetree On Thu, Mar 03, 2016 at 09:38:38AM +0900, Simon Horman wrote: > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > relationship between IP blocks might be. For example, I believe that > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a > descendant of the former or vice versa. > > We can, however, by examining the documentation and behaviour of the > hardware at run-time observe that the current driver implementation appears > to be compatible with the IP blocks on SoCs within a given generation. > > For the above reasons and convenience when enabling new SoCs a > per-generation fallback compatibility string scheme being adopted for > drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > v2 > * Use renesas,rcar-gen3-usb-phy rather than renesas,usb-phy-gen3 as > the new compatibility string to fit in with the preferred scheme > for new compatibility string names. > --- > Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 10 ++++++++-- > drivers/phy/phy-rcar-gen3-usb2.c | 1 + > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > index eaf7e9b7ce6b..86826ca2fdef 100644 > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > @@ -6,6 +6,12 @@ This file provides information on what the device node for the R-Car generation > Required properties: > - compatible: "renesas,usb2-phy-r8a7795" if the device is a part of an R8A7795 > SoC. > + "renesas,rcar-gen3-usb2-phy" for a generic R-Car Gen3 compatible device. > + > + When compatible with the generic version, nodes must list the > + SoC-specific version corresponding to the platform first > + followed by the generic version. > + > - reg: offset and length of the partial USB 2.0 Host register block. > - clocks: clock phandle and specifier pair(s). > - #phy-cells: see phy-bindings.txt in the same directory, must be <0>. > @@ -19,14 +25,14 @@ channel as USB OTG: > Example (R-Car H3): > > usb-phy@ee080200 { > - compatible = "renesas,usb2-phy-r8a7795"; > + compatible = "renesas,usb2-phy-r8a7795","renesas,rcar-gen3-usb2-phy"; space... > reg = <0 0xee080200 0 0x700>; > interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&mstp7_clks R8A7795_CLK_EHCI0>; > }; > > usb-phy@ee0a0200 { > - compatible = "renesas,usb2-phy-r8a7795"; > + compatible = "renesas,usb2-phy-r8a7795","renesas,rcar-gen3-usb2-phy"; space... Otherwise, Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-03-05 4:28 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-03-03 0:38 [PATCH v2 0/2] phy: rcar-gen2, rcar-gen3-usb2: add fallback binding Simon Horman 2016-03-03 0:38 ` [PATCH v2 1/2] phy: rcar-gen2: " Simon Horman 2016-03-03 0:38 ` Simon Horman 2016-03-03 8:12 ` Geert Uytterhoeven 2016-03-05 4:27 ` Rob Herring 2016-03-05 4:27 ` Rob Herring 2016-03-03 0:38 ` [PATCH v2 2/2] phy: rcar-gen3-usb2: " Simon Horman 2016-03-03 8:13 ` Geert Uytterhoeven 2016-03-03 8:13 ` Geert Uytterhoeven 2016-03-03 9:23 ` Yoshihiro Shimoda 2016-03-03 9:23 ` Yoshihiro Shimoda 2016-03-03 9:23 ` Yoshihiro Shimoda 2016-03-05 4:28 ` Rob Herring
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.