* [PATCH] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd'
@ 2016-03-05 3:12 Brian Norris
2016-03-05 8:34 ` Robert Jarzmik
0 siblings, 1 reply; 5+ messages in thread
From: Brian Norris @ 2016-03-05 3:12 UTC (permalink / raw)
To: linux-mtd; +Cc: Brian Norris, Ezequiel Garcia, Robert Jarzmik
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
drivers/mtd/nand/pxa3xx_nand.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index f100c4da0423..a60c413c8d7f 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -211,7 +211,6 @@ struct pxa3xx_nand_info {
struct dma_chan *dma_chan;
dma_cookie_t dma_cookie;
int drcmr_dat;
- int drcmr_cmd;
unsigned char *data_buff;
unsigned char *oob_buff;
@@ -1812,7 +1811,6 @@ static int alloc_nand_resource(struct platform_device *pdev)
ret = -ENXIO;
goto fail_disable_clk;
}
- info->drcmr_cmd = r->start;
}
irq = platform_get_irq(pdev, 0);
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd'
2016-03-05 3:12 [PATCH] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd' Brian Norris
@ 2016-03-05 8:34 ` Robert Jarzmik
2016-03-07 18:37 ` [PATCH v2] " Brian Norris
0 siblings, 1 reply; 5+ messages in thread
From: Robert Jarzmik @ 2016-03-05 8:34 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd, Ezequiel Garcia
Brian Norris <computersforpeace@gmail.com> writes:
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Hi Brian,
> @@ -1812,7 +1811,6 @@ static int alloc_nand_resource(struct platform_device *pdev)
> ret = -ENXIO;
> goto fail_disable_clk;
> }
> - info->drcmr_cmd = r->start;
> }
If you kill this field, why not kill also this block just above ?
r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
if (r == NULL) {
dev_err(&pdev->dev,
"no resource defined for cmd DMA\n");
ret = -ENXIO;
goto fail_disable_clk;
}
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd'
2016-03-05 8:34 ` Robert Jarzmik
@ 2016-03-07 18:37 ` Brian Norris
2016-03-07 19:35 ` Robert Jarzmik
0 siblings, 1 reply; 5+ messages in thread
From: Brian Norris @ 2016-03-07 18:37 UTC (permalink / raw)
To: Robert Jarzmik; +Cc: linux-mtd, Ezequiel Garcia
With this removal, we don't need to 'get' the second DMA resource
either, as it's also unused.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
On Sat, Mar 05, 2016 at 09:34:14AM +0100, Robert Jarzmik wrote:
> Brian Norris <computersforpeace@gmail.com> writes:
> > @@ -1812,7 +1811,6 @@ static int alloc_nand_resource(struct platform_device *pdev)
> > ret = -ENXIO;
> > goto fail_disable_clk;
> > }
> > - info->drcmr_cmd = r->start;
> > }
> If you kill this field, why not kill also this block just above ?
> r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
> if (r == NULL) {
> dev_err(&pdev->dev,
> "no resource defined for cmd DMA\n");
> ret = -ENXIO;
> goto fail_disable_clk;
> }
Indeed, why not.
drivers/mtd/nand/pxa3xx_nand.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index f100c4da0423..d6508856da99 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -211,7 +211,6 @@ struct pxa3xx_nand_info {
struct dma_chan *dma_chan;
dma_cookie_t dma_cookie;
int drcmr_dat;
- int drcmr_cmd;
unsigned char *data_buff;
unsigned char *oob_buff;
@@ -1804,15 +1803,6 @@ static int alloc_nand_resource(struct platform_device *pdev)
goto fail_disable_clk;
}
info->drcmr_dat = r->start;
-
- r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
- if (r == NULL) {
- dev_err(&pdev->dev,
- "no resource defined for cmd DMA\n");
- ret = -ENXIO;
- goto fail_disable_clk;
- }
- info->drcmr_cmd = r->start;
}
irq = platform_get_irq(pdev, 0);
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd'
2016-03-07 18:37 ` [PATCH v2] " Brian Norris
@ 2016-03-07 19:35 ` Robert Jarzmik
2016-03-07 20:49 ` Brian Norris
0 siblings, 1 reply; 5+ messages in thread
From: Robert Jarzmik @ 2016-03-07 19:35 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd, Ezequiel Garcia
Brian Norris <computersforpeace@gmail.com> writes:
> With this removal, we don't need to 'get' the second DMA resource
> either, as it's also unused.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> On Sat, Mar 05, 2016 at 09:34:14AM +0100, Robert Jarzmik wrote:
>> Brian Norris <computersforpeace@gmail.com> writes:
>> > @@ -1812,7 +1811,6 @@ static int alloc_nand_resource(struct platform_device *pdev)
>> > ret = -ENXIO;
>> > goto fail_disable_clk;
>> > }
>> > - info->drcmr_cmd = r->start;
>> > }
>> If you kill this field, why not kill also this block just above ?
>> r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
>> if (r == NULL) {
>> dev_err(&pdev->dev,
>> "no resource defined for cmd DMA\n");
>> ret = -ENXIO;
>> goto fail_disable_clk;
>> }
>
> Indeed, why not.
>
> drivers/mtd/nand/pxa3xx_nand.c | 10 ----------
> 1 file changed, 10 deletions(-)
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd'
2016-03-07 19:35 ` Robert Jarzmik
@ 2016-03-07 20:49 ` Brian Norris
0 siblings, 0 replies; 5+ messages in thread
From: Brian Norris @ 2016-03-07 20:49 UTC (permalink / raw)
To: Robert Jarzmik; +Cc: linux-mtd, Ezequiel Garcia
On Mon, Mar 07, 2016 at 08:35:34PM +0100, Robert Jarzmik wrote:
> Brian Norris <computersforpeace@gmail.com> writes:
>
> > With this removal, we don't need to 'get' the second DMA resource
> > either, as it's also unused.
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > ---
> > On Sat, Mar 05, 2016 at 09:34:14AM +0100, Robert Jarzmik wrote:
> >> Brian Norris <computersforpeace@gmail.com> writes:
> >> > @@ -1812,7 +1811,6 @@ static int alloc_nand_resource(struct platform_device *pdev)
> >> > ret = -ENXIO;
> >> > goto fail_disable_clk;
> >> > }
> >> > - info->drcmr_cmd = r->start;
> >> > }
> >> If you kill this field, why not kill also this block just above ?
> >> r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
> >> if (r == NULL) {
> >> dev_err(&pdev->dev,
> >> "no resource defined for cmd DMA\n");
> >> ret = -ENXIO;
> >> goto fail_disable_clk;
> >> }
> >
> > Indeed, why not.
> >
> > drivers/mtd/nand/pxa3xx_nand.c | 10 ----------
> > 1 file changed, 10 deletions(-)
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Applied to l2-mtd.git
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-07 20:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-05 3:12 [PATCH] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd' Brian Norris
2016-03-05 8:34 ` Robert Jarzmik
2016-03-07 18:37 ` [PATCH v2] " Brian Norris
2016-03-07 19:35 ` Robert Jarzmik
2016-03-07 20:49 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.