All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cxl: Remove dead code
@ 2016-03-09 11:53 Frederic Barrat
  2016-03-09 23:22 ` Ian Munsie
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Frederic Barrat @ 2016-03-09 11:53 UTC (permalink / raw)
  To: imunsie, michael.neuling, mpe, linuxppc-dev

Function cxl_get_phys_dev() was removed from the kernel API by a
previous patch, but it's actually dead code. Remove it.

Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
---
 drivers/misc/cxl/api.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
index 2107c94..8075823 100644
--- a/drivers/misc/cxl/api.c
+++ b/drivers/misc/cxl/api.c
@@ -68,15 +68,6 @@ struct cxl_context *cxl_get_context(struct pci_dev *dev)
 }
 EXPORT_SYMBOL_GPL(cxl_get_context);
 
-struct device *cxl_get_phys_dev(struct pci_dev *dev)
-{
-	struct cxl_afu *afu;
-
-	afu = cxl_pci_to_afu(dev);
-
-	return afu->adapter->dev.parent;
-}
-
 int cxl_release_context(struct cxl_context *ctx)
 {
 	if (ctx->status >= STARTED)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] cxl: Remove dead code
  2016-03-09 11:53 [PATCH] cxl: Remove dead code Frederic Barrat
@ 2016-03-09 23:22 ` Ian Munsie
  2016-03-09 23:35 ` Andrew Donnellan
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Ian Munsie @ 2016-03-09 23:22 UTC (permalink / raw)
  To: Frederic Barrat; +Cc: michael.neuling, mpe, linuxppc-dev

Acked-by: Ian Munsie <imunsie@au1.ibm.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] cxl: Remove dead code
  2016-03-09 11:53 [PATCH] cxl: Remove dead code Frederic Barrat
  2016-03-09 23:22 ` Ian Munsie
@ 2016-03-09 23:35 ` Andrew Donnellan
  2016-03-09 23:59 ` Michael Neuling
  2016-04-11 12:35 ` Michael Ellerman
  3 siblings, 0 replies; 5+ messages in thread
From: Andrew Donnellan @ 2016-03-09 23:35 UTC (permalink / raw)
  To: Frederic Barrat, imunsie, michael.neuling, mpe, linuxppc-dev

On 09/03/16 22:53, Frederic Barrat wrote:
> Function cxl_get_phys_dev() was removed from the kernel API by a
> previous patch, but it's actually dead code. Remove it.
>
> Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>

For those playing along at home, this applies on top of the cxl PowerVM 
series.

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

-- 
Andrew Donnellan              Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com  Australia Development Lab, Canberra
+61 2 6201 8874 (work)        IBM Australia Limited

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] cxl: Remove dead code
  2016-03-09 11:53 [PATCH] cxl: Remove dead code Frederic Barrat
  2016-03-09 23:22 ` Ian Munsie
  2016-03-09 23:35 ` Andrew Donnellan
@ 2016-03-09 23:59 ` Michael Neuling
  2016-04-11 12:35 ` Michael Ellerman
  3 siblings, 0 replies; 5+ messages in thread
From: Michael Neuling @ 2016-03-09 23:59 UTC (permalink / raw)
  To: Frederic Barrat, ian, mpe, linuxppc-dev

On Wed, 2016-03-09 at 12:53 +0100, Frederic Barrat wrote:
> Function cxl_get_phys_dev() was removed from the kernel API by a
> previous patch, but it's actually dead code. Remove it.
>=20
> Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>

Acked-by: Michael Neuling <mikey@neuling.org>

> ---
>  drivers/misc/cxl/api.c | 9 ---------
>  1 file changed, 9 deletions(-)
>=20
> diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> index 2107c94..8075823 100644
> --- a/drivers/misc/cxl/api.c
> +++ b/drivers/misc/cxl/api.c
> @@ -68,15 +68,6 @@ struct cxl_context *cxl_get_context(struct pci_dev
> *dev)
>  }
>  EXPORT_SYMBOL_GPL(cxl_get_context);
> =20
> -struct device *cxl_get_phys_dev(struct pci_dev *dev)
> -{
> -	struct cxl_afu *afu;
> -
> -	afu =3D cxl_pci_to_afu(dev);
> -
> -	return afu->adapter->dev.parent;
> -}
> -
>  int cxl_release_context(struct cxl_context *ctx)
>  {
>  	if (ctx->status >=3D STARTED)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: cxl: Remove dead code
  2016-03-09 11:53 [PATCH] cxl: Remove dead code Frederic Barrat
                   ` (2 preceding siblings ...)
  2016-03-09 23:59 ` Michael Neuling
@ 2016-04-11 12:35 ` Michael Ellerman
  3 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2016-04-11 12:35 UTC (permalink / raw)
  To: Frederic Barrat, imunsie, michael.neuling, linuxppc-dev

On Wed, 2016-09-03 at 11:53:13 UTC, Frederic Barrat wrote:
> Function cxl_get_phys_dev() was removed from the kernel API by a
> previous patch, but it's actually dead code. Remove it.
> 
> Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Acked-by: Michael Neuling <mikey@neuling.org>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/d88e397f12ba0c8c672952c471

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-04-11 12:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-09 11:53 [PATCH] cxl: Remove dead code Frederic Barrat
2016-03-09 23:22 ` Ian Munsie
2016-03-09 23:35 ` Andrew Donnellan
2016-03-09 23:59 ` Michael Neuling
2016-04-11 12:35 ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.