[PATCH] toaster: correctly handle quotes in project names

* [PATCH] toaster: correctly handle quotes in project names
@ 2016-03-09 14:52 Elliot Smith
  2016-03-10 11:24 ` Michael Wood
  0 siblings, 1 reply; 3+ messages in thread
From: Elliot Smith @ 2016-03-09 14:52 UTC (permalink / raw)
  To: toaster

A project name like "Elliot's project" causes the "Rebuild" buttons
in the most recent builds section to fail when clicked with:

Uncaught SyntaxError: Unexpected token ILLEGAL

This is because the single quote character causes the JavaScript
for handling the button click event to be badly-formed.

As the project name is passed to the scheduleBuild() function
but doesn't actually do anything, this can be fixed by removing
the project name from the arguments passed to scheduleBuild()
(as well as the project URL, which is also ignored).

Signed-off-by: Elliot Smith <elliot.smith@intel.com>
---
 bitbake/lib/toaster/toastergui/templates/mrb_section.html | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/bitbake/lib/toaster/toastergui/templates/mrb_section.html b/bitbake/lib/toaster/toastergui/templates/mrb_section.html
index 551e341..f43390f 100644
--- a/bitbake/lib/toaster/toastergui/templates/mrb_section.html
+++ b/bitbake/lib/toaster/toastergui/templates/mrb_section.html
@@ -109,10 +109,7 @@
                       {%endif%}
                       pull-right"
                       onclick='scheduleBuild({% url 'projectbuilds' build.project.id as bpi %}{{bpi|json}},
-                        {{build.project.name|json}},
-                        {% url 'project' build.project.id as purl %}{{purl|json}},
                         {{build.target_set.all|get_tasks|json}})'>
-
                         Rebuild
                   </button>
               {% endif %}
@@ -134,7 +131,7 @@
 
 <script>
 
-function scheduleBuild(url, projectName, projectUrl, buildlist) {
+function scheduleBuild(url, buildlist) {
   console.log("scheduleBuild");
   libtoaster.startABuild(url, null, buildlist.join(" "), function(){
     console.log("reloading page");
-- 
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



^ permalink raw reply related	[flat|nested] 3+ messages in thread