All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mx6slevk: Fix the power up of the Ethernet PHY
@ 2016-03-11 13:50 Fabio Estevam
  2016-03-13 13:45 ` Tom Rini
  2016-03-13 13:50 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-03-11 13:50 UTC (permalink / raw)
  To: u-boot

From: Fabio Estevam <fabio.estevam@nxp.com>

GPIO4_21 is the LAN8720 power pin, not the LAN8720 reset pin.

Fix that, so that we can have Ethernet functional again.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 board/freescale/mx6slevk/mx6slevk.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/board/freescale/mx6slevk/mx6slevk.c b/board/freescale/mx6slevk/mx6slevk.c
index 4f816c4..f440ce6 100644
--- a/board/freescale/mx6slevk/mx6slevk.c
+++ b/board/freescale/mx6slevk/mx6slevk.c
@@ -57,7 +57,7 @@ DECLARE_GLOBAL_DATA_PTR;
 			PAD_CTL_DSE_80ohm | PAD_CTL_HYS |	\
 			PAD_CTL_SRE_FAST)
 
-#define ETH_PHY_RESET	IMX_GPIO_NR(4, 21)
+#define ETH_PHY_POWER	IMX_GPIO_NR(4, 21)
 
 int dram_init(void)
 {
@@ -154,10 +154,9 @@ static void setup_iomux_fec(void)
 {
 	imx_iomux_v3_setup_multiple_pads(fec_pads, ARRAY_SIZE(fec_pads));
 
-	/* Reset LAN8720 PHY */
-	gpio_direction_output(ETH_PHY_RESET , 0);
-	udelay(25000);
-	gpio_set_value(ETH_PHY_RESET, 1);
+	/* Power up LAN8720 PHY */
+	gpio_direction_output(ETH_PHY_POWER , 1);
+	udelay(15000);
 }
 
 #define USDHC1_CD_GPIO	IMX_GPIO_NR(4, 7)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mx6slevk: Fix the power up of the Ethernet PHY
  2016-03-11 13:50 [U-Boot] [PATCH] mx6slevk: Fix the power up of the Ethernet PHY Fabio Estevam
@ 2016-03-13 13:45 ` Tom Rini
  2016-03-13 13:50 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-03-13 13:45 UTC (permalink / raw)
  To: u-boot

On Fri, Mar 11, 2016 at 10:50:22AM -0300, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> GPIO4_21 is the LAN8720 power pin, not the LAN8720 reset pin.
> 
> Fix that, so that we can have Ethernet functional again.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160313/69cb74d8/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mx6slevk: Fix the power up of the Ethernet PHY
  2016-03-11 13:50 [U-Boot] [PATCH] mx6slevk: Fix the power up of the Ethernet PHY Fabio Estevam
  2016-03-13 13:45 ` Tom Rini
@ 2016-03-13 13:50 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-03-13 13:50 UTC (permalink / raw)
  To: u-boot

On Fri, Mar 11, 2016 at 10:50:22AM -0300, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> GPIO4_21 is the LAN8720 power pin, not the LAN8720 reset pin.
> 
> Fix that, so that we can have Ethernet functional again.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160313/e47adf28/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-03-13 13:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-11 13:50 [U-Boot] [PATCH] mx6slevk: Fix the power up of the Ethernet PHY Fabio Estevam
2016-03-13 13:45 ` Tom Rini
2016-03-13 13:50 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.