[PATCH] drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs

[PATCH] drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs

[Imre Deak]

After the commit below the Broxton PLL IDs had an off-by-one error, so
fix this up. Also add a missing brace at intel_shared_dpll_init(), it
happened to compile only due to the way the IS_BROXTON macro is defined.

Fixes: a3c988ea068c ("drm/i915: Make SKL/KBL DPLL0 managed by the shared dpll code")
CC: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c  | 9 ++++++---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 8 ++++----
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index a720628..0167f67 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9762,21 +9762,24 @@ static void bxt_get_ddi_pll(struct drm_i915_private *dev_priv,
 	switch (port) {
 	case PORT_A:
 		pipe_config->ddi_pll_sel = SKL_DPLL0;
-		id = DPLL_ID_SKL_DPLL1;
+		id = DPLL_ID_SKL_DPLL0;
 		break;
 	case PORT_B:
 		pipe_config->ddi_pll_sel = SKL_DPLL1;
-		id = DPLL_ID_SKL_DPLL2;
+		id = DPLL_ID_SKL_DPLL1;
 		break;
 	case PORT_C:
 		pipe_config->ddi_pll_sel = SKL_DPLL2;
-		id = DPLL_ID_SKL_DPLL3;
+		id = DPLL_ID_SKL_DPLL2;
 		break;
 	default:
 		DRM_ERROR("Incorrect port type\n");
 		return;
 	}
 
+	DRM_DEBUG_DRIVER("port %c PLL id %d\n", port_name(port),
+			 id);
+
 	pipe_config->shared_dpll = intel_get_shared_dpll_by_id(dev_priv, id);
 }
 
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index 4b636c4..74d5aec 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -1706,9 +1706,9 @@ static const struct intel_dpll_mgr skl_pll_mgr = {
 };
 
 static const struct dpll_info bxt_plls[] = {
-	{ "PORT PLL A", 0, &bxt_ddi_pll_funcs, 0 },
-	{ "PORT PLL B", 1, &bxt_ddi_pll_funcs, 0 },
-	{ "PORT PLL C", 2, &bxt_ddi_pll_funcs, 0 },
+	{ "PORT PLL A", DPLL_ID_SKL_DPLL0, &bxt_ddi_pll_funcs, 0 },
+	{ "PORT PLL B", DPLL_ID_SKL_DPLL1, &bxt_ddi_pll_funcs, 0 },
+	{ "PORT PLL C", DPLL_ID_SKL_DPLL2, &bxt_ddi_pll_funcs, 0 },
 	{ NULL, -1, NULL, },
 };
 
@@ -1726,7 +1726,7 @@ void intel_shared_dpll_init(struct drm_device *dev)
 
 	if (IS_SKYLAKE(dev) || IS_KABYLAKE(dev))
 		dpll_mgr = &skl_pll_mgr;
-	else if IS_BROXTON(dev)
+	else if (IS_BROXTON(dev))
 		dpll_mgr = &bxt_pll_mgr;
 	else if (HAS_DDI(dev))
 		dpll_mgr = &hsw_pll_mgr;
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v2] drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs

[Imre Deak]

After the commit below the Broxton PLL IDs had an off-by-one error, so
fix this up. Also add a missing brace at intel_shared_dpll_init(), it
happened to compile only due to the way the IS_BROXTON macro is defined.

v2:
- remove debugging left-over

Fixes: a3c988ea068c ("drm/i915: Make SKL/KBL DPLL0 managed by the shared dpll code")
CC: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c  | 6 +++---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index a720628..3cbb02b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9762,15 +9762,15 @@ static void bxt_get_ddi_pll(struct drm_i915_private *dev_priv,
 	switch (port) {
 	case PORT_A:
 		pipe_config->ddi_pll_sel = SKL_DPLL0;
-		id = DPLL_ID_SKL_DPLL1;
+		id = DPLL_ID_SKL_DPLL0;
 		break;
 	case PORT_B:
 		pipe_config->ddi_pll_sel = SKL_DPLL1;
-		id = DPLL_ID_SKL_DPLL2;
+		id = DPLL_ID_SKL_DPLL1;
 		break;
 	case PORT_C:
 		pipe_config->ddi_pll_sel = SKL_DPLL2;
-		id = DPLL_ID_SKL_DPLL3;
+		id = DPLL_ID_SKL_DPLL2;
 		break;
 	default:
 		DRM_ERROR("Incorrect port type\n");
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index 4b636c4..74d5aec 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -1706,9 +1706,9 @@ static const struct intel_dpll_mgr skl_pll_mgr = {
 };
 
 static const struct dpll_info bxt_plls[] = {
-	{ "PORT PLL A", 0, &bxt_ddi_pll_funcs, 0 },
-	{ "PORT PLL B", 1, &bxt_ddi_pll_funcs, 0 },
-	{ "PORT PLL C", 2, &bxt_ddi_pll_funcs, 0 },
+	{ "PORT PLL A", DPLL_ID_SKL_DPLL0, &bxt_ddi_pll_funcs, 0 },
+	{ "PORT PLL B", DPLL_ID_SKL_DPLL1, &bxt_ddi_pll_funcs, 0 },
+	{ "PORT PLL C", DPLL_ID_SKL_DPLL2, &bxt_ddi_pll_funcs, 0 },
 	{ NULL, -1, NULL, },
 };
 
@@ -1726,7 +1726,7 @@ void intel_shared_dpll_init(struct drm_device *dev)
 
 	if (IS_SKYLAKE(dev) || IS_KABYLAKE(dev))
 		dpll_mgr = &skl_pll_mgr;
-	else if IS_BROXTON(dev)
+	else if (IS_BROXTON(dev))
 		dpll_mgr = &bxt_pll_mgr;
 	else if (HAS_DDI(dev))
 		dpll_mgr = &hsw_pll_mgr;
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2] drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs

[Ander Conselvan De Oliveira]

On Mon, 2016-03-14 at 19:55 +0200, Imre Deak wrote:
> After the commit below the Broxton PLL IDs had an off-by-one error, so
> fix this up. Also add a missing brace at intel_shared_dpll_init(), it
> happened to compile only due to the way the IS_BROXTON macro is defined.
> 
> v2:
> - remove debugging left-over
> 
> Fixes: a3c988ea068c ("drm/i915: Make SKL/KBL DPLL0 managed by the shared dpll
> code")
> CC: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c  | 6 +++---
>  drivers/gpu/drm/i915/intel_dpll_mgr.c | 8 ++++----
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index a720628..3cbb02b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9762,15 +9762,15 @@ static void bxt_get_ddi_pll(struct drm_i915_private
> *dev_priv,
>  	switch (port) {
>  	case PORT_A:
>  		pipe_config->ddi_pll_sel = SKL_DPLL0;
> -		id = DPLL_ID_SKL_DPLL1;
> +		id = DPLL_ID_SKL_DPLL0;
>  		break;
>  	case PORT_B:
>  		pipe_config->ddi_pll_sel = SKL_DPLL1;
> -		id = DPLL_ID_SKL_DPLL2;
> +		id = DPLL_ID_SKL_DPLL1;
>  		break;
>  	case PORT_C:
>  		pipe_config->ddi_pll_sel = SKL_DPLL2;
> -		id = DPLL_ID_SKL_DPLL3;
> +		id = DPLL_ID_SKL_DPLL2;

Hmm, I think the mistake is that BXT relied on SKL DPLL ids in the first place.
This is fine as a fix up, but maybe it would be better to just add separate ids
for broxton too. Or even better, get rid of pll->id.

>  		break;
>  	default:
>  		DRM_ERROR("Incorrect port type\n");
> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> index 4b636c4..74d5aec 100644
> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> @@ -1706,9 +1706,9 @@ static const struct intel_dpll_mgr skl_pll_mgr = {
>  };
>  
>  static const struct dpll_info bxt_plls[] = {
> -	{ "PORT PLL A", 0, &bxt_ddi_pll_funcs, 0 },
> -	{ "PORT PLL B", 1, &bxt_ddi_pll_funcs, 0 },
> -	{ "PORT PLL C", 2, &bxt_ddi_pll_funcs, 0 },
> +	{ "PORT PLL A", DPLL_ID_SKL_DPLL0, &bxt_ddi_pll_funcs, 0 },
> +	{ "PORT PLL B", DPLL_ID_SKL_DPLL1, &bxt_ddi_pll_funcs, 0 },
> +	{ "PORT PLL C", DPLL_ID_SKL_DPLL2, &bxt_ddi_pll_funcs, 0 },
>  	{ NULL, -1, NULL, },
>  };
>  
> @@ -1726,7 +1726,7 @@ void intel_shared_dpll_init(struct drm_device *dev)
>  
>  	if (IS_SKYLAKE(dev) || IS_KABYLAKE(dev))
>  		dpll_mgr = &skl_pll_mgr;
> -	else if IS_BROXTON(dev)
> +	else if (IS_BROXTON(dev))

Wow, really don't know how I managed to do this. Thanks for fixing.

Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

>  		dpll_mgr = &bxt_pll_mgr;
>  	else if (HAS_DDI(dev))
>  		dpll_mgr = &hsw_pll_mgr;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2] drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs

[Imre Deak]

On ti, 2016-03-15 at 09:50 +0200, Ander Conselvan De Oliveira wrote:
> On Mon, 2016-03-14 at 19:55 +0200, Imre Deak wrote:
> > After the commit below the Broxton PLL IDs had an off-by-one error,
> > so
> > fix this up. Also add a missing brace at intel_shared_dpll_init(),
> > it
> > happened to compile only due to the way the IS_BROXTON macro is
> > defined.
> > 
> > v2:
> > - remove debugging left-over
> > 
> > Fixes: a3c988ea068c ("drm/i915: Make SKL/KBL DPLL0 managed by the
> > shared dpll
> > code")
> > CC: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.
> > com>
> > CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_display.c  | 6 +++---
> >  drivers/gpu/drm/i915/intel_dpll_mgr.c | 8 ++++----
> >  2 files changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index a720628..3cbb02b 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -9762,15 +9762,15 @@ static void bxt_get_ddi_pll(struct
> > drm_i915_private
> > *dev_priv,
> >  	switch (port) {
> >  	case PORT_A:
> >  		pipe_config->ddi_pll_sel = SKL_DPLL0;
> > -		id = DPLL_ID_SKL_DPLL1;
> > +		id = DPLL_ID_SKL_DPLL0;
> >  		break;
> >  	case PORT_B:
> >  		pipe_config->ddi_pll_sel = SKL_DPLL1;
> > -		id = DPLL_ID_SKL_DPLL2;
> > +		id = DPLL_ID_SKL_DPLL1;
> >  		break;
> >  	case PORT_C:
> >  		pipe_config->ddi_pll_sel = SKL_DPLL2;
> > -		id = DPLL_ID_SKL_DPLL3;
> > +		id = DPLL_ID_SKL_DPLL2;
> 
> Hmm, I think the mistake is that BXT relied on SKL DPLL ids in the
> first place.
> This is fine as a fix up, but maybe it would be better to just add
> separate ids
> for broxton too. Or even better, get rid of pll->id.

Yes, SKL_DPLLx and DPLL_ID_SKL_DPLLx that were defined originally had
confusingly different indexes already, not sure for the reason for
that. Removing 'id' if possible seems like a good idea.

> 
> >  		break;
> >  	default:
> >  		DRM_ERROR("Incorrect port type\n");
> > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > index 4b636c4..74d5aec 100644
> > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > @@ -1706,9 +1706,9 @@ static const struct intel_dpll_mgr
> > skl_pll_mgr = {
> >  };
> >  
> >  static const struct dpll_info bxt_plls[] = {
> > -	{ "PORT PLL A", 0, &bxt_ddi_pll_funcs, 0 },
> > -	{ "PORT PLL B", 1, &bxt_ddi_pll_funcs, 0 },
> > -	{ "PORT PLL C", 2, &bxt_ddi_pll_funcs, 0 },
> > +	{ "PORT PLL A", DPLL_ID_SKL_DPLL0, &bxt_ddi_pll_funcs, 0
> > },
> > +	{ "PORT PLL B", DPLL_ID_SKL_DPLL1, &bxt_ddi_pll_funcs, 0
> > },
> > +	{ "PORT PLL C", DPLL_ID_SKL_DPLL2, &bxt_ddi_pll_funcs, 0
> > },
> >  	{ NULL, -1, NULL, },
> >  };
> >  
> > @@ -1726,7 +1726,7 @@ void intel_shared_dpll_init(struct drm_device
> > *dev)
> >  
> >  	if (IS_SKYLAKE(dev) || IS_KABYLAKE(dev))
> >  		dpll_mgr = &skl_pll_mgr;
> > -	else if IS_BROXTON(dev)
> > +	else if (IS_BROXTON(dev))
> 
> Wow, really don't know how I managed to do this. Thanks for fixing.
> 
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

Thanks for the review.

> 
> >  		dpll_mgr = &bxt_pll_mgr;
> >  	else if (HAS_DDI(dev))
> >  		dpll_mgr = &hsw_pll_mgr;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH RESEND FOR CI] drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs

[Imre Deak]

After the commit below the Broxton PLL IDs had an off-by-one error, so
fix this up. Also add a missing brace at intel_shared_dpll_init(), it
happened to compile only due to the way the IS_BROXTON macro is defined.

v2:
- remove debugging left-over

Fixes: a3c988ea068c ("drm/i915: Make SKL/KBL DPLL0 managed by the shared dpll code")
CC: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
---
 drivers/gpu/drm/i915/intel_display.c  | 6 +++---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index ce55f0b..df8b78a 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9778,15 +9778,15 @@ static void bxt_get_ddi_pll(struct drm_i915_private *dev_priv,
 	switch (port) {
 	case PORT_A:
 		pipe_config->ddi_pll_sel = SKL_DPLL0;
-		id = DPLL_ID_SKL_DPLL1;
+		id = DPLL_ID_SKL_DPLL0;
 		break;
 	case PORT_B:
 		pipe_config->ddi_pll_sel = SKL_DPLL1;
-		id = DPLL_ID_SKL_DPLL2;
+		id = DPLL_ID_SKL_DPLL1;
 		break;
 	case PORT_C:
 		pipe_config->ddi_pll_sel = SKL_DPLL2;
-		id = DPLL_ID_SKL_DPLL3;
+		id = DPLL_ID_SKL_DPLL2;
 		break;
 	default:
 		DRM_ERROR("Incorrect port type\n");
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index 4b636c4..74d5aec 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -1706,9 +1706,9 @@ static const struct intel_dpll_mgr skl_pll_mgr = {
 };
 
 static const struct dpll_info bxt_plls[] = {
-	{ "PORT PLL A", 0, &bxt_ddi_pll_funcs, 0 },
-	{ "PORT PLL B", 1, &bxt_ddi_pll_funcs, 0 },
-	{ "PORT PLL C", 2, &bxt_ddi_pll_funcs, 0 },
+	{ "PORT PLL A", DPLL_ID_SKL_DPLL0, &bxt_ddi_pll_funcs, 0 },
+	{ "PORT PLL B", DPLL_ID_SKL_DPLL1, &bxt_ddi_pll_funcs, 0 },
+	{ "PORT PLL C", DPLL_ID_SKL_DPLL2, &bxt_ddi_pll_funcs, 0 },
 	{ NULL, -1, NULL, },
 };
 
@@ -1726,7 +1726,7 @@ void intel_shared_dpll_init(struct drm_device *dev)
 
 	if (IS_SKYLAKE(dev) || IS_KABYLAKE(dev))
 		dpll_mgr = &skl_pll_mgr;
-	else if IS_BROXTON(dev)
+	else if (IS_BROXTON(dev))
 		dpll_mgr = &bxt_pll_mgr;
 	else if (HAS_DDI(dev))
 		dpll_mgr = &hsw_pll_mgr;
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)
URL   : https://patchwork.freedesktop.org/series/4444/
State : failure

== Summary ==

Series 4444v3 drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs
http://patchwork.freedesktop.org/api/1.0/series/4444/revisions/3/mbox/

Test drv_module_reload_basic:
                skip       -> PASS       (bdw-nuci7)
Test gem_ringfill:
        Subgroup basic-default-s3:
                pass       -> DMESG-WARN (skl-nuci5)
Test gem_storedw_loop:
        Subgroup basic-bsd:
                pass       -> DMESG-WARN (skl-nuci5)
        Subgroup basic-bsd1:
                pass       -> DMESG-WARN (skl-nuci5)
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                dmesg-warn -> PASS       (hsw-brixbox)
                pass       -> DMESG-WARN (bdw-ultra)
        Subgroup basic-plain-flip:
                pass       -> DMESG-WARN (hsw-gt2)
Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-c:
                fail       -> PASS       (hsw-brixbox)
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (skl-nuci5)
        Subgroup suspend-read-crc-pipe-c:
                pass       -> INCOMPLETE (skl-nuci5)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                pass       -> DMESG-WARN (snb-dellxps)
        Subgroup basic-rte:
                pass       -> DMESG-WARN (bsw-nuc-2)

bdw-nuci7        total:194  pass:182  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:194  pass:172  dwarn:1   dfail:0   fail:0   skip:21 
bsw-nuc-2        total:194  pass:156  dwarn:1   dfail:0   fail:0   skip:37 
byt-nuc          total:194  pass:155  dwarn:4   dfail:0   fail:0   skip:35 
hsw-brixbox      total:194  pass:172  dwarn:0   dfail:0   fail:0   skip:22 
hsw-gt2          total:194  pass:176  dwarn:1   dfail:0   fail:0   skip:17 
ivb-t430s        total:194  pass:169  dwarn:0   dfail:0   fail:0   skip:25 
skl-i5k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
skl-i7k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
skl-nuci5        total:152  pass:138  dwarn:3   dfail:0   fail:0   skip:10 
snb-dellxps      total:194  pass:158  dwarn:2   dfail:0   fail:0   skip:34 

Results at /archive/results/CI_IGT_test/Patchwork_1607/

fc881ebd9c3c26919c7d1113f8bf7014e1a05563 drm-intel-nightly: 2016y-03m-15d-13h-10m-41s UTC integration manifest
7cb417d02e1ff8af6261f9a159470dc61ae0faa7 drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Imre Deak]

Tomi, noticed two things that maybe infrastructure related, see below:

On Wed, 2016-03-16 at 07:31 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)
> URL   : https://patchwork.freedesktop.org/series/4444/
> State : failure
> 
> == Summary ==
> 
> Series 4444v3 drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs
> http://patchwork.freedesktop.org/api/1.0/series/4444/revisions/3/mbox
> /
> 
> Test drv_module_reload_basic:
>                 skip       -> PASS       (bdw-nuci7)
> Test gem_ringfill:
>         Subgroup basic-default-s3:
>                 pass       -> DMESG-WARN (skl-nuci5)
> Test gem_storedw_loop:
>         Subgroup basic-bsd:
>                 pass       -> DMESG-WARN (skl-nuci5)
>         Subgroup basic-bsd1:
>                 pass       -> DMESG-WARN (skl-nuci5)

Unrelated platform. All of the above are SND resume failures. Ville
said he contacted Takashi about them.

> Test kms_flip:
>         Subgroup basic-flip-vs-wf_vblank:
>                 dmesg-warn -> PASS       (hsw-brixbox)
>                 pass       -> DMESG-WARN (bdw-ultra)

Unrelated platform.
Tomi, there are ACPI erros in the log, maybe needs a BIOS upgrade? It's
also affected by
https://bugs.freedesktop.org/show_bug.cgi?id=94349

>         Subgroup basic-plain-flip:
>                 pass       -> DMESG-WARN (hsw-gt2)

Unrelated platform:
https://patchwork.freedesktop.org/patch/75903/

> Test kms_pipe_crc_basic:
>         Subgroup read-crc-pipe-c:
>                 fail       -> PASS       (hsw-brixbox)
>         Subgroup suspend-read-crc-pipe-b:
>                 dmesg-warn -> PASS       (skl-nuci5)
>         Subgroup suspend-read-crc-pipe-c:
>                 pass       -> INCOMPLETE (skl-nuci5)

Unrelated platform, I opened a new bug:
https://bugs.freedesktop.org/show_bug.cgi?id=94566


> Test pm_rpm:
>         Subgroup basic-pci-d3-state:
>                 pass       -> DMESG-WARN (snb-dellxps)

Unrelated platform:
https://patchwork.freedesktop.org/patch/75903/

>         Subgroup basic-rte:
>                 pass       -> DMESG-WARN (bsw-nuc-2)

Unrelated platform:
https://bugs.freedesktop.org/show_bug.cgi?id=94164

Tomi, basic-rte has also DMESG-WARN on snb-dellxps, yet not on this
list.

--Imre

> 
> bdw-
> nuci7        total:194  pass:182  dwarn:0   dfail:0   fail:0   skip:1
> 2 
> bdw-
> ultra        total:194  pass:172  dwarn:1   dfail:0   fail:0   skip:2
> 1 
> bsw-nuc-
> 2        total:194  pass:156  dwarn:1   dfail:0   fail:0   skip:37 
> byt-
> nuc          total:194  pass:155  dwarn:4   dfail:0   fail:0   skip:3
> 5 
> hsw-
> brixbox      total:194  pass:172  dwarn:0   dfail:0   fail:0   skip:2
> 2 
> hsw-
> gt2          total:194  pass:176  dwarn:1   dfail:0   fail:0   skip:1
> 7 
> ivb-
> t430s        total:194  pass:169  dwarn:0   dfail:0   fail:0   skip:2
> 5 
> skl-i5k-
> 2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
> skl-i7k-
> 2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
> skl-
> nuci5        total:152  pass:138  dwarn:3   dfail:0   fail:0   skip:1
> 0 
> snb-
> dellxps      total:194  pass:158  dwarn:2   dfail:0   fail:0   skip:3
> 4 
> 
> Results at /archive/results/CI_IGT_test/Patchwork_1607/
> 
> fc881ebd9c3c26919c7d1113f8bf7014e1a05563 drm-intel-nightly: 2016y-
> 03m-15d-13h-10m-41s UTC integration manifest
> 7cb417d02e1ff8af6261f9a159470dc61ae0faa7 drm/i915/bxt: Fix off-by-one 
> error in Broxton PLL IDs
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Tomi Sarvela]

On Wednesday 16 March 2016 10:48:43 Imre Deak wrote:
> Tomi, noticed two things that maybe infrastructure related, see below:
> 
> > Test drv_module_reload_basic:
> >                 skip       -> PASS       (bdw-nuci7)
> > Test gem_ringfill:
> >         Subgroup basic-default-s3:
> >                 pass       -> DMESG-WARN (skl-nuci5)
> > Test gem_storedw_loop:
> >         Subgroup basic-bsd:
> >                 pass       -> DMESG-WARN (skl-nuci5)
> >         Subgroup basic-bsd1:
> >                 pass       -> DMESG-WARN (skl-nuci5)
> 
> Unrelated platform. All of the above are SND resume failures. Ville
> said he contacted Takashi about them.

SND is recurring problem. I'd like to see drm-intel-nightly not breaking when 
pulling sound updates.

> > Test kms_flip:
> >         Subgroup basic-flip-vs-wf_vblank:
> >                 dmesg-warn -> PASS       (hsw-brixbox)
> >                 pass       -> DMESG-WARN (bdw-ultra)
> 
> Unrelated platform.
> Tomi, there are ACPI erros in the log, maybe needs a BIOS upgrade? It's
> also affected by
> https://bugs.freedesktop.org/show_bug.cgi?id=94349

Brixbox is at the newest BIOS available. Did you mean Intel Ultrabook 2in1?

> > Test kms_pipe_crc_basic:
> >         Subgroup read-crc-pipe-c:
> >                 fail       -> PASS       (hsw-brixbox)
> >         Subgroup suspend-read-crc-pipe-b:
> >                 dmesg-warn -> PASS       (skl-nuci5)
> >         Subgroup suspend-read-crc-pipe-c:
> >                 pass       -> INCOMPLETE (skl-nuci5)
> 
> Unrelated platform, I opened a new bug:
> https://bugs.freedesktop.org/show_bug.cgi?id=94566

Suspend-read-crc-pipes are notoriously unstable, and main reason (in addition 
to drv_module_reload_basic) to hangs.

> Tomi, basic-rte has also DMESG-WARN on snb-dellxps, yet not on this
> list.

SNB-dellxps is in a bad state, there's alsa blocking shutdown and startup 
within set timelimits. It'll be probably out until snd is fixed.

Tomi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Imre Deak]

On Wed, 2016-03-16 at 14:37 +0200, Tomi Sarvela wrote:
> On Wednesday 16 March 2016 10:48:43 Imre Deak wrote:
> > Tomi, noticed two things that maybe infrastructure related, see
> > below:
> > 
> > > Test drv_module_reload_basic:
> > >                 skip       -> PASS       (bdw-nuci7)
> > > Test gem_ringfill:
> > >         Subgroup basic-default-s3:
> > >                 pass       -> DMESG-WARN (skl-nuci5)
> > > Test gem_storedw_loop:
> > >         Subgroup basic-bsd:
> > >                 pass       -> DMESG-WARN (skl-nuci5)
> > >         Subgroup basic-bsd1:
> > >                 pass       -> DMESG-WARN (skl-nuci5)
> > 
> > Unrelated platform. All of the above are SND resume failures. Ville
> > said he contacted Takashi about them.
> 
> SND is recurring problem. I'd like to see drm-intel-nightly not
> breaking when 
> pulling sound updates.
> 
> > > Test kms_flip:
> > >         Subgroup basic-flip-vs-wf_vblank:
> > >                 dmesg-warn -> PASS       (hsw-brixbox)
> > >                 pass       -> DMESG-WARN (bdw-ultra)
> > 
> > Unrelated platform.
> > Tomi, there are ACPI erros in the log, maybe needs a BIOS upgrade?
> > It's
> > also affected by
> > https://bugs.freedesktop.org/show_bug.cgi?id=94349
> 
> Brixbox is at the newest BIOS available. Did you mean Intel Ultrabook
> 2in1?

No not that one but the above bdw-ultra. See the ACPI errors in
archive/results/CI_IGT_test/Patchwork_1607/bdw-ultra/html/bdw-ultra@Patchwork_1607@1/igt@kms_flip@basic-flip-vs-wf_vblank.html

--Imre

> 
> > > Test kms_pipe_crc_basic:
> > >         Subgroup read-crc-pipe-c:
> > >                 fail       -> PASS       (hsw-brixbox)
> > >         Subgroup suspend-read-crc-pipe-b:
> > >                 dmesg-warn -> PASS       (skl-nuci5)
> > >         Subgroup suspend-read-crc-pipe-c:
> > >                 pass       -> INCOMPLETE (skl-nuci5)
> > 
> > Unrelated platform, I opened a new bug:
> > https://bugs.freedesktop.org/show_bug.cgi?id=94566
> 
> Suspend-read-crc-pipes are notoriously unstable, and main reason (in
> addition 
> to drv_module_reload_basic) to hangs.
> 
> > Tomi, basic-rte has also DMESG-WARN on snb-dellxps, yet not on this
> > list.
> 
> SNB-dellxps is in a bad state, there's alsa blocking shutdown and
> startup 
> within set timelimits. It'll be probably out until snd is fixed.
> 
> Tomi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Imre Deak]

On Wed, 2016-03-16 at 10:48 +0200, Imre Deak wrote:
> Tomi, noticed two things that maybe infrastructure related, see
> below:
> 
> On Wed, 2016-03-16 at 07:31 +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs
> > (rev3)
> > URL   : https://patchwork.freedesktop.org/series/4444/
> > State : failure
> > 
> > == Summary ==
> > 
> > Series 4444v3 drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs
> > http://patchwork.freedesktop.org/api/1.0/series/4444/revisions/3/mb
> > ox
> > /
> > 
> > Test drv_module_reload_basic:
> >                 skip       -> PASS       (bdw-nuci7)
> > Test gem_ringfill:
> >         Subgroup basic-default-s3:
> >                 pass       -> DMESG-WARN (skl-nuci5)
> > Test gem_storedw_loop:
> >         Subgroup basic-bsd:
> >                 pass       -> DMESG-WARN (skl-nuci5)
> >         Subgroup basic-bsd1:
> >                 pass       -> DMESG-WARN (skl-nuci5)
> 
> Unrelated platform. All of the above are SND resume failures. Ville
> said he contacted Takashi about them.
> 
> > Test kms_flip:
> >         Subgroup basic-flip-vs-wf_vblank:
> >                 dmesg-warn -> PASS       (hsw-brixbox)
> >                 pass       -> DMESG-WARN (bdw-ultra)
> 
> Unrelated platform.
> Tomi, there are ACPI erros in the log, maybe needs a BIOS upgrade?
> It's
> also affected by
> https://bugs.freedesktop.org/show_bug.cgi?id=94349
> 
> >         Subgroup basic-plain-flip:
> >                 pass       -> DMESG-WARN (hsw-gt2)
> 
> Unrelated platform:
> https://patchwork.freedesktop.org/patch/75903/
> 
> > Test kms_pipe_crc_basic:
> >         Subgroup read-crc-pipe-c:
> >                 fail       -> PASS       (hsw-brixbox)
> >         Subgroup suspend-read-crc-pipe-b:
> >                 dmesg-warn -> PASS       (skl-nuci5)
> >         Subgroup suspend-read-crc-pipe-c:
> >                 pass       -> INCOMPLETE (skl-nuci5)
> 
> Unrelated platform, I opened a new bug:
> https://bugs.freedesktop.org/show_bug.cgi?id=94566
> 
> 
> > Test pm_rpm:
> >         Subgroup basic-pci-d3-state:
> >                 pass       -> DMESG-WARN (snb-dellxps)
> 
> Unrelated platform:
> https://patchwork.freedesktop.org/patch/75903/
> 
> >         Subgroup basic-rte:
> >                 pass       -> DMESG-WARN (bsw-nuc-2)
> 
> Unrelated platform:
> https://bugs.freedesktop.org/show_bug.cgi?id=94164

Pushed the patch to -dinq, thanks for the review.

--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Daniel Vetter]

On Wed, Mar 16, 2016 at 02:37:24PM +0200, Tomi Sarvela wrote:
> On Wednesday 16 March 2016 10:48:43 Imre Deak wrote:
> > Tomi, noticed two things that maybe infrastructure related, see below:
> > 
> > > Test drv_module_reload_basic:
> > >                 skip       -> PASS       (bdw-nuci7)
> > > Test gem_ringfill:
> > >         Subgroup basic-default-s3:
> > >                 pass       -> DMESG-WARN (skl-nuci5)
> > > Test gem_storedw_loop:
> > >         Subgroup basic-bsd:
> > >                 pass       -> DMESG-WARN (skl-nuci5)
> > >         Subgroup basic-bsd1:
> > >                 pass       -> DMESG-WARN (skl-nuci5)
> > 
> > Unrelated platform. All of the above are SND resume failures. Ville
> > said he contacted Takashi about them.
> 
> SND is recurring problem. I'd like to see drm-intel-nightly not breaking when 
> pulling sound updates.

We need to escalate this again, snd team seriously sucks at quality
control :( Adding Libin&Takashi. If this doesn't improve I need to throw
sound trees out of -nightly for real.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Takashi Iwai]

On Wed, 16 Mar 2016 16:37:06 +0100,
Daniel Vetter wrote:
> 
> On Wed, Mar 16, 2016 at 02:37:24PM +0200, Tomi Sarvela wrote:
> > On Wednesday 16 March 2016 10:48:43 Imre Deak wrote:
> > > Tomi, noticed two things that maybe infrastructure related, see below:
> > > 
> > > > Test drv_module_reload_basic:
> > > >                 skip       -> PASS       (bdw-nuci7)
> > > > Test gem_ringfill:
> > > >         Subgroup basic-default-s3:
> > > >                 pass       -> DMESG-WARN (skl-nuci5)
> > > > Test gem_storedw_loop:
> > > >         Subgroup basic-bsd:
> > > >                 pass       -> DMESG-WARN (skl-nuci5)
> > > >         Subgroup basic-bsd1:
> > > >                 pass       -> DMESG-WARN (skl-nuci5)
> > > 
> > > Unrelated platform. All of the above are SND resume failures. Ville
> > > said he contacted Takashi about them.
> > 
> > SND is recurring problem. I'd like to see drm-intel-nightly not breaking when 
> > pulling sound updates.
> 
> We need to escalate this again, snd team seriously sucks at quality
> control :( Adding Libin&Takashi. If this doesn't improve I need to throw
> sound trees out of -nightly for real.

Sorry about that, but I couldn't get the warning on my machine.

How is the procedure to reproduce the bug?  Please give the exact
commit id and environment you're testing, too.


Takashi

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Jani Nikula]

On Wed, 16 Mar 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> [ text/plain ]
> On Wed, Mar 16, 2016 at 02:37:24PM +0200, Tomi Sarvela wrote:
>> On Wednesday 16 March 2016 10:48:43 Imre Deak wrote:
>> > Tomi, noticed two things that maybe infrastructure related, see below:
>> > 
>> > > Test drv_module_reload_basic:
>> > >                 skip       -> PASS       (bdw-nuci7)
>> > > Test gem_ringfill:
>> > >         Subgroup basic-default-s3:
>> > >                 pass       -> DMESG-WARN (skl-nuci5)
>> > > Test gem_storedw_loop:
>> > >         Subgroup basic-bsd:
>> > >                 pass       -> DMESG-WARN (skl-nuci5)
>> > >         Subgroup basic-bsd1:
>> > >                 pass       -> DMESG-WARN (skl-nuci5)
>> > 
>> > Unrelated platform. All of the above are SND resume failures. Ville
>> > said he contacted Takashi about them.
>> 
>> SND is recurring problem. I'd like to see drm-intel-nightly not breaking when 
>> pulling sound updates.
>
> We need to escalate this again, snd team seriously sucks at quality
> control :( Adding Libin&Takashi. If this doesn't improve I need to throw
> sound trees out of -nightly for real.

With that, we'd get more stable CI, but we'd also only see the failures
once the sound trees get merged upstream. We don't want that either.

One idea would be to have separate CI runs for updating trees not in our
control. But we're pretty far from making that happen.

BR,
Jani.



-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Daniel Vetter]

On Wed, Mar 16, 2016 at 4:50 PM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
> On Wed, 16 Mar 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
>> [ text/plain ]
>> On Wed, Mar 16, 2016 at 02:37:24PM +0200, Tomi Sarvela wrote:
>>> On Wednesday 16 March 2016 10:48:43 Imre Deak wrote:
>>> > Tomi, noticed two things that maybe infrastructure related, see below:
>>> >
>>> > > Test drv_module_reload_basic:
>>> > >                 skip       -> PASS       (bdw-nuci7)
>>> > > Test gem_ringfill:
>>> > >         Subgroup basic-default-s3:
>>> > >                 pass       -> DMESG-WARN (skl-nuci5)
>>> > > Test gem_storedw_loop:
>>> > >         Subgroup basic-bsd:
>>> > >                 pass       -> DMESG-WARN (skl-nuci5)
>>> > >         Subgroup basic-bsd1:
>>> > >                 pass       -> DMESG-WARN (skl-nuci5)
>>> >
>>> > Unrelated platform. All of the above are SND resume failures. Ville
>>> > said he contacted Takashi about them.
>>>
>>> SND is recurring problem. I'd like to see drm-intel-nightly not breaking when
>>> pulling sound updates.
>>
>> We need to escalate this again, snd team seriously sucks at quality
>> control :( Adding Libin&Takashi. If this doesn't improve I need to throw
>> sound trees out of -nightly for real.
>
> With that, we'd get more stable CI, but we'd also only see the failures
> once the sound trees get merged upstream. We don't want that either.
>
> One idea would be to have separate CI runs for updating trees not in our
> control. But we're pretty far from making that happen.

Yes agreed, it would probably not help a lot at all to drop sound
trees, we'd simply notice a bit later. I'm not sure what would be the
best option here, just expressing maintainer grumpiness ;-) Good ideas
very much welcome ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Tomi Sarvela]

On Wednesday 16 March 2016 16:40:24 Takashi Iwai wrote:
> On Wed, 16 Mar 2016 16:37:06 +0100, Daniel Vetter wrote:
> > On Wed, Mar 16, 2016 at 02:37:24PM +0200, Tomi Sarvela wrote:
> > > 
> > > SND is recurring problem. I'd like to see drm-intel-nightly not breaking
> > > when pulling sound updates.
> > 
> > We need to escalate this again, snd team seriously sucks at quality
> > control :( Adding Libin&Takashi. If this doesn't improve I need to throw
> > sound trees out of -nightly for real.
> 
> Sorry about that, but I couldn't get the warning on my machine.
> 
> How is the procedure to reproduce the bug?  Please give the exact
> commit id and environment you're testing, too.

Our CI has been built to mimic user environment, so base is up-to-date Ubuntu 
15.04. This affects to boot-up mechanics and usermode software versions. There 
are about dozen machines, 8 gens, from ILK to SKL.

Reproduction: CI is doing these steps

- Compile kernel: CI_DRM is drm-intel-nightly HEAD
- Deploy it to testhost: copy to /boot, recreate initrd
- Boot testhost to init 3
- Run newest IGT/piglit with basic testset
- Collect results

The last commits tested are:

CI_DRM_1140 git://anongit.freedesktop.org/drm-intel 
3e5ecc8c5ff80cb1fb635ce1cf16b7cd4cfb1979

CI_DRM_1141 git://anongit.freedesktop.org/drm-intel 
fc881ebd9c3c26919c7d1113f8bf7014e1a05563

CI_DRM_1142 git://anongit.freedesktop.org/drm-intel 
9f8709ffd099e85e5e116ed7d09f1b8009f40847

CI_DRM_1143 git://anongit.freedesktop.org/drm-intel 
5356c22379fc96cb087ee59bfdbbe46ec3bdf654

CI_DRM_1144 git://anongit.freedesktop.org/drm-intel 
a5c43f5d1b4968a370f54bdda5387ce213aca785

CI_DRM_1145 git://anongit.freedesktop.org/drm-intel 
bf3dcd53821a7d6c81f7061c6c7956aad57ec615

CI_DRM_1146 git://anongit.freedesktop.org/drm-intel 
be0d1481fb1a2fd1cb199b81c9c01154a78d43dd

CI_DRM_1147 git://anongit.freedesktop.org/drm-intel 
dbbc6d276864d7b7a3a1edb04f0511153f9c3852

Note that drm-intel-nightly history changes, so the exact commits might not be 
there any more.

Tomi

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Takashi Iwai]

On Thu, 17 Mar 2016 08:57:23 +0100,
Tomi Sarvela wrote:
> 
> On Wednesday 16 March 2016 16:40:24 Takashi Iwai wrote:
> > On Wed, 16 Mar 2016 16:37:06 +0100, Daniel Vetter wrote:
> > > On Wed, Mar 16, 2016 at 02:37:24PM +0200, Tomi Sarvela wrote:
> > > > 
> > > > SND is recurring problem. I'd like to see drm-intel-nightly not breaking
> > > > when pulling sound updates.
> > > 
> > > We need to escalate this again, snd team seriously sucks at quality
> > > control :( Adding Libin&Takashi. If this doesn't improve I need to throw
> > > sound trees out of -nightly for real.
> > 
> > Sorry about that, but I couldn't get the warning on my machine.
> > 
> > How is the procedure to reproduce the bug?  Please give the exact
> > commit id and environment you're testing, too.
> 
> Our CI has been built to mimic user environment, so base is up-to-date Ubuntu 
> 15.04. This affects to boot-up mechanics and usermode software versions. There 
> are about dozen machines, 8 gens, from ILK to SKL.
> 
> Reproduction: CI is doing these steps
> 
> - Compile kernel: CI_DRM is drm-intel-nightly HEAD
> - Deploy it to testhost: copy to /boot, recreate initrd
> - Boot testhost to init 3
> - Run newest IGT/piglit with basic testset
> - Collect results
> 
> The last commits tested are:
> 
> CI_DRM_1140 git://anongit.freedesktop.org/drm-intel 
> 3e5ecc8c5ff80cb1fb635ce1cf16b7cd4cfb1979
> 
> CI_DRM_1141 git://anongit.freedesktop.org/drm-intel 
> fc881ebd9c3c26919c7d1113f8bf7014e1a05563
> 
> CI_DRM_1142 git://anongit.freedesktop.org/drm-intel 
> 9f8709ffd099e85e5e116ed7d09f1b8009f40847
> 
> CI_DRM_1143 git://anongit.freedesktop.org/drm-intel 
> 5356c22379fc96cb087ee59bfdbbe46ec3bdf654
> 
> CI_DRM_1144 git://anongit.freedesktop.org/drm-intel 
> a5c43f5d1b4968a370f54bdda5387ce213aca785
> 
> CI_DRM_1145 git://anongit.freedesktop.org/drm-intel 
> bf3dcd53821a7d6c81f7061c6c7956aad57ec615
> 
> CI_DRM_1146 git://anongit.freedesktop.org/drm-intel 
> be0d1481fb1a2fd1cb199b81c9c01154a78d43dd
> 
> CI_DRM_1147 git://anongit.freedesktop.org/drm-intel 
> dbbc6d276864d7b7a3a1edb04f0511153f9c3852
> 
> Note that drm-intel-nightly history changes, so the exact commits might not be 
> there any more.

Well, I have no internal access, so I have no idea which one succeeded
and which one failed.

Unfortunately I can't reproduce it in my side.  A simpler unit test
that can reliably reproduce the issue would be really appreciated...


thanks,

Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Tomi Sarvela]

On Thursday 17 March 2016 18:00:52 Takashi Iwai wrote:
...

> > CI_DRM_1147 git://anongit.freedesktop.org/drm-intel
> > dbbc6d276864d7b7a3a1edb04f0511153f9c3852
> > 
> > Note that drm-intel-nightly history changes, so the exact commits might
> > not be there any more.
> 
> Well, I have no internal access, so I have no idea which one succeeded
> and which one failed.
> 
> Unfortunately I can't reproduce it in my side.  A simpler unit test
> that can reliably reproduce the issue would be really appreciated...

Sorry, I was being unclear. They all fail on selected machines (ILK, SNB), 
since CI_DRM_1140.

The unit tests that hang quite reliably on first run are
igt@gem_ringfill_basic-default-s3
igt@drv_module_reload_basic
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-[abc]

Tomi

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Takashi Iwai]

On Fri, 18 Mar 2016 08:36:27 +0100,
Tomi Sarvela wrote:
> 
> On Thursday 17 March 2016 18:00:52 Takashi Iwai wrote:
> ...
> 
> > > CI_DRM_1147 git://anongit.freedesktop.org/drm-intel
> > > dbbc6d276864d7b7a3a1edb04f0511153f9c3852
> > > 
> > > Note that drm-intel-nightly history changes, so the exact commits might
> > > not be there any more.
> > 
> > Well, I have no internal access, so I have no idea which one succeeded
> > and which one failed.
> > 
> > Unfortunately I can't reproduce it in my side.  A simpler unit test
> > that can reliably reproduce the issue would be really appreciated...
> 
> Sorry, I was being unclear. They all fail on selected machines (ILK, SNB), 
> since CI_DRM_1140.

Do you have the commit of the last working kernel?

> The unit tests that hang quite reliably on first run are
> igt@gem_ringfill_basic-default-s3
> igt@drv_module_reload_basic
> igt@kms_pipe_crc_basic@suspend-read-crc-pipe-[abc]

Where can I get these?


Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Tomi Sarvela]

On Friday 18 March 2016 09:00:13 Takashi Iwai wrote:
> On Fri, 18 Mar 2016 08:36:27 +0100,
> 
> Do you have the commit of the last working kernel?
> 
> > The unit tests that hang quite reliably on first run are
> > igt@gem_ringfill_basic-default-s3
> > igt@drv_module_reload_basic
> > igt@kms_pipe_crc_basic@suspend-read-crc-pipe-[abc]
> 
> Where can I get these?

IGT is intel-gpu-tools, hardware unittests using piglit as a base. CI runs BAT 
(Basic Acceptance Tests), a set of IGT tests: around 200 tests, runs under 10 
minutes. Can be run with ${IGT_PATH}/scripts/run-tests.sh -t basic

git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

http://anongit.freedesktop.org/git/piglit.git

Latest working drm-intel commit was CI_DRM_1139:
3e5ecc8c5ff80cb1fb635ce1cf16b7cd4cfb1979 2016-03-14_09-06-45 drm-intel-nightly: 
2016y-03m-14d-09h-06m-00s UTC integration manifest

Best Regards,

Tomi

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

[Takashi Iwai]

On Fri, 18 Mar 2016 09:12:53 +0100,
Tomi Sarvela wrote:
> 
> On Friday 18 March 2016 09:00:13 Takashi Iwai wrote:
> > On Fri, 18 Mar 2016 08:36:27 +0100,
> > 
> > Do you have the commit of the last working kernel?
> > 
> > > The unit tests that hang quite reliably on first run are
> > > igt@gem_ringfill_basic-default-s3
> > > igt@drv_module_reload_basic
> > > igt@kms_pipe_crc_basic@suspend-read-crc-pipe-[abc]
> > 
> > Where can I get these?
> 
> IGT is intel-gpu-tools, hardware unittests using piglit as a base. CI runs BAT 
> (Basic Acceptance Tests), a set of IGT tests: around 200 tests, runs under 10 
> minutes. Can be run with ${IGT_PATH}/scripts/run-tests.sh -t basic
> 
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> 
> http://anongit.freedesktop.org/git/piglit.git
> 
> Latest working drm-intel commit was CI_DRM_1139:
> 3e5ecc8c5ff80cb1fb635ce1cf16b7cd4cfb1979 2016-03-14_09-06-45 drm-intel-nightly: 
> 2016y-03m-14d-09h-06m-00s UTC integration manifest

There were a few different kernel warnings, so this date is possibly a
red herring.  One is the kernel warning from pin2port(), and this has
nothing to do with Skylake.  It's being addressed now.

The problem I can't follow is the PM refcount unbalance found on
Skylake.  It'd be helpful if you can give the exact *minimal*
reproducer.  The warning shows the result, and it means that something
wrong did happen before that.  So, we need the procedure until that
point, not the point of the outcome.


thanks,

Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx