All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARC: axs10x - add Ethernet PHY description in .dts
@ 2016-03-15  9:29 ` Alexey Brodkin
  0 siblings, 0 replies; 7+ messages in thread
From: Alexey Brodkin @ 2016-03-15  9:29 UTC (permalink / raw)
  To: linux-snps-arc
  Cc: Alexey Brodkin, Rob Herring, Phil Reid, David S. Miller,
	linux-kernel, netdev, stable, #,
	4.5.x

Following commit broke DW GMAC functionality on AXS10x boards:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763

That's what happens on eth0 up:
--------------------------->8------------------------
libphy: PHY stmmac-0:ffffffff not found
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
--------------------------->8------------------------

Simplest solution is to add PHY description in board's .dts.
And so we do here.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Phil Reid <preid@electromag.com.au>
Cc: David S. Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: stable@vger.kernel.org # 4.5.x
---
 arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 44a578c..04b999e 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -47,6 +47,14 @@
 			clocks = <&apbclk>;
 			clock-names = "stmmaceth";
 			max-speed = <100>;
+			mdio0 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "snps,dwmac-mdio";
+				phy0: ethernet-phy@0 {
+					reg = <1>;
+				};
+			};
 		};
 
 		ehci@0x40000 {
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] ARC: axs10x - add Ethernet PHY description in .dts
@ 2016-03-15  9:29 ` Alexey Brodkin
  0 siblings, 0 replies; 7+ messages in thread
From: Alexey Brodkin @ 2016-03-15  9:29 UTC (permalink / raw)
  To: linux-snps-arc

Following commit broke DW GMAC functionality on AXS10x boards:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763

That's what happens on eth0 up:
--------------------------->8------------------------
libphy: PHY stmmac-0:ffffffff not found
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
--------------------------->8------------------------

Simplest solution is to add PHY description in board's .dts.
And so we do here.

Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
Cc: Rob Herring <robh at kernel.org>
Cc: Phil Reid <preid at electromag.com.au>
Cc: David S. Miller <davem at davemloft.net>
Cc: linux-kernel at vger.kernel.org
Cc: netdev at vger.kernel.org
Cc: stable at vger.kernel.org # 4.5.x
---
 arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 44a578c..04b999e 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -47,6 +47,14 @@
 			clocks = <&apbclk>;
 			clock-names = "stmmaceth";
 			max-speed = <100>;
+			mdio0 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "snps,dwmac-mdio";
+				phy0: ethernet-phy at 0 {
+					reg = <1>;
+				};
+			};
 		};
 
 		ehci at 0x40000 {
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts
  2016-03-15  9:29 ` Alexey Brodkin
@ 2016-03-15 14:38   ` Sergei Shtylyov
  -1 siblings, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2016-03-15 14:38 UTC (permalink / raw)
  To: Alexey Brodkin, linux-snps-arc
  Cc: Rob Herring, Phil Reid, David S. Miller, linux-kernel, netdev,
	stable, #,
	4.5.x

Hello.

On 3/15/2016 12:29 PM, Alexey Brodkin wrote:

> Following commit broke DW GMAC functionality on AXS10x boards:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>
> That's what happens on eth0 up:
> --------------------------->8------------------------
> libphy: PHY stmmac-0:ffffffff not found
> eth0: Could not attach to PHY
> stmmac_open: Cannot attach to PHY (error: -19)
> --------------------------->8------------------------
>
> Simplest solution is to add PHY description in board's .dts.
> And so we do here.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Phil Reid <preid@electromag.com.au>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: linux-kernel@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: stable@vger.kernel.org # 4.5.x
> ---
>   arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> index 44a578c..04b999e 100644
> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> @@ -47,6 +47,14 @@
>   			clocks = <&apbclk>;
>   			clock-names = "stmmaceth";
>   			max-speed = <100>;
> +			mdio0 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "snps,dwmac-mdio";
> +				phy0: ethernet-phy@0 {

    The naming is inconsistent with the "reg" prop specified, should be @1.

MBR, Sergei

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] ARC: axs10x - add Ethernet PHY description in .dts
@ 2016-03-15 14:38   ` Sergei Shtylyov
  0 siblings, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2016-03-15 14:38 UTC (permalink / raw)
  To: linux-snps-arc

Hello.

On 3/15/2016 12:29 PM, Alexey Brodkin wrote:

> Following commit broke DW GMAC functionality on AXS10x boards:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>
> That's what happens on eth0 up:
> --------------------------->8------------------------
> libphy: PHY stmmac-0:ffffffff not found
> eth0: Could not attach to PHY
> stmmac_open: Cannot attach to PHY (error: -19)
> --------------------------->8------------------------
>
> Simplest solution is to add PHY description in board's .dts.
> And so we do here.
>
> Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Rob Herring <robh at kernel.org>
> Cc: Phil Reid <preid at electromag.com.au>
> Cc: David S. Miller <davem at davemloft.net>
> Cc: linux-kernel at vger.kernel.org
> Cc: netdev at vger.kernel.org
> Cc: stable at vger.kernel.org # 4.5.x
> ---
>   arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> index 44a578c..04b999e 100644
> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> @@ -47,6 +47,14 @@
>   			clocks = <&apbclk>;
>   			clock-names = "stmmaceth";
>   			max-speed = <100>;
> +			mdio0 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "snps,dwmac-mdio";
> +				phy0: ethernet-phy at 0 {

    The naming is inconsistent with the "reg" prop specified, should be @1.

MBR, Sergei

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts
  2016-03-15 14:38   ` Sergei Shtylyov
  (?)
@ 2016-03-15 14:50     ` Alexey Brodkin
  -1 siblings, 0 replies; 7+ messages in thread
From: Alexey Brodkin @ 2016-03-15 14:50 UTC (permalink / raw)
  To: sergei.shtylyov; +Cc: robh, preid, davem, linux-kernel, linux-snps-arc, netdev

Hi Sergei,

On Tue, 2016-03-15 at 17:38 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 3/15/2016 12:29 PM, Alexey Brodkin wrote:
> 
> > 
> > Following commit broke DW GMAC functionality on AXS10x boards:
> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
> > 
> > That's what happens on eth0 up:
> > --------------------------->8------------------------
> > libphy: PHY stmmac-0:ffffffff not found
> > eth0: Could not attach to PHY
> > stmmac_open: Cannot attach to PHY (error: -19)
> > --------------------------->8------------------------
> > 
> > Simplest solution is to add PHY description in board's .dts.
> > And so we do here.
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Phil Reid <preid@electromag.com.au>
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: linux-kernel@vger.kernel.org
> > Cc: netdev@vger.kernel.org
> > Cc: stable@vger.kernel.org # 4.5.x
> > ---
> >   arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> > index 44a578c..04b999e 100644
> > --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> > @@ -47,6 +47,14 @@
> >   			clocks = <&apbclk>;
> >   			clock-names = "stmmaceth";
> >   			max-speed = <100>;
> > +			mdio0 {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +				compatible = "snps,dwmac-mdio";
> > +				phy0: ethernet-phy@0 {
>     The naming is inconsistent with the "reg" prop specified, should be @1.

Makes sense.
Will re-send it with mentioned fix.

-Alexey

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts
@ 2016-03-15 14:50     ` Alexey Brodkin
  0 siblings, 0 replies; 7+ messages in thread
From: Alexey Brodkin @ 2016-03-15 14:50 UTC (permalink / raw)
  To: sergei.shtylyov; +Cc: robh, preid, davem, linux-kernel, linux-snps-arc, netdev

Hi Sergei,

On Tue, 2016-03-15 at 17:38 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 3/15/2016 12:29 PM, Alexey Brodkin wrote:
> 
> > 
> > Following commit broke DW GMAC functionality on AXS10x boards:
> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
> > 
> > That's what happens on eth0 up:
> > --------------------------->8------------------------
> > libphy: PHY stmmac-0:ffffffff not found
> > eth0: Could not attach to PHY
> > stmmac_open: Cannot attach to PHY (error: -19)
> > --------------------------->8------------------------
> > 
> > Simplest solution is to add PHY description in board's .dts.
> > And so we do here.
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Phil Reid <preid@electromag.com.au>
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: linux-kernel@vger.kernel.org
> > Cc: netdev@vger.kernel.org
> > Cc: stable@vger.kernel.org # 4.5.x
> > ---
> >   arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> > index 44a578c..04b999e 100644
> > --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> > @@ -47,6 +47,14 @@
> >   			clocks = <&apbclk>;
> >   			clock-names = "stmmaceth";
> >   			max-speed = <100>;
> > +			mdio0 {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +				compatible = "snps,dwmac-mdio";
> > +				phy0: ethernet-phy@0 {
>     The naming is inconsistent with the "reg" prop specified, should be @1.

Makes sense.
Will re-send it with mentioned fix.

-Alexey

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] ARC: axs10x - add Ethernet PHY description in .dts
@ 2016-03-15 14:50     ` Alexey Brodkin
  0 siblings, 0 replies; 7+ messages in thread
From: Alexey Brodkin @ 2016-03-15 14:50 UTC (permalink / raw)
  To: linux-snps-arc

Hi Sergei,

On Tue, 2016-03-15@17:38 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 3/15/2016 12:29 PM, Alexey Brodkin wrote:
> 
> > 
> > Following commit broke DW GMAC functionality on AXS10x boards:
> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
> > 
> > That's what happens on eth0 up:
> > --------------------------->8------------------------
> > libphy: PHY stmmac-0:ffffffff not found
> > eth0: Could not attach to PHY
> > stmmac_open: Cannot attach to PHY (error: -19)
> > --------------------------->8------------------------
> > 
> > Simplest solution is to add PHY description in board's .dts.
> > And so we do here.
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> > Cc: Rob Herring <robh at kernel.org>
> > Cc: Phil Reid <preid at electromag.com.au>
> > Cc: David S. Miller <davem at davemloft.net>
> > Cc: linux-kernel at vger.kernel.org
> > Cc: netdev at vger.kernel.org
> > Cc: stable at vger.kernel.org # 4.5.x
> > ---
> > ? arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
> > ? 1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> > index 44a578c..04b999e 100644
> > --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> > @@ -47,6 +47,14 @@
> > ??			clocks = <&apbclk>;
> > ??			clock-names = "stmmaceth";
> > ??			max-speed = <100>;
> > +			mdio0 {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +				compatible = "snps,dwmac-mdio";
> > +				phy0: ethernet-phy at 0 {
> ????The naming is inconsistent with the "reg" prop specified, should be @1.

Makes sense.
Will re-send it with mentioned fix.

-Alexey

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-03-15 14:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15  9:29 [PATCH] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin
2016-03-15  9:29 ` Alexey Brodkin
2016-03-15 14:38 ` Sergei Shtylyov
2016-03-15 14:38   ` Sergei Shtylyov
2016-03-15 14:50   ` Alexey Brodkin
2016-03-15 14:50     ` Alexey Brodkin
2016-03-15 14:50     ` Alexey Brodkin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.