All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, patches.audio@intel.com,
	liam.r.girdwood@linux.intel.com,
	Vinod Koul <vinod.koul@intel.com>,
	broonie@kernel.org, Jeeja KP <jeeja.kp@intel.com>
Subject: [PATCH 5/6] ASoC: Intel: Skylake: Call i915 exit last
Date: Tue, 15 Mar 2016 15:27:15 +0530	[thread overview]
Message-ID: <1458035836-1843-6-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1458035836-1843-1-git-send-email-vinod.koul@intel.com>

The Skylake driver uses i915 component APIs to talk to display.
On remove we should free up by invoking snd_hdac_i915_exit() but
that should be last thing in remove routine, so move it to last
in skl_free()

Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/skylake/skl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
index 06887eacffa7..fdf345b1ace5 100644
--- a/sound/soc/intel/skylake/skl.c
+++ b/sound/soc/intel/skylake/skl.c
@@ -328,6 +328,8 @@ static int skl_free(struct hdac_ext_bus *ebus)
 
 	snd_hdac_ext_bus_exit(ebus);
 
+	if (IS_ENABLED(CONFIG_SND_SOC_HDAC_HDMI))
+		snd_hdac_i915_exit(&ebus->bus);
 	return 0;
 }
 
@@ -728,9 +730,6 @@ static void skl_remove(struct pci_dev *pci)
 	if (skl->tplg)
 		release_firmware(skl->tplg);
 
-	if (IS_ENABLED(CONFIG_SND_SOC_HDAC_HDMI))
-		snd_hdac_i915_exit(&ebus->bus);
-
 	if (pci_dev_run_wake(pci))
 		pm_runtime_get_noresume(&pci->dev);
 	pci_dev_put(pci);
-- 
1.9.1

  parent reply	other threads:[~2016-03-15  9:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15  9:57 [PATCH 0/6] ASoC: Intel: Skylake: Fix module removal Vinod Koul
2016-03-15  9:57 ` [PATCH 1/6] ALSA: hda: use list macro for parsing on cleanup Vinod Koul
2016-03-15 10:00   ` Takashi Iwai
2016-03-15 10:54     ` Vinod Koul
2016-03-16 10:09   ` Applied "ALSA: hda: use list macro for parsing on cleanup" to the asoc tree Mark Brown
2016-03-15  9:57 ` [PATCH 2/6] ASoC: Intel: Skylake: free codec objects on removal Vinod Koul
2016-03-15 10:07   ` Mark Brown
2016-03-15 10:52     ` Vinod Koul
2016-03-15  9:57 ` [PATCH 3/6] ASoC: Intel: Skylake: Freeup properly on skl_dsp_free Vinod Koul
2016-03-16 10:09   ` Applied "ASoC: Intel: Skylake: Freeup properly on skl_dsp_free" to the asoc tree Mark Brown
2016-03-15  9:57 ` [PATCH 4/6] ASoC: Intel: Skylake: Unmap the address last Vinod Koul
2016-03-16 10:09   ` Applied "ASoC: Intel: Skylake: Unmap the address last" to the asoc tree Mark Brown
2016-03-15  9:57 ` Vinod Koul [this message]
2016-03-16 10:09   ` Applied "ASoC: Intel: Skylake: Call i915 exit " Mark Brown
2016-03-15  9:57 ` [PATCH 6/6] ASoC: Intel: Skylake: remove call to pci_dev_put Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458035836-1843-6-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jeeja.kp@intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.