From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: liam.r.girdwood@linux.intel.com, tiwai@suse.de,
alsa-devel@alsa-project.org, Jeeja KP <jeeja.kp@intel.com>,
patches.audio@intel.com
Subject: Re: [PATCH 2/6] ASoC: Intel: Skylake: free codec objects on removal
Date: Tue, 15 Mar 2016 16:22:30 +0530 [thread overview]
Message-ID: <20160315105230.GH13211@localhost> (raw)
In-Reply-To: <20160315100743.GM2566@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 506 bytes --]
On Tue, Mar 15, 2016 at 10:07:43AM +0000, Mark Brown wrote:
> On Tue, Mar 15, 2016 at 03:27:12PM +0530, Vinod Koul wrote:
>
> > +/*
> > + * codec destructor
> > + */
> > +static void skl_codecs_remove(struct hdac_ext_bus *ebus)
> > +{
> > + snd_hdac_ext_bus_device_remove(ebus);
> > +}
>
> > + skl_codecs_remove(ebus);
>
> Why the wrapper here?
IIRC Shameless copy of old HDA code, but yes I don't think we need this,
I will update this one.
Thanks for pointing out.
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-03-15 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 9:57 [PATCH 0/6] ASoC: Intel: Skylake: Fix module removal Vinod Koul
2016-03-15 9:57 ` [PATCH 1/6] ALSA: hda: use list macro for parsing on cleanup Vinod Koul
2016-03-15 10:00 ` Takashi Iwai
2016-03-15 10:54 ` Vinod Koul
2016-03-16 10:09 ` Applied "ALSA: hda: use list macro for parsing on cleanup" to the asoc tree Mark Brown
2016-03-15 9:57 ` [PATCH 2/6] ASoC: Intel: Skylake: free codec objects on removal Vinod Koul
2016-03-15 10:07 ` Mark Brown
2016-03-15 10:52 ` Vinod Koul [this message]
2016-03-15 9:57 ` [PATCH 3/6] ASoC: Intel: Skylake: Freeup properly on skl_dsp_free Vinod Koul
2016-03-16 10:09 ` Applied "ASoC: Intel: Skylake: Freeup properly on skl_dsp_free" to the asoc tree Mark Brown
2016-03-15 9:57 ` [PATCH 4/6] ASoC: Intel: Skylake: Unmap the address last Vinod Koul
2016-03-16 10:09 ` Applied "ASoC: Intel: Skylake: Unmap the address last" to the asoc tree Mark Brown
2016-03-15 9:57 ` [PATCH 5/6] ASoC: Intel: Skylake: Call i915 exit last Vinod Koul
2016-03-16 10:09 ` Applied "ASoC: Intel: Skylake: Call i915 exit last" to the asoc tree Mark Brown
2016-03-15 9:57 ` [PATCH 6/6] ASoC: Intel: Skylake: remove call to pci_dev_put Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315105230.GH13211@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.