All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] xorriso: Bump version, Add host variant
@ 2016-03-15 14:07 Benoît Allard
  2016-03-15 14:07 ` [Buildroot] [PATCH 1/2] xorriso: Bump version to 1.4.2 Benoît Allard
  2016-03-15 14:07 ` [Buildroot] [PATCH 2/2] xorriso: Add host variant Benoît Allard
  0 siblings, 2 replies; 7+ messages in thread
From: Benoît Allard @ 2016-03-15 14:07 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
---
 package/Config.in.host         |  1 +
 package/xorriso/Config.in.host | 14 ++++++++++++++
 package/xorriso/xorriso.hash   |  2 +-
 package/xorriso/xorriso.mk     |  3 ++-
 4 files changed, 18 insertions(+), 2 deletions(-)
 create mode 100644 package/xorriso/Config.in.host

diff --git a/package/Config.in.host b/package/Config.in.host
index 09c98fb..a91612b 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -32,6 +32,7 @@ menu "Host utilities"
 	source "package/uboot-tools/Config.in.host"
 	source "package/util-linux/Config.in.host"
 	source "package/vboot-utils/Config.in.host"
+	source "package/xorriso/Config.in.host"
 	source "package/zip/Config.in.host"
 
 endmenu
diff --git a/package/xorriso/Config.in.host b/package/xorriso/Config.in.host
new file mode 100644
index 0000000..2baa043
--- /dev/null
+++ b/package/xorriso/Config.in.host
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_HOST_XORRISO
+	bool "host xorriso"
+	help
+	  xorriso copies file objects from POSIX compliant
+	  filesystems into Rock Ridge enhanced ISO 9660 filesystems
+	  and allows session-wise manipulation of such filesystems.
+	  It can load the management information of existing ISO
+	  images and it writes the session results to optical media
+	  or to filesystem objects.
+
+	  Vice versa xorriso is able to copy file objects out of ISO
+	  9660 filesystems.
+
+	  https://www.gnu.org/software/xorriso
diff --git a/package/xorriso/xorriso.hash b/package/xorriso/xorriso.hash
index 98a716d..3c2a726 100644
--- a/package/xorriso/xorriso.hash
+++ b/package/xorriso/xorriso.hash
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 901204634651533f7cbd105eab560534702458258529aac4b2f0fc946992107e xorriso-1.3.8.tar.gz
+sha256 2843beded1aa4c678706e96fdf9cc5e4b34430b559bdf5bc35df5202125004b3 xorriso-1.4.2.tar.gz
diff --git a/package/xorriso/xorriso.mk b/package/xorriso/xorriso.mk
index 5826340..a465beb 100644
--- a/package/xorriso/xorriso.mk
+++ b/package/xorriso/xorriso.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-XORRISO_VERSION = 1.3.8
+XORRISO_VERSION = 1.4.2
 XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
 XORRISO_LICENSE = GPLv3+
 XORRISO_LICENSE_FILES = COPYING COPYRIGHT
@@ -64,3 +64,4 @@ XORRISO_CONF_OPTS += --disable-jtethreads
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 1/2] xorriso: Bump version to 1.4.2
  2016-03-15 14:07 [Buildroot] [PATCH 1/1] xorriso: Bump version, Add host variant Benoît Allard
@ 2016-03-15 14:07 ` Benoît Allard
  2016-03-15 21:56   ` Yann E. MORIN
  2016-03-15 22:12   ` Peter Korsgaard
  2016-03-15 14:07 ` [Buildroot] [PATCH 2/2] xorriso: Add host variant Benoît Allard
  1 sibling, 2 replies; 7+ messages in thread
From: Benoît Allard @ 2016-03-15 14:07 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
---
 package/xorriso/xorriso.hash | 2 +-
 package/xorriso/xorriso.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/xorriso/xorriso.hash b/package/xorriso/xorriso.hash
index 98a716d..3c2a726 100644
--- a/package/xorriso/xorriso.hash
+++ b/package/xorriso/xorriso.hash
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 901204634651533f7cbd105eab560534702458258529aac4b2f0fc946992107e xorriso-1.3.8.tar.gz
+sha256 2843beded1aa4c678706e96fdf9cc5e4b34430b559bdf5bc35df5202125004b3 xorriso-1.4.2.tar.gz
diff --git a/package/xorriso/xorriso.mk b/package/xorriso/xorriso.mk
index 5826340..e8bb5cb 100644
--- a/package/xorriso/xorriso.mk
+++ b/package/xorriso/xorriso.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-XORRISO_VERSION = 1.3.8
+XORRISO_VERSION = 1.4.2
 XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
 XORRISO_LICENSE = GPLv3+
 XORRISO_LICENSE_FILES = COPYING COPYRIGHT
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] xorriso: Add host variant
  2016-03-15 14:07 [Buildroot] [PATCH 1/1] xorriso: Bump version, Add host variant Benoît Allard
  2016-03-15 14:07 ` [Buildroot] [PATCH 1/2] xorriso: Bump version to 1.4.2 Benoît Allard
@ 2016-03-15 14:07 ` Benoît Allard
  2016-03-15 21:35   ` Yann E. MORIN
  1 sibling, 1 reply; 7+ messages in thread
From: Benoît Allard @ 2016-03-15 14:07 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
---
 package/Config.in.host         |  1 +
 package/xorriso/Config.in.host | 14 ++++++++++++++
 package/xorriso/xorriso.mk     |  2 ++
 3 files changed, 17 insertions(+)
 create mode 100644 package/xorriso/Config.in.host

diff --git a/package/Config.in.host b/package/Config.in.host
index 09c98fb..a91612b 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -32,6 +32,7 @@ menu "Host utilities"
 	source "package/uboot-tools/Config.in.host"
 	source "package/util-linux/Config.in.host"
 	source "package/vboot-utils/Config.in.host"
+	source "package/xorriso/Config.in.host"
 	source "package/zip/Config.in.host"
 
 endmenu
diff --git a/package/xorriso/Config.in.host b/package/xorriso/Config.in.host
new file mode 100644
index 0000000..2baa043
--- /dev/null
+++ b/package/xorriso/Config.in.host
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_HOST_XORRISO
+	bool "host xorriso"
+	help
+	  xorriso copies file objects from POSIX compliant
+	  filesystems into Rock Ridge enhanced ISO 9660 filesystems
+	  and allows session-wise manipulation of such filesystems.
+	  It can load the management information of existing ISO
+	  images and it writes the session results to optical media
+	  or to filesystem objects.
+
+	  Vice versa xorriso is able to copy file objects out of ISO
+	  9660 filesystems.
+
+	  https://www.gnu.org/software/xorriso
diff --git a/package/xorriso/xorriso.mk b/package/xorriso/xorriso.mk
index e8bb5cb..9e9ec8a 100644
--- a/package/xorriso/xorriso.mk
+++ b/package/xorriso/xorriso.mk
@@ -8,6 +8,7 @@ XORRISO_VERSION = 1.4.2
 XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
 XORRISO_LICENSE = GPLv3+
 XORRISO_LICENSE_FILES = COPYING COPYRIGHT
+HOST_XORRISO_DEPENDENCIES =
 
 ifeq ($(BR2_PACKAGE_LIBICONV),y)
 XORRISO_DEPENDENCIES += libiconv
@@ -64,3 +65,4 @@ XORRISO_CONF_OPTS += --disable-jtethreads
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] xorriso: Add host variant
  2016-03-15 14:07 ` [Buildroot] [PATCH 2/2] xorriso: Add host variant Benoît Allard
@ 2016-03-15 21:35   ` Yann E. MORIN
  2016-03-16  8:00     ` Benoît Allard
  0 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2016-03-15 21:35 UTC (permalink / raw)
  To: buildroot

Beno?t, All,

On 2016-03-15 15:07 +0100, Beno?t Allard spake thusly:
> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
> ---
>  package/Config.in.host         |  1 +
>  package/xorriso/Config.in.host | 14 ++++++++++++++
>  package/xorriso/xorriso.mk     |  2 ++
>  3 files changed, 17 insertions(+)
>  create mode 100644 package/xorriso/Config.in.host
> 
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 09c98fb..a91612b 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -32,6 +32,7 @@ menu "Host utilities"
>  	source "package/uboot-tools/Config.in.host"
>  	source "package/util-linux/Config.in.host"
>  	source "package/vboot-utils/Config.in.host"
> +	source "package/xorriso/Config.in.host"
>  	source "package/zip/Config.in.host"
>  
>  endmenu
> diff --git a/package/xorriso/Config.in.host b/package/xorriso/Config.in.host
> new file mode 100644
> index 0000000..2baa043
> --- /dev/null
> +++ b/package/xorriso/Config.in.host
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_HOST_XORRISO
> +	bool "host xorriso"
> +	help
> +	  xorriso copies file objects from POSIX compliant
> +	  filesystems into Rock Ridge enhanced ISO 9660 filesystems
> +	  and allows session-wise manipulation of such filesystems.
> +	  It can load the management information of existing ISO
> +	  images and it writes the session results to optical media
> +	  or to filesystem objects.
> +
> +	  Vice versa xorriso is able to copy file objects out of ISO
> +	  9660 filesystems.
> +
> +	  https://www.gnu.org/software/xorriso

As I already replied in response to your previous iteration, I am
totally fine with xorriso being exposed in the host utilities submenu.

> diff --git a/package/xorriso/xorriso.mk b/package/xorriso/xorriso.mk
> index e8bb5cb..9e9ec8a 100644
> --- a/package/xorriso/xorriso.mk
> +++ b/package/xorriso/xorriso.mk
> @@ -8,6 +8,7 @@ XORRISO_VERSION = 1.4.2
>  XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
>  XORRISO_LICENSE = GPLv3+
>  XORRISO_LICENSE_FILES = COPYING COPYRIGHT
> +HOST_XORRISO_DEPENDENCIES =

Well, that part I am not so sure. Yes, it does build correectly, but it
is highly dependent on the set of libraries (and their -dev files) being
installed on your host distro.

So, either we set the dependency list to empty, but then we explicitly
disable all optional features:

    HOST_XORRISO_DEPENDENCIES =
    HOST_XORRISO_CONF_OPTS = \
        --disable-libcdio \
        --disable-libreadline \
        --disable-libacl \
        and so on...

or we enable all those for which we do have a host package and for which
it makes sense (probably just acl, zlib and bzip2):

    HOST_XORRISO_DEPENDENCIES = host-acl host-zlib host-bzip2
    HOST_XORRISO_CONF_OPTS = \
        --enable-libacl \
        --enable-zlib \
        --enable-bzip2 \
        --disable-libcdio
        --disable-libreadline \
        ...

Both are equally easy I guess. However, I think the latter is more
interesting.

Regards,
Yann E. MORIN.

>  ifeq ($(BR2_PACKAGE_LIBICONV),y)
>  XORRISO_DEPENDENCIES += libiconv
> @@ -64,3 +65,4 @@ XORRISO_CONF_OPTS += --disable-jtethreads
>  endif
>  
>  $(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 1/2] xorriso: Bump version to 1.4.2
  2016-03-15 14:07 ` [Buildroot] [PATCH 1/2] xorriso: Bump version to 1.4.2 Benoît Allard
@ 2016-03-15 21:56   ` Yann E. MORIN
  2016-03-15 22:12   ` Peter Korsgaard
  1 sibling, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2016-03-15 21:56 UTC (permalink / raw)
  To: buildroot

Beno?t, All,

On 2016-03-15 15:07 +0100, Beno?t Allard spake thusly:
> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>

Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[build-tested only, with no deps then with all deps]
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

PS. Sorry for the potential duplicate, the previous mail hasn't made it
    to the list yet, one hour later...
YEM.

> ---
>  package/xorriso/xorriso.hash | 2 +-
>  package/xorriso/xorriso.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/xorriso/xorriso.hash b/package/xorriso/xorriso.hash
> index 98a716d..3c2a726 100644
> --- a/package/xorriso/xorriso.hash
> +++ b/package/xorriso/xorriso.hash
> @@ -1,2 +1,2 @@
>  # Locally computed
> -sha256 901204634651533f7cbd105eab560534702458258529aac4b2f0fc946992107e xorriso-1.3.8.tar.gz
> +sha256 2843beded1aa4c678706e96fdf9cc5e4b34430b559bdf5bc35df5202125004b3 xorriso-1.4.2.tar.gz
> diff --git a/package/xorriso/xorriso.mk b/package/xorriso/xorriso.mk
> index 5826340..e8bb5cb 100644
> --- a/package/xorriso/xorriso.mk
> +++ b/package/xorriso/xorriso.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -XORRISO_VERSION = 1.3.8
> +XORRISO_VERSION = 1.4.2
>  XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
>  XORRISO_LICENSE = GPLv3+
>  XORRISO_LICENSE_FILES = COPYING COPYRIGHT
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 1/2] xorriso: Bump version to 1.4.2
  2016-03-15 14:07 ` [Buildroot] [PATCH 1/2] xorriso: Bump version to 1.4.2 Benoît Allard
  2016-03-15 21:56   ` Yann E. MORIN
@ 2016-03-15 22:12   ` Peter Korsgaard
  1 sibling, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2016-03-15 22:12 UTC (permalink / raw)
  To: buildroot

>>>>> "Beno?t" == Beno?t Allard <benoit.allard@greenbone.net> writes:

 > Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] xorriso: Add host variant
  2016-03-15 21:35   ` Yann E. MORIN
@ 2016-03-16  8:00     ` Benoît Allard
  0 siblings, 0 replies; 7+ messages in thread
From: Benoît Allard @ 2016-03-16  8:00 UTC (permalink / raw)
  To: buildroot

On Tue, 15 Mar 2016 22:35:37 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> > diff --git a/package/xorriso/xorriso.mk b/package/xorriso/xorriso.mk
> > index e8bb5cb..9e9ec8a 100644
> > --- a/package/xorriso/xorriso.mk
> > +++ b/package/xorriso/xorriso.mk
> > @@ -8,6 +8,7 @@ XORRISO_VERSION = 1.4.2
> >  XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
> >  XORRISO_LICENSE = GPLv3+
> >  XORRISO_LICENSE_FILES = COPYING COPYRIGHT
> > +HOST_XORRISO_DEPENDENCIES =
> 
> Well, that part I am not so sure. Yes, it does build correectly, but
> it is highly dependent on the set of libraries (and their -dev files)
> being installed on your host distro.
> 
> So, either we set the dependency list to empty, but then we explicitly
> disable all optional features:
> 
>     HOST_XORRISO_DEPENDENCIES =
>     HOST_XORRISO_CONF_OPTS = \
>         --disable-libcdio \
>         --disable-libreadline \
>         --disable-libacl \
>         and so on...
> 
> or we enable all those for which we do have a host package and for
> which it makes sense (probably just acl, zlib and bzip2):
> 
>     HOST_XORRISO_DEPENDENCIES = host-acl host-zlib host-bzip2
>     HOST_XORRISO_CONF_OPTS = \
>         --enable-libacl \
>         --enable-zlib \
>         --enable-bzip2 \
>         --disable-libcdio
>         --disable-libreadline \
>         ...
> 
> Both are equally easy I guess. However, I think the latter is more
> interesting.

That makes sense of course ! I'll repost that patch with these options
and extend the CONF_OPTS with all the necessary disables, hopefully,
the needed features will still be included. I believe it makes sense to
`select` the correct packages in the Config.in.host as well, right ?

Regards,
Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160316/b0cb1fae/attachment.asc>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-03-16  8:00 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15 14:07 [Buildroot] [PATCH 1/1] xorriso: Bump version, Add host variant Benoît Allard
2016-03-15 14:07 ` [Buildroot] [PATCH 1/2] xorriso: Bump version to 1.4.2 Benoît Allard
2016-03-15 21:56   ` Yann E. MORIN
2016-03-15 22:12   ` Peter Korsgaard
2016-03-15 14:07 ` [Buildroot] [PATCH 2/2] xorriso: Add host variant Benoît Allard
2016-03-15 21:35   ` Yann E. MORIN
2016-03-16  8:00     ` Benoît Allard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.