All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Lechner <david@lechnology.com>
To: unlisted-recipients:; (no To-header on input)
Cc: "Petr Kulhavy" <petr@barix.com>,
	"David Lechner" <david@lechnology.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Sekhar Nori" <nsekhar@ti.com>,
	"Kevin Hilman" <khilman@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Bin Liu" <b-liu@ti.com>, "Andreas Färber" <afaerber@suse.de>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Tony Lindgren" <tony@atomide.com>,
	"Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org
Subject: [PATCH v2 10/11] usb: musb: da8xx: Use devm in probe
Date: Wed, 16 Mar 2016 21:26:43 -0500	[thread overview]
Message-ID: <1458181615-27782-11-git-send-email-david@lechnology.com> (raw)
In-Reply-To: <1458181615-27782-1-git-send-email-david@lechnology.com>

Simplify things a bit by using devm functions where possible.

Signed-off-by: David Lechner <david@lechnology.com>
---

v2 changes: This is part of a previous patch that was split. No changes from
previous version.


 drivers/usb/musb/da8xx.c | 28 ++++++++--------------------
 1 file changed, 8 insertions(+), 20 deletions(-)

diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index b03d3b8..50f07a5 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -489,32 +489,27 @@ static int da8xx_probe(struct platform_device *pdev)
 	struct platform_device		*musb;
 	struct da8xx_glue		*glue;
 	struct platform_device_info	pinfo;
-	struct clk			*clk;
+	int				ret;
 
-	int				ret = -ENOMEM;
-
-	glue = kzalloc(sizeof(*glue), GFP_KERNEL);
+	glue = devm_kzalloc(&pdev->dev, sizeof(*glue), GFP_KERNEL);
 	if (!glue) {
 		dev_err(&pdev->dev, "failed to allocate glue context\n");
-		goto err0;
+		return -ENOMEM;
 	}
 
-	clk = clk_get(&pdev->dev, "usb20");
-	if (IS_ERR(clk)) {
+	glue->clk = devm_clk_get(&pdev->dev, "usb20");
+	if (IS_ERR(glue->clk)) {
 		dev_err(&pdev->dev, "failed to get clock\n");
-		ret = PTR_ERR(clk);
-		goto err3;
+		return PTR_ERR(glue->clk);
 	}
 
-	ret = clk_enable(clk);
+	ret = clk_enable(glue->clk);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to enable clock\n");
 		goto err4;
 	}
 
 	glue->dev			= &pdev->dev;
-	glue->clk			= clk;
-
 	pdata->platform_ops		= &da8xx_ops;
 
 	glue->phy = usb_phy_generic_register();
@@ -557,15 +552,10 @@ err6:
 	usb_phy_generic_unregister(glue->phy);
 
 err5:
-	clk_disable(clk);
+	clk_disable(glue->clk);
 
 err4:
-	clk_put(clk);
-
-err3:
-	kfree(glue);
 
-err0:
 	return ret;
 }
 
@@ -576,8 +566,6 @@ static int da8xx_remove(struct platform_device *pdev)
 	platform_device_unregister(glue->musb);
 	usb_phy_generic_unregister(glue->phy);
 	clk_disable(glue->clk);
-	clk_put(glue->clk);
-	kfree(glue);
 
 	return 0;
 }
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
Cc: "Petr Kulhavy" <petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>,
	"David Lechner" <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Ian Campbell"
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	"Sekhar Nori" <nsekhar-l0cyMroinI0@public.gmane.org>,
	"Kevin Hilman" <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Kishon Vijay Abraham I" <kishon-l0cyMroinI0@public.gmane.org>,
	"Alan Stern"
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	"Greg Kroah-Hartman"
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	"Bin Liu" <b-liu-l0cyMroinI0@public.gmane.org>,
	"Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>,
	"Robert Jarzmik" <robert.jarzmik-GANU6spQydw@public.gmane.org>,
	"Tony Lindgren" <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	"Sergei Shtylyov"
	<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v2 10/11] usb: musb: da8xx: Use devm in probe
Date: Wed, 16 Mar 2016 21:26:43 -0500	[thread overview]
Message-ID: <1458181615-27782-11-git-send-email-david@lechnology.com> (raw)
In-Reply-To: <1458181615-27782-1-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>

Simplify things a bit by using devm functions where possible.

Signed-off-by: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
---

v2 changes: This is part of a previous patch that was split. No changes from
previous version.


 drivers/usb/musb/da8xx.c | 28 ++++++++--------------------
 1 file changed, 8 insertions(+), 20 deletions(-)

diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index b03d3b8..50f07a5 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -489,32 +489,27 @@ static int da8xx_probe(struct platform_device *pdev)
 	struct platform_device		*musb;
 	struct da8xx_glue		*glue;
 	struct platform_device_info	pinfo;
-	struct clk			*clk;
+	int				ret;
 
-	int				ret = -ENOMEM;
-
-	glue = kzalloc(sizeof(*glue), GFP_KERNEL);
+	glue = devm_kzalloc(&pdev->dev, sizeof(*glue), GFP_KERNEL);
 	if (!glue) {
 		dev_err(&pdev->dev, "failed to allocate glue context\n");
-		goto err0;
+		return -ENOMEM;
 	}
 
-	clk = clk_get(&pdev->dev, "usb20");
-	if (IS_ERR(clk)) {
+	glue->clk = devm_clk_get(&pdev->dev, "usb20");
+	if (IS_ERR(glue->clk)) {
 		dev_err(&pdev->dev, "failed to get clock\n");
-		ret = PTR_ERR(clk);
-		goto err3;
+		return PTR_ERR(glue->clk);
 	}
 
-	ret = clk_enable(clk);
+	ret = clk_enable(glue->clk);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to enable clock\n");
 		goto err4;
 	}
 
 	glue->dev			= &pdev->dev;
-	glue->clk			= clk;
-
 	pdata->platform_ops		= &da8xx_ops;
 
 	glue->phy = usb_phy_generic_register();
@@ -557,15 +552,10 @@ err6:
 	usb_phy_generic_unregister(glue->phy);
 
 err5:
-	clk_disable(clk);
+	clk_disable(glue->clk);
 
 err4:
-	clk_put(clk);
-
-err3:
-	kfree(glue);
 
-err0:
 	return ret;
 }
 
@@ -576,8 +566,6 @@ static int da8xx_remove(struct platform_device *pdev)
 	platform_device_unregister(glue->musb);
 	usb_phy_generic_unregister(glue->phy);
 	clk_disable(glue->clk);
-	clk_put(glue->clk);
-	kfree(glue);
 
 	return 0;
 }
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: david@lechnology.com (David Lechner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 10/11] usb: musb: da8xx: Use devm in probe
Date: Wed, 16 Mar 2016 21:26:43 -0500	[thread overview]
Message-ID: <1458181615-27782-11-git-send-email-david@lechnology.com> (raw)
In-Reply-To: <1458181615-27782-1-git-send-email-david@lechnology.com>

Simplify things a bit by using devm functions where possible.

Signed-off-by: David Lechner <david@lechnology.com>
---

v2 changes: This is part of a previous patch that was split. No changes from
previous version.


 drivers/usb/musb/da8xx.c | 28 ++++++++--------------------
 1 file changed, 8 insertions(+), 20 deletions(-)

diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index b03d3b8..50f07a5 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -489,32 +489,27 @@ static int da8xx_probe(struct platform_device *pdev)
 	struct platform_device		*musb;
 	struct da8xx_glue		*glue;
 	struct platform_device_info	pinfo;
-	struct clk			*clk;
+	int				ret;
 
-	int				ret = -ENOMEM;
-
-	glue = kzalloc(sizeof(*glue), GFP_KERNEL);
+	glue = devm_kzalloc(&pdev->dev, sizeof(*glue), GFP_KERNEL);
 	if (!glue) {
 		dev_err(&pdev->dev, "failed to allocate glue context\n");
-		goto err0;
+		return -ENOMEM;
 	}
 
-	clk = clk_get(&pdev->dev, "usb20");
-	if (IS_ERR(clk)) {
+	glue->clk = devm_clk_get(&pdev->dev, "usb20");
+	if (IS_ERR(glue->clk)) {
 		dev_err(&pdev->dev, "failed to get clock\n");
-		ret = PTR_ERR(clk);
-		goto err3;
+		return PTR_ERR(glue->clk);
 	}
 
-	ret = clk_enable(clk);
+	ret = clk_enable(glue->clk);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to enable clock\n");
 		goto err4;
 	}
 
 	glue->dev			= &pdev->dev;
-	glue->clk			= clk;
-
 	pdata->platform_ops		= &da8xx_ops;
 
 	glue->phy = usb_phy_generic_register();
@@ -557,15 +552,10 @@ err6:
 	usb_phy_generic_unregister(glue->phy);
 
 err5:
-	clk_disable(clk);
+	clk_disable(glue->clk);
 
 err4:
-	clk_put(clk);
-
-err3:
-	kfree(glue);
 
-err0:
 	return ret;
 }
 
@@ -576,8 +566,6 @@ static int da8xx_remove(struct platform_device *pdev)
 	platform_device_unregister(glue->musb);
 	usb_phy_generic_unregister(glue->phy);
 	clk_disable(glue->clk);
-	clk_put(glue->clk);
-	kfree(glue);
 
 	return 0;
 }
-- 
1.9.1

  parent reply	other threads:[~2016-03-17  3:42 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17  2:26 [PATCH v2 00/11] da8xx USB clocks David Lechner
2016-03-17  2:26 ` David Lechner
2016-03-17  2:26 ` David Lechner
2016-03-17  2:26 ` [PATCH v2 01/11] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros for MUSB PHY David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26 ` [PATCH v2 02/11] ARM: davinci: add set_parent callback for mux clocks David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26 ` [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3 David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-23 15:56   ` Sekhar Nori
2016-03-23 15:56     ` Sekhar Nori
2016-03-23 15:56     ` Sekhar Nori
2016-03-23 17:20     ` David Lechner
2016-03-23 17:20       ` David Lechner
2016-03-23 17:20       ` David Lechner
2016-03-23 17:29       ` Sekhar Nori
2016-03-23 17:29         ` Sekhar Nori
2016-03-23 18:32         ` David Lechner
2016-03-23 18:32           ` David Lechner
2016-03-24 13:44           ` Sekhar Nori
2016-03-24 13:44             ` Sekhar Nori
2016-03-17  2:26 ` [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17 12:12   ` Sergei Shtylyov
2016-03-17 12:12     ` Sergei Shtylyov
2016-03-23 16:56   ` Sekhar Nori
2016-03-23 16:56     ` Sekhar Nori
2016-03-23 16:56     ` Sekhar Nori
2016-03-23 17:45     ` David Lechner
2016-03-23 17:45       ` David Lechner
2016-03-23 17:45       ` David Lechner
2016-03-23 17:54       ` Sekhar Nori
2016-03-23 17:54         ` Sekhar Nori
2016-03-23 17:54         ` Sekhar Nori
2016-03-17  2:26 ` [PATCH v2 05/11] dt-bindings: Add bindings for phy-da8xx-usb David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-19 23:56   ` Rob Herring
2016-03-19 23:56     ` Rob Herring
2016-03-19 23:56     ` Rob Herring
2016-03-23 17:06   ` Sekhar Nori
2016-03-23 17:06     ` Sekhar Nori
2016-03-23 17:06     ` Sekhar Nori
2016-03-23 17:56     ` David Lechner
2016-03-23 17:56       ` David Lechner
2016-03-23 17:56       ` David Lechner
2016-03-17  2:26 ` [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17 12:38   ` Sergei Shtylyov
2016-03-17 12:38     ` Sergei Shtylyov
2016-03-17 12:38     ` Sergei Shtylyov
2016-03-23 17:21   ` Sekhar Nori
2016-03-23 17:21     ` Sekhar Nori
2016-03-23 18:06     ` David Lechner
2016-03-23 18:06       ` David Lechner
2016-03-23 18:06       ` David Lechner
2016-03-24 14:01       ` David Laight
2016-03-24 14:01         ` David Laight
2016-03-24 14:01         ` David Laight
2016-04-01 13:16   ` Kishon Vijay Abraham I
2016-04-01 13:16     ` Kishon Vijay Abraham I
2016-04-01 14:45     ` Bin Liu
2016-04-01 14:45       ` Bin Liu
2016-04-01 14:45       ` Bin Liu
2016-04-01 16:02       ` David Lechner
2016-04-01 16:02         ` David Lechner
2016-04-01 16:02         ` David Lechner
2016-04-01 16:19         ` Bin Liu
2016-04-01 16:19           ` Bin Liu
2016-04-01 16:19           ` Bin Liu
2016-04-01 19:49           ` Sergei Shtylyov
2016-04-01 19:49             ` Sergei Shtylyov
2016-04-01 19:49             ` Sergei Shtylyov
2016-04-01 19:45         ` Sergei Shtylyov
2016-04-01 19:45           ` Sergei Shtylyov
2016-04-01 19:56           ` Bin Liu
2016-04-01 19:56             ` Bin Liu
2016-04-01 19:56             ` Bin Liu
2016-04-13 20:51     ` David Lechner
2016-04-13 20:51       ` David Lechner
2016-04-14 12:32       ` Kishon Vijay Abraham I
2016-04-14 12:32         ` Kishon Vijay Abraham I
2016-03-17  2:26 ` [PATCH v2 07/11] ARM: davinci: da8xx: Add USB PHY platform declaration David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26 ` [PATCH v2 08/11] ARM: dt: da850: Add usb phy node David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26 ` [PATCH v2 09/11] usb: ohci-da8xx: Remove code that references mach David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17 12:53   ` Sergei Shtylyov
2016-03-17 12:53     ` Sergei Shtylyov
2016-03-17 12:53     ` Sergei Shtylyov
2016-03-17 18:01   ` Alan Stern
2016-03-17  2:26 ` David Lechner [this message]
2016-03-17  2:26   ` [PATCH v2 10/11] usb: musb: da8xx: Use devm in probe David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17 11:07   ` Sergei Shtylyov
2016-03-17 11:07     ` Sergei Shtylyov
2016-03-17 11:07     ` Sergei Shtylyov
2016-03-17  2:26 ` [PATCH v2 11/11] usb: musb: da8xx: Remove mach code David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17  2:26   ` David Lechner
2016-03-17 13:11   ` Sergei Shtylyov
2016-03-17 13:11     ` Sergei Shtylyov
2016-03-17 13:11     ` Sergei Shtylyov
2016-03-17 17:38     ` David Lechner
2016-03-17 17:38       ` David Lechner
2016-03-17 17:38       ` David Lechner
2016-03-17 13:39 ` [PATCH v2 00/11] da8xx USB clocks Sergei Shtylyov
2016-03-17 13:39   ` Sergei Shtylyov
2016-03-17 13:39   ` Sergei Shtylyov
2016-03-23 17:26   ` Sekhar Nori
2016-03-23 17:26     ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458181615-27782-11-git-send-email-david@lechnology.com \
    --to=david@lechnology.com \
    --cc=afaerber@suse.de \
    --cc=b-liu@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=khilman@kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=nsekhar@ti.com \
    --cc=pawel.moll@arm.com \
    --cc=petr@barix.com \
    --cc=robert.jarzmik@free.fr \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.